eslint 5.0.0-alpha.4 → 5.1.0

package/CHANGELOG.md

@@ -1,3 +1,63 @@
+v5.1.0 - July 8, 2018
+
+* 7328f99 Build: package.json update for eslint-config-eslint release (ESLint Jenkins)
+* b161f6b Build: Include prerelease install info in release blog post (#10463) (Kevin Partington)
+* b2df738 Fix: prefer-object-spread duplicated comma (fixes #10512, fixes #10532) (#10524) (Toru Nagashima)
+* d8c3a25 Fix: wrap-regex doesn't work in some expression(fixes #10573) (#10576) (薛定谔的猫)
+* 114f42e Docs: Clarify option defaults in max-lines-per-function docs (#10569) (Chris Harwood)
+* 63f36f7 Fix: sort-keys in an object that contains spread (fixes #10261) (#10495) (katerberg)
+* 601a5c4 Fix: Prefer-const rule crashing on array destructuring (fixes #10520) (#10527) (Michael Mason)
+* 143890a Update: Adjust grammar of error/warnings fixable (#10546) (Matt Mischuk)
+* 8ee39c5 Chore: small refactor config-validator (#10565) (薛定谔的猫)
+* 100f1be Docs: add note about release issues to readme (#10572) (Teddy Katz)
+* 02efeac Fix: do not fail on nested unknown operators (#10561) (Rubén Norte)
+* 92b19ca Chore: use eslintrc overrides(dogfooding) (#10566) (薛定谔的猫)
+* 076a6b6 Docs: add actionable fix to no-irregular-whitespace (#10558) (Matteo Collina)
+* de663ec Docs: Only successfully linted files are cached (fixes #9802) (#10557) (Kevin Partington)
+* f0e22fc Upgrade: globals@11.7.0 (#10497) (薛定谔的猫)
+* 8a2ff2c Docs:  adding a section about disable rules for some files (#10536) (Wellington Soares)
+* f22a3f8 Docs: fix a word in no-implied-eval (#10539) (Dan Homola)
+* 20d8bbd Docs: add missing paragraph about "custom parsers" (#10547) (Pig Fang)
+* b7addf6 Update: deprecate no-catch-shadow (fixes #10466) (#10526) (Toru Nagashima)
+* e862dc3 Fix: Remove autofixer for no-debugger (fixes #10242) (#10509) (Teddy Katz)
+
+v5.0.1 - June 25, 2018
+
+* 196c102 Fix: valid-jsdoc should allow optional returns for async (fixes #10386) (#10480) (Mark Banner)
+* 4c823bd Docs: Fix max-lines-per-function correct code's max value (#10513) (Rhys Bower)
+
+v5.0.0 - June 22, 2018
+
+* 0feedfd New: Added max-lines-per-function rule (fixes #9842) (#10188) (peteward44)
+* daefbdb Upgrade: eslint-scope and espree to 4.0.0 (refs #10458) (#10500) (Brandon Mills)
+* 077358b Docs: no-process-exit: recommend process.exitCode (#10478) (Andres Kalle)
+* f93d6ff Fix: do not fail on unknown operators from custom parsers (fixes #10475) (#10476) (Rubén Norte)
+* 05343fd Fix: add parens for yield statement (fixes #10432) (#10468) (Pig Fang)
+* d477c5e Fix: check destructuring for "no-shadow-restricted-names" (fixes #10467) (#10470) (Pig Fang)
+* 7a7580b Update: Add considerPropertyDescriptor option to func-name-matching (#9078) (Dieter Luypaert)
+* e0a0418 Fix: crash on optional catch binding (#10429) (Toru Nagashima)
+* de4dba9 Docs: styling team members (#10460) (薛定谔的猫)
+* 5e453a3 Docs: display team members in tables. (#10433) (薛定谔的猫)
+* b1895eb Docs: Restore intentional spelling mistake (#10459) (Wilfred Hughes)
+
+v5.0.0-rc.0 - June 9, 2018
+
+* abf400d Update: Add ignoreDestructing option to camelcase rule (fixes #9807) (#10373) (Andrew Lunny)
+* e2b394d Upgrade: espree and eslint-scope to rc versions (#10457) (Kevin Partington)
+* a370da2 Chore: small opt to improve readability (#10241) (薛定谔的猫)
+* 640bf07 Update: Fixes multiline no-warning-comments rule. (fixes #9884) (#10381) (Scott Stern)
+* 831c39a Build: Adding rc release script to package.json (#10456) (Kevin Partington)
+* dc4075e Update: fix false negative in no-use-before-define (fixes #10227) (#10396) (Toru Nagashima)
+* 3721841 Docs: Add new experimental syntax policy to README (fixes #9804) (#10408) (Kevin Partington)
+* d0aae3c Docs: Create docs landing page (#10453) (Kevin Partington)
+* fe8bec3 Fix: fix writing config file when `source` is `prompt` (#10422) (Pig Fang)
+* 917108d Update: Add requireParamType option to valid-jsdoc (fixes #6753) (#10220) (Tomasz Sterna)
+* 1984c21 Docs: move custom parsers docs into a page (fixes #9919) (#10431) (Pig Fang)
+* 400d4b5 Docs: Add rest and spread operator changes to migration guide (#10416) (Yannick Croissant)
+* e7bdd02 Upgrade: Consume espree@4.0.0-alpha.1 (#10410) (Kevin Partington)
+* 3e9f33a Fix: prevent crashing from JSON parsing error (fixes #10364) (#10376) (Pig Fang)
+* 636457d Fix: parse later ES files in `eslint --init` (fixes #10003) (#10378) (Pig Fang)
+
 v5.0.0-alpha.4 - May 28, 2018
 
 * ce3e62a Docs: remove test coverage badge (#10407) (薛定谔的猫)

package/README.md

@@ -145,7 +145,9 @@ ESLint has full support for ECMAScript 3, 5 (default), 2015, 2016, 2017, and 201
 
 ### What about experimental features?
 
-ESLint doesn't natively support experimental ECMAScript language features. You can use [babel-eslint](https://github.com/babel/babel-eslint) to use any option available in Babel.
+ESLint's parser only officially supports the latest final ECMAScript standard. We will make changes to core rules in order to avoid crashes on stage 3 ECMAScript syntax proposals (as long as they are implemented using the correct experimental ESTree syntax). We may make changes to core rules to better work with language extensions (such as JSX, Flow, and TypeScript) on a case-by-case basis.
+
+In other cases (including if rules need to warn on more or fewer cases due to new syntax, rather than just not crashing), we recommend you use other parsers and/or rule plugins. If you are using Babel, you can use the [babel-eslint](https://github.com/babel/babel-eslint) parser and [eslint-plugin-babel](https://github.com/babel/eslint-plugin-babel) to use any option available in Babel.
 
 Once a language feature has been adopted into the ECMAScript standard (stage 4 according to the [TC39 process](https://tc39.github.io/process-document/)), we will accept issues and pull requests related to the new feature, subject to our [contributing guidelines](https://eslint.org/docs/developer-guide/contributing). Until then, please use the appropriate parser and plugin(s) for your experimental feature.
 
@@ -155,7 +157,7 @@ Join our [Mailing List](https://groups.google.com/group/eslint) or [Chatroom](ht
 
 ## Releases
 
-We have scheduled releases every two weeks on Friday or Saturday.
+We have scheduled releases every two weeks on Friday or Saturday. You can follow a [release issue](https://github.com/eslint/eslint/issues?q=is%3Aopen+is%3Aissue+label%3Arelease) for updates about the scheduling of any particular release.
 
 ## Semantic Versioning Policy
 
@@ -193,34 +195,148 @@ These folks keep the project moving and are resources for help.
 
 ### Technical Steering Committee (TSC)
 
-* Nicholas C. Zakas ([@nzakas](https://github.com/nzakas))
-* Ilya Volodin ([@ilyavolodin](https://github.com/ilyavolodin))
-* Brandon Mills ([@btmills](https://github.com/btmills))
-* Gyandeep Singh ([@gyandeeps](https://github.com/gyandeeps))
-* Toru Nagashima ([@mysticatea](https://github.com/mysticatea))
-* Alberto Rodríguez ([@alberto](https://github.com/alberto))
-* Kai Cataldo ([@kaicataldo](https://github.com/kaicataldo))
-* Teddy Katz ([@not-an-aardvark](https://github.com/not-an-aardvark))
-* Kevin Partington ([@platinumazure](https://github.com/platinumazure))
+<table>
+    <tbody>
+        <tr>
+            <td align="center" valign="top" width="11%">
+                <a href="https://github.com/nzakas">
+                <img src="https://github.com/nzakas.png?s=75" width="75px" height="75px"><br/>
+                <sub>Nicholas C. Zakas</sub></a>
+            </td>
+            <td align="center" valign="top" width="11%">
+                <a href="https://github.com/ilyavolodin">
+                <img src="https://github.com/ilyavolodin.png?s=75" width="75px" height="75px"><br/>
+                <sub>Ilya Volodin</sub></a>
+            </td>
+            <td align="center" valign="top" width="11%">
+                <a href="https://github.com/btmills">
+                <img src="https://github.com/btmills.png?s=75" width="75px" height="75px"><br/>
+                <sub>Brandon Mills</sub></a>
+            </td>
+            <td align="center" valign="top" width="11%">
+                <a href="https://github.com/gyandeeps">
+                <img src="https://github.com/gyandeeps.png?s=75" width="75px" height="75px"><br/>
+                <sub>Gyandeep Singh</sub></a>
+            </td>
+            <td align="center" valign="top" width="11%">
+                <a  href="https://github.com/mysticatea">
+                <img src="https://github.com/mysticatea.png?s=75" width="75px" height="75px"><br/>
+                <sub>Toru Nagashima</sub></a>
+            </td>
+            <td align="center" valign="top" width="11%">
+                <a href="https://github.com/alberto">
+                <img src="https://github.com/alberto.png?s=75" width="75px" height="75px"><br/>
+                <sub>Alberto Rodríguez</sub></a>
+            </td>
+            <td align="center" valign="top" width="11%">
+                <a href="https://github.com/kaicataldo">
+                <img src="https://github.com/kaicataldo.png?s=75" width="75px" height="75px"><br/>
+                <sub>Kai Cataldo</sub></a>
+            </td>
+            <td align="center" valign="top" width="11%">
+                <a href="https://github.com/not-an-aardvark">
+                <img src="https://github.com/not-an-aardvark.png?s=75" width="75px" height="75px"><br/>
+                <sub>Teddy Katz</sub></a>
+            </td>
+            <td align="center" valign="top" width="11%">
+                <a href="https://github.com/platinumazure">
+                <img src="https://github.com/platinumazure.png?s=75" width="75px" height="75px"><br/>
+                <sub>Kevin Partington</sub></a>
+            </td>
+        </tr>
+    </tbody>
+</table>
 
 ### Development Team
 
-* Mathias Schreck ([@lo1tuma](https://github.com/lo1tuma))
-* Jamund Ferguson ([@xjamundx](https://github.com/xjamundx))
-* Ian VanSchooten ([@ianvs](https://github.com/ianvs))
-* Burak Yiğit Kaya ([@byk](https://github.com/byk))
-* Michael Ficarra ([@michaelficarra](https://github.com/michaelficarra))
-* Mark Pedrotti ([@pedrottimark](https://github.com/pedrottimark))
-* Oleg Gaidarenko ([@markelog](https://github.com/markelog))
-* Mike Sherov ([@mikesherov](https://github.com/mikesherov))
-* Henry Zhu ([@hzoo](https://github.com/hzoo))
-* Marat Dulin ([@mdevils](https://github.com/mdevils))
-* Alexej Yaroshevich ([@zxqfox](https://github.com/zxqfox))
-* Vitor Balocco ([@vitorbal](https://github.com/vitorbal))
-* James Henry ([@JamesHenry](https://github.com/JamesHenry))
-* Reyad Attiyat ([@soda0289](https://github.com/soda0289))
-* 薛定谔的猫 ([@Aladdin-ADD](https://github.com/Aladdin-ADD))
-* Victor Hom ([@VictorHom](https://github.com/VictorHom))
+<table>
+    <tbody>
+        <tr>
+            <td align="center" valign="top" width="11%">
+                <a href="https://github.com/lo1tuma">
+                <img src="https://github.com/lo1tuma.png?s=75" width="75px" height="75px"><br/>
+                <sub>Mathias Schreck</sub></a>
+            </td>
+            <td align="center" valign="top" width="11%">
+                <a href="https://github.com/xjamundx">
+                <img src="https://github.com/xjamundx.png?s=75" width="75px" height="75px"><br/>
+                <sub>Jamund Ferguson</sub></a>
+            </td>
+            <td align="center" valign="top" width="11%">
+                <a href="https://github.com/ianvs">
+                <img src="https://github.com/ianvs.png?s=75" width="75px" height="75px"><br/>
+                <sub>Ian VanSchooten</sub></a>
+            </td>
+            <td align="center" valign="top" width="11%">
+                <a href="https://github.com/byk">
+                <img src="https://github.com/byk.png?s=75" width="75px" height="75px"><br/>
+                <sub>Burak Yiğit Kaya</sub></a>
+            </td>
+            <td align="center" valign="top" width="11%">
+                <a href="https://github.com/michaelficarra">
+                <img src="https://github.com/michaelficarra.png?s=75" width="75px" height="75px"><br/>
+                <sub>Michael Ficarra</sub></a>
+            </td>
+            <td align="center" valign="top" width="11%">
+                <a href="https://github.com/pedrottimark">
+                <img src="https://github.com/pedrottimark.png?s=75" width="75px" height="75px"><br/>
+                <sub>Mark Pedrotti</sub></a>
+            </td>
+            <td align="center" valign="top" width="11%">
+                <a href="https://github.com/markelog">
+                <img src="https://github.com/markelog.png?s=75" width="75px" height="75px"><br/>
+                <sub>Oleg Gaidarenko</sub></a>
+            </td>
+            <td align="center" valign="top" width="11%">
+                <a href="https://github.com/mikesherov">
+                <img src="https://github.com/mikesherov.png?s=75" width="75px" height="75px"><br/>
+                <sub>Mike Sherov</sub></a>
+            </td>
+        </tr>
+        <tr>
+            <td align="center" valign="top" width="11%">
+                <a href="https://github.com/hzoo">
+                <img src="https://github.com/hzoo.png?s=75" width="75px" height="75px"><br/>
+                <sub>Henry Zhu</sub></a>
+            </td>
+            <td align="center" valign="top" width="11%">
+                <a href="https://github.com/mdevils">
+                <img src="https://github.com/mdevils.png?s=75" width="75px" height="75px"><br/>
+                <sub>Marat Dulin</sub></a>
+            </td>
+            <td align="center" valign="top" width="11%">
+                <a href="https://github.com/zxqfox">
+                <img src="https://github.com/zxqfox.png?s=75" width="75px" height="75px"><br/>
+                <sub>Alexej Yaroshevich</sub></a>
+            </td>
+            <td align="center" valign="top" width="11%">
+                <a href="https://github.com/vitorbal">
+                <img src="https://github.com/vitorbal.png?s=75" width="75px" height="75px"><br/>
+                <sub>Vitor Balocco</sub></a>
+            </td>
+            <td align="center" valign="top" width="11%">
+                <a href="https://github.com/JamesHenry">
+                <img src="https://github.com/JamesHenry.png?s=75" width="75px" height="75px"><br/>
+                <sub>James Henry</sub></a>
+            </td>
+            <td align="center" valign="top" width="11%">
+                <a href="https://github.com/soda0289">
+                <img src="https://github.com/soda0289.png?s=75" width="75px" height="75px"><br/>
+                <sub>Reyad Attiyat</sub></a>
+            </td>
+            <td align="center" valign="top" width="11%">
+                <a href="https://github.com/Aladdin-ADD">
+                <img src="https://github.com/Aladdin-ADD.png?s=75" width="75px" height="75px"><br/>
+                <sub>薛定谔的猫</sub></a>
+            </td>
+            <td align="center" valign="top" width="11%">
+                <a href="https://github.com/VictorHom">
+                <img src="https://github.com/VictorHom.png?s=75" width="75px" height="75px"><br/>
+                <sub>Victor Hom</sub></a>
+            </td>
+        </tr>
+    </tbody>
+</table>
 
 ## Sponsors
 

package/conf/eslint-recommended.js

@@ -69,6 +69,7 @@ module.exports = {
         "max-depth": "off",
         "max-len": "off",
         "max-lines": "off",
+        "max-lines-per-function": "off",
         "max-nested-callbacks": "off",
         "max-params": "off",
         "max-statements": "off",

package/lib/code-path-analysis/code-path-analyzer.js

@@ -30,6 +30,17 @@ function isCaseNode(node) {
     return Boolean(node.test);
 }
 
+/**
+ * Checks whether the given logical operator is taken into account for the code
+ * path analysis.
+ *
+ * @param {string} operator - The operator found in the LogicalExpression node
+ * @returns {boolean} `true` if the operator is "&&" or "||"
+ */
+function isHandledLogicalOperator(operator) {
+    return operator === "&&" || operator === "||";
+}
+
 /**
  * Checks whether or not a given logical expression node goes different path
  * between the `true` case and the `false` case.
@@ -49,7 +60,7 @@ function isForkingByTrueOrFalse(node) {
             return parent.test === node;
 
         case "LogicalExpression":
-            return true;
+            return isHandledLogicalOperator(parent.operator);
 
         default:
             return false;
@@ -230,7 +241,10 @@ function preprocess(analyzer, node) {
 
     switch (parent.type) {
         case "LogicalExpression":
-            if (parent.right === node) {
+            if (
+                parent.right === node &&
+                isHandledLogicalOperator(parent.operator)
+            ) {
                 state.makeLogicalRight();
             }
             break;
@@ -361,7 +375,12 @@ function processCodePathToEnter(analyzer, node) {
             break;
 
         case "LogicalExpression":
-            state.pushChoiceContext(node.operator, isForkingByTrueOrFalse(node));
+            if (isHandledLogicalOperator(node.operator)) {
+                state.pushChoiceContext(
+                    node.operator,
+                    isForkingByTrueOrFalse(node)
+                );
+            }
             break;
 
         case "ConditionalExpression":
@@ -430,10 +449,15 @@ function processCodePathToExit(analyzer, node) {
     switch (node.type) {
         case "IfStatement":
         case "ConditionalExpression":
-        case "LogicalExpression":
             state.popChoiceContext();
             break;
 
+        case "LogicalExpression":
+            if (isHandledLogicalOperator(node.operator)) {
+                state.popChoiceContext();
+            }
+            break;
+
         case "SwitchStatement":
             state.popSwitchContext();
             break;

package/lib/config/config-file.js

@@ -115,6 +115,11 @@ function loadJSONConfigFile(filePath) {
     } catch (e) {
         debug(`Error reading JSON file: ${filePath}`);
         e.message = `Cannot read config file: ${filePath}\nError: ${e.message}`;
+        e.messageTemplate = "failed-to-read-json";
+        e.messageData = {
+            path: filePath,
+            message: e.message
+        };
         throw e;
     }
 }

package/lib/config/config-initializer.js

@@ -239,15 +239,16 @@ function configureRules(answers, config) {
  * @returns {Object} config object
  */
 function processAnswers(answers) {
-    let config = { rules: {}, env: {} };
+    let config = { rules: {}, env: {}, parserOptions: {} };
 
-    if (answers.es6) {
-        config.env.es6 = true;
+    config.parserOptions.ecmaVersion = answers.ecmaVersion;
+    if (answers.ecmaVersion >= 2015) {
         if (answers.modules) {
-            config.parserOptions = config.parserOptions || {};
             config.parserOptions.sourceType = "module";
         }
+        config.env.es6 = true;
     }
+
     if (answers.commonjs) {
         config.env.commonjs = true;
     }
@@ -514,10 +515,18 @@ function promptUser() {
         // continue with the questions otherwise...
         return inquirer.prompt([
             {
-                type: "confirm",
-                name: "es6",
-                message: "Are you using ECMAScript 6 features?",
-                default: false
+                type: "list",
+                name: "ecmaVersion",
+                message: "Which version of ECMAScript do you use?",
+                choices: [
+                    { name: "ES3", value: 3 },
+                    { name: "ES5", value: 5 },
+                    { name: "ES2015", value: 2015 },
+                    { name: "ES2016", value: 2016 },
+                    { name: "ES2017", value: 2017 },
+                    { name: "ES2018", value: 2018 }
+                ],
+                default: 1 // This is the index in the choices list
             },
             {
                 type: "confirm",
@@ -525,7 +534,7 @@ function promptUser() {
                 message: "Are you using ES6 modules?",
                 default: false,
                 when(answers) {
-                    return answers.es6 === true;
+                    return answers.ecmaVersion >= 2015;
                 }
             },
             {
@@ -614,7 +623,7 @@ function promptUser() {
                 const config = processAnswers(totalAnswers);
                 const modules = getModulesList(config);
 
-                return askInstallModules(modules).then(() => writeFile(config, earlyAnswers.format));
+                return askInstallModules(modules).then(() => writeFile(config, answers.format));
             });
         });
     });

package/lib/config/config-validator.js

@@ -23,10 +23,15 @@ const ruleValidators = new WeakMap();
 let validateSchema;
 
 // Defitions for deprecation warnings.
-const deprecationWarningMessages = Object.freeze({
+const deprecationWarningMessages = {
     ESLINT_LEGACY_ECMAFEATURES: "The 'ecmaFeatures' config file property is deprecated, and has no effect.",
     ESLINT_LEGACY_OBJECT_REST_SPREAD: "The 'parserOptions.ecmaFeatures.experimentalObjectRestSpread' option is deprecated. Use 'parserOptions.ecmaVersion' instead."
-});
+};
+const severityMap = {
+    error: 2,
+    warn: 1,
+    off: 0
+};
 
 /**
  * Gets a complete options schema for a rule.
@@ -65,12 +70,14 @@ function getRuleOptionsSchema(rule) {
  */
 function validateRuleSeverity(options) {
     const severity = Array.isArray(options) ? options[0] : options;
+    const normSeverity = typeof severity === "string" ? severityMap[severity.toLowerCase()] : severity;
 
-    if (severity !== 0 && severity !== 1 && severity !== 2 && !(typeof severity === "string" && /^(?:off|warn|error)$/i.test(severity))) {
-        throw new Error(`\tSeverity should be one of the following: 0 = off, 1 = warn, 2 = error (you passed '${util.inspect(severity).replace(/'/g, "\"").replace(/\n/g, "")}').\n`);
+    if (normSeverity === 0 || normSeverity === 1 || normSeverity === 2) {
+        return normSeverity;
     }
 
-    return severity;
+    throw new Error(`\tSeverity should be one of the following: 0 = off, 1 = warn, 2 = error (you passed '${util.inspect(severity).replace(/'/g, "\"").replace(/\n/g, "")}').\n`);
+
 }
 
 /**
@@ -116,7 +123,7 @@ function validateRuleOptions(rule, ruleId, options, source) {
     try {
         const severity = validateRuleSeverity(options);
 
-        if (severity !== 0 && !(typeof severity === "string" && severity.toLowerCase() === "off")) {
+        if (severity !== 0) {
             validateRuleSchema(rule, Array.isArray(options) ? options.slice(1) : []);
         }
     } catch (err) {

package/lib/config.js

@@ -209,7 +209,7 @@ class Config {
             const localConfigHierarchyCache = this.configCache.getHierarchyLocalConfigs(localConfigDirectory);
 
             if (localConfigHierarchyCache) {
-                const localConfigHierarchy = localConfigHierarchyCache.concat(configs.reverse());
+                const localConfigHierarchy = localConfigHierarchyCache.concat(configs);
 
                 this.configCache.setHierarchyLocalConfigs(searched, localConfigHierarchy);
                 return localConfigHierarchy;
@@ -232,7 +232,7 @@ class Config {
             }
 
             debug(`Using ${localConfigFile}`);
-            configs.push(localConfig);
+            configs.unshift(localConfig);
             searched.push(localConfigDirectory);
 
             // Stop traversing if a config is found with the root flag set
@@ -248,7 +248,7 @@ class Config {
             const personalConfig = this.getPersonalConfig();
 
             if (personalConfig) {
-                configs.push(personalConfig);
+                configs.unshift(personalConfig);
             } else if (!hasRules(this.options) && !this.options.baseConfig) {
 
                 // No config file, no manual configuration, and no rules, so error.
@@ -265,7 +265,7 @@ class Config {
         }
 
         // Set the caches for the parent directories
-        this.configCache.setHierarchyLocalConfigs(searched, configs.reverse());
+        this.configCache.setHierarchyLocalConfigs(searched, configs);
 
         return configs;
     }

package/lib/formatters/stylish.js

@@ -89,7 +89,7 @@ module.exports = function(results) {
 
         if (fixableErrorCount > 0 || fixableWarningCount > 0) {
             output += chalk[summaryColor].bold([
-                "  ", fixableErrorCount, pluralize(" error", fixableErrorCount), ", ",
+                "  ", fixableErrorCount, pluralize(" error", fixableErrorCount), " and ",
                 fixableWarningCount, pluralize(" warning", fixableWarningCount),
                 " potentially fixable with the `--fix` option.\n"
             ].join(""));

package/lib/ignored-paths.js

@@ -176,6 +176,11 @@ class IgnoredPaths {
                             packageJSONOptions = JSON.parse(fs.readFileSync(packageJSONPath, "utf8"));
                         } catch (e) {
                             debug("Could not read package.json file to check eslintIgnore property");
+                            e.messageTemplate = "failed-to-read-json";
+                            e.messageData = {
+                                path: packageJSONPath,
+                                message: e.message
+                            };
                             throw e;
                         }
 
@@ -231,7 +236,7 @@ class IgnoredPaths {
     /**
      * Determine whether a file path is included in the default or custom ignore patterns
      * @param {string} filepath Path to check
-     * @param {string} [category=null] check 'default', 'custom' or both (null)
+     * @param {string} [category=undefined] check 'default', 'custom' or both (undefined)
      * @returns {boolean} true if the file path matches one or more patterns, false otherwise
      */
     contains(filepath, category) {
@@ -240,12 +245,11 @@ class IgnoredPaths {
         const absolutePath = path.resolve(this.options.cwd, filepath);
         const relativePath = pathUtil.getRelativePath(absolutePath, this.baseDir);
 
-        if ((typeof category === "undefined") || (category === "default")) {
-            result = result || (this.ig.default.filter([relativePath]).length === 0);
-        }
-
-        if ((typeof category === "undefined") || (category === "custom")) {
-            result = result || (this.ig.custom.filter([relativePath]).length === 0);
+        if (typeof category === "undefined") {
+            result = (this.ig.default.filter([relativePath]).length === 0) ||
+                (this.ig.custom.filter([relativePath]).length === 0);
+        } else {
+            result = (this.ig[category].filter([relativePath]).length === 0);
         }
 
         return result;

package/lib/rules/camelcase.js

@@ -22,6 +22,9 @@ module.exports = {
             {
                 type: "object",
                 properties: {
+                    ignoreDestructuring: {
+                        type: "boolean"
+                    },
                     properties: {
                         enum: ["always", "never"]
                     }
@@ -57,6 +60,26 @@ module.exports = {
             return name.indexOf("_") > -1 && name !== name.toUpperCase();
         }
 
+        /**
+         * Checks if a parent of a node is an ObjectPattern.
+         * @param {ASTNode} node The node to check.
+         * @returns {boolean} if the node is inside an ObjectPattern
+         * @private
+         */
+        function isInsideObjectPattern(node) {
+            let { parent } = node;
+
+            while (parent) {
+                if (parent.type === "ObjectPattern") {
+                    return true;
+                }
+
+                parent = parent.parent;
+            }
+
+            return false;
+        }
+
         /**
          * Reports an AST node as a rule violation.
          * @param {ASTNode} node The node to report.
@@ -72,6 +95,7 @@ module.exports = {
 
         const options = context.options[0] || {};
         let properties = options.properties || "";
+        const ignoreDestructuring = options.ignoreDestructuring || false;
 
         if (properties !== "always" && properties !== "never") {
             properties = "always";
@@ -113,24 +137,28 @@ module.exports = {
                 } else if (node.parent.type === "Property" || node.parent.type === "AssignmentPattern") {
 
                     if (node.parent.parent && node.parent.parent.type === "ObjectPattern") {
-
                         if (node.parent.shorthand && node.parent.value.left && isUnderscored(name)) {
 
                             report(node);
                         }
 
+                        const assignmentKeyEqualsValue = node.parent.key.name === node.parent.value.name;
+
                         // prevent checking righthand side of destructured object
-                        if (node.parent.key === node && node.parent.value !== node) {
+                        if (!assignmentKeyEqualsValue && node.parent.key === node) {
                             return;
                         }
 
-                        if (node.parent.value.name && isUnderscored(name)) {
+                        const valueIsUnderscored = node.parent.value.name && isUnderscored(name);
+
+                        // ignore destructuring if the option is set, unless a new identifier is created
+                        if (valueIsUnderscored && !(assignmentKeyEqualsValue && ignoreDestructuring)) {
                             report(node);
                         }
                     }
 
-                    // "never" check properties
-                    if (properties === "never") {
+                    // "never" check properties or always ignore destructuring
+                    if (properties === "never" || (ignoreDestructuring && isInsideObjectPattern(node))) {
                         return;
                     }