eslint 4.7.2 → 4.11.0

package/CHANGELOG.md

@@ -1,3 +1,126 @@
+v4.11.0 - November 10, 2017
+
+* d4557a6 Docs: disallow use of the comma operator using no-restricted-syntax (#9585) (薛定谔的猫)
+* d602f9e Upgrade: espree v3.5.2 (#9611) (Kai Cataldo)
+* 4def876 Chore: avoid handling rules instances in config-validator (#9364) (Teddy Katz)
+* fe5ac7e Chore: fix incorrect comment in safe-emitter.js (#9605) (Teddy Katz)
+* 6672fae Docs: Fixed a typo on lines-between-class-members doc (#9603) (Moinul Hossain)
+* 980ecd3 Chore: Update copyright and license info (#9599) (薛定谔的猫)
+* cc2c7c9 Build: use Node 8 in appveyor (#9595) (薛定谔的猫)
+* 2542f04 Docs: Add missing options for `lines-around-comment` (#9589) (Clément Fiorio)
+* b6a7490 Build: ensure fuzzer tests get run with `npm test` (#9590) (Teddy Katz)
+* 1073bc5 Build: remove shelljs-nodecli (refs #9533) (#9588) (Teddy Katz)
+* 7e3bf6a Fix: edge-cases of semi-style (#9560) (Toru Nagashima)
+* e5a37ce Fix: object-curly-newline for flow code (#9458) (Tiddo Langerak)
+* 9064b9c Chore: add equalTokens in ast-utils. (#9500) (薛定谔的猫)
+* b7c5b19 Fix: Correct [object Object] output of error.data. (#9561) (Jonathan Pool)
+* 51c8cf0 Docs: Disambiguate definition of Update tag (#9584) (Jonathan Pool)
+* afc3c75 Docs: clarify what eslint-config-eslint is (#9582) (Teddy Katz)
+* aedae9d Docs: fix spelling in valid-typeof example (#9574) (Maksim Degtyarev)
+* 4c5aaf3 Docs: Fix typo in no-underscore-dangle rule (#9567) (Fabien Lucas)
+* 3623600 Chore: upgrade ajv@5.3.0 (#9557) (薛定谔的猫)
+* 1b606cd Chore: Remove an indirect dependency on jsonify (#9444) (Rouven Weßling)
+* 4d7d7ab Update: Resolve npm installed formatters (#5900) (#9464) (Tom Erik Støwer)
+* accc490 Fix: Files with no failures get "passing" testcase (#9547) (Samuel Levy)
+* ab0f66d Docs: Add examples to better show rule coverage. (#9548) (Jonathan Pool)
+* 88d2303 Chore: Add object-property-newline tests to increase coverage. (#9553) (Jonathan Pool)
+* 7f37b1c Build: test Node 9 on Travis (#9556) (Teddy Katz)
+* acccfbd Docs: Minor rephrase in `no-invalid-this`. (#9542) (Francisc)
+* 8f9c0fe Docs: improve id-match usage advice (#9544) (Teddy Katz)
+* a9606a3 Fix: invalid tests with super (fixes #9539) (#9545) (Teddy Katz)
+* 8e1a095 Chore: enable a modified version of multiline-comment-style on codebase (#9452) (Teddy Katz)
+* cb60285 Chore: remove commented test for HTML formatter (#9532) (Teddy Katz)
+* 06b491e Docs: fix duplicate entries in changelog (#9530) (Teddy Katz)
+* 2224733 Chore: use eslint-plugin-rulesdir instead of --rulesdir for self-linting (#9164) (Teddy Katz)
+* 9cf4ebe Docs: add .md to link(for github users) (#9529) (薛定谔的猫)
+
+v4.10.0 - October 27, 2017
+
+* bb6e60a Fix: Improve the doc for no-restricted-modules rule (fixes #9437) (#9495) (vibss2397)
+* c529de9 Docs: Amend rule document to correct and complete it (refs #6251). (#9498) (Jonathan Pool)
+* f9c6673 Chore: Add tests to cover array and object values and leading commas. (#9502) (Jonathan Pool)
+* 9169258 Chore: remove `npm run check-commit` script (#9513) (Teddy Katz)
+* 7d390b2 Docs: Revise contributor documentation on issue labels. (#9469) (Jonathan Pool)
+* d80b9d0 Fix: no-var don't fix globals (fixes #9520) (#9525) (Toru Nagashima)
+* b8aa071 Fix: allow linting the empty string from stdin (fixes #9515) (#9517) (Teddy Katz)
+* 350a72c Chore: regex.test => string.startsWith (#9518) (薛定谔的猫)
+* de0bef4 Chore: remove obsolete eslintbot templates (#9512) (Teddy Katz)
+* 720b6d5 Docs: Update ISSUE_TEMPLATE.md (#9504) (薛定谔的猫)
+* 2fa64b7 Fix: should not convert non-consecutive line comments to a single blo… (#9475) (薛定谔的猫)
+* 9725146 Fix: multiline-comment-style fix produces invalid code (fixes #9461). (#9463) (薛定谔的猫)
+* b12cff8 Fix: Expected order of jsdoc tags (fixes #9412) (#9451) (Orlando Wenzinger)
+* f054ab5 Docs: add `.md` to link (for github users) (#9501) (薛定谔的猫)
+* 5ed9cfc Docs: Correct violations of “Variable Declarations” in Code Conventions (#9447) (Jonathan Pool)
+* 3171097 Docs: Clears confusion on usage of global and local plugins.(#9492) (Vasili Sviridov)
+* 3204773 Chore: enable max-len. (#9414) (薛定谔的猫)
+* 0f71fef Docs: Unquote booleans in lines-between-class-members docs (#9497) (Brandon Mills)
+* b3d7532 Docs: use consistent terminology & fix link etc. (#9490) (薛定谔的猫)
+* 87db8ae Docs: Fix broken links (#9488) (gpiress)
+* 51bdb2f Docs: Incorrect link to related rule (#9477) (Gavin King)
+* 1a962e8 Docs: Add FAQ for when ESLint cannot find plugin (#9467) (Kevin Partington)
+* 8768b2d Fix: multiline-comment-style autofixer added trailing space (#9454) (Teddy Katz)
+* e830aa1 Fix: multiline-comment-style reports block comments followed by code (#9450) (Teddy Katz)
+* b12e5fe Docs: Repair broken links and add migration links. (#9473) (Jonathan Pool)
+* eca01ed Docs: Add missing info about special status of home-dir config files. (#9472) (Jonathan Pool)
+* eb8cfb1 Fix: change err report in constant condition (fixes #9398) (#9436) (Victor Hom)
+* da77eb4 Chore: Revise no-config-file test to prevent false failure. (#9443) (Jonathan Pool)
+* 47e5f6f Docs: ensure "good commit message" examples actually follow guidelines (#9466) (Teddy Katz)
+* ebb530d Update: Don't ignore comments (no-trailing-spaces) (#9416) (Chris van Marle)
+* 5012661 Build: fix `npm run profile` script (fixes #9397) (#9455) (Teddy Katz)
+* ecac0fd Docs: Remove blockBindings references (#9446) (Jan Pilzer)
+* 0b89865 Chore: ensure tests for internal rules get run (#9453) (Teddy Katz)
+* 052c504 Docs: suggest deleting branches after merging PRs (#9449) (Teddy Katz)
+* b31e55a Chore: move internal rules out of lib/ (#9448) (Teddy Katz)
+* a7521e3 Docs: improve examples for multiline-comment-style (#9440) (Teddy Katz)
+
+v4.9.0 - October 14, 2017
+
+* 85388fb Fix: Correct error and test messages to fit config search path (#9428) (Jonathan Pool)
+* 62a323c Fix: Add class options for `lines-around-comment` (fixes #8564) (#8565) (Ed Lee)
+* 8eb4aae New: multiline-comment-style rule (fixes #8320) (#9389) (薛定谔的猫)
+* db41408 Chore: avoid applying eslint-env comments twice (#9278) (Teddy Katz)
+* febb897 Chore: avoid loose equality assertions (#9415) (Teddy Katz)
+* 2247efa Update: Add FunctionExpression to require-jsdoc (fixes #5867) (#9395) (Kai Cataldo)
+* 6791d18 Docs: Corrected noun to verb. (#9438) (Jonathan Pool)
+* b02fbb6 Update: custom messages for no-restricted-* (refs #8400) (Maja Wichrowska)
+* 02732bd Docs: Reorganized to avoid misunderstandings. (#9434) (Jonathan Pool)
+* d9466b8 Docs: Correct time forecast for tests. (#9432) (Jonathan Pool)
+* f7ed84f Docs: Add instruction re home-directory config files (refs #7729) (#9426) (Jonathan Pool)
+* 30d018b Chore: Add Aladdin-ADD & VictorHom to README (#9424) (Kai Cataldo)
+* 2d8a303 Docs: fix examples for prefer-numeric-literals (#9155) (Lutz Lengemann)
+* d7610f5 Docs: Add jquery warning to prefer-destructuring (#9409) (Thomas Grainger)
+* e835dd1 Docs: clarify no-mixed-operators (fixes #8051) (Ruxandra Fediuc)
+* 51360c8 Docs: update block-spacing details (fixes #8743) (#9375) (Victor Hom)
+* 6767857 Update: fix ignored nodes in indent rule when using tabs (fixes #9392) (#9393) (Robin Houston)
+* 37dde77 Chore: Refactor SourceCode#getJSDocComment (#9403) (Kai Cataldo)
+* 9fedd51 Chore: Add missing space in blog post template (#9407) (Kevin Partington)
+* 7654c99 Docs: add installing prerequisites in readme. (#9401) (薛定谔的猫)
+* 786cc73 Update: Add "consistent" option to array-bracket-newline (fixes #9136) (#9206) (Ethan Rutherford)
+* e171f6b Docs: add installing prerequisites. (#9394) (薛定谔的猫)
+* 74dfc87 Docs: update doc for class-methods-use-this (fixes #8910) (#9374) (Victor Hom)
+* b4a9dbf Docs: show console call with no-restricted-syntax (fixes #7806) (#9376) (Victor Hom)
+* 8da525f Fix: recognise multiline comments as multiline arrays (fixes #9211) (#9369) (Phil Quinn)
+* c581b77 Chore: Error => TypeError (#9390) (薛定谔的猫)
+* ee99876 New: lines-between-class-members rule (fixes #5949) (#9141) (薛定谔的猫)
+* 9d3f5ad Chore: report unused eslint-disable directives in ESLint codebase (#9371) (Teddy Katz)
+* 1167638 Update: add allowElseIf option to no-else-return (fixes #9228) (#9229) (Thomas Grainger)
+* 4567ab1 New: Add the fix-dry-run flag (fixes #9076) (#9073) (Rafał Ruciński)
+
+v4.8.0 - September 29, 2017
+
+* 3f2b908 New: add option to report unused eslint-disable directives (fixes #9249) (#9250) (Teddy Katz)
+* ff2be59 Fix: dot notation rule failing to catch string template (fixes #9350) (#9357) (Phil Quinn)
+* b1372da Chore: remove sourceCode property from Linter (refs #9161) (#9363) (Teddy Katz)
+* cef6f8c Docs: remove line about removing rules from semver policy (#9367) (Teddy Katz)
+* 06efe87 Fix: Add meta element with charset attribute. (#9365) (H1Gdev)
+* 458ca67 Docs: update architecture page (fixes #9337) (#9345) (Victor Hom)
+* 1c6bc67 Fix: special EventEmitter keys leak information about other rules (#9328) (Teddy Katz)
+* d593e61 Docs: update eslint.org links to use https (#9358) (Teddy Katz)
+* 38d0cb2 Fix: fix wrong code-path about try-for-in (fixes #8848) (#9348) (Toru Nagashima)
+* 434d9e2 Fix: Invalid font-size property value issue. (#9341) (H1Gdev)
+* a7668c2 Chore: Remove unnecessary slice from logging utility (#9343) (Gyandeep Singh)
+* 2ff6fb6 Chore: remove unused arguments in codebase (#9340) (Teddy Katz)
+
 v4.7.2 - September 21, 2017
 
 * 4f87732 Fix: Revert setting node.parent early (fixes #9331) (#9336) (Teddy Katz)

package/README.md

@@ -9,11 +9,11 @@
 
 # ESLint
 
-[Website](http://eslint.org) |
-[Configuring](http://eslint.org/docs/user-guide/configuring) |
-[Rules](http://eslint.org/docs/rules/) |
-[Contributing](http://eslint.org/docs/developer-guide/contributing) |
-[Reporting Bugs](http://eslint.org/docs/developer-guide/contributing/reporting-bugs) |
+[Website](https://eslint.org) |
+[Configuring](https://eslint.org/docs/user-guide/configuring) |
+[Rules](https://eslint.org/docs/rules/) |
+[Contributing](https://eslint.org/docs/developer-guide/contributing) |
+[Reporting Bugs](https://eslint.org/docs/developer-guide/contributing/reporting-bugs) |
 [Code of Conduct](https://js.foundation/community/code-of-conduct) |
 [Twitter](https://twitter.com/geteslint) |
 [Mailing List](https://groups.google.com/group/eslint) |
@@ -27,6 +27,8 @@ ESLint is a tool for identifying and reporting on patterns found in ECMAScript/J
 
 ## Installation and Usage
 
+Prerequisites: [Node.js](https://nodejs.org/en/) (>=4.x), npm version 2+.
+
 There are two ways to install ESLint: globally and locally.
 
 ### Local Installation and Usage
@@ -88,17 +90,17 @@ After running `eslint --init`, you'll have a `.eslintrc` file in your directory.
 }
 ```
 
-The names `"semi"` and `"quotes"` are the names of [rules](http://eslint.org/docs/rules) in ESLint. The first value is the error level of the rule and can be one of these values:
+The names `"semi"` and `"quotes"` are the names of [rules](https://eslint.org/docs/rules) in ESLint. The first value is the error level of the rule and can be one of these values:
 
 * `"off"` or `0` - turn the rule off
 * `"warn"` or `1` - turn the rule on as a warning (doesn't affect exit code)
 * `"error"` or `2` - turn the rule on as an error (exit code will be 1)
 
-The three error levels allow you fine-grained control over how ESLint applies rules (for more configuration options and details, see the [configuration docs](http://eslint.org/docs/user-guide/configuring)).
+The three error levels allow you fine-grained control over how ESLint applies rules (for more configuration options and details, see the [configuration docs](https://eslint.org/docs/user-guide/configuring)).
 
 ## Sponsors
 
-* Site search ([eslint.org](http://eslint.org)) is sponsored by [Algolia](https://www.algolia.com)
+* Site search ([eslint.org](https://eslint.org)) is sponsored by [Algolia](https://www.algolia.com)
 
 ## Team
 
@@ -132,6 +134,8 @@ These folks keep the project moving and are resources for help.
 * Vitor Balocco ([@vitorbal](https://github.com/vitorbal))
 * James Henry ([@JamesHenry](https://github.com/JamesHenry))
 * Reyad Attiyat ([@soda0289](https://github.com/soda0289))
+* 薛定谔的猫 ([@Aladdin-ADD](https://github.com/Aladdin-ADD))
+* Victor Hom ([@VictorHom](https://github.com/VictorHom))
 
 ## Releases
 
@@ -145,10 +149,10 @@ ESLint adheres to the [JS Foundation Code of Conduct](https://js.foundation/comm
 
 Before filing an issue, please be sure to read the guidelines for what you're reporting:
 
-* [Bug Report](http://eslint.org/docs/developer-guide/contributing/reporting-bugs)
-* [Propose a New Rule](http://eslint.org/docs/developer-guide/contributing/new-rules)
-* [Proposing a Rule Change](http://eslint.org/docs/developer-guide/contributing/rule-changes)
-* [Request a Change](http://eslint.org/docs/developer-guide/contributing/changes)
+* [Bug Report](https://eslint.org/docs/developer-guide/contributing/reporting-bugs)
+* [Propose a New Rule](https://eslint.org/docs/developer-guide/contributing/new-rules)
+* [Proposing a Rule Change](https://eslint.org/docs/developer-guide/contributing/rule-changes)
+* [Request a Change](https://eslint.org/docs/developer-guide/contributing/changes)
 
 ## Semantic Versioning Policy
 
@@ -171,7 +175,6 @@ ESLint follows [semantic versioning](http://semver.org). However, due to the nat
 * Major release (likely to break your lint build)
     * `eslint:recommended` is updated.
     * A new option to an existing rule that results in ESLint reporting more errors by default.
-    * An existing rule is removed.
     * An existing formatter is removed.
     * Part of the public API is removed or changed in an incompatible way.
 
@@ -195,32 +198,44 @@ Despite being slower, we believe that ESLint is fast enough to replace JSHint wi
 
 ### I heard ESLint is going to replace JSCS?
 
-Yes. Since we are solving the same problems, ESLint and JSCS teams have decided to join forces and work together in the development of ESLint instead of competing with each other. You can read more about this in both [ESLint](http://eslint.org/blog/2016/04/welcoming-jscs-to-eslint) and [JSCS](https://medium.com/@markelog/jscs-end-of-the-line-bc9bf0b3fdb2#.u76sx334n) announcements.
+Yes. Since we are solving the same problems, ESLint and JSCS teams have decided to join forces and work together in the development of ESLint instead of competing with each other. You can read more about this in both [ESLint](https://eslint.org/blog/2016/04/welcoming-jscs-to-eslint) and [JSCS](https://medium.com/@markelog/jscs-end-of-the-line-bc9bf0b3fdb2#.u76sx334n) announcements.
 
 ### So, should I stop using JSCS and start using ESLint?
 
-Maybe, depending on how much you need it. [JSCS has reached end of life](http://eslint.org/blog/2016/07/jscs-end-of-life), but if it is working for you then there is no reason to move yet. We are still working to smooth the transition. You can see our progress [here](https://github.com/eslint/eslint/milestones/JSCS%20Compatibility). We’ll announce when all of the changes necessary to support JSCS users in ESLint are complete and will start encouraging JSCS users to switch to ESLint at that time.
+Maybe, depending on how much you need it. [JSCS has reached end of life](https://eslint.org/blog/2016/07/jscs-end-of-life), but if it is working for you then there is no reason to move yet. We are still working to smooth the transition. You can see our progress [here](https://github.com/eslint/eslint/milestones/JSCS%20Compatibility). We’ll announce when all of the changes necessary to support JSCS users in ESLint are complete and will start encouraging JSCS users to switch to ESLint at that time.
 
 If you are having issues with JSCS, you can try to move to ESLint. We are focusing our time and energy on JSCS compatibility issues.
 
-
 ### Is ESLint just linting or does it also check style?
 
 ESLint does both traditional linting (looking for problematic patterns) and style checking (enforcement of conventions). You can use it for both.
 
+### Why can't ESLint find my plugins?
+
+ESLint can be [globally or locally installed](#installation-and-usage). If you install ESLint globally, your plugins must also be installed globally; if you install ESLint locally, your plugins must also be installed locally.
+
+If you are trying to run globally, make sure your plugins are installed globally (use `npm ls -g`).
+
+If you are trying to run locally:
+
+* Make sure your plugins (and ESLint) are both in your project's `package.json` as devDependencies (or dependencies, if your project uses ESLint at runtime).
+* Make sure you have run `npm install` and all your dependencies are installed.
+
+In all cases, make sure your plugins' peerDependencies have been installed as well. You can use `npm view eslint-plugin-myplugin peerDepencies` to see what peer dependencies `eslint-plugin-myplugin` has.
+
 ### Does ESLint support JSX?
 
-Yes, ESLint natively supports parsing JSX syntax (this must be enabled in [configuration](http://eslint.org/docs/user-guide/configuring).). Please note that supporting JSX syntax *is not* the same as supporting React. React applies specific semantics to JSX syntax that ESLint doesn't recognize. We recommend using [eslint-plugin-react](https://www.npmjs.com/package/eslint-plugin-react) if you are using React and want React semantics.
+Yes, ESLint natively supports parsing JSX syntax (this must be enabled in [configuration](https://eslint.org/docs/user-guide/configuring).). Please note that supporting JSX syntax *is not* the same as supporting React. React applies specific semantics to JSX syntax that ESLint doesn't recognize. We recommend using [eslint-plugin-react](https://www.npmjs.com/package/eslint-plugin-react) if you are using React and want React semantics.
 
 ### What about ECMAScript 6 support?
 
-ESLint has full support for ECMAScript 6. By default, this support is off. You can enable ECMAScript 6 syntax and global variables through [configuration](http://eslint.org/docs/user-guide/configuring).
+ESLint has full support for ECMAScript 6. By default, this support is off. You can enable ECMAScript 6 syntax and global variables through [configuration](https://eslint.org/docs/user-guide/configuring).
 
 ### What about experimental features?
 
 ESLint doesn't natively support experimental ECMAScript language features. You can use [babel-eslint](https://github.com/babel/babel-eslint) to use any option available in Babel.
 
-Once a language feature has been adopted into the ECMAScript standard (stage 4 according to the [TC39 process](https://tc39.github.io/process-document/)), we will accept issues and pull requests related to the new feature, subject to our [contributing guidelines](http://eslint.org/docs/developer-guide/contributing). Until then, please use the appropriate parser and plugin(s) for your experimental feature.
+Once a language feature has been adopted into the ECMAScript standard (stage 4 according to the [TC39 process](https://tc39.github.io/process-document/)), we will accept issues and pull requests related to the new feature, subject to our [contributing guidelines](https://eslint.org/docs/developer-guide/contributing). Until then, please use the appropriate parser and plugin(s) for your experimental feature.
 
 ### Where to ask for help?
 

package/conf/default-cli-options.js

@@ -17,11 +17,14 @@ module.exports = {
     ignorePath: null,
     cache: false,
 
-    // in order to honor the cacheFile option if specified
-    // this option should not have a default value otherwise
-    // it will always be used
+    /*
+     * in order to honor the cacheFile option if specified
+     * this option should not have a default value otherwise
+     * it will always be used
+     */
     cacheLocation: "",
     cacheFile: ".eslintcache",
     fix: false,
-    allowInlineConfig: true
+    allowInlineConfig: true,
+    reportUnusedDisableDirectives: false
 };

package/conf/eslint-recommended.js

@@ -63,6 +63,7 @@ module.exports = {
         "linebreak-style": "off",
         "lines-around-comment": "off",
         "lines-around-directive": "off",
+        "lines-between-class-members": "off",
         "max-depth": "off",
         "max-len": "off",
         "max-lines": "off",
@@ -70,6 +71,7 @@ module.exports = {
         "max-params": "off",
         "max-statements": "off",
         "max-statements-per-line": "off",
+        "multiline-comment-style": "off",
         "multiline-ternary": "off",
         "new-cap": "off",
         "new-parens": "off",

package/lib/ast-utils.js

@@ -406,6 +406,31 @@ function createGlobalLinebreakMatcher() {
     return new RegExp(LINEBREAK_MATCHER.source, "g");
 }
 
+/**
+ * Checks whether or not the tokens of two given nodes are same.
+ * @param {ASTNode} left - A node 1 to compare.
+ * @param {ASTNode} right - A node 2 to compare.
+ * @param {SourceCode} sourceCode - The ESLint source code object.
+ * @returns {boolean} the source code for the given node.
+ */
+function equalTokens(left, right, sourceCode) {
+    const tokensL = sourceCode.getTokens(left);
+    const tokensR = sourceCode.getTokens(right);
+
+    if (tokensL.length !== tokensR.length) {
+        return false;
+    }
+    for (let i = 0; i < tokensL.length; ++i) {
+        if (tokensL[i].type !== tokensR[i].type ||
+            tokensL[i].value !== tokensR[i].value
+        ) {
+            return false;
+        }
+    }
+
+    return true;
+}
+
 //------------------------------------------------------------------------------
 // Public Interface
 //------------------------------------------------------------------------------
@@ -438,6 +463,7 @@ module.exports = {
     isArrayFromMethod,
     isParenthesised,
     createGlobalLinebreakMatcher,
+    equalTokens,
 
     isArrowToken,
     isClosingBraceToken,
@@ -620,15 +646,17 @@ module.exports = {
                     node = parent;
                     break;
 
-                // If the upper function is IIFE, checks the destination of the return value.
-                // e.g.
-                //   obj.foo = (function() {
-                //     // setup...
-                //     return function foo() { ... };
-                //   })();
-                //   obj.foo = (() =>
-                //     function foo() { ... }
-                //   )();
+                /*
+                 * If the upper function is IIFE, checks the destination of the return value.
+                 * e.g.
+                 *   obj.foo = (function() {
+                 *     // setup...
+                 *     return function foo() { ... };
+                 *   })();
+                 *   obj.foo = (() =>
+                 *     function foo() { ... }
+                 *   )();
+                 */
                 case "ReturnStatement": {
                     const func = getUpperFunction(parent);
 
@@ -645,23 +673,27 @@ module.exports = {
                     node = parent.parent;
                     break;
 
-                // e.g.
-                //   var obj = { foo() { ... } };
-                //   var obj = { foo: function() { ... } };
-                //   class A { constructor() { ... } }
-                //   class A { foo() { ... } }
-                //   class A { get foo() { ... } }
-                //   class A { set foo() { ... } }
-                //   class A { static foo() { ... } }
+                /*
+                 * e.g.
+                 *   var obj = { foo() { ... } };
+                 *   var obj = { foo: function() { ... } };
+                 *   class A { constructor() { ... } }
+                 *   class A { foo() { ... } }
+                 *   class A { get foo() { ... } }
+                 *   class A { set foo() { ... } }
+                 *   class A { static foo() { ... } }
+                 */
                 case "Property":
                 case "MethodDefinition":
                     return parent.value !== node;
 
-                // e.g.
-                //   obj.foo = function foo() { ... };
-                //   Foo = function() { ... };
-                //   [obj.foo = function foo() { ... }] = a;
-                //   [Foo = function() { ... }] = a;
+                /*
+                 * e.g.
+                 *   obj.foo = function foo() { ... };
+                 *   Foo = function() { ... };
+                 *   [obj.foo = function foo() { ... }] = a;
+                 *   [Foo = function() { ... }] = a;
+                 */
                 case "AssignmentExpression":
                 case "AssignmentPattern":
                     if (parent.left.type === "MemberExpression") {
@@ -676,8 +708,10 @@ module.exports = {
                     }
                     return true;
 
-                // e.g.
-                //   var Foo = function() { ... };
+                /*
+                 * e.g.
+                 *   var Foo = function() { ... };
+                 */
                 case "VariableDeclarator":
                     return !(
                         isAnonymous &&
@@ -686,10 +720,12 @@ module.exports = {
                         startsWithUpperCase(parent.id.name)
                     );
 
-                // e.g.
-                //   var foo = function foo() { ... }.bind(obj);
-                //   (function foo() { ... }).call(obj);
-                //   (function foo() { ... }).apply(obj, []);
+                /*
+                 * e.g.
+                 *   var foo = function foo() { ... }.bind(obj);
+                 *   (function foo() { ... }).call(obj);
+                 *   (function foo() { ... }).apply(obj, []);
+                 */
                 case "MemberExpression":
                     return (
                         parent.object !== node ||
@@ -700,10 +736,12 @@ module.exports = {
                         isNullOrUndefined(parent.parent.arguments[0])
                     );
 
-                // e.g.
-                //   Reflect.apply(function() {}, obj, []);
-                //   Array.from([], function() {}, obj);
-                //   list.forEach(function() {}, obj);
+                /*
+                 * e.g.
+                 *   Reflect.apply(function() {}, obj, []);
+                 *   Array.from([], function() {}, obj);
+                 *   list.forEach(function() {}, obj);
+                 */
                 case "CallExpression":
                     if (isReflectApply(parent.callee)) {
                         return (
@@ -930,8 +968,10 @@ module.exports = {
             node.type === "FunctionDeclaration" ||
             node.type === "FunctionExpression" ||
 
-            // Do not check arrow functions with implicit return.
-            // `() => "use strict";` returns the string `"use strict"`.
+            /*
+             * Do not check arrow functions with implicit return.
+             * `() => "use strict";` returns the string `"use strict"`.
+             */
             (node.type === "ArrowFunctionExpression" && node.body.type === "BlockStatement")
         ) {
             const statements = node.type === "Program" ? node.body : node.body.body;
@@ -954,7 +994,7 @@ module.exports = {
 
     /**
      * Determines whether this node is a decimal integer literal. If a node is a decimal integer literal, a dot added
-     after the node will be parsed as a decimal point, rather than a property-access dot.
+     * after the node will be parsed as a decimal point, rather than a property-access dot.
      * @param {ASTNode} node - The node to check.
      * @returns {boolean} `true` if this node is a decimal integer.
      * @example
@@ -1041,7 +1081,8 @@ module.exports = {
         } else if (parent.type === "Property" || parent.type === "MethodDefinition") {
             if (parent.kind === "constructor") {
                 return "constructor";
-            } else if (parent.kind === "get") {
+            }
+            if (parent.kind === "get") {
                 tokens.push("getter");
             } else if (parent.kind === "set") {
                 tokens.push("setter");
@@ -1182,12 +1223,12 @@ module.exports = {
     },
 
     /**
-    * Gets the parenthesized text of a node. This is similar to sourceCode.getText(node), but it also includes any parentheses
-    * surrounding the node.
-    * @param {SourceCode} sourceCode The source code object
-    * @param {ASTNode} node An expression node
-    * @returns {string} The text representing the node, with all surrounding parentheses included
-    */
+     * Gets the parenthesized text of a node. This is similar to sourceCode.getText(node), but it also includes any parentheses
+     * surrounding the node.
+     * @param {SourceCode} sourceCode The source code object
+     * @param {ASTNode} node An expression node
+     * @returns {string} The text representing the node, with all surrounding parentheses included
+     */
     getParenthesisedText(sourceCode, node) {
         let leftToken = sourceCode.getFirstToken(node);
         let rightToken = sourceCode.getLastToken(node);

package/lib/cli-engine.js

@@ -24,12 +24,16 @@ const fs = require("fs"),
     fileEntryCache = require("file-entry-cache"),
     globUtil = require("./util/glob-util"),
     validator = require("./config/config-validator"),
-    stringify = require("json-stable-stringify"),
+    stringify = require("json-stable-stringify-without-jsonify"),
     hash = require("./util/hash"),
+    ModuleResolver = require("./util/module-resolver"),
+    naming = require("./util/naming"),
     pkg = require("../package.json");
 
 const debug = require("debug")("eslint:cli-engine");
 
+const resolver = new ModuleResolver();
+
 //------------------------------------------------------------------------------
 // Typedefs
 //------------------------------------------------------------------------------
@@ -56,6 +60,7 @@ const debug = require("debug")("eslint:cli-engine");
  * @property {string[]} plugins An array of plugins to load.
  * @property {Object<string,*>} rules An object of rules to use.
  * @property {string[]} rulePaths An array of directories to load custom rules from.
+ * @property {boolean} reportUnusedDisableDirectives `true` adds reports for unused eslint-disable directives
  */
 
 /**
@@ -137,11 +142,12 @@ function calculateStatsPerRun(results) {
  * @param {string} filename An optional string representing the texts filename.
  * @param {boolean|Function} fix Indicates if fixes should be processed.
  * @param {boolean} allowInlineConfig Allow/ignore comments that change config.
+ * @param {boolean} reportUnusedDisableDirectives Allow/ignore comments that change config.
  * @param {Linter} linter Linter context
  * @returns {LintResult} The results for linting on this text.
  * @private
  */
-function processText(text, configHelper, filename, fix, allowInlineConfig, linter) {
+function processText(text, configHelper, filename, fix, allowInlineConfig, reportUnusedDisableDirectives, linter) {
     let filePath,
         fileExtension,
         processor;
@@ -173,6 +179,7 @@ function processText(text, configHelper, filename, fix, allowInlineConfig, linte
     const fixedResult = linter.verifyAndFix(text, config, {
         filename,
         allowInlineConfig,
+        reportUnusedDisableDirectives,
         fix: !!autofixingEnabled && fix,
         preprocess: processor && (rawText => processor.preprocess(rawText, filename)),
         postprocess: processor && (problemLists => processor.postprocess(problemLists, filename))
@@ -213,7 +220,15 @@ function processText(text, configHelper, filename, fix, allowInlineConfig, linte
 function processFile(filename, configHelper, options, linter) {
 
     const text = fs.readFileSync(path.resolve(filename), "utf8"),
-        result = processText(text, configHelper, filename, options.fix, options.allowInlineConfig, linter);
+        result = processText(
+            text,
+            configHelper,
+            filename,
+            options.fix,
+            options.allowInlineConfig,
+            options.reportUnusedDisableDirectives,
+            linter
+        );
 
     return result;
 
@@ -229,8 +244,8 @@ function processFile(filename, configHelper, options, linter) {
 function createIgnoreResult(filePath, baseDir) {
     let message;
     const isHidden = /^\./.test(path.basename(filePath));
-    const isInNodeModules = baseDir && /^node_modules/.test(path.relative(baseDir, filePath));
-    const isInBowerComponents = baseDir && /^bower_components/.test(path.relative(baseDir, filePath));
+    const isInNodeModules = baseDir && path.relative(baseDir, filePath).startsWith("node_modules");
+    const isInBowerComponents = baseDir && path.relative(baseDir, filePath).startsWith("bower_components");
 
     if (isHidden) {
         message = "File ignored by default.  Use a negated ignore pattern (like \"--ignore-pattern '!<relative/path/to/filename>'\") to override.";
@@ -394,9 +409,13 @@ class CLIEngine {
             });
         }
 
-        Object.keys(this.options.rules || {}).forEach(name => {
-            validator.validateRuleOptions(name, this.options.rules[name], "CLI", this.linter.rules);
-        });
+        if (this.options.rules && Object.keys(this.options.rules).length) {
+            const loadedRules = this.linter.getRules();
+
+            Object.keys(this.options.rules).forEach(name => {
+                validator.validateRuleOptions(loadedRules.get(name), name, this.options.rules[name], "CLI");
+            });
+        }
 
         this.config = new Config(this.options, this.linter);
     }
@@ -531,10 +550,10 @@ class CLIEngine {
                 if (result.messages.length) {
 
                     /*
-                    * if a file contains errors or warnings we don't want to
-                    * store the file in the cache so we can guarantee that
-                    * next execution will also operate on this file
-                    */
+                     * if a file contains errors or warnings we don't want to
+                     * store the file in the cache so we can guarantee that
+                     * next execution will also operate on this file
+                     */
                     fileCache.removeEntry(result.filePath);
                 } else {
 
@@ -591,7 +610,17 @@ class CLIEngine {
                 results.push(createIgnoreResult(filename, options.cwd));
             }
         } else {
-            results.push(processText(text, configHelper, filename, options.fix, options.allowInlineConfig, this.linter));
+            results.push(
+                processText(
+                    text,
+                    configHelper,
+                    filename,
+                    options.fix,
+                    options.allowInlineConfig,
+                    options.reportUnusedDisableDirectives,
+                    this.linter
+                )
+            );
         }
 
         const stats = calculateStatsPerRun(results);
@@ -649,15 +678,22 @@ class CLIEngine {
             // replace \ with / for Windows compatibility
             format = format.replace(/\\/g, "/");
 
+            const cwd = this.options ? this.options.cwd : process.cwd();
+            const namespace = naming.getNamespaceFromTerm(format);
+
             let formatterPath;
 
             // if there's a slash, then it's a file
-            if (format.indexOf("/") > -1) {
-                const cwd = this.options ? this.options.cwd : process.cwd();
-
+            if (!namespace && format.indexOf("/") > -1) {
                 formatterPath = path.resolve(cwd, format);
             } else {
-                formatterPath = `./formatters/${format}`;
+                try {
+                    const npmFormat = naming.normalizePackageName(format, "eslint-formatter");
+
+                    formatterPath = resolver.resolve(npmFormat, `${cwd}/node_modules`);
+                } catch (e) {
+                    formatterPath = `./formatters/${format}`;
+                }
             }
 
             try {