eslint 4.16.0 → 4.18.2

package/lib/rules/no-control-regex.js

@@ -18,7 +18,11 @@ module.exports = {
             url: "https://eslint.org/docs/rules/no-control-regex"
         },
 
-        schema: []
+        schema: [],
+
+        messages: {
+            unexpected: "Unexpected control character(s) in regular expression: {{controlChars}}."
+        }
     },
 
     create(context) {
@@ -26,7 +30,7 @@ module.exports = {
         /**
          * Get the regex expression
          * @param {ASTNode} node node to evaluate
-         * @returns {*} Regex if found else null
+         * @returns {RegExp|null} Regex if found else null
          * @private
          */
         function getRegExp(node) {
@@ -114,7 +118,7 @@ module.exports = {
                     if (controlCharacters.length > 0) {
                         context.report({
                             node,
-                            message: "Unexpected control character(s) in regular expression: {{controlChars}}.",
+                            messageId: "unexpected",
                             data: {
                                 controlChars: controlCharacters.join(", ")
                             }

package/lib/rules/no-debugger.js

@@ -20,7 +20,10 @@ module.exports = {
             url: "https://eslint.org/docs/rules/no-debugger"
         },
         fixable: "code",
-        schema: []
+        schema: [],
+        messages: {
+            unexpected: "Unexpected 'debugger' statement."
+        }
     },
 
     create(context) {
@@ -29,7 +32,7 @@ module.exports = {
             DebuggerStatement(node) {
                 context.report({
                     node,
-                    message: "Unexpected 'debugger' statement.",
+                    messageId: "unexpected",
                     fix(fixer) {
                         if (astUtils.STATEMENT_LIST_PARENTS.has(node.parent.type)) {
                             return fixer.remove(node);

package/lib/rules/no-delete-var.js

@@ -18,7 +18,11 @@ module.exports = {
             url: "https://eslint.org/docs/rules/no-delete-var"
         },
 
-        schema: []
+        schema: [],
+
+        messages: {
+            unexpected: "Variables should not be deleted."
+        }
     },
 
     create(context) {
@@ -27,7 +31,7 @@ module.exports = {
 
             UnaryExpression(node) {
                 if (node.operator === "delete" && node.argument.type === "Identifier") {
-                    context.report({ node, message: "Variables should not be deleted." });
+                    context.report({ node, messageId: "unexpected" });
                 }
             }
         };

package/lib/rules/no-div-regex.js

@@ -18,7 +18,11 @@ module.exports = {
             url: "https://eslint.org/docs/rules/no-div-regex"
         },
 
-        schema: []
+        schema: [],
+
+        messages: {
+            unexpected: "A regular expression literal can be confused with '/='."
+        }
     },
 
     create(context) {
@@ -30,7 +34,7 @@ module.exports = {
                 const token = sourceCode.getFirstToken(node);
 
                 if (token.type === "RegularExpression" && token.value[1] === "=") {
-                    context.report({ node, message: "A regular expression literal can be confused with '/='." });
+                    context.report({ node, messageId: "unexpected" });
                 }
             }
         };

package/lib/rules/no-dupe-args.js

@@ -18,7 +18,11 @@ module.exports = {
             url: "https://eslint.org/docs/rules/no-dupe-args"
         },
 
-        schema: []
+        schema: [],
+
+        messages: {
+            unexpected: "Duplicate param '{{name}}'."
+        }
     },
 
     create(context) {
@@ -54,7 +58,7 @@ module.exports = {
                 if (defs.length >= 2) {
                     context.report({
                         node,
-                        message: "Duplicate param '{{name}}'.",
+                        messageId: "unexpected",
                         data: { name: variable.name }
                     });
                 }

package/lib/rules/no-dupe-class-members.js

@@ -18,7 +18,11 @@ module.exports = {
             url: "https://eslint.org/docs/rules/no-dupe-class-members"
         },
 
-        schema: []
+        schema: [],
+
+        messages: {
+            unexpected: "Duplicate name '{{name}}'."
+        }
     },
 
     create(context) {
@@ -102,7 +106,7 @@ module.exports = {
                 }
 
                 if (isDuplicate) {
-                    context.report({ node, message: "Duplicate name '{{name}}'.", data: { name } });
+                    context.report({ node, messageId: "unexpected", data: { name } });
                 }
             }
         };

package/lib/rules/no-dupe-keys.js

@@ -91,7 +91,11 @@ module.exports = {
             url: "https://eslint.org/docs/rules/no-dupe-keys"
         },
 
-        schema: []
+        schema: [],
+
+        messages: {
+            unexpected: "Duplicate key '{{name}}'."
+        }
     },
 
     create(context) {
@@ -123,7 +127,7 @@ module.exports = {
                     context.report({
                         node: info.node,
                         loc: node.key.loc,
-                        message: "Duplicate key '{{name}}'.",
+                        messageId: "unexpected",
                         data: { name }
                     });
                 }

package/lib/rules/no-duplicate-case.js

@@ -19,7 +19,11 @@ module.exports = {
             url: "https://eslint.org/docs/rules/no-duplicate-case"
         },
 
-        schema: []
+        schema: [],
+
+        messages: {
+            unexpected: "Duplicate case label."
+        }
     },
 
     create(context) {
@@ -33,7 +37,7 @@ module.exports = {
                     const key = sourceCode.getText(switchCase.test);
 
                     if (mapping[key]) {
-                        context.report({ node: switchCase, message: "Duplicate case label." });
+                        context.report({ node: switchCase, messageId: "unexpected" });
                     } else {
                         mapping[key] = switchCase;
                     }

package/lib/rules/no-else-return.js

@@ -34,7 +34,12 @@ module.exports = {
             },
             additionalProperties: false
         }],
-        fixable: "code"
+
+        fixable: "code",
+
+        messages: {
+            unexpected: "Unnecessary 'else' after 'return'."
+        }
     },
 
     create(context) {
@@ -52,7 +57,7 @@ module.exports = {
         function displayReport(node) {
             context.report({
                 node,
-                message: "Unnecessary 'else' after 'return'.",
+                messageId: "unexpected",
                 fix: fixer => {
                     const sourceCode = context.getSourceCode();
                     const startToken = sourceCode.getFirstToken(node);

package/lib/rules/no-empty-character-class.js

@@ -36,7 +36,11 @@ module.exports = {
             url: "https://eslint.org/docs/rules/no-empty-character-class"
         },
 
-        schema: []
+        schema: [],
+
+        messages: {
+            unexpected: "Empty class."
+        }
     },
 
     create(context) {
@@ -48,7 +52,7 @@ module.exports = {
                 const token = sourceCode.getFirstToken(node);
 
                 if (token.type === "RegularExpression" && !regex.test(token.value)) {
-                    context.report({ node, message: "Empty class." });
+                    context.report({ node, messageId: "unexpected" });
                 }
             }
 

package/lib/rules/no-empty-function.js

@@ -109,7 +109,11 @@ module.exports = {
                 },
                 additionalProperties: false
             }
-        ]
+        ],
+
+        messages: {
+            unexpected: "Unexpected empty {{name}}."
+        }
     },
 
     create(context) {
@@ -146,7 +150,7 @@ module.exports = {
                 context.report({
                     node,
                     loc: node.body.loc.start,
-                    message: "Unexpected empty {{name}}.",
+                    messageId: "unexpected",
                     data: { name }
                 });
             }

package/lib/rules/no-empty-pattern.js

@@ -17,19 +17,23 @@ module.exports = {
             url: "https://eslint.org/docs/rules/no-empty-pattern"
         },
 
-        schema: []
+        schema: [],
+
+        messages: {
+            unexpected: "Unexpected empty {{type}} pattern."
+        }
     },
 
     create(context) {
         return {
             ObjectPattern(node) {
                 if (node.properties.length === 0) {
-                    context.report({ node, message: "Unexpected empty object pattern." });
+                    context.report({ node, messageId: "unexpected", data: { type: "object" } });
                 }
             },
             ArrayPattern(node) {
                 if (node.elements.length === 0) {
-                    context.report({ node, message: "Unexpected empty array pattern." });
+                    context.report({ node, messageId: "unexpected", data: { type: "array" } });
                 }
             }
         };

package/lib/rules/no-empty.js

@@ -33,7 +33,11 @@ module.exports = {
                 },
                 additionalProperties: false
             }
-        ]
+        ],
+
+        messages: {
+            unexpected: "Empty {{type}} statement."
+        }
     },
 
     create(context) {
@@ -64,13 +68,13 @@ module.exports = {
                     return;
                 }
 
-                context.report({ node, message: "Empty block statement." });
+                context.report({ node, messageId: "unexpected", data: { type: "block" } });
             },
 
             SwitchStatement(node) {
 
                 if (typeof node.cases === "undefined" || node.cases.length === 0) {
-                    context.report({ node, message: "Empty switch statement." });
+                    context.report({ node, messageId: "unexpected", data: { type: "switch" } });
                 }
             }
         };

package/lib/rules/no-eq-null.js

@@ -19,7 +19,11 @@ module.exports = {
             url: "https://eslint.org/docs/rules/no-eq-null"
         },
 
-        schema: []
+        schema: [],
+
+        messages: {
+            unexpected: "Use '===' to compare with null."
+        }
     },
 
     create(context) {
@@ -31,7 +35,7 @@ module.exports = {
 
                 if (node.right.type === "Literal" && node.right.raw === "null" && badOperator ||
                         node.left.type === "Literal" && node.left.raw === "null" && badOperator) {
-                    context.report({ node, message: "Use '===' to compare with null." });
+                    context.report({ node, messageId: "unexpected" });
                 }
             }
         };

package/lib/rules/no-eval.js

@@ -91,7 +91,11 @@ module.exports = {
                 },
                 additionalProperties: false
             }
-        ]
+        ],
+
+        messages: {
+            unexpected: "eval can be harmful."
+        }
     },
 
     create(context) {
@@ -160,7 +164,7 @@ module.exports = {
             context.report({
                 node,
                 loc: locationNode.loc.start,
-                message: "eval can be harmful."
+                messageId: "unexpected"
             });
         }
 

package/lib/rules/no-ex-assign.js

@@ -20,7 +20,11 @@ module.exports = {
             url: "https://eslint.org/docs/rules/no-ex-assign"
         },
 
-        schema: []
+        schema: [],
+
+        messages: {
+            unexpected: "Do not assign to the exception parameter."
+        }
     },
 
     create(context) {
@@ -32,7 +36,7 @@ module.exports = {
          */
         function checkVariable(variable) {
             astUtils.getModifyingReferences(variable.references).forEach(reference => {
-                context.report({ node: reference.identifier, message: "Do not assign to the exception parameter." });
+                context.report({ node: reference.identifier, messageId: "unexpected" });
             });
         }
 

package/lib/rules/no-extend-native.js

@@ -45,7 +45,11 @@ module.exports = {
                 },
                 additionalProperties: false
             }
-        ]
+        ],
+
+        messages: {
+            unexpected: "{{builtin}} prototype is read only, properties should not be added."
+        }
     },
 
     create(context) {
@@ -67,7 +71,7 @@ module.exports = {
         function reportNode(node, builtin) {
             context.report({
                 node,
-                message: "{{builtin}} prototype is read only, properties should not be added.",
+                messageId: "unexpected",
                 data: {
                     builtin
                 }

package/lib/rules/no-extra-bind.js

@@ -25,7 +25,11 @@ module.exports = {
 
         schema: [],
 
-        fixable: "code"
+        fixable: "code",
+
+        messages: {
+            unexpected: "The function binding is unnecessary."
+        }
     },
 
     create(context) {
@@ -41,7 +45,7 @@ module.exports = {
         function report(node) {
             context.report({
                 node: node.parent.parent,
-                message: "The function binding is unnecessary.",
+                messageId: "unexpected",
                 loc: node.parent.property.loc.start,
                 fix(fixer) {
                     const firstTokenToRemove = context.getSourceCode()

package/lib/rules/no-extra-boolean-cast.js

@@ -26,7 +26,12 @@ module.exports = {
 
         schema: [],
 
-        fixable: "code"
+        fixable: "code",
+
+        messages: {
+            unexpectedCall: "Redundant Boolean call.",
+            unexpectedNegation: "Redundant double negation."
+        }
     },
 
     create(context) {
@@ -82,7 +87,7 @@ module.exports = {
                 ) {
                     context.report({
                         node,
-                        message: "Redundant double negation.",
+                        messageId: "unexpectedNegation",
                         fix: fixer => fixer.replaceText(parent, sourceCode.getText(node.argument))
                     });
                 }
@@ -97,7 +102,7 @@ module.exports = {
                 if (isInBooleanContext(node, parent)) {
                     context.report({
                         node,
-                        message: "Redundant Boolean call.",
+                        messageId: "unexpectedCall",
                         fix: fixer => {
                             if (!node.arguments.length) {
                                 return fixer.replaceText(parent, "true");

package/lib/rules/no-extra-label.js

@@ -26,7 +26,11 @@ module.exports = {
 
         schema: [],
 
-        fixable: "code"
+        fixable: "code",
+
+        messages: {
+            unexpected: "This label '{{name}}' is unnecessary."
+        }
     },
 
     create(context) {
@@ -109,7 +113,7 @@ module.exports = {
                     if (info.breakable && info.label && info.label.name === labelNode.name) {
                         context.report({
                             node: labelNode,
-                            message: "This label '{{name}}' is unnecessary.",
+                            messageId: "unexpected",
                             data: labelNode,
                             fix: fixer => fixer.removeRange([sourceCode.getFirstToken(node).range[1], labelNode.range[1]])
                         });

package/lib/rules/no-extra-parens.js

@@ -55,6 +55,10 @@ module.exports = {
                     maxItems: 2
                 }
             ]
+        },
+
+        messages: {
+            unexpected: "Gratuitous parentheses around expression."
         }
     },
 
@@ -312,7 +316,7 @@ module.exports = {
             context.report({
                 node,
                 loc: leftParenToken.loc.start,
-                message: "Gratuitous parentheses around expression.",
+                messageId: "unexpected",
                 fix(fixer) {
                     const parenthesizedSource = sourceCode.text.slice(leftParenToken.range[1], rightParenToken.range[0]);
 

package/lib/rules/no-extra-semi.js

@@ -26,7 +26,11 @@ module.exports = {
         },
 
         fixable: "code",
-        schema: []
+        schema: [],
+
+        messages: {
+            unexpected: "Unnecessary semicolon."
+        }
     },
 
     create(context) {
@@ -40,7 +44,7 @@ module.exports = {
         function report(nodeOrToken) {
             context.report({
                 node: nodeOrToken,
-                message: "Unnecessary semicolon.",
+                messageId: "unexpected",
                 fix(fixer) {
 
                     /*

package/lib/rules/no-self-assign.js

@@ -121,7 +121,9 @@ function eachSelfAssignment(left, right, props, report) {
         let startJ = 0;
 
         for (let i = right.properties.length - 1; i >= 0; --i) {
-            if (right.properties[i].type === "ExperimentalSpreadProperty") {
+            const propType = right.properties[i].type;
+
+            if (propType === "SpreadElement" || propType === "ExperimentalSpreadProperty") {
                 startJ = i + 1;
                 break;
             }

package/lib/rules/no-unused-vars.js

@@ -65,7 +65,7 @@ module.exports = {
     create(context) {
         const sourceCode = context.getSourceCode();
 
-        const REST_PROPERTY_TYPE = /^(?:Experimental)?RestProperty$/;
+        const REST_PROPERTY_TYPE = /^(?:RestElement|(?:Experimental)?RestProperty)$/;
 
         const config = {
             vars: "all",