eslint 10.2.1 → 10.3.0

package/README.md

@@ -360,7 +360,7 @@ to get your logo on our READMEs and [website](https://eslint.org/sponsors).
 <p><a href="https://automattic.com"><img src="https://images.opencollective.com/automattic/d0ef3e1/logo.png" alt="Automattic" height="128"></a></p><h3>Gold Sponsors</h3>
 <p><a href="https://qlty.sh/"><img src="https://images.opencollective.com/qltysh/33d157d/logo.png" alt="Qlty Software" height="96"></a></p><h3>Silver Sponsors</h3>
 <p><a href="https://vite.dev/"><img src="https://images.opencollective.com/vite/d472863/logo.png" alt="Vite" height="64"></a> <a href="https://liftoff.io/"><img src="https://images.opencollective.com/liftoff/2d6c3b6/logo.png" alt="Liftoff" height="64"></a> <a href="https://stackblitz.com"><img src="https://avatars.githubusercontent.com/u/28635252" alt="StackBlitz" height="64"></a></p><h3>Bronze Sponsors</h3>
-<p><a href="https://cybozu.co.jp/"><img src="https://images.opencollective.com/cybozu/933e46d/logo.png" alt="Cybozu" height="32"></a> <a href="https://opensource.sap.com"><img src="https://avatars.githubusercontent.com/u/2531208" alt="SAP" height="32"></a> <a href="https://www.crawljobs.com/"><img src="https://images.opencollective.com/crawljobs-poland/fa43a17/logo.png" alt="CrawlJobs" height="32"></a> <a href="https://depot.dev"><img src="https://images.opencollective.com/depot/39125a1/logo.png" alt="Depot" height="32"></a> <a href="https://icons8.com/"><img src="https://images.opencollective.com/icons8/7fa1641/logo.png" alt="Icons8" height="32"></a> <a href="https://discord.com"><img src="https://images.opencollective.com/discordapp/f9645d9/logo.png" alt="Discord" height="32"></a> <a href="https://www.gitbook.com"><img src="https://avatars.githubusercontent.com/u/7111340" alt="GitBook" height="32"></a> <a href="https://herocoders.com"><img src="https://avatars.githubusercontent.com/u/37549774" alt="HeroCoders" height="32"></a> <a href="https://www.lambdatest.com"><img src="https://avatars.githubusercontent.com/u/171592363" alt="TestMu AI Open Source Office (Formerly LambdaTest)" height="32"></a></p>
+<p><a href="https://cybozu.co.jp/"><img src="https://images.opencollective.com/cybozu/933e46d/logo.png" alt="Cybozu" height="32"></a> <a href="https://opensource.sap.com"><img src="https://avatars.githubusercontent.com/u/2531208" alt="SAP" height="32"></a> <a href="https://www.crawljobs.com/"><img src="https://images.opencollective.com/crawljobs-poland/fa43a17/logo.png" alt="CrawlJobs" height="32"></a> <a href="https://depot.dev"><img src="https://images.opencollective.com/depot/39125a1/logo.png" alt="Depot" height="32"></a> <a href="https://icons8.com/"><img src="https://images.opencollective.com/icons8/7fa1641/logo.png" alt="Icons8" height="32"></a> <a href="https://discord.com"><img src="https://images.opencollective.com/discordapp/f9645d9/logo.png" alt="Discord" height="32"></a> <a href="https://www.gitbook.com"><img src="https://avatars.githubusercontent.com/u/7111340" alt="GitBook" height="32"></a> <a href="https://herocoders.com"><img src="https://avatars.githubusercontent.com/u/37549774" alt="HeroCoders" height="32"></a> <a href="https://citadel.co.jp"><img src="https://avatars.githubusercontent.com/u/75781367" alt="Citadel AI" height="32"></a> <a href="https://www.lambdatest.com"><img src="https://avatars.githubusercontent.com/u/171592363" alt="TestMu AI Open Source Office (Formerly LambdaTest)" height="32"></a></p>
 <h3>Technology Sponsors</h3>
 Technology sponsors allow us to use their products and services for free as part of a contribution to the open source ecosystem and our work.
 <p><a href="https://netlify.com"><img src="https://raw.githubusercontent.com/eslint/eslint.org/main/src/assets/images/techsponsors/netlify-icon.svg" alt="Netlify" height="32"></a> <a href="https://algolia.com"><img src="https://raw.githubusercontent.com/eslint/eslint.org/main/src/assets/images/techsponsors/algolia-icon.svg" alt="Algolia" height="32"></a> <a href="https://1password.com"><img src="https://raw.githubusercontent.com/eslint/eslint.org/main/src/assets/images/techsponsors/1password-icon.svg" alt="1Password" height="32"></a></p>

package/lib/config/config-loader.js

@@ -230,7 +230,7 @@ async function loadConfigFile(filePath, hasUnstableNativeNodeJsTSConfigFlag) {
 	 * the require cache only if the file has been changed.
 	 */
 	if (importedConfigFileModificationTime.get(filePath) !== mtime) {
-		delete require.cache[filePath];
+		delete require.cache?.[filePath];
 	}
 
 	const isTS = isFileTS(filePath);

package/lib/linter/code-path-analysis/code-path-analyzer.js

@@ -77,8 +77,8 @@ function getLabel(node) {
 }
 
 /**
- * Checks whether or not a given logical expression node goes different path
- * between the `true` case and the `false` case.
+ * Checks whether a given logical expression node takes different paths for the
+ * `true` and `false` cases.
  * @param {ASTNode} node A node to check.
  * @returns {boolean} `true` if the node is a test of a choice statement.
  */
@@ -107,8 +107,8 @@ function isForkingByTrueOrFalse(node) {
 /**
  * Gets the boolean value of a given literal node.
  *
- * This is used to detect infinity loops (e.g. `while (true) {}`).
- * Statements preceded by an infinity loop are unreachable if the loop didn't
+ * This is used to detect infinite loops (e.g. `while (true) {}`).
+ * Statements preceded by an infinite loop are unreachable if the loop didn't
  * have any `break` statement.
  * @param {ASTNode} node A node to get.
  * @returns {boolean|undefined} a boolean value if the node is a Literal node,
@@ -221,8 +221,8 @@ function forwardCurrentToHead(analyzer, node) {
 }
 
 /**
- * Updates the current segment with empty.
- * This is called at the last of functions or the program.
+ * Updates the current segment with an empty array.
+ * This is called when a code path ends.
  * @param {CodePathAnalyzer} analyzer The instance.
  * @param {ASTNode} node The current AST node.
  * @returns {void}
@@ -727,7 +727,7 @@ function postprocess(analyzer, node) {
 	 *     a = () => {}
 	 * }
 	 *
-	 * In this case, The ArrowFunctionExpression code path is closed first
+	 * In this case, the ArrowFunctionExpression code path is closed first,
 	 * and then we need to close the code path for the PropertyDefinition
 	 * value.
 	 */

package/lib/linter/code-path-analysis/id-generator.js

@@ -32,10 +32,9 @@ class IdGenerator {
 	next() {
 		this.n = (1 + this.n) | 0;
 
-		/* c8 ignore start */
 		if (this.n < 0) {
 			this.n = 1;
-		} /* c8 ignore stop */
+		}
 
 		return this.prefix + this.n;
 	}

package/lib/rules/no-unused-private-class-members.js

@@ -5,6 +5,12 @@
 
 "use strict";
 
+//------------------------------------------------------------------------------
+// Requirements
+//------------------------------------------------------------------------------
+
+const astUtils = require("./utils/ast-utils");
+
 //------------------------------------------------------------------------------
 // Rule Definition
 //------------------------------------------------------------------------------
@@ -13,6 +19,7 @@
 module.exports = {
 	meta: {
 		type: "problem",
+		hasSuggestions: true,
 
 		docs: {
 			description: "Disallow unused private class members",
@@ -25,12 +32,168 @@ module.exports = {
 		messages: {
 			unusedPrivateClassMember:
 				"'{{classMemberName}}' is defined but never used.",
+			removeUnusedPrivateClassMember:
+				"Remove unused private class member '{{classMemberName}}'.",
 		},
 	},
 
 	create(context) {
+		const sourceCode = context.sourceCode;
 		const trackedClasses = [];
 
+		/**
+		 * Gets the start index of the line that contains a given token or node.
+		 * @param {ASTNode|Token|Comment} nodeOrToken The token or node to check
+		 * @returns {number} The line start index
+		 */
+		function getLineStartIndex(nodeOrToken) {
+			return nodeOrToken.range[0] - nodeOrToken.loc.start.column;
+		}
+
+		/**
+		 * Checks whether a token or node starts on its own line, preceded only by whitespace.
+		 * @param {ASTNode|Token|Comment} nodeOrToken The token or node to check
+		 * @returns {boolean} Whether the token or node starts on its own line
+		 */
+		function startsOnOwnLine(nodeOrToken) {
+			return (
+				sourceCode.getTokenBefore(nodeOrToken, {
+					includeComments: true,
+				}).loc.end.line !== nodeOrToken.loc.start.line
+			);
+		}
+
+		/**
+		 * Gets leading comments that are directly attached to a class member.
+		 * @param {ASTNode} classMemberNode The class member node
+		 * @returns {Comment[]} Leading comments to remove with the member
+		 */
+		function getLeadingComments(classMemberNode) {
+			const commentsBefore =
+				sourceCode.getCommentsBefore(classMemberNode);
+			const lastNonLeadingCommentIndex = commentsBefore.findLastIndex(
+				(comment, index, self) => {
+					const next =
+						index < self.length - 1
+							? self[index + 1]
+							: classMemberNode;
+
+					return (
+						!startsOnOwnLine(comment) ||
+						next.loc.start.line - comment.loc.end.line > 1
+					);
+				},
+			);
+
+			return commentsBefore.slice(lastNonLeadingCommentIndex + 1);
+		}
+
+		/**
+		 * Checks whether a class member shares its line with another token.
+		 * @param {ASTNode} classMemberNode The class member node
+		 * @returns {boolean} Whether the member shares its line with another token
+		 */
+		function sharesLineWithAnotherToken(classMemberNode) {
+			const previousToken = sourceCode.getTokenBefore(classMemberNode);
+			const nextToken = sourceCode.getTokenAfter(classMemberNode);
+
+			return (
+				previousToken.loc.end.line === classMemberNode.loc.start.line ||
+				nextToken.loc.start.line === classMemberNode.loc.end.line
+			);
+		}
+
+		/**
+		 * Gets trailing comments that are directly attached to a class member.
+		 * Same-line trailing comments are preserved when another token shares
+		 * the line, because the comment might describe the remaining code rather
+		 * than the unused member alone.
+		 * @param {ASTNode} classMemberNode The class member node
+		 * @returns {Comment[]} Trailing comments to remove with the member
+		 */
+		function getTrailingComments(classMemberNode) {
+			if (sharesLineWithAnotherToken(classMemberNode)) {
+				return [];
+			}
+
+			return sourceCode
+				.getCommentsAfter(classMemberNode)
+				.filter(
+					comment =>
+						comment.loc.start.line === classMemberNode.loc.end.line,
+				);
+		}
+
+		/**
+		 * Gets the token after which a semicolon should be inserted when removing a class member.
+		 * @param {ASTNode} classMemberNode The member that would be removed
+		 * @returns {Token|null} The token after which a semicolon should be inserted, or null if no semicolon is needed
+		 */
+		function getSemicolonInsertionToken(classMemberNode) {
+			const nextToken = sourceCode.getTokenAfter(classMemberNode);
+
+			if (
+				astUtils.canContinueExpressionInClassBody(nextToken) &&
+				astUtils.needsPrecedingSemicolon(sourceCode, classMemberNode)
+			) {
+				return sourceCode.getTokenBefore(classMemberNode);
+			}
+
+			return null;
+		}
+
+		/**
+		 * Gets the replacement range for removing an unused class member.
+		 * @param {ASTNode} classMemberNode The member that would be removed
+		 * @returns {number[]} The text range to remove
+		 */
+		function getMemberRemovalRange(classMemberNode) {
+			const leadingComments = getLeadingComments(classMemberNode);
+			const trailingComments = getTrailingComments(classMemberNode);
+			const shouldRemoveLeadingComments =
+				leadingComments.length > 0 &&
+				!sharesLineWithAnotherToken(classMemberNode);
+			const lastItemToRemove =
+				trailingComments.length > 0
+					? trailingComments.at(-1)
+					: classMemberNode;
+
+			const previousToken = sourceCode.getTokenBefore(classMemberNode);
+			const nextToken = sourceCode.getTokenAfter(lastItemToRemove, {
+				includeComments: true,
+			});
+			const nextTokenStartsOnNewLine =
+				nextToken.loc.start.line > lastItemToRemove.loc.end.line;
+			const shouldRemoveOwnLine =
+				!shouldRemoveLeadingComments &&
+				startsOnOwnLine(classMemberNode) &&
+				nextTokenStartsOnNewLine;
+			let start = classMemberNode.range[0];
+			let end = lastItemToRemove.range[1];
+
+			if (shouldRemoveLeadingComments) {
+				start = nextTokenStartsOnNewLine
+					? getLineStartIndex(leadingComments[0])
+					: leadingComments[0].range[0];
+				end = nextTokenStartsOnNewLine
+					? getLineStartIndex(nextToken)
+					: nextToken.range[0];
+			} else if (shouldRemoveOwnLine) {
+				start = getLineStartIndex(classMemberNode);
+				end = getLineStartIndex(nextToken);
+			} else if (
+				previousToken.loc.end.line === classMemberNode.loc.start.line
+			) {
+				start = previousToken.range[1];
+			} else if (
+				nextToken.loc.start.line === lastItemToRemove.loc.end.line
+			) {
+				end = nextToken.range[0];
+			}
+
+			return [start, end];
+		}
+
 		/**
 		 * Check whether the current node is in a write only assignment.
 		 * @param {ASTNode} privateIdentifierNode Node referring to a private identifier
@@ -86,6 +249,7 @@ module.exports = {
 						if (bodyMember.key.type === "PrivateIdentifier") {
 							privateMembers.set(bodyMember.key.name, {
 								declaredNode: bodyMember,
+								hasReference: false,
 								isAccessor:
 									bodyMember.type === "MethodDefinition" &&
 									(bodyMember.kind === "set" ||
@@ -128,6 +292,8 @@ module.exports = {
 					return;
 				}
 
+				memberDefinition.hasReference = true;
+
 				/*
 				 * Any usage of an accessor is considered a read, as the getter/setter can have
 				 * side-effects in its definition.
@@ -199,11 +365,12 @@ module.exports = {
 
 				for (const [
 					classMemberName,
-					{ declaredNode, isUsed },
+					{ declaredNode, hasReference, isUsed },
 				] of unusedPrivateMembers.entries()) {
 					if (isUsed) {
 						continue;
 					}
+
 					context.report({
 						node: declaredNode,
 						loc: declaredNode.key.loc,
@@ -211,6 +378,39 @@ module.exports = {
 						data: {
 							classMemberName: `#${classMemberName}`,
 						},
+						suggest: [
+							{
+								messageId: "removeUnusedPrivateClassMember",
+								data: {
+									classMemberName: `#${classMemberName}`,
+								},
+								*fix(fixer) {
+									if (hasReference) {
+										return;
+									}
+
+									const removalRange =
+										getMemberRemovalRange(declaredNode);
+									const semicolonInsertionToken =
+										getSemicolonInsertionToken(
+											declaredNode,
+										);
+									const removalFix = fixer.replaceTextRange(
+										removalRange,
+										"",
+									);
+
+									yield removalFix;
+
+									if (semicolonInsertionToken) {
+										yield fixer.insertTextAfter(
+											semicolonInsertionToken,
+											";",
+										);
+									}
+								},
+							},
+						],
 					});
 				}
 			},

package/lib/rules/no-useless-concat.js

@@ -33,7 +33,7 @@ function isConcatOperatorToken(token) {
 }
 
 /**
- * Get's the right most node on the left side of a BinaryExpression with + operator.
+ * Gets the right most node on the left side of a BinaryExpression with + operator.
  * @param {ASTNode} node A BinaryExpression node to check.
  * @returns {ASTNode} node
  */
@@ -47,7 +47,7 @@ function getLeft(node) {
 }
 
 /**
- * Get's the left most node on the right side of a BinaryExpression with + operator.
+ * Gets the left most node on the right side of a BinaryExpression with + operator.
  * @param {ASTNode} node A BinaryExpression node to check.
  * @returns {ASTNode} node
  */

package/lib/rules/no-useless-constructor.js

@@ -237,8 +237,9 @@ module.exports = {
 								const nextToken =
 									sourceCode.getTokenAfter(node);
 								const addSemiColon =
-									nextToken.type === "Punctuator" &&
-									nextToken.value === "[" &&
+									astUtils.canContinueExpressionInClassBody(
+										nextToken,
+									) &&
 									astUtils.needsPrecedingSemicolon(
 										sourceCode,
 										node,

package/lib/rules/require-await.js

@@ -110,12 +110,14 @@ module.exports = {
 				 */
 				const nextToken = sourceCode.getTokenAfter(asyncToken);
 				const addSemiColon =
-					nextToken.type === "Punctuator" &&
-					(nextToken.value === "[" || nextToken.value === "(") &&
-					(nodeWithAsyncKeyword.type === "MethodDefinition" ||
+					((astUtils.isOpeningParenToken(nextToken) &&
 						astUtils.isStartOfExpressionStatement(
 							nodeWithAsyncKeyword,
-						)) &&
+						)) ||
+						(nodeWithAsyncKeyword.type === "MethodDefinition" &&
+							astUtils.canContinueExpressionInClassBody(
+								nextToken,
+							))) &&
 					astUtils.needsPrecedingSemicolon(
 						sourceCode,
 						nodeWithAsyncKeyword,

package/lib/rules/utils/ast-utils.js

@@ -1258,12 +1258,31 @@ function isStartOfExpressionStatement(node) {
 }
 
 /**
- * Determines whether an opening parenthesis `(`, bracket `[` or backtick ``` ` ``` needs to be preceded by a semicolon.
- * This opening parenthesis or bracket should be at the start of an `ExpressionStatement`, a `MethodDefinition` or at
- * the start of the body of an `ArrowFunctionExpression`.
+ * Checks whether a token can cause continuation of a preceding expression
+ * (for example, of a class field initializer expression) in a class body.
+ * This function checks specifically for tokens that can appear at the start
+ * of a class member: `[` (computed key), `*` (generator method), `in` or `instanceof` (valid keys)
+ * Without a preceding semicolon, these tokens would be parsed as index access or operators.
+ * @param {Token} token The token to check.
+ * @returns {boolean} Whether the token can cause continuation of a preceding expression.
+ */
+function canContinueExpressionInClassBody(token) {
+	return (
+		(token.type === "Punctuator" &&
+			(token.value === "[" || token.value === "*")) ||
+		// Different parsers may return these tokens as either "Identifier" or "Keyword"
+		((token.type === "Identifier" || token.type === "Keyword") &&
+			(token.value === "in" || token.value === "instanceof"))
+	);
+}
+
+/**
+ * Determines whether an opening parenthesis `(`, bracket `[`, asterisk `*`, or backtick ``` ` ``` needs to be preceded by a semicolon.
+ * This opening parenthesis or bracket should be at the start of an `ExpressionStatement`, a `MethodDefinition`, a `PropertyDefinition`,
+ * or at the start of the body of an `ArrowFunctionExpression`.
  * @type {(sourceCode: SourceCode, node: ASTNode) => boolean}
  * @param {SourceCode} sourceCode The source code object.
- * @param {ASTNode} node A node at the position where an opening parenthesis or bracket will be inserted.
+ * @param {ASTNode} node A node at the position where an opening parenthesis, bracket, or asterisk will be inserted.
  * @returns {boolean} Whether a semicolon is required before the opening parenthesis or bracket.
  */
 let needsPrecedingSemicolon;
@@ -1354,6 +1373,18 @@ let needsPrecedingSemicolon;
 
 		const prevNode = sourceCode.getNodeByRangeIndex(prevToken.range[0]);
 
+		// Uninitialized class fields don't need a semicolon
+		if (
+			// Key
+			(prevNode.parent.type === "PropertyDefinition" &&
+				prevNode.parent.key === prevNode) ||
+			// Closing bracket of a computed key
+			(prevNode.type === "PropertyDefinition" &&
+				isClosingBracketToken(prevToken))
+		) {
+			return false;
+		}
+
 		if (
 			prevNode.type === "TSDeclareFunction" ||
 			prevNode.parent.type === "TSImportEqualsDeclaration" ||
@@ -2842,6 +2873,7 @@ module.exports = {
 	isTopLevelExpressionStatement,
 	isDirective,
 	isStartOfExpressionStatement,
+	canContinueExpressionInClassBody,
 	needsPrecedingSemicolon,
 	isImportAttributeKey,
 	getOpeningParenOfParams,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint",
-  "version": "10.2.1",
+  "version": "10.3.0",
   "author": "Nicholas C. Zakas <nicholas+npm@nczconsulting.com>",
   "description": "An AST-based pattern checker for JavaScript.",
   "type": "commonjs",
@@ -72,6 +72,8 @@
     "test": "node Makefile.js test",
     "test:browser": "node Makefile.js cypress",
     "test:cli": "mocha",
+    "test:ecosystem": "node tools/test-ecosystem/index.mjs",
+    "test:ecosystem:update": "node tools/test-ecosystem/update.mjs",
     "test:emfile": "node tools/check-emfile-handling.js",
     "test:fuzz": "node Makefile.js fuzz",
     "test:performance": "node Makefile.js perf",
@@ -157,7 +159,7 @@
     "@eslint/json": "^1.2.0",
     "@types/esquery": "^1.5.4",
     "@types/node": "^22.13.14",
-    "@typescript-eslint/parser": "^8.56.0",
+    "@typescript-eslint/parser": "^8.58.2",
     "babel-loader": "^8.0.5",
     "c8": "^11.0.0",
     "chai": "^4.0.1",
@@ -196,7 +198,7 @@
     "mocha": "^11.7.1",
     "node-polyfill-webpack-plugin": "^1.0.3",
     "npm-license": "^0.3.3",
-    "prettier": "3.8.2",
+    "prettier": "3.8.3",
     "progress": "^2.0.3",
     "proxyquire": "^2.0.1",
     "recast": "^0.23.0",
@@ -204,7 +206,7 @@
     "semver": "^7.5.3",
     "shelljs": "^0.10.0",
     "sinon": "^11.0.0",
-    "typescript": "^5.9.3",
+    "typescript": "^6.0.3",
     "webpack": "^5.23.0",
     "webpack-cli": "^4.5.0",
     "yorkie": "^2.0.0"