eslint-plugin-zod-utils 1.0.1 → 1.0.2

package/README.md

@@ -49,7 +49,7 @@ Legacy eslintrc:
 
 ### `zod-utils/no-inline-zod-schema`
 
-Requires Zod schemas to be created as module-level variable declarations. This avoids recreating schemas inside functions, callbacks, render paths, hooks, or argument lists.
+Requires Zod schemas to be created during module initialization. This avoids recreating schemas inside functions, callbacks, render paths, hooks, or instance fields.
 
 This rule was inspired by the motivation behind [`babel-plugin-zod-hoist`](https://github.com/gajus/babel-plugin-zod-hoist#motivation), which documents the cost of repeatedly initializing equivalent Zod schemas and the benefits of hoisting them.
 
@@ -70,10 +70,10 @@ function parseUser(input: unknown) {
 ```ts
 import { z } from "zod";
 
-app.post("/users", {
-  body: z.object({
+app.post("/users", (request) => {
+  return z.object({
     id: z.string(),
-  }),
+  }).parse(request.body);
 });
 ```
 
@@ -91,6 +91,16 @@ function parseUser(input: unknown) {
 }
 ```
 
+```ts
+import { z } from "zod";
+
+app.post("/users", {
+  body: z.object({
+    id: z.string(),
+  }),
+});
+```
+
 The rule understands `import { z } from "zod"`, `import * as zod from "zod"`, aliased `z` imports, and direct named schema factories such as `import { object, string } from "zod"`.
 
 ## Development

package/dist/index.cjs

@@ -141,28 +141,6 @@ function isZodImportSpecifier(node) {
   const importedName = node.imported.type === "Identifier" ? node.imported.name : node.imported.value;
   return ZOD_NAMESPACE_IMPORTS.has(importedName) || ZOD_FACTORY_IMPORTS.has(importedName);
 }
-function unwrapExpression(node) {
-  let current = node;
-  while (current.parent?.type === "TSAsExpression" || current.parent?.type === "TSNonNullExpression" || current.parent?.type === "TSSatisfiesExpression" || current.parent?.type === "TSTypeAssertion") {
-    current = current.parent;
-  }
-  return current;
-}
-function isModuleLevelVariableInitializer(node) {
-  const expression = unwrapExpression(node);
-  if (expression.parent?.type !== "VariableDeclarator") {
-    return false;
-  }
-  if (expression.parent.init !== expression) {
-    return false;
-  }
-  const declaration = expression.parent.parent;
-  if (declaration.type !== "VariableDeclaration") {
-    return false;
-  }
-  const container = declaration.parent;
-  return container.type === "Program" || container.type === "ExportNamedDeclaration" && container.parent.type === "Program";
-}
 var noInlineZodSchema = import_utils.ESLintUtils.RuleCreator(
   (ruleName2) => `https://www.npmjs.com/package/eslint-plugin-zod-utils#${ruleName2}`
 )({
@@ -173,7 +151,7 @@ var noInlineZodSchema = import_utils.ESLintUtils.RuleCreator(
       description: "Disallow creating Zod schemas outside module scope."
     },
     messages: {
-      inlineSchema: "Create Zod schemas at module scope instead of inline inside functions, callbacks, classes, or arguments."
+      inlineSchema: "Create Zod schemas during module initialization instead of inside functions, callbacks, or other repeated execution paths."
     },
     schema: []
   },
@@ -199,6 +177,19 @@ var noInlineZodSchema = import_utils.ESLintUtils.RuleCreator(
       }
       return false;
     }
+    function isInsideRepeatedExecutionPath(node) {
+      let current = node.parent;
+      while (current) {
+        if (current.type === "FunctionDeclaration" || current.type === "FunctionExpression" || current.type === "ArrowFunctionExpression") {
+          return true;
+        }
+        if (current.type === "PropertyDefinition" && !current.static) {
+          return true;
+        }
+        current = current.parent;
+      }
+      return false;
+    }
     return {
       CallExpression(node) {
         if (!isZodSchemaCall(node)) {
@@ -207,7 +198,7 @@ var noInlineZodSchema = import_utils.ESLintUtils.RuleCreator(
         if (hasZodCallAncestor(node)) {
           return;
         }
-        if (isModuleLevelVariableInitializer(node)) {
+        if (!isInsideRepeatedExecutionPath(node)) {
           return;
         }
         context.report({

package/dist/index.js

@@ -113,28 +113,6 @@ function isZodImportSpecifier(node) {
   const importedName = node.imported.type === "Identifier" ? node.imported.name : node.imported.value;
   return ZOD_NAMESPACE_IMPORTS.has(importedName) || ZOD_FACTORY_IMPORTS.has(importedName);
 }
-function unwrapExpression(node) {
-  let current = node;
-  while (current.parent?.type === "TSAsExpression" || current.parent?.type === "TSNonNullExpression" || current.parent?.type === "TSSatisfiesExpression" || current.parent?.type === "TSTypeAssertion") {
-    current = current.parent;
-  }
-  return current;
-}
-function isModuleLevelVariableInitializer(node) {
-  const expression = unwrapExpression(node);
-  if (expression.parent?.type !== "VariableDeclarator") {
-    return false;
-  }
-  if (expression.parent.init !== expression) {
-    return false;
-  }
-  const declaration = expression.parent.parent;
-  if (declaration.type !== "VariableDeclaration") {
-    return false;
-  }
-  const container = declaration.parent;
-  return container.type === "Program" || container.type === "ExportNamedDeclaration" && container.parent.type === "Program";
-}
 var noInlineZodSchema = ESLintUtils.RuleCreator(
   (ruleName2) => `https://www.npmjs.com/package/eslint-plugin-zod-utils#${ruleName2}`
 )({
@@ -145,7 +123,7 @@ var noInlineZodSchema = ESLintUtils.RuleCreator(
       description: "Disallow creating Zod schemas outside module scope."
     },
     messages: {
-      inlineSchema: "Create Zod schemas at module scope instead of inline inside functions, callbacks, classes, or arguments."
+      inlineSchema: "Create Zod schemas during module initialization instead of inside functions, callbacks, or other repeated execution paths."
     },
     schema: []
   },
@@ -171,6 +149,19 @@ var noInlineZodSchema = ESLintUtils.RuleCreator(
       }
       return false;
     }
+    function isInsideRepeatedExecutionPath(node) {
+      let current = node.parent;
+      while (current) {
+        if (current.type === "FunctionDeclaration" || current.type === "FunctionExpression" || current.type === "ArrowFunctionExpression") {
+          return true;
+        }
+        if (current.type === "PropertyDefinition" && !current.static) {
+          return true;
+        }
+        current = current.parent;
+      }
+      return false;
+    }
     return {
       CallExpression(node) {
         if (!isZodSchemaCall(node)) {
@@ -179,7 +170,7 @@ var noInlineZodSchema = ESLintUtils.RuleCreator(
         if (hasZodCallAncestor(node)) {
           return;
         }
-        if (isModuleLevelVariableInitializer(node)) {
+        if (!isInsideRepeatedExecutionPath(node)) {
           return;
         }
         context.report({

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-zod-utils",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "ESLint utilities for safer Zod schema usage.",
   "type": "module",
   "main": "./dist/index.cjs",