eslint-plugin-yenz 2.2.0-beta.1 → 2.2.0

package/README.md

@@ -124,7 +124,7 @@ class Foo { bar = () => {} }
 ## Preset Configurations
 
 - `**recommended**` - Enables `type-ordering` as error and `no-loops` as warning
-- `**all**` - Enables all rules (`type-ordering`, `no-loops`, `no-named-arrow-functions`) as errors
+- `**all**` - Enables `type-ordering`, `no-loops`, and `no-named-arrow-functions` as errors
 
 # Release Procedure
 
@@ -134,14 +134,17 @@ class Foo { bar = () => {} }
 4. Add code samples in `test/` that intentionally fail your new or updated rules to confirm they are caught.
 5. Commit and push your changes, then open a PR.
 6. **Bump to a pre-release version and publish a beta:**
+
   ```bash
    yarn version --pre[major|minor|patch] --preid beta
    npm publish --tag beta                # or alpha, rc
   ```
+
    Users can test it with:
 7. After review, **merge your branch into `main`**.
 8. Open a version bump PR against `main` and merge it in.
 9. **Publish the stable release** from `main`:
+
   ```bash
    yarn version --[major|minor|patch]
    npm publish

package/lib/rules/export-at-end-of-file.js

@@ -149,6 +149,49 @@ function formatMergedSpecifierExport(items) {
     .join(', ')} }`;
 }
 
+/**
+ * Returns a location that covers only the exported header (for example
+ * `export function foo()` through the closing `)`), not the whole declaration
+ * body, so editors underline the signature instead of the entire block.
+ *
+ * @param {object} exportNamedNode - Inline `ExportNamedDeclaration`.
+ * @param {import('eslint').SourceCode} sourceCode
+ * @returns {object} ESLint `SourceLocation` (`start` / `end` in line/column).
+ */
+function getInlineExportReportLoc(exportNamedNode, sourceCode) {
+  const declaration = exportNamedNode.declaration;
+  const { start } = exportNamedNode.loc;
+
+  const endsBeforeBraceBody =
+    (declaration.type === 'FunctionDeclaration'
+      || declaration.type === 'ClassDeclaration'
+      || declaration.type === 'TSInterfaceDeclaration')
+    && declaration.body;
+
+  if (endsBeforeBraceBody) {
+    const bodyOpenIndex = declaration.body.range[0];
+    return {
+      start,
+      end: sourceCode.getLocFromIndex(bodyOpenIndex),
+    };
+  }
+
+  if (declaration.type === 'TSTypeAliasDeclaration') {
+    const anchor = declaration.typeParameters ?? declaration.id;
+    const equalsToken = sourceCode.getTokenAfter(anchor, {
+      filter: (token) => token.type === 'Punctuator' && token.value === '=',
+    });
+    if (equalsToken) {
+      return {
+        start,
+        end: sourceCode.getLocFromIndex(equalsToken.range[0]),
+      };
+    }
+  }
+
+  return exportNamedNode.loc;
+}
+
 const exportAtEndOfFileRule = {
   meta: {
     type: 'suggestion',
@@ -180,7 +223,7 @@ const exportAtEndOfFileRule = {
 
         violations.forEach((node) => {
           context.report({
-            node,
+            loc: getInlineExportReportLoc(node, sourceCode),
             message:
               'Declare this without inline export and list it in a single export statement at the end of the file.',
             ...(node === lastViolation

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-yenz",
-  "version": "2.2.0-beta.1",
+  "version": "2.2.0",
   "description": "Adds custom rules that Jens likes",
   "repository": "https://github.com/JensAstrup/eslint-plugin-yenz",
   "type": "module",
@@ -21,7 +21,7 @@
   "license": "ISC",
   "devDependencies": {
     "eslint": "^10.0.1",
-    "typescript": "^5.0.0",
+    "typescript": "^6.0.3",
     "typescript-eslint": "^8.0.0"
   },
   "peerDependencies": {

package/test/fixtures.ts

@@ -47,3 +47,9 @@ export class ExportClass { method() { return 1; } } // expect-error yenz/export-
 export type FixtureExportType = 1 // expect-error yenz/export-at-end-of-file // fix: type FixtureExportType = 1
 
 export interface FixtureExportIface { n: number } // expect-error yenz/export-at-end-of-file // fix: interface FixtureExportIface { n: number }
+
+// Should pass (export-at-end-of-file — specifier exports and non-exported decls only):
+function notExported() {}
+function someExisting() {}
+export { someExisting }
+export { foo } from './other'