eslint-plugin-unicorn 70.0.0 → 71.1.0

package/rules/consistent-json-file-read.js

@@ -113,15 +113,12 @@ function isBufferEncoding(node, scope) {
 
 function isJsonReadFileCall(node, scope) {
 	if (
-		!(
-			node
+		!(node
 			&& node.type === 'CallExpression'
 			&& !node.optional
 			&& (node.arguments.length === 1 || node.arguments.length === 2)
 			&& node.arguments.every(node => node.type !== 'SpreadElement')
-			&& node.callee.type === 'MemberExpression'
-			&& !node.callee.optional
-		)
+			&& node.callee.type === 'MemberExpression') || node.callee.optional
 	) {
 		return false;
 	}

package/rules/dom-node-dataset.js

@@ -1,4 +1,3 @@
-import helperValidatorIdentifier from '@babel/helper-validator-identifier';
 import {findVariable} from '@eslint-community/eslint-utils';
 import {
 	escapeString,
@@ -12,6 +11,7 @@ import {
 	needsSemicolon,
 	shouldAddParenthesesToMemberExpressionObject,
 	wouldRemoveComments,
+	isIdentifierName,
 } from './utils/index.js';
 import {removeStatement} from './fix/index.js';
 import {
@@ -21,7 +21,6 @@ import {
 	isExpressionStatement,
 } from './ast/index.js';
 
-const {isIdentifierName} = helperValidatorIdentifier;
 const MESSAGE_ID = 'prefer-dataset';
 const INVERSE_MESSAGE_ID = 'prefer-attributes';
 const messages = {
@@ -106,11 +105,8 @@ function getDatasetVariableReadMembers(variable) {
 
 		const {identifier} = reference;
 		const member = identifier.parent;
-		if (!(
-			member.type === 'MemberExpression'
-			&& member.object === identifier
-			&& !member.optional
-		)) {
+		if (!(member.type === 'MemberExpression'
+			&& member.object === identifier) || member.optional) {
 			return;
 		}
 

package/rules/escape-case.js

@@ -24,14 +24,14 @@ const getProblem = ({node, original, regex = escapeCase, lowercase, fix}) => {
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
-	const lowercase = context.options[0] === 'lowercase';
+	const isLowercase = context.options[0] === 'lowercase';
 
 	context.on('Literal', node => {
 		if (isStringLiteral(node)) {
 			return getProblem({
 				node,
 				original: node.raw,
-				lowercase,
+				lowercase: isLowercase,
 			});
 		}
 	});
@@ -42,7 +42,7 @@ const create = context => {
 				node,
 				original: node.raw,
 				regex: escapePatternCase,
-				lowercase,
+				lowercase: isLowercase,
 			});
 		}
 	});
@@ -55,7 +55,7 @@ const create = context => {
 		return getProblem({
 			node,
 			original: node.value.raw,
-			lowercase,
+			lowercase: isLowercase,
 			fix: (fixer, fixed) => replaceTemplateElement(node, fixed, context, fixer),
 		});
 	});

package/rules/expiring-todo-comments.js

@@ -191,8 +191,8 @@ function getPackageHelpers(dirname) {
 
 		// Check if have to skip colon
 		// @example "TODO [...]: message here"
-		const dropColon = afterArguments[0] === ':';
-		if (dropColon) {
+		const isDropColon = afterArguments[0] === ':';
+		if (isDropColon) {
 			return afterArguments.slice(1).trim();
 		}
 

package/rules/explicit-length-check.js

@@ -250,7 +250,7 @@ function create(context) {
 		}
 
 		let node;
-		let autoFix = true;
+		let isAutoFix = true;
 		let {isZeroLengthCheck, node: lengthCheckNode} = getLengthCheckNode(lengthNode);
 		if (lengthCheckNode) {
 			const {isNegative, node: ancestor} = getBooleanAncestor(lengthCheckNode, context);
@@ -266,7 +266,7 @@ function create(context) {
 			} else if (isLogicalExpression(lengthNode.parent) && lengthNode.parent.operator === '&&') {
 				isZeroLengthCheck = isNegative;
 				node = lengthNode;
-				autoFix = false;
+				isAutoFix = false;
 			}
 		}
 
@@ -287,7 +287,7 @@ function create(context) {
 				node,
 				isZeroLengthCheck,
 				lengthNode,
-				autoFix: autoFix && !isUnsafeNegationInBinaryExpression,
+				autoFix: isAutoFix && !isUnsafeNegationInBinaryExpression,
 				shouldSuggest: !isUnsafeNegationInBinaryExpression,
 			});
 		}

package/rules/filename-case.js

@@ -280,8 +280,8 @@ const create = context => {
 
 		return new RegExp(item, 'u');
 	});
-	const multipleFileExtensions = options.multipleFileExtensions !== false;
-	const checkDirectories = options.checkDirectories !== false;
+	const isMultipleFileExtensions = options.multipleFileExtensions !== false;
+	const isCheckDirectories = options.checkDirectories !== false;
 	const chosenCasesFunctions = chosenCases.map(case_ => cases[case_].fn);
 
 	onRoot(context, () => {
@@ -292,13 +292,13 @@ const create = context => {
 			filename,
 			middle,
 			extension,
-		} = getFilenameParts(basenameWithExtension, {multipleFileExtensions});
+		} = getFilenameParts(basenameWithExtension, {multipleFileExtensions: isMultipleFileExtensions});
 
 		if (pathSegments.some(segment => ignore.some(regexp => regexp.test(segment)))) {
 			return;
 		}
 
-		if (checkDirectories) {
+		if (isCheckDirectories) {
 			for (const directory of pathSegments.slice(0, -1)) {
 				const report = getInvalidDirectoryReport(directory, chosenCases, chosenCasesFunctions);
 

package/rules/fix/remove-argument.js

@@ -1,5 +1,5 @@
 import {isCommaToken} from '@eslint-community/eslint-utils';
-import {getParentheses} from '../utils/index.js';
+import {getParentheses, hasCommentInRange} from '../utils/index.js';
 
 /**
 @import {TSESTree as ESTree} from '@typescript-eslint/types';
@@ -22,17 +22,22 @@ function getArgumentRemovalRange(node, context) {
 	let [start] = sourceCode.getRange(firstToken);
 	let [, end] = sourceCode.getRange(lastToken);
 
-	if (index !== 0) {
-		const commaToken = sourceCode.getTokenBefore(firstToken);
-		[start] = sourceCode.getRange(commaToken);
-	}
-
-	// If the removed argument is the only argument, the trailing comma must be removed too
 	if (callOrNewExpression.arguments.length === 1) {
+		// The only argument: also drop a dangling trailing comma if present (`fn(a,)`).
 		const tokenAfter = sourceCode.getTokenAfter(lastToken);
 		if (isCommaToken(tokenAfter)) {
 			[, end] = sourceCode.getRange(tokenAfter);
 		}
+	} else if (index === 0) {
+		// First of several: remove it through the following comma and the gap after it, so
+		// `fn(a, b)` becomes `fn(b)` rather than `fn( b)`.
+		const commaToken = sourceCode.getTokenAfter(lastToken);
+		const tokenAfterComma = sourceCode.getTokenAfter(commaToken, {includeComments: true});
+		[end] = sourceCode.getRange(tokenAfterComma);
+	} else {
+		// Otherwise remove the comma that precedes it.
+		const commaToken = sourceCode.getTokenBefore(firstToken);
+		[start] = sourceCode.getRange(commaToken);
 	}
 
 	return [start, end];
@@ -45,7 +50,28 @@ function getArgumentRemovalRange(node, context) {
 @returns {ESLint.Rule.Fix}
 */
 export default function removeArgument(fixer, node, context) {
-	return fixer.removeRange(getArgumentRemovalRange(node, context));
+	const removalRange = getArgumentRemovalRange(node, context);
+	const callOrNewExpression = node.parent;
+	const index = callOrNewExpression.arguments.indexOf(node);
+
+	if (
+		index === 0
+		&& callOrNewExpression.arguments.length > 1
+		&& hasCommentInRange(context, removalRange)
+	) {
+		const {sourceCode} = context;
+		const parentheses = getParentheses(node, context);
+		const lastToken = parentheses.at(-1) || node;
+		const [, argumentEnd] = sourceCode.getRange(lastToken);
+		const commaToken = sourceCode.getTokenAfter(lastToken);
+		const [commaStart, commaEnd] = sourceCode.getRange(commaToken);
+		const rangeText = sourceCode.text.slice(...removalRange);
+		const replacement = rangeText.slice(argumentEnd - removalRange[0], commaStart - removalRange[0]) + rangeText.slice(commaEnd - removalRange[0]);
+
+		return fixer.replaceTextRange(removalRange, replacement);
+	}
+
+	return fixer.removeRange(removalRange);
 }
 
 export {

package/rules/fix/remove-statement.js

@@ -3,7 +3,7 @@ import {isSemicolonToken} from '@eslint-community/eslint-utils';
 const isWhitespaceOnly = text => /^\s*$/.test(text);
 
 // Removes a statement node along with its surrounding whitespace, while preserving comments.
-function removeStatement(statement, context, fixer, preserveSemiColon = false) {
+export default function removeStatement(statement, context, fixer, preserveSemiColon = false) {
 	const {sourceCode} = context;
 	const {lines} = sourceCode;
 	let endToken = statement;
@@ -44,5 +44,3 @@ function removeStatement(statement, context, fixer, preserveSemiColon = false) {
 
 	return fixer.removeRange([start, end]);
 }
-
-export default removeStatement;

package/rules/id-match.js

@@ -26,11 +26,11 @@ const shouldIgnoreNamedSpecifierReport = (problem, checkNamedSpecifiers) =>
 @param {import('eslint').Rule.RuleContext} context
 */
 const create = context => {
-	const checkNamedSpecifiers = context.options[1]?.checkNamedSpecifiers !== false;
+	const isCheckNamedSpecifiers = context.options[1]?.checkNamedSpecifiers !== false;
 	const fakeContext = Object.create(context, {
 		report: {
 			value(problem) {
-				if (shouldIgnoreNamedSpecifierReport(problem, checkNamedSpecifiers)) {
+				if (shouldIgnoreNamedSpecifierReport(problem, isCheckNamedSpecifiers)) {
 					return;
 				}
 

package/rules/isolated-functions.js

@@ -98,13 +98,51 @@ const create = context => {
 
 	options.comments = options.comments.map(comment => comment.toLowerCase());
 
-	const allowedGlobals = {
+	const configuredGlobals = {
 		...(globals[`es${context.languageOptions.ecmaVersion}`] ?? globals.builtins),
 		...context.languageOptions.globals,
-		...options.overrideGlobals,
 	};
 	const checked = new WeakSet();
 
+	const getAllowedGlobalValue = reference => {
+		const {identifier, resolved} = reference;
+		const {name} = identifier;
+
+		if (Object.hasOwn(options.overrideGlobals, name)) {
+			const overrideGlobalValue = options.overrideGlobals[name];
+
+			if (overrideGlobalValue === 'off') {
+				return 'off';
+			}
+
+			if (resolved && !sourceCode.isGlobalReference(identifier)) {
+				return;
+			}
+
+			return overrideGlobalValue;
+		}
+
+		if (
+			Object.hasOwn(configuredGlobals, name)
+			&& configuredGlobals[name] === 'off'
+		) {
+			return 'off';
+		}
+
+		if (!sourceCode.isGlobalReference(identifier)) {
+			return;
+		}
+
+		if (
+			!Object.hasOwn(configuredGlobals, name)
+			&& !resolved?.eslintExplicitGlobal
+		) {
+			return;
+		}
+
+		return resolved?.writeable ? 'writable' : 'readonly';
+	};
+
 	function * getFunctionContextProblems(node, reason, root = node) {
 		const messageId = functionContextReferenceMessageIds.get(node.type);
 		if (messageId) {
@@ -173,18 +211,20 @@ const create = context => {
 				continue;
 			}
 
-			if (Object.hasOwn(allowedGlobals, identifier.name) && allowedGlobals[identifier.name] !== 'off') {
+			const allowedGlobalValue = getAllowedGlobalValue(reference);
+			let problemReason = reason;
+
+			if (allowedGlobalValue !== undefined && allowedGlobalValue !== 'off') {
 				if (reference.isReadOnly()) {
 					continue;
 				}
 
-				const globalsValue = allowedGlobals[identifier.name];
-				const isGlobalWritable = [true, 'writable', 'writeable'].includes(globalsValue);
+				const isGlobalWritable = [true, 'writable', 'writeable'].includes(allowedGlobalValue);
 				if (isGlobalWritable) {
 					continue;
 				}
 
-				reason += ' (global variable is not writable)';
+				problemReason += ' (global variable is not writable)';
 			}
 
 			// Could consider checking for typeof operator here, like in no-undef?
@@ -192,7 +232,7 @@ const create = context => {
 			context.report({
 				node: identifier,
 				messageId: MESSAGE_ID_EXTERNALLY_SCOPED_VARIABLE,
-				data: {name: identifier.name, reason},
+				data: {name: identifier.name, reason: problemReason},
 			});
 		}
 

package/rules/name-replacements.js

@@ -1,6 +1,5 @@
 import path from 'node:path';
 import {isRegExp} from 'node:util/types';
-import helperValidatorIdentifier from '@babel/helper-validator-identifier';
 import {
 	getAvailableVariableName,
 	cartesianProductSamples,
@@ -9,6 +8,7 @@ import {
 	upperFirst,
 	lowerFirst,
 	isVirtualFilename,
+	isIdentifierName,
 } from './utils/index.js';
 import {defaultReplacements, defaultAllowList, defaultIgnore} from './shared/name-replacements.js';
 import {
@@ -24,7 +24,6 @@ import {functionTypes} from './ast/index.js';
 const MESSAGE_ID_REPLACE = 'replace';
 const MESSAGE_ID_SUGGESTION = 'suggestion';
 const MESSAGE_ID_RENAME = 'rename';
-const {isIdentifierName} = helperValidatorIdentifier;
 const anotherNameMessage = 'A more descriptive name will do too.';
 const messages = {
 	[MESSAGE_ID_REPLACE]: `The {{nameTypeText}} \`{{discouragedName}}\` should be named \`{{replacement}}\`. ${anotherNameMessage}`,

package/rules/no-anonymous-default-export.js

@@ -1,6 +1,5 @@
 import path from 'node:path';
 import {getFunctionHeadLocation, getFunctionNameWithKind, isOpeningParenToken} from '@eslint-community/eslint-utils';
-import helperValidatorIdentifier from '@babel/helper-validator-identifier';
 import {camelCase} from 'change-case';
 import {
 	getClassHeadLocation,
@@ -9,11 +8,10 @@ import {
 	getAvailableVariableName,
 	upperFirst,
 	isVirtualFilename,
+	isIdentifierName,
 } from './utils/index.js';
 import {isMemberExpression} from './ast/index.js';
 
-const {isIdentifierName} = helperValidatorIdentifier;
-
 const MESSAGE_ID_ERROR = 'no-anonymous-default-export/error';
 const MESSAGE_ID_SUGGESTION = 'no-anonymous-default-export/suggestion';
 const messages = {

package/rules/no-array-callback-reference.js

@@ -1,4 +1,4 @@
-import helperValidatorIdentifier from '@babel/helper-validator-identifier';
+import isIdentifier from 'is-identifier';
 import {findVariable} from '@eslint-community/eslint-utils';
 import typedArray from './shared/typed-array.js';
 import {isMethodCall, isUndefined} from './ast/index.js';
@@ -22,11 +22,6 @@ const ERROR_WITH_NAME_MESSAGE_ID = 'error-with-name';
 const ERROR_WITHOUT_NAME_MESSAGE_ID = 'error-without-name';
 const REPLACE_WITH_NAME_MESSAGE_ID = 'replace-with-name';
 const REPLACE_WITHOUT_NAME_MESSAGE_ID = 'replace-without-name';
-const {
-	isIdentifierName,
-	isKeyword,
-	isStrictBindReservedWord,
-} = helperValidatorIdentifier;
 const messages = {
 	[ERROR_WITH_NAME_MESSAGE_ID]: 'Do not pass function `{{name}}` directly to `.{{method}}(…)`.',
 	[ERROR_WITHOUT_NAME_MESSAGE_ID]: 'Do not pass function directly to `.{{method}}(…)`.',
@@ -301,10 +296,7 @@ function isDefinitelyNotFunctionValue(node, context, visitedVariables = new Set(
 		: false;
 }
 
-const isValidParameterName = name =>
-	isIdentifierName(name)
-	&& !isKeyword(name)
-	&& !isStrictBindReservedWord(name, true);
+const isValidParameterName = isIdentifier;
 
 function getSuggestionParameters(callExpression, callback, parameters) {
 	if (callback.type !== 'Identifier') {

package/rules/no-chained-comparison.js

@@ -1,4 +1,5 @@
 import {hasSideEffect} from '@eslint-community/eslint-utils';
+import {isBooleanLiteral} from './ast/index.js';
 import {getParenthesizedText, isParenthesized, isBoolean} from './utils/index.js';
 
 const MESSAGE_ID_ERROR = 'no-chained-comparison/error';
@@ -13,7 +14,6 @@ const equalityOperators = new Set(['===', '!==', '==', '!=']);
 const comparisonOperators = orderingOperators.union(equalityOperators);
 
 const isComparison = node => node.type === 'BinaryExpression' && comparisonOperators.has(node.operator);
-const isBooleanLiteral = node => node.type === 'Literal' && typeof node.value === 'boolean';
 
 // The `&&` rewrite is a `LogicalExpression`, which binds looser than any comparison. It can only
 // replace `node` where a surrounding operator won't recapture it: at the top of an expression or

package/rules/no-computed-property-existence-check.js

@@ -134,10 +134,7 @@ const create = context => {
 	});
 
 	context.on('BinaryExpression', node => {
-		if (!(
-			node.operator === 'in'
-			&& !isStaticPropertyKey(node.left)
-		)) {
+		if (node.operator !== 'in' || isStaticPropertyKey(node.left)) {
 			return;
 		}
 

package/rules/no-declarations-before-early-exit.js

@@ -1,5 +1,10 @@
 import {isCommentToken, hasSideEffect} from '@eslint-community/eslint-utils';
-import {containsSuspensionPoint, getReferences, trackBranchExits} from './utils/index.js';
+import {
+	containsSuspensionPoint,
+	getReferences,
+	isReactHookName,
+	trackBranchExits,
+} from './utils/index.js';
 
 const MESSAGE_ID = 'no-declarations-before-early-exit';
 const messages = {
@@ -23,10 +28,6 @@ function isGuardStatement(node, branchAlwaysExits) {
 	return consequentExits !== alternateExits;
 }
 
-// https://github.com/facebook/react/blob/main/packages/eslint-plugin-react-hooks/src/rules/RulesOfHooks.ts
-const isReactHookName = name =>
-	name === 'use' || /^use[\dA-Z]/.test(name);
-
 // Matches `useFoo(…)` and `Namespace.useFoo(…)` (for example, `React.useMemo(…)`).
 const isReactHookCall = node => {
 	if (node?.type !== 'CallExpression') {

package/rules/no-error-property-assignment.js

@@ -142,7 +142,7 @@ const getLocalUpdateFrame = knownErrorVariableFrames =>
 	?? knownErrorVariableFrames.at(-1);
 
 const updateExistingKnownErrorVariable = (knownErrorVariableFrames, variable, constructorName) => {
-	let crossesFunctionBoundary = false;
+	let isCrossesFunctionBoundary = false;
 
 	for (const frame of knownErrorVariableFrames.toReversed()) {
 		if (frame.knownErrorVariables.has(variable)) {
@@ -151,7 +151,7 @@ const updateExistingKnownErrorVariable = (knownErrorVariableFrames, variable, co
 				return true;
 			}
 
-			if (!crossesFunctionBoundary) {
+			if (!isCrossesFunctionBoundary) {
 				frame.knownErrorVariables.set(variable, undefined);
 			}
 
@@ -160,7 +160,7 @@ const updateExistingKnownErrorVariable = (knownErrorVariableFrames, variable, co
 		}
 
 		if (frame.isFunctionBoundary) {
-			crossesFunctionBoundary = true;
+			isCrossesFunctionBoundary = true;
 		}
 	}
 

package/rules/no-for-loop.js

@@ -876,14 +876,14 @@ const create = context => {
 
 				let declarationElement = element;
 				let declarationType = 'const';
-				let removeDeclaration = true;
+				let isRemoveDeclaration = true;
 
 				if (elementNode) {
 					if (elementNode.id.type === 'ObjectPattern' || elementNode.id.type === 'ArrayPattern') {
-						removeDeclaration = arrayReferences.length === 1;
+						isRemoveDeclaration = arrayReferences.length === 1;
 					}
 
-					if (removeDeclaration) {
+					if (isRemoveDeclaration) {
 						declarationType = elementNode.parent.kind;
 						declarationElement = sourceCode.getText(elementNode.id);
 					}
@@ -911,7 +911,7 @@ const create = context => {
 				}
 
 				if (elementNode) {
-					yield removeDeclaration
+					yield isRemoveDeclaration
 						? fixer.removeRange(getRemovalRange(elementNode, sourceCode))
 						: fixer.replaceText(elementNode.init, element);
 				}

package/rules/no-keyword-prefix.js

@@ -90,12 +90,12 @@ function reportObjectPatternAndShouldSkipPropertyCheck(report, node, options) {
 		return true;
 	}
 
-	const assignmentKeyEqualsValue = parent.key.name === parent.value.name;
+	const isAssignmentKeyEqualsValue = parent.key.name === parent.value.name;
 
 	const valueIsInvalid = parent.value.name && Boolean(keyword);
 
 	// Ignore destructuring if the option is set, unless a new identifier is created
-	if (valueIsInvalid && !assignmentKeyEqualsValue) {
+	if (valueIsInvalid && !isAssignmentKeyEqualsValue) {
 		report(node, keyword);
 	}
 

package/rules/no-mismatched-map-key.js

@@ -1,7 +1,7 @@
 import {findVariable, getStaticValue} from '@eslint-community/eslint-utils';
 import {isMethodCall} from './ast/index.js';
 import {isReference, isSame, unwrapExpression} from './utils/comparison.js';
-import {isKnownNonMap} from './utils/index.js';
+import {isComparableStaticValue, isKnownNonMap} from './utils/index.js';
 
 /**
 @import {TSESTree as ESTree} from '@typescript-eslint/types';
@@ -21,13 +21,6 @@ const skippedNodeTypes = new Set([
 	'FunctionExpression',
 ]);
 
-const isComparableStaticValue = value =>
-	value === null
-	|| (
-		typeof value !== 'object'
-		&& typeof value !== 'function'
-	);
-
 const isSameValueZero = (left, right) =>
 	left === right
 	|| (
@@ -132,7 +125,7 @@ function patternContainsSameBinding(node, mapHasRoot, context) {
 
 function hasCallExpression(node, context) {
 	const {visitorKeys} = context.sourceCode;
-	let result = false;
+	let isResult = false;
 
 	function visit(node) {
 		if (!node) {
@@ -142,14 +135,14 @@ function hasCallExpression(node, context) {
 		node = unwrapExpression(node);
 
 		if (
-			result
+			isResult
 			|| skippedNodeTypes.has(node.type)
 		) {
 			return;
 		}
 
 		if (node.type === 'CallExpression') {
-			result = true;
+			isResult = true;
 			return;
 		}
 
@@ -170,7 +163,7 @@ function hasCallExpression(node, context) {
 
 	visit(node);
 
-	return result;
+	return isResult;
 }
 
 function areDifferentKeys(left, right, context) {
@@ -353,11 +346,11 @@ function isNestedMapHasGuard(node, mapHasCall, context) {
 
 function hasSameMapHasCall(node, mapHasCall, context) {
 	const {visitorKeys} = context.sourceCode;
-	let result = false;
+	let isResult = false;
 
 	function visit(node) {
 		if (
-			result
+			isResult
 			|| !node
 			|| skippedNodeTypes.has(node.type)
 		) {
@@ -370,7 +363,7 @@ function hasSameMapHasCall(node, mapHasCall, context) {
 			nestedMapHasCall
 			&& isSameMapReceiver(unwrapExpression(mapHasCall).callee.object, unwrapExpression(nestedMapHasCall).callee.object, context)
 		) {
-			result = true;
+			isResult = true;
 			return;
 		}
 
@@ -391,16 +384,16 @@ function hasSameMapHasCall(node, mapHasCall, context) {
 
 	visit(node);
 
-	return result;
+	return isResult;
 }
 
 function hasMapReceiverWrite(node, mapHasCall, context) {
 	const {visitorKeys} = context.sourceCode;
-	let result = false;
+	let isResult = false;
 
 	function visit(node) {
 		if (
-			result
+			isResult
 			|| !node
 			|| skippedNodeTypes.has(node.type)
 			|| isNestedMapHasGuard(node, mapHasCall, context)
@@ -409,7 +402,7 @@ function hasMapReceiverWrite(node, mapHasCall, context) {
 		}
 
 		if (isMapReceiverWrite(node, mapHasCall, context)) {
-			result = true;
+			isResult = true;
 			return;
 		}
 
@@ -430,7 +423,7 @@ function hasMapReceiverWrite(node, mapHasCall, context) {
 
 	visit(node);
 
-	return result;
+	return isResult;
 }
 
 function getMapAccessProblems(node, mapHasCall, context, reportedAccessKeys) {

package/rules/no-named-default.js

@@ -97,12 +97,9 @@ const create = context => {
 	});
 
 	context.on('ExportSpecifier', specifier => {
-		if (!(
-			isValueExport(specifier)
+		if (!(isValueExport(specifier)
 			&& specifier.exported.name === 'default'
-			&& isValueExport(specifier.parent)
-			&& !specifier.parent.source
-		)) {
+			&& isValueExport(specifier.parent)) || specifier.parent.source) {
 			return;
 		}