eslint-plugin-unicorn 7.0.0 → 8.0.2

package/index.js

@@ -17,44 +17,40 @@ module.exports = {
 				'unicorn'
 			],
 			rules: {
-				'unicorn/catch-error-name': [
-					'error',
-					{
-						name: 'error'
-					}
-				],
+				'unicorn/catch-error-name': 'error',
+				'unicorn/custom-error-definition': 'off',
+				'unicorn/error-message': 'error',
+				'unicorn/escape-case': 'error',
 				'unicorn/explicit-length-check': 'error',
-				'unicorn/filename-case': [
-					'error',
-					{
-						case: 'kebabCase'
-					}
-				],
+				'unicorn/filename-case': 'error',
+				'unicorn/import-index': 'error',
+				'unicorn/new-for-builtins': 'error',
 				'unicorn/no-abusive-eslint-disable': 'error',
-				'unicorn/no-process-exit': 'error',
-				'unicorn/throw-new-error': 'error',
-				'unicorn/number-literal-case': 'error',
-				'unicorn/escape-case': 'error',
 				'unicorn/no-array-instanceof': 'error',
-				'unicorn/no-new-buffer': 'error',
-				'unicorn/no-hex-escape': 'error',
-				'unicorn/custom-error-definition': 'off',
-				'unicorn/prefer-starts-ends-with': 'error',
-				'unicorn/prefer-type-error': 'error',
+				'unicorn/no-console-spaces': 'error',
 				'unicorn/no-fn-reference-in-iterator': 'off',
-				'unicorn/import-index': 'error',
-				'unicorn/new-for-builtins': 'error',
-				'unicorn/regex-shorthand': 'error',
-				'unicorn/prefer-spread': 'error',
-				'unicorn/error-message': 'error',
+				'unicorn/no-for-loop': 'error',
+				'unicorn/no-hex-escape': 'error',
+				'unicorn/no-new-buffer': 'error',
+				'unicorn/no-process-exit': 'error',
+				'unicorn/no-unreadable-array-destructuring': 'error',
 				'unicorn/no-unsafe-regex': 'off',
+				'unicorn/no-unused-properties': 'off',
+				'unicorn/no-zero-fractions': 'error',
+				'unicorn/number-literal-case': 'error',
 				'unicorn/prefer-add-event-listener': 'error',
 				'unicorn/prefer-exponentiation-operator': 'error',
-				'unicorn/no-console-spaces': 'error',
-				'unicorn/no-unreadable-array-destructuring': 'error',
-				'unicorn/no-unused-properties': 'off',
+				'unicorn/prefer-includes': 'error',
 				'unicorn/prefer-node-append': 'error',
-				'unicorn/prefer-query-selector': 'error'
+				'unicorn/prefer-node-remove': 'error',
+				'unicorn/prefer-query-selector': 'error',
+				'unicorn/prefer-spread': 'error',
+				'unicorn/prefer-starts-ends-with': 'error',
+				'unicorn/prefer-text-content': 'error',
+				'unicorn/prefer-type-error': 'error',
+				'unicorn/prevent-abbreviations': 'error',
+				'unicorn/regex-shorthand': 'error',
+				'unicorn/throw-new-error': 'error'
 			}
 		}
 	}

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "eslint-plugin-unicorn",
-	"version": "7.0.0",
+	"version": "8.0.2",
 	"description": "Various awesome ESLint rules",
 	"license": "MIT",
 	"repository": "sindresorhus/eslint-plugin-unicorn",
@@ -35,9 +35,12 @@
 		"eslint-ast-utils": "^1.0.0",
 		"import-modules": "^1.1.0",
 		"lodash.camelcase": "^4.1.1",
+		"lodash.defaultsdeep": "^4.6.0",
 		"lodash.kebabcase": "^4.0.1",
 		"lodash.snakecase": "^4.0.1",
+		"lodash.topairs": "^4.3.0",
 		"lodash.upperfirst": "^4.2.0",
+		"reserved-words": "^0.1.2",
 		"safe-regex": "^2.0.1"
 	},
 	"devDependencies": {
@@ -53,7 +56,7 @@
 		"nyc": "^13.1.0",
 		"pify": "^4.0.1",
 		"tempy": "^0.2.1",
-		"xo": "^0.23.0"
+		"xo": "^0.24.0"
 	},
 	"peerDependencies": {
 		"eslint": ">=5.0.0"

package/readme.md

@@ -35,43 +35,40 @@ Configure it in `package.json`.
 			"unicorn"
 		],
 		"rules": {
-			"unicorn/catch-error-name": [
-				"error",
-				{
-					"name": "error"
-				}
-			],
-			"unicorn/explicit-length-check": "error",
-			"unicorn/filename-case": [
-				"error",
-				{
-					"case": "kebabCase"
-				}
-			],
-			"unicorn/no-abusive-eslint-disable": "error",
-			"unicorn/no-process-exit": "error",
-			"unicorn/throw-new-error": "error",
-			"unicorn/number-literal-case": "error",
-			"unicorn/escape-case": "error",
-			"unicorn/no-array-instanceof": "error",
-			"unicorn/no-new-buffer": "error",
-			"unicorn/no-hex-escape": "error",
+			"unicorn/catch-error-name": "error",
 			"unicorn/custom-error-definition": "off",
-			"unicorn/prefer-starts-ends-with": "error",
-			"unicorn/prefer-type-error": "error",
-			"unicorn/no-fn-reference-in-iterator": "off",
+			"unicorn/error-message": "error",
+			"unicorn/escape-case": "error",
+			"unicorn/explicit-length-check": "error",
+			"unicorn/filename-case": "error",
 			"unicorn/import-index": "error",
 			"unicorn/new-for-builtins": "error",
-			"unicorn/regex-shorthand": "error",
-			"unicorn/prefer-spread": "error",
-			"unicorn/error-message": "error",
-			"unicorn/no-unsafe-regex": "off",
-			"unicorn/prefer-add-event-listener": "error",
+			"unicorn/no-abusive-eslint-disable": "error",
+			"unicorn/no-array-instanceof": "error",
 			"unicorn/no-console-spaces": "error",
+			"unicorn/no-fn-reference-in-iterator": "off",
+			"unicorn/no-for-loop": "error",
+			"unicorn/no-hex-escape": "error",
+			"unicorn/no-new-buffer": "error",
+			"unicorn/no-process-exit": "error",
 			"unicorn/no-unreadable-array-destructuring": "error",
+			"unicorn/no-unsafe-regex": "off",
 			"unicorn/no-unused-properties": "off",
+			"unicorn/no-zero-fractions": "error",
+			"unicorn/number-literal-case": "error",
+			"unicorn/prefer-add-event-listener": "error",
+			"unicorn/prefer-exponentiation-operator": "error",
+			"unicorn/prefer-includes": "error",
 			"unicorn/prefer-node-append": "error",
-			"unicorn/prefer-query-selector": "error"
+			"unicorn/prefer-node-remove": "error",
+			"unicorn/prefer-query-selector": "error",
+			"unicorn/prefer-spread": "error",
+			"unicorn/prefer-starts-ends-with": "error",
+			"unicorn/prefer-text-content": "error",
+			"unicorn/prefer-type-error": "error",
+			"unicorn/prevent-abbreviations": "error",
+			"unicorn/regex-shorthand": "error",
+			"unicorn/throw-new-error": "error"
 		}
 	}
 }
@@ -81,33 +78,39 @@ Configure it in `package.json`.
 ## Rules
 
 - [catch-error-name](docs/rules/catch-error-name.md) - Enforce a specific parameter name in catch clauses.
+- [custom-error-definition](docs/rules/custom-error-definition.md) - Enforce correct `Error` subclassing. *(fixable)*
+- [error-message](docs/rules/error-message.md) - Enforce passing a `message` value when throwing a built-in error.
+- [escape-case](docs/rules/escape-case.md) - Require escape sequences to use uppercase values. *(fixable)*
 - [explicit-length-check](docs/rules/explicit-length-check.md) - Enforce explicitly comparing the `length` property of a value. *(partly fixable)*
 - [filename-case](docs/rules/filename-case.md) - Enforce a case style for filenames.
+- [import-index](docs/rules/import-index.md) - Enforce importing index files with `.`. *(fixable)*
+- [new-for-builtins](docs/rules/new-for-builtins.md) - Enforce the use of `new` for all builtins, except `String`, `Number`, `Boolean` and `Symbol`. *(fixable)*
 - [no-abusive-eslint-disable](docs/rules/no-abusive-eslint-disable.md) - Enforce specifying rules to disable in `eslint-disable` comments.
-- [no-process-exit](docs/rules/no-process-exit.md) - Disallow `process.exit()`.
-- [throw-new-error](docs/rules/throw-new-error.md) - Require `new` when throwing an error. *(fixable)*
-- [number-literal-case](docs/rules/number-literal-case.md) - Enforce lowercase identifier and uppercase value for number literals. *(fixable)*
-- [escape-case](docs/rules/escape-case.md) - Require escape sequences to use uppercase values. *(fixable)*
 - [no-array-instanceof](docs/rules/no-array-instanceof.md) - Require `Array.isArray()` instead of `instanceof Array`. *(fixable)*
-- [no-new-buffer](docs/rules/no-new-buffer.md) - Enforce the use of `Buffer.from()` and `Buffer.alloc()` instead of the deprecated `new Buffer()`. *(fixable)*
-- [no-hex-escape](docs/rules/no-hex-escape.md) - Enforce the use of unicode escapes instead of hexadecimal escapes. *(fixable)*
-- [custom-error-definition](docs/rules/custom-error-definition.md) - Enforce correct `Error` subclassing. *(fixable)*
-- [prefer-starts-ends-with](docs/rules/prefer-starts-ends-with.md) - Prefer `String#startsWith` & `String#endsWith` over more complex alternatives.
-- [prefer-type-error](docs/rules/prefer-type-error.md) - Enforce throwing `TypeError` in type checking conditions. *(fixable)*
+- [no-console-spaces](docs/rules/no-console-spaces.md) - Do not use leading/trailing space between `console.log` parameters. *(fixable)*
 - [no-fn-reference-in-iterator](docs/rules/no-fn-reference-in-iterator.md) - Prevents passing a function reference directly to iterator methods. *(fixable)*
-- [import-index](docs/rules/import-index.md) - Enforce importing index files with `.`. *(fixable)*
-- [new-for-builtins](docs/rules/new-for-builtins.md) - Enforce the use of `new` for all builtins, except `String`, `Number` and `Boolean`. *(fixable)*
-- [regex-shorthand](docs/rules/regex-shorthand.md) - Enforce the use of regex shorthands to improve readability. *(fixable)*
-- [prefer-spread](docs/rules/prefer-spread.md) - Prefer the spread operator over `Array.from()`. *(fixable)*
-- [error-message](docs/rules/error-message.md) - Enforce passing a `message` value when throwing a built-in error.
+- [no-for-loop](docs/rules/no-for-loop.md) - Do not use a `for` loop that can be replaced with a `for-of` loop. *(fixable)*
+- [no-hex-escape](docs/rules/no-hex-escape.md) - Enforce the use of unicode escapes instead of hexadecimal escapes. *(fixable)*
+- [no-new-buffer](docs/rules/no-new-buffer.md) - Enforce the use of `Buffer.from()` and `Buffer.alloc()` instead of the deprecated `new Buffer()`. *(fixable)*
+- [no-process-exit](docs/rules/no-process-exit.md) - Disallow `process.exit()`.
+- [no-unreadable-array-destructuring](docs/rules/no-unreadable-array-destructuring.md) - Disallow unreadable array destructuring.
 - [no-unsafe-regex](docs/rules/no-unsafe-regex.md) - Disallow unsafe regular expressions.
+- [no-unused-properties](docs/rules/no-unused-properties.md) - Disallow unused object properties.
+- [no-zero-fractions](docs/rules/no-zero-fractions.md) - Disallow number literals with zero fractions or dangling dots. *(fixable)*
+- [number-literal-case](docs/rules/number-literal-case.md) - Enforce lowercase identifier and uppercase value for number literals. *(fixable)*
 - [prefer-add-event-listener](docs/rules/prefer-add-event-listener.md) - Prefer `addEventListener` over `on`-functions. *(fixable)*
 - [prefer-exponentiation-operator](docs/rules/prefer-exponentiation-operator.md) - Prefer the exponentiation operator over `Math.pow()` *(fixable)*
-- [no-console-spaces](docs/rules/no-console-spaces.md) - Do not use leading/trailing space between `console.log` parameters. *(fixable)*
-- [no-unreadable-array-destructuring](docs/rules/no-unreadable-array-destructuring.md) - Disallow unreadable array destructuring.
-- [no-unused-properties](docs/rules/no-unused-properties.md) - Disallow unused object properties.
+- [prefer-includes](docs/rules/prefer-includes.md) - Prefer `.includes()` over `.indexOf()` when checking for existence or non-existence. *(fixable)*
 - [prefer-node-append](docs/rules/prefer-node-append.md) - Prefer `append` over `appendChild`. *(fixable)*
+- [prefer-node-remove](docs/rules/prefer-node-remove.md) - Prefer `remove` over `parentNode.removeChild` and `parentElement.removeChild`. *(fixable)*
 - [prefer-query-selector](docs/rules/prefer-query-selector.md) - Prefer `querySelector` over `getElementById`, `querySelectorAll` over `getElementsByClassName` and `getElementsByTagName`. *(partly fixable)*
+- [prefer-spread](docs/rules/prefer-spread.md) - Prefer the spread operator over `Array.from()`. *(fixable)*
+- [prefer-starts-ends-with](docs/rules/prefer-starts-ends-with.md) - Prefer `String#startsWith` & `String#endsWith` over more complex alternatives.
+- [prefer-text-content](docs/rules/prefer-text-content.md) - Prefer `textContent` over `innerText`. *(fixable)*
+- [prefer-type-error](docs/rules/prefer-type-error.md) - Enforce throwing `TypeError` in type checking conditions. *(fixable)*
+- [prevent-abbreviations](docs/rules/prevent-abbreviations.md) - Prevent abbreviations *(partly fixable)*
+- [regex-shorthand](docs/rules/regex-shorthand.md) - Enforce the use of regex shorthands to improve readability. *(fixable)*
+- [throw-new-error](docs/rules/throw-new-error.md) - Require `new` when throwing an error. *(fixable)*
 
 
 ## Recommended config

package/rules/catch-error-name.js

@@ -25,6 +25,7 @@ function isLintablePromiseCatch(node) {
 	return arg0.type === 'FunctionExpression' || arg0.type === 'ArrowFunctionExpression';
 }
 
+// TODO: Use `./utils/avoid-capture.js` instead
 function indexifyName(name, scope) {
 	const variables = scope.variableScope.set;
 
@@ -42,6 +43,8 @@ const create = context => {
 		caughtErrorsIgnorePattern: '^_$'
 	}, context.options[0]);
 
+	const {scopeManager} = context.getSourceCode();
+
 	const {name} = options;
 	const caughtErrorsIgnorePattern = new RegExp(options.caughtErrorsIgnorePattern);
 	const stack = [];
@@ -54,14 +57,31 @@ const create = context => {
 		stack.push(stack.length > 0 || value);
 	}
 
-	function popAndReport(node) {
+	function popAndReport(node, scopeNode) {
 		const value = stack.pop();
 
 		if (value !== true && !caughtErrorsIgnorePattern.test(node.name)) {
-			context.report({
+			const expectedName = value || name;
+			const problem = {
 				node,
-				message: `The catch parameter should be named \`${value || name}\`.`
-			});
+				message: `The catch parameter should be named \`${expectedName}\`.`
+			};
+
+			if (node.type === 'Identifier') {
+				problem.fix = fixer => {
+					const fixings = [fixer.replaceText(node, expectedName)];
+
+					const scope = scopeManager.acquire(scopeNode);
+					const variable = scope.set.get(node.name);
+					for (const reference of variable.references) {
+						fixings.push(fixer.replaceText(reference.identifier, expectedName));
+					}
+
+					return fixings;
+				};
+			}
+
+			context.report(problem);
 		}
 	}
 
@@ -81,7 +101,8 @@ const create = context => {
 		},
 		'CallExpression:exit': node => {
 			if (isLintablePromiseCatch(node)) {
-				popAndReport(node.arguments[0].params[0]);
+				const callbackNode = node.arguments[0];
+				popAndReport(callbackNode.params[0], callbackNode);
 			}
 		},
 		CatchClause: node => {
@@ -100,7 +121,7 @@ const create = context => {
 			push(node.param.name === errName || errName);
 		},
 		'CatchClause:exit': node => {
-			popAndReport(node.param);
+			popAndReport(node.param, node);
 		}
 	};
 };
@@ -120,9 +141,11 @@ const schema = [{
 module.exports = {
 	create,
 	meta: {
+		type: 'suggestion',
 		docs: {
 			url: getDocsUrl(__filename)
 		},
+		fixable: 'code',
 		schema
 	}
 };

package/rules/custom-error-definition.js

@@ -134,6 +134,7 @@ const create = context => {
 module.exports = {
 	create,
 	meta: {
+		type: 'problem',
 		docs: {
 			url: getDocsUrl(__filename)
 		},

package/rules/error-message.js

@@ -17,6 +17,7 @@ const isReferenceAssigned = expression => {
 		const assignedVariable = expression.left;
 		return assignedVariable.type === 'Identifier' && assignedVariable.name;
 	}
+
 	return false;
 };
 
@@ -36,6 +37,7 @@ const findIdentifierValues = (identifierNode, context) => {
 			referenceValues.push(expression.init);
 		}
 	}
+
 	return referenceValues;
 };
 
@@ -90,6 +92,7 @@ const create = context => {
 module.exports = {
 	create,
 	meta: {
+		type: 'problem',
 		docs: {
 			url: getDocsUrl(__filename)
 		}

package/rules/escape-case.js

@@ -55,6 +55,7 @@ const create = context => {
 module.exports = {
 	create,
 	meta: {
+		type: 'suggestion',
 		docs: {
 			url: getDocsUrl(__filename)
 		},

package/rules/explicit-length-check.js

@@ -56,6 +56,7 @@ function checkNonZeroType(context, node, type) {
 					}
 				);
 			}
+
 			break;
 		case 'greater-than-or-equal':
 			if (
@@ -73,6 +74,7 @@ function checkNonZeroType(context, node, type) {
 					}
 				);
 			}
+
 			break;
 		case 'not-equal':
 			if (
@@ -90,6 +92,7 @@ function checkNonZeroType(context, node, type) {
 					}
 				);
 			}
+
 			break;
 		default:
 			break;
@@ -159,6 +162,7 @@ const schema = [{
 module.exports = {
 	create,
 	meta: {
+		type: 'problem',
 		docs: {
 			url: getDocsUrl(__filename)
 		},

package/rules/filename-case.js

@@ -70,7 +70,7 @@ function splitFilename(filename) {
 const create = context => {
 	const options = context.options[0] || {};
 
-	const chosenCase = cases[options.case || 'camelCase'];
+	const chosenCase = cases[options.case || 'kebabCase'];
 	const filenameWithExt = context.getFilename();
 
 	if (filenameWithExt === '<text>') {
@@ -117,6 +117,7 @@ const schema = [{
 module.exports = {
 	create,
 	meta: {
+		type: 'suggestion',
 		docs: {
 			url: getDocsUrl(__filename)
 		},

package/rules/import-index.js

@@ -25,6 +25,7 @@ const create = context => {
 module.exports = {
 	create,
 	meta: {
+		type: 'suggestion',
 		docs: {
 			url: getDocsUrl(__filename)
 		},

package/rules/new-for-builtins.js

@@ -66,6 +66,7 @@ const create = context => {
 module.exports = {
 	create,
 	meta: {
+		type: 'suggestion',
 		docs: {
 			url: getDocsUrl(__filename)
 		},

package/rules/no-abusive-eslint-disable.js

@@ -1,7 +1,7 @@
 'use strict';
 const getDocsUrl = require('./utils/get-docs-url');
 
-const disableRegex = /^eslint-disable(-next-line|-line)?($|(\s+(@[\w-]+\/[\w-]+\/)?[\w-]+)?)/;
+const disableRegex = /^eslint-disable(-next-line|-line)?($|(\s+(@[\w-]+\/(?:[\w-]+\/)?)?[\w-]+)?)/;
 
 const create = context => ({
 	Program: node => {
@@ -32,6 +32,7 @@ const create = context => ({
 module.exports = {
 	create,
 	meta: {
+		type: 'suggestion',
 		docs: {
 			url: getDocsUrl(__filename)
 		}

package/rules/no-array-instanceof.js

@@ -19,6 +19,7 @@ const create = context => ({
 module.exports = {
 	create,
 	meta: {
+		type: 'suggestion',
 		docs: {
 			url: getDocsUrl(__filename)
 		},

package/rules/no-console-spaces.js

@@ -133,6 +133,7 @@ const create = context => {
 module.exports = {
 	create,
 	meta: {
+		type: 'suggestion',
 		docs: {
 			url: getDocsUrl(__filename)
 		},

package/rules/no-fn-reference-in-iterator.js

@@ -13,12 +13,20 @@ const iteratorMethods = new Map([
 	['reduceRight', 2]
 ]);
 
-const whitelist = new Set([
+const functionWhitelist = new Set([
 	'Boolean'
 ]);
 
+const calleeBlacklist = [
+	'Promise',
+	'React.children',
+	'_',
+	'Async',
+	'async'
+];
+
 const isIteratorMethod = node => node.callee.property && iteratorMethods.has(node.callee.property.name);
-const hasFunctionArgument = node => node.arguments.length > 0 && (node.arguments[0].type === 'Identifier' || node.arguments[0].type === 'CallExpression') && !whitelist.has(node.arguments[0].name);
+const hasFunctionArgument = node => node.arguments.length > 0 && (node.arguments[0].type === 'Identifier' || node.arguments[0].type === 'CallExpression') && !functionWhitelist.has(node.arguments[0].name);
 
 const getNumberOfArguments = node => node.callee.property && iteratorMethods.get(node.callee.property.name);
 const parseArgument = (context, arg) => arg.type === 'Identifier' ? arg.name : context.getSourceCode().getText(arg);
@@ -31,8 +39,16 @@ const fix = (context, node) => {
 	return fixer => fixer.replaceText(arg, `${numberOfArgs === 1 ? argString : `(${argString})`} => ${parseArgument(context, arg)}(${argString})`);
 };
 
+const toSelector = name => {
+	const splitted = name.split('.');
+	return `[callee.${'object.'.repeat(splitted.length)}name!="${splitted.shift()}"]`;
+};
+
+// Select all the call expressions except the ones present in the blacklist
+const selector = `CallExpression${calleeBlacklist.map(toSelector).join('')}`;
+
 const create = context => ({
-	'CallExpression[callee.object.name!="Promise"]': node => {
+	[selector]: node => {
 		if (isIteratorMethod(node) && hasFunctionArgument(node)) {
 			const [arg] = node.arguments;
 
@@ -48,6 +64,7 @@ const create = context => ({
 module.exports = {
 	create,
 	meta: {
+		type: 'problem',
 		docs: {
 			url: getDocsUrl(__filename)
 		},