eslint-plugin-unicorn 69.0.0 → 71.0.0

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "eslint-plugin-unicorn",
-	"version": "69.0.0",
+	"version": "71.0.0",
 	"description": "More than 300 powerful ESLint rules",
 	"license": "MIT",
 	"repository": {
@@ -62,58 +62,59 @@
 		"xo"
 	],
 	"dependencies": {
-		"@babel/helper-validator-identifier": "^7.29.7",
 		"@eslint-community/eslint-utils": "^4.9.1",
-		"browserslist": "^4.28.2",
+		"browserslist": "^4.28.4",
 		"change-case": "^5.4.4",
 		"ci-info": "^4.4.0",
 		"core-js-compat": "^3.49.0",
 		"detect-indent": "^7.0.2",
 		"find-up-simple": "^1.0.1",
-		"globals": "^17.6.0",
+		"globals": "^17.7.0",
 		"indent-string": "^5.0.0",
 		"is-builtin-module": "^5.0.0",
-		"jsesc": "^3.1.0",
+		"is-identifier": "^1.1.0",
 		"pluralize": "^8.0.0",
-		"regjsparser": "^0.13.1",
-		"semver": "^7.8.4",
+		"quote-js-string": "^0.1.0",
+		"regjsparser": "^0.13.2",
+		"reserved-identifiers": "^1.2.0",
+		"semver": "^7.8.5",
 		"strip-indent": "^4.1.1"
 	},
 	"devDependencies": {
-		"@babel/code-frame": "^8.0.0-rc.6",
-		"@eslint/css": "^1.3.0",
+		"@babel/code-frame": "^8.0.0",
+		"@eslint/css": "^1.4.0",
 		"@eslint/eslintrc": "^3.3.5",
-		"@eslint/json": "^2.0.0",
-		"@eslint/markdown": "^8.0.2",
-		"@html-eslint/eslint-plugin": "^0.62.0",
-		"@html-eslint/parser": "^0.62.0",
+		"@eslint/json": "^2.0.1",
+		"@eslint/markdown": "^8.0.3",
+		"@html-eslint/eslint-plugin": "^0.63.0",
+		"@html-eslint/parser": "^0.63.0",
 		"@lubien/fixture-beta-package": "^1.0.0-beta.1",
-		"@typescript-eslint/parser": "^8.61.0",
-		"@typescript-eslint/types": "^8.61.0",
+		"@typescript-eslint/parser": "^8.62.1",
+		"@typescript-eslint/types": "^8.62.1",
 		"ava": "^8.0.1",
 		"c8": "^11.0.0",
 		"enquirer": "^2.4.1",
-		"eslint": "^10.4.1",
+		"eslint": "^10.6.0",
 		"eslint-ava-rule-tester": "^5.0.1",
-		"eslint-config-xo": "^0.52.0",
+		"eslint-config-xo": "^0.56.0",
 		"eslint-doc-generator": "^3.6.0",
-		"eslint-plugin-eslint-plugin": "^7.4.0",
-		"eslint-plugin-jsdoc": "^63.0.2",
-		"eslint-plugin-unicorn": "^65.0.1",
+		"eslint-plugin-eslint-plugin": "^7.4.1",
+		"eslint-plugin-jsdoc": "^63.0.11",
+		"eslint-plugin-unicorn": "^70.0.0",
 		"eslint-remote-tester": "^4.0.4",
 		"eslint-remote-tester-repositories": "^2.0.2",
 		"eslint-scope": "^9.1.2",
 		"espree": "^11.2.0",
-		"listr2": "^10.2.1",
-		"markdownlint-cli": "^0.48.0",
+		"listr2": "^10.2.2",
+		"markdownlint-cli": "^0.49.0",
 		"nano-spawn": "^2.1.0",
 		"node-style-text": "^2.1.2",
-		"npm-package-json-lint": "^10.4.0",
-		"npm-run-all2": "^9.0.1",
+		"npm-package-json-lint": "^10.4.1",
+		"npm-run-all2": "^9.0.2",
 		"open-editor": "^6.0.0",
 		"outdent": "^0.8.0",
 		"pretty-ms": "^9.3.0",
-		"svelte": "^5.56.3",
+		"svelte": "^5.56.4",
 		"svelte-eslint-parser": "^1.8.0",
 		"typescript": "^6.0.3",
 		"vue-eslint-parser": "^10.4.1",

package/readme.md

@@ -144,6 +144,7 @@ export default defineConfig([
 | [no-array-sort-for-min-max](docs/rules/no-array-sort-for-min-max.md)                                       | Disallow sorting arrays to get the minimum or maximum value.                                                                   | ✅ ☑️ |    | 💡 |    |
 | [no-array-splice](docs/rules/no-array-splice.md)                                                           | Prefer `Array#toSpliced()` over `Array#splice()`.                                                                              | ✅    |    | 💡 |    |
 | [no-asterisk-prefix-in-documentation-comments](docs/rules/no-asterisk-prefix-in-documentation-comments.md) | Disallow asterisk prefixes in documentation comments.                                                                          |      | 🔧 |    |    |
+| [no-async-promise-finally](docs/rules/no-async-promise-finally.md)                                         | Disallow async functions as `Promise#finally()` callbacks.                                                                     | ✅ ☑️ |    |    |    |
 | [no-await-expression-member](docs/rules/no-await-expression-member.md)                                     | Disallow member access from await expression.                                                                                  | ✅    | 🔧 |    |    |
 | [no-await-in-promise-methods](docs/rules/no-await-in-promise-methods.md)                                   | Disallow using `await` in `Promise` method parameters.                                                                         | ✅ ☑️ |    | 💡 |    |
 | [no-blob-to-file](docs/rules/no-blob-to-file.md)                                                           | Disallow unnecessary `Blob` to `File` conversion.                                                                              | ✅ ☑️ |    | 💡 |    |
@@ -220,9 +221,11 @@ export default defineConfig([
 | [no-uncalled-method](docs/rules/no-uncalled-method.md)                                                     | Disallow referencing methods without calling them.                                                                             | ✅    |    |    |    |
 | [no-undeclared-class-members](docs/rules/no-undeclared-class-members.md)                                   | Require class members to be declared.                                                                                          | ✅    |    | 💡 |    |
 | [no-unnecessary-array-flat-depth](docs/rules/no-unnecessary-array-flat-depth.md)                           | Disallow using `1` as the `depth` argument of `Array#flat()`.                                                                  | ✅ ☑️ | 🔧 |    |    |
+| [no-unnecessary-array-flat-map](docs/rules/no-unnecessary-array-flat-map.md)                               | Disallow `Array#flatMap()` callbacks that only wrap a single item.                                                             | ✅    | 🔧 | 💡 |    |
 | [no-unnecessary-array-splice-count](docs/rules/no-unnecessary-array-splice-count.md)                       | Disallow using `.length` or `Infinity` as the `deleteCount` or `skipCount` argument of `Array#{splice,toSpliced}()`.           | ✅ ☑️ | 🔧 |    |    |
 | [no-unnecessary-await](docs/rules/no-unnecessary-await.md)                                                 | Disallow awaiting non-promise values.                                                                                          | ✅ ☑️ | 🔧 |    |    |
 | [no-unnecessary-boolean-comparison](docs/rules/no-unnecessary-boolean-comparison.md)                       | Disallow unnecessary comparisons against boolean literals.                                                                     | ✅    | 🔧 |    |    |
+| [no-unnecessary-fetch-options](docs/rules/no-unnecessary-fetch-options.md)                                 | Disallow unnecessary options in `fetch()` and `new Request()`.                                                                 | ✅ ☑️ | 🔧 |    |    |
 | [no-unnecessary-global-this](docs/rules/no-unnecessary-global-this.md)                                     | Disallow unnecessary `globalThis` references.                                                                                  | ✅ ☑️ | 🔧 |    |    |
 | [no-unnecessary-nested-ternary](docs/rules/no-unnecessary-nested-ternary.md)                               | Disallow unnecessary nested ternary expressions.                                                                               | ✅ ☑️ | 🔧 |    |    |
 | [no-unnecessary-polyfills](docs/rules/no-unnecessary-polyfills.md)                                         | Enforce the use of built-in methods instead of unnecessary polyfills.                                                          | ✅ ☑️ |    |    |    |
@@ -235,6 +238,7 @@ export default defineConfig([
 | [no-unreadable-object-destructuring](docs/rules/no-unreadable-object-destructuring.md)                     | Disallow unreadable object destructuring.                                                                                      | ✅ ☑️ |    |    |    |
 | [no-unsafe-buffer-conversion](docs/rules/no-unsafe-buffer-conversion.md)                                   | Prevent unsafe use of ArrayBuffer view `.buffer`.                                                                              | ✅ ☑️ |    | 💡 |    |
 | [no-unsafe-dom-html](docs/rules/no-unsafe-dom-html.md)                                                     | Disallow unsafe DOM HTML APIs.                                                                                                 |      |    |    |    |
+| [no-unsafe-promise-all-settled-values](docs/rules/no-unsafe-promise-all-settled-values.md)                 | Disallow reading `.value` from `Promise.allSettled()` results without a fulfilled status guard.                                | ✅ ☑️ |    |    |    |
 | [no-unsafe-property-key](docs/rules/no-unsafe-property-key.md)                                             | Disallow unsafe values as property keys.                                                                                       | ✅    |    |    |    |
 | [no-unsafe-string-replacement](docs/rules/no-unsafe-string-replacement.md)                                 | Disallow non-literal replacement values in `String#replace()` and `String#replaceAll()`.                                       | ✅    |    |    |    |
 | [no-unused-array-method-return](docs/rules/no-unused-array-method-return.md)                               | Disallow ignoring the return value of selected array methods.                                                                  | ✅ ☑️ |    |    |    |
@@ -264,6 +268,7 @@ export default defineConfig([
 | [number-literal-case](docs/rules/number-literal-case.md)                                                   | Enforce proper case for numeric literals.                                                                                      | ✅ ☑️ | 🔧 |    |    |
 | [numeric-separators-style](docs/rules/numeric-separators-style.md)                                         | Enforce the style of numeric separators by correctly grouping digits.                                                          | ✅ ☑️ | 🔧 |    |    |
 | [operator-assignment](docs/rules/operator-assignment.md)                                                   | Require assignment operator shorthand where possible.                                                                          | ✅    | 🔧 | 💡 |    |
+| [prefer-abort-signal-any](docs/rules/prefer-abort-signal-any.md)                                           | Prefer `AbortSignal.any()` over manually forwarding abort events between signals.                                              | ✅    |    | 💡 |    |
 | [prefer-abort-signal-timeout](docs/rules/prefer-abort-signal-timeout.md)                                   | Prefer `AbortSignal.timeout()` over manually aborting an `AbortController` with `setTimeout()`.                                | ✅    |    | 💡 |    |
 | [prefer-add-event-listener](docs/rules/prefer-add-event-listener.md)                                       | Prefer `.addEventListener()` and `.removeEventListener()` over `on`-functions.                                                 | ✅ ☑️ | 🔧 |    |    |
 | [prefer-add-event-listener-options](docs/rules/prefer-add-event-listener-options.md)                       | Prefer an options object over a boolean in `.addEventListener()`.                                                              | ✅ ☑️ | 🔧 |    |    |
@@ -273,6 +278,7 @@ export default defineConfig([
 | [prefer-array-flat-map](docs/rules/prefer-array-flat-map.md)                                               | Prefer `.flatMap(…)` over `.map(…).flat()` and `.filter(…).flatMap(…)`.                                                        | ✅ ☑️ | 🔧 | 💡 |    |
 | [prefer-array-from-async](docs/rules/prefer-array-from-async.md)                                           | Prefer `Array.fromAsync()` over `for await…of` array accumulation.                                                             | ✅    | 🔧 |    |    |
 | [prefer-array-from-map](docs/rules/prefer-array-from-map.md)                                               | Prefer using the `Array.from()` mapping function argument.                                                                     | ✅ ☑️ | 🔧 | 💡 |    |
+| [prefer-array-from-range](docs/rules/prefer-array-from-range.md)                                           | Prefer `Array.from({length}, …)` when creating range arrays.                                                                   | ✅ ☑️ | 🔧 |    |    |
 | [prefer-array-index-of](docs/rules/prefer-array-index-of.md)                                               | Prefer `Array#{indexOf,lastIndexOf}()` over `Array#{findIndex,findLastIndex}()` when looking for the index of an item.         | ✅ ☑️ | 🔧 | 💡 |    |
 | [prefer-array-iterable-methods](docs/rules/prefer-array-iterable-methods.md)                               | Prefer iterating an array directly or with `Array#keys()` over `Array#entries()` when the index or value is unused.            | ✅    | 🔧 |    |    |
 | [prefer-array-last-methods](docs/rules/prefer-array-last-methods.md)                                       | Prefer last-oriented array methods over `Array#reverse()` or `Array#toReversed()` followed by a method.                        | ✅ ☑️ |    | 💡 |    |
@@ -282,6 +288,7 @@ export default defineConfig([
 | [prefer-await](docs/rules/prefer-await.md)                                                                 | Prefer `await` over promise chaining.                                                                                          | ✅ ☑️ |    |    |    |
 | [prefer-bigint-literals](docs/rules/prefer-bigint-literals.md)                                             | Prefer `BigInt` literals over the constructor.                                                                                 | ✅ ☑️ | 🔧 | 💡 |    |
 | [prefer-blob-reading-methods](docs/rules/prefer-blob-reading-methods.md)                                   | Prefer `Blob#arrayBuffer()` over `FileReader#readAsArrayBuffer(…)` and `Blob#text()` over `FileReader#readAsText(…)`.          | ✅ ☑️ |    |    |    |
+| [prefer-block-statement-over-iife](docs/rules/prefer-block-statement-over-iife.md)                         | Prefer block statements over IIFEs used only for scoping.                                                                      | ✅ ☑️ | 🔧 |    |    |
 | [prefer-boolean-return](docs/rules/prefer-boolean-return.md)                                               | Prefer directly returning boolean expressions over `if` statements.                                                            | ✅ ☑️ | 🔧 |    |    |
 | [prefer-class-fields](docs/rules/prefer-class-fields.md)                                                   | Prefer class field declarations over `this` assignments in constructors.                                                       | ✅ ☑️ | 🔧 | 💡 |    |
 | [prefer-classlist-toggle](docs/rules/prefer-classlist-toggle.md)                                           | Prefer using `Element#classList.toggle()` to toggle class names.                                                               | ✅ ☑️ | 🔧 | 💡 |    |
@@ -305,6 +312,7 @@ export default defineConfig([
 | [prefer-get-or-insert-computed](docs/rules/prefer-get-or-insert-computed.md)                               | Prefer `.getOrInsertComputed()` when the default value has side effects.                                                       | ✅    | 🔧 |    |    |
 | [prefer-global-number-constants](docs/rules/prefer-global-number-constants.md)                             | Prefer global numeric constants over `Number` static properties.                                                               | ✅ ☑️ | 🔧 |    |    |
 | [prefer-global-this](docs/rules/prefer-global-this.md)                                                     | Prefer `globalThis` over `window`, `self`, and `global`.                                                                       | ✅ ☑️ | 🔧 |    |    |
+| [prefer-group-by](docs/rules/prefer-group-by.md)                                                           | Prefer `Object.groupBy()` or `Map.groupBy()` over reduce-based grouping.                                                       | ✅    | 🔧 |    |    |
 | [prefer-has-check](docs/rules/prefer-has-check.md)                                                         | Prefer `.has()` when checking existence.                                                                                       | ✅ ☑️ | 🔧 |    |    |
 | [prefer-hoisting-branch-code](docs/rules/prefer-hoisting-branch-code.md)                                   | Prefer moving code shared by all branches of an `if` statement out of the branches.                                            | ✅    | 🔧 | 💡 |    |
 | [prefer-https](docs/rules/prefer-https.md)                                                                 | Prefer HTTPS over HTTP.                                                                                                        | ✅    | 🔧 |    |    |
@@ -314,6 +322,7 @@ export default defineConfig([
 | [prefer-includes-over-repeated-comparisons](docs/rules/prefer-includes-over-repeated-comparisons.md)       | Prefer `.includes()` over repeated equality comparisons.                                                                       | ✅    |    |    |    |
 | [prefer-iterable-in-constructor](docs/rules/prefer-iterable-in-constructor.md)                             | Prefer passing iterables directly to constructors instead of filling empty collections.                                        | ✅ ☑️ | 🔧 |    |    |
 | [prefer-iterator-concat](docs/rules/prefer-iterator-concat.md)                                             | Prefer `Iterator.concat(…)` over temporary spread arrays.                                                                      |      | 🔧 | 💡 |    |
+| [prefer-iterator-helpers](docs/rules/prefer-iterator-helpers.md)                                           | Prefer iterator helpers over temporary arrays from iterators.                                                                  | ✅ ☑️ |    | 💡 |    |
 | [prefer-iterator-to-array](docs/rules/prefer-iterator-to-array.md)                                         | Prefer `Iterator#toArray()` over temporary arrays from iterator spreads.                                                       | ✅    | 🔧 | 💡 |    |
 | [prefer-iterator-to-array-at-end](docs/rules/prefer-iterator-to-array-at-end.md)                           | Prefer moving `.toArray()` to the end of iterator helper chains.                                                               | ✅ ☑️ |    | 💡 |    |
 | [prefer-keyboard-event-key](docs/rules/prefer-keyboard-event-key.md)                                       | Prefer `KeyboardEvent#key` over deprecated keyboard event properties.                                                          | ✅ ☑️ | 🔧 | 💡 |    |
@@ -358,6 +367,7 @@ export default defineConfig([
 | [prefer-short-arrow-method](docs/rules/prefer-short-arrow-method.md)                                       | Prefer arrow function properties over methods with a single return.                                                            |      | 🔧 |    |    |
 | [prefer-simple-condition-first](docs/rules/prefer-simple-condition-first.md)                               | Prefer simple conditions first in logical expressions.                                                                         | ✅ ☑️ | 🔧 | 💡 |    |
 | [prefer-simple-sort-comparator](docs/rules/prefer-simple-sort-comparator.md)                               | Prefer a simple comparison function for `Array#sort()`.                                                                        | ✅ ☑️ |    | 💡 |    |
+| [prefer-simplified-conditions](docs/rules/prefer-simplified-conditions.md)                                 | Prefer simplified conditions.                                                                                                  | ✅ ☑️ | 🔧 |    |    |
 | [prefer-single-array-predicate](docs/rules/prefer-single-array-predicate.md)                               | Prefer a single `Array#some()` or `Array#every()` with a combined predicate.                                                   | ✅ ☑️ |    | 💡 |    |
 | [prefer-single-call](docs/rules/prefer-single-call.md)                                                     | Enforce combining multiple `Array#{push,unshift}()`, `Element#classList.{add,remove}()`, and `importScripts()` into one call.  | ✅ ☑️ | 🔧 | 💡 |    |
 | [prefer-single-object-destructuring](docs/rules/prefer-single-object-destructuring.md)                     | Prefer a single object destructuring declaration per local const source.                                                       | ✅    | 🔧 |    |    |
@@ -381,7 +391,7 @@ export default defineConfig([
 | [prefer-top-level-await](docs/rules/prefer-top-level-await.md)                                             | Prefer top-level await over top-level promises and async function calls.                                                       | ✅ ☑️ |    | 💡 |    |
 | [prefer-type-error](docs/rules/prefer-type-error.md)                                                       | Enforce throwing `TypeError` in type checking conditions.                                                                      | ✅ ☑️ | 🔧 |    |    |
 | [prefer-type-literal-last](docs/rules/prefer-type-literal-last.md)                                         | Require type literals to be last in union types.                                                                               | ✅    | 🔧 |    |    |
-| [prefer-uint8array-base64](docs/rules/prefer-uint8array-base64.md)                                         | Prefer `Uint8Array#toBase64()` and `Uint8Array.fromBase64()` over `atob()`, `btoa()`, and `Buffer` base64 conversions.         | ✅ ☑️ |    | 💡 |    |
+| [prefer-uint8array-base64](docs/rules/prefer-uint8array-base64.md)                                         | Prefer `Uint8Array#toBase64()` and `Uint8Array.fromBase64()` over `atob()`, `btoa()`, and `Buffer` base64 conversions.         |      |    | 💡 |    |
 | [prefer-unary-minus](docs/rules/prefer-unary-minus.md)                                                     | Prefer the unary minus operator over multiplying or dividing by `-1`.                                                          | ✅ ☑️ | 🔧 |    |    |
 | [prefer-unicode-code-point-escapes](docs/rules/prefer-unicode-code-point-escapes.md)                       | Prefer Unicode code point escapes over legacy escape sequences.                                                                | ✅ ☑️ | 🔧 | 💡 |    |
 | [prefer-url-can-parse](docs/rules/prefer-url-can-parse.md)                                                 | Prefer `URL.canParse()` over constructing a `URL` in a try/catch for validation.                                               | ✅ ☑️ | 🔧 |    |    |
@@ -556,3 +566,7 @@ export default defineConfig([
 
 - [Sindre Sorhus](https://github.com/sindresorhus)
 - [Fisker Cheung](https://github.com/fisker)
+
+## Related
+
+- [eslint-node-test](https://github.com/sindresorhus/eslint-node-test) — ESLint rules for the Node.js built-in test runner.

package/rules/ast/call-or-new-expression.js

@@ -79,18 +79,12 @@ function create(node, options, types) {
 		}
 	}
 
-	if (
-		Array.isArray(names)
+	return !(Array.isArray(names)
 		&& names.length > 0
 		&& (
 			node.callee.type !== 'Identifier'
 			|| !names.includes(node.callee.name)
-		)
-	) {
-		return false;
-	}
-
-	return true;
+		));
 }
 
 /**

package/rules/ast/is-member-expression.js

@@ -83,16 +83,10 @@ export default function isMemberExpression(node, options) {
 		return false;
 	}
 
-	if (
-		Array.isArray(objects)
+	return !(Array.isArray(objects)
 		&& objects.length > 0
 		&& (
 			node.object.type !== 'Identifier'
 			|| !objects.includes(node.object.name)
-		)
-	) {
-		return false;
-	}
-
-	return true;
+		));
 }

package/rules/comment-content.js

@@ -346,7 +346,7 @@ const pathTerminatorCharacters = '"\'`<>';
 const packageSpecifierTerminatorCharacters = '"\'`()[]{}<>,';
 const domainLeadingPunctuation = '([{<';
 const domainTrailingPunctuation = '.,;:!?)]}>';
-const maskCharacter = '\uFFFF';
+const maskCharacter = '\u{FFFF}';
 const openBrackets = '([{';
 const closeBrackets = ')]}';
 const quoteCharacters = '"\'`';
@@ -1062,14 +1062,14 @@ const create = context => {
 		return;
 	}
 
-	let checked = false;
+	let isChecked = false;
 
 	onRoot(context, function * (node) {
-		if (checked) {
+		if (isChecked) {
 			return;
 		}
 
-		checked = true;
+		isChecked = true;
 
 		const {sourceCode} = context;
 		const comments = getRuleComments(context);