eslint-plugin-unicorn 69.0.0 → 70.0.0

package/rules/consistent-boolean-name.js

@@ -1,10 +1,14 @@
 import {isRegExp} from 'node:util/types';
-import {getPropertyName} from '@eslint-community/eslint-utils';
+import {findVariable, getPropertyName, getStaticValue} from '@eslint-community/eslint-utils';
 import {renameVariable} from './fix/index.js';
+import resolveVariableName from './utils/resolve-variable-name.js';
 import {
 	getAvailableVariableName,
 	getScopes,
 	getVariableIdentifiers,
+	isNullishType,
+	isTypeParameterType,
+	isUnknownType,
 	upperFirst,
 } from './utils/index.js';
 import {
@@ -16,9 +20,11 @@ import {
 } from './utils/is-boolean.js';
 
 const MESSAGE_ID = 'consistent-boolean-name';
+const MESSAGE_ID_NON_BOOLEAN_PREFIX = 'non-boolean-prefix';
 const MESSAGE_ID_SUGGESTION = 'rename';
 const messages = {
 	[MESSAGE_ID]: 'Boolean name `{{name}}` should start with {{prefixes}}.',
+	[MESSAGE_ID_NON_BOOLEAN_PREFIX]: '`{{name}}` starts with `{{prefix}}`, so it should be boolean.',
 	[MESSAGE_ID_SUGGESTION]: 'Rename to `{{replacement}}`.',
 };
 
@@ -33,6 +39,8 @@ const defaultPrefixes = {
 	were: true,
 	did: true,
 	will: true,
+	// `requireLogin()` reads like an action or assertion, not a boolean.
+	requires: true,
 };
 
 const getEnabledPrefixes = ({prefixes = {}} = {}) =>
@@ -46,6 +54,48 @@ const getEnabledPrefixes = ({prefixes = {}} = {}) =>
 const formatPrefixes = prefixes =>
 	prefixes.map(prefix => `\`${prefix}\``).join(', ');
 
+const booleanBinaryOperators = new Set([
+	'>',
+	'>=',
+	'<',
+	'<=',
+	'==',
+	'===',
+	'!=',
+	'!==',
+	'in',
+	'instanceof',
+]);
+const boolean = 'boolean';
+const nonBoolean = 'non-boolean';
+const unknown = 'unknown';
+const nullishTypeAnnotationTypes = new Set([
+	'TSNullKeyword',
+	'TSUndefinedKeyword',
+]);
+const unknownTypeAnnotationTypes = new Set([
+	'TSAnyKeyword',
+	'TSNeverKeyword',
+	'TSUnknownKeyword',
+]);
+const nonBooleanExpressionTypes = new Set([
+	'ArrayExpression',
+	'ObjectExpression',
+	'ClassExpression',
+	'NewExpression',
+	'TemplateLiteral',
+	'UpdateExpression',
+]);
+const expressionWrapperTypes = new Set([
+	'AwaitExpression',
+	'TSNonNullExpression',
+	'ParenthesizedExpression',
+]);
+const typeScriptExpressionWrapperTypes = new Set([
+	'TSAsExpression',
+	'TSTypeAssertion',
+	'TSSatisfiesExpression',
+]);
 const isUpperCase = string => string === string.toUpperCase();
 const stripLeadingUnderscores = name => name.replace(/^_+/, '');
 
@@ -103,12 +153,12 @@ function isIgnoredName(name, ignore) {
 	});
 }
 
-function hasBooleanPrefix(name, prefixes) {
+function getBooleanPrefix(name, prefixes) {
 	name = stripLeadingUnderscores(name);
 
 	for (const prefix of prefixes) {
 		if (name.startsWith(`${prefix.toUpperCase()}_`)) {
-			return true;
+			return prefix;
 		}
 
 		if (
@@ -116,11 +166,9 @@ function hasBooleanPrefix(name, prefixes) {
 			&& name.length > prefix.length
 			&& /[\dA-Z_]/.test(name[prefix.length])
 		) {
-			return true;
+			return prefix;
 		}
 	}
-
-	return false;
 }
 
 function getReplacementName(name, prefix) {
@@ -184,45 +232,435 @@ const isBooleanValue = (node, context) => isFunction(node)
 	? isBooleanFunction(node, context)
 	: isBooleanFunctionReference(node, context) || isBooleanExpression(node, context);
 
-const isBooleanVariable = (variable, context) => {
-	const {sourceCode} = context;
+function getSupportedVariableDefinition(variable) {
+	if (variable.defs.length !== 1) {
+		return;
+	}
+
+	const [definition] = variable.defs;
+	const {name} = definition;
 
 	if (
-		variable.defs.length > 1
-		&& variable.defs.every(definition => definition.type === 'FunctionName')
+		name?.type !== 'Identifier'
+		|| !['Variable', 'Parameter', 'FunctionName'].includes(definition.type)
+		|| (definition.type === 'Variable' && definition.node.id.type !== 'Identifier')
+		|| (definition.type === 'Parameter' && definition.node.parent?.kind === 'set')
 	) {
-		const overloadDefinitions = variable.defs.filter(definition => definition.node.type === 'TSDeclareFunction');
+		return;
+	}
 
-		return overloadDefinitions.length > 0
-			? overloadDefinitions.every(definition => isBooleanFunctionDefinition(definition, context))
-			: variable.defs.every(definition => isBooleanFunctionDefinition(definition, context));
+	return definition;
+}
+
+function getFunctionDefinitions(variable) {
+	if (
+		variable.defs.length <= 1
+		|| variable.defs.some(definition => definition.type !== 'FunctionName')
+	) {
+		return;
 	}
 
-	if (variable.defs.length !== 1) {
-		return false;
+	const overloadDefinitions = variable.defs.filter(definition => definition.node.type === 'TSDeclareFunction');
+	return overloadDefinitions.length > 0 ? overloadDefinitions : variable.defs;
+}
+
+function combineBooleanStates(states) {
+	if (
+		states.length === 0
+		|| states.includes(unknown)
+	) {
+		return unknown;
 	}
 
-	const [definition] = variable.defs;
-	const {name} = definition;
+	return states.every(state => state === boolean) ? boolean : nonBoolean;
+}
 
-	if (name?.type !== 'Identifier') {
-		return false;
+function combineVariableBooleanStates(states) {
+	if (states.includes(nonBoolean)) {
+		return nonBoolean;
 	}
 
-	if (!['Variable', 'Parameter', 'FunctionName'].includes(definition.type)) {
-		return false;
+	return combineBooleanStates(states);
+}
+
+function getTypeBooleanState(type, checker, visitedTypes = new Set(), functionTypesAreBoolean = true) {
+	if (!type) {
+		return unknown;
 	}
 
-	// Destructuring patterns (`const {completed} = task`, `const [enabled] = list`) are intentionally not checked, since renaming a destructured binding is more involved than renaming a plain identifier.
-	if (definition.type === 'Variable' && definition.node.id.type !== 'Identifier') {
-		return false;
+	if (
+		isUnknownType(type)
+		|| type.intrinsicName === 'never'
+	) {
+		return unknown;
+	}
+
+	if (visitedTypes.has(type)) {
+		return unknown;
+	}
+
+	visitedTypes.add(type);
+
+	if (isTypeParameterType(type)) {
+		const constraint = type.getConstraint();
+		const result = constraint ? getTypeBooleanState(constraint, checker, visitedTypes, functionTypesAreBoolean) : unknown;
+		visitedTypes.delete(type);
+		return result;
+	}
+
+	const nonNullableType = checker.getNonNullableType(type);
+	if (nonNullableType !== type) {
+		const result = getTypeBooleanState(nonNullableType, checker, visitedTypes, functionTypesAreBoolean);
+		visitedTypes.delete(type);
+		return result;
+	}
+
+	if (type.isUnion()) {
+		const result = combineBooleanStates(
+			type.types
+				.filter(type => !isNullishType(type))
+				.map(type => getTypeBooleanState(type, checker, visitedTypes, functionTypesAreBoolean)),
+		);
+		visitedTypes.delete(type);
+		return result;
+	}
+
+	const signatures = type.getCallSignatures();
+	if (signatures.length > 0) {
+		const result = functionTypesAreBoolean
+			? combineBooleanStates(signatures.map(signature => getTypeBooleanState(signature.getReturnType(), checker, visitedTypes, false)))
+			: nonBoolean;
+		visitedTypes.delete(type);
+		return result;
+	}
+
+	const constraint = checker.getBaseConstraintOfType(type);
+	if (constraint && constraint !== type) {
+		const result = getTypeBooleanState(constraint, checker, visitedTypes, functionTypesAreBoolean);
+		visitedTypes.delete(type);
+		return result;
+	}
+
+	if (type.getProperties().length === 0) {
+		visitedTypes.delete(type);
+		return unknown;
+	}
+
+	const typeString = checker.typeToString(checker.getWidenedType(checker.getBaseTypeOfLiteralType(type)));
+	visitedTypes.delete(type);
+
+	return typeString === 'boolean' ? boolean : nonBoolean;
+}
+
+function getTypeInformationBooleanState(node, context, functionTypesAreBoolean = true) {
+	const {parserServices} = context.sourceCode;
+	if (!parserServices?.program) {
+		return unknown;
+	}
+
+	try {
+		return getTypeBooleanState(
+			parserServices.getTypeAtLocation(node),
+			parserServices.program.getTypeChecker(),
+			new Set(),
+			functionTypesAreBoolean,
+		);
+	} catch {
+		return unknown;
+	}
+}
+
+function getTypeReferenceName(typeName) {
+	if (typeName?.type === 'Identifier') {
+		return typeName.name;
+	}
+}
+
+const getTypeState = typeState => ({
+	visitedTypeReferenceNames: new Set(),
+	functionTypesAreBoolean: true,
+	...typeState,
+});
+
+function getTypeMembersBooleanState(members, context, scope, typeState) {
+	const normalizedTypeState = getTypeState(typeState);
+	const callSignatures = members.filter(member => member.type === 'TSCallSignatureDeclaration');
+
+	if (callSignatures.length > 0) {
+		return normalizedTypeState.functionTypesAreBoolean
+			? combineBooleanStates(callSignatures.map(member => getTypeAnnotationBooleanState(member.returnType, context, scope, {...normalizedTypeState, functionTypesAreBoolean: false})))
+			: nonBoolean;
+	}
+
+	return members.length > 0 ? nonBoolean : unknown;
+}
+
+function getTypeReferenceBooleanState(node, context, scope, typeState) {
+	const normalizedTypeState = getTypeState(typeState);
+	const {visitedTypeReferenceNames} = normalizedTypeState;
+	const name = getTypeReferenceName(node.typeName);
+	if (!name || visitedTypeReferenceNames.has(name)) {
+		return unknown;
+	}
+
+	visitedTypeReferenceNames.add(name);
+
+	const [definition] = resolveVariableName(name, scope)?.defs ?? [];
+	let result = unknown;
+
+	if (definition?.type === 'Type') {
+		const definitionScope = context.sourceCode.getScope(definition.node);
+
+		if (definition.node.type === 'TSTypeAliasDeclaration') {
+			result = getTypeAnnotationBooleanState(definition.node.typeAnnotation, context, definitionScope, normalizedTypeState);
+		} else if (definition.node.type === 'TSInterfaceDeclaration') {
+			result = getTypeMembersBooleanState(definition.node.body.body, context, definitionScope, normalizedTypeState);
+		}
+	}
+
+	visitedTypeReferenceNames.delete(name);
+	return result;
+}
+
+function getUnionTypeAnnotationBooleanState(node, context, scope, typeState) {
+	return combineBooleanStates(
+		node.types
+			.filter(type => !nullishTypeAnnotationTypes.has(type.type))
+			.map(type => getTypeAnnotationBooleanState(type, context, scope, typeState)),
+	);
+}
+
+function getSimpleTypeAnnotationBooleanState(node) {
+	if (!node) {
+		return unknown;
+	}
+
+	if (
+		nullishTypeAnnotationTypes.has(node.type)
+		|| unknownTypeAnnotationTypes.has(node.type)
+	) {
+		return unknown;
+	}
+
+	if (node.type === 'TSBooleanKeyword') {
+		return boolean;
+	}
+
+	if (node.type === 'TSLiteralType') {
+		return typeof node.literal.value === 'boolean' ? boolean : nonBoolean;
+	}
+
+	if (node.type === 'TSTypePredicate') {
+		return node.asserts ? nonBoolean : boolean;
+	}
+
+	if (node.type === 'TypeAnnotation') {
+		return node.typeAnnotation?.type === 'BooleanTypeAnnotation' ? boolean : nonBoolean;
+	}
+
+	return nonBoolean;
+}
+
+function getTypeAnnotationBooleanState(node, context, scope, typeState) {
+	const normalizedTypeState = getTypeState(typeState);
+
+	if (
+		node?.type === 'TSTypeAnnotation'
+		|| node?.type === 'TSParenthesizedType'
+	) {
+		return getTypeAnnotationBooleanState(node.typeAnnotation, context, scope, normalizedTypeState);
+	}
+
+	if (node?.type === 'TSFunctionType') {
+		return normalizedTypeState.functionTypesAreBoolean
+			? getTypeAnnotationBooleanState(node.returnType, context, scope, {...normalizedTypeState, functionTypesAreBoolean: false})
+			: nonBoolean;
+	}
+
+	if (node?.type === 'TSUnionType') {
+		return getUnionTypeAnnotationBooleanState(node, context, scope, normalizedTypeState);
+	}
+
+	if (node?.type === 'TSTypeReference') {
+		return getTypeReferenceBooleanState(node, context, scope, normalizedTypeState);
+	}
+
+	if (node?.type === 'TSTypeLiteral') {
+		return getTypeMembersBooleanState(node.members, context, scope, normalizedTypeState);
+	}
+
+	return getSimpleTypeAnnotationBooleanState(node);
+}
+
+function getFunctionBooleanState(node, context, visitedVariables = new Set()) {
+	if (node.async || node.generator) {
+		return nonBoolean;
+	}
+
+	const stateFromTypeInformation = getTypeInformationBooleanState(node, context);
+	if (stateFromTypeInformation !== unknown) {
+		return stateFromTypeInformation;
+	}
+
+	const scope = context.sourceCode.getScope(node);
+	const stateFromReturnType = getTypeAnnotationBooleanState(node.returnType, context, scope, {functionTypesAreBoolean: false});
+	if (stateFromReturnType !== unknown) {
+		return stateFromReturnType;
+	}
+
+	if (!node.body) {
+		return unknown;
+	}
+
+	if (node.body.type === 'BlockStatement') {
+		if (node.body.body.length === 0) {
+			return nonBoolean;
+		}
+
+		if (
+			node.body.body.length === 1
+			&& node.body.body[0].type === 'ReturnStatement'
+		) {
+			return node.body.body[0].argument
+				? getExpressionBooleanState(node.body.body[0].argument, context, visitedVariables, false)
+				: nonBoolean;
+		}
+	}
+
+	return node.type === 'ArrowFunctionExpression' && node.body.type !== 'BlockStatement'
+		? getExpressionBooleanState(node.body, context, visitedVariables, false)
+		: unknown;
+}
+
+function getKnownIdentifierBooleanState(node, context, visitedVariables, functionValuesAreBoolean) {
+	const variable = findVariable(context.sourceCode.getScope(node), node);
+	return variable ? getVariableBooleanState(variable, context, visitedVariables, functionValuesAreBoolean) : unknown;
+}
+
+function getStaticExpressionBooleanState(node, scope) {
+	if (node.type === 'Identifier') {
+		return unknown;
+	}
+
+	const staticValue = getStaticValue(node, scope)?.value;
+
+	return staticValue === undefined
+		? unknown
+		: (typeof staticValue === 'boolean' ? boolean : nonBoolean);
+}
+
+function getSimpleExpressionBooleanState(node) {
+	if (nonBooleanExpressionTypes.has(node.type)) {
+		return nonBoolean;
+	}
+
+	if (node.type === 'Literal') {
+		return node.value === null ? unknown : nonBoolean;
+	}
+
+	if (node.type === 'UnaryExpression') {
+		return ['!', 'delete'].includes(node.operator) ? boolean : nonBoolean;
+	}
+
+	if (node.type === 'BinaryExpression') {
+		return booleanBinaryOperators.has(node.operator) ? boolean : nonBoolean;
+	}
+
+	return unknown;
+}
+
+function getWrappedExpression(node) {
+	if (expressionWrapperTypes.has(node.type)) {
+		return node.argument ?? node.expression;
+	}
+
+	if (typeScriptExpressionWrapperTypes.has(node.type)) {
+		return node.expression;
+	}
+}
+
+function getDerivedExpressionBooleanState(node, context, visitedVariables, functionValuesAreBoolean) {
+	if (node.type === 'Identifier') {
+		return getKnownIdentifierBooleanState(node, context, visitedVariables, functionValuesAreBoolean);
+	}
+
+	const wrappedExpression = getWrappedExpression(node);
+	if (wrappedExpression) {
+		return getExpressionBooleanState(wrappedExpression, context, visitedVariables, functionValuesAreBoolean);
+	}
+
+	if (node.type === 'AssignmentExpression') {
+		return node.operator === '=' ? getExpressionBooleanState(node.right, context, visitedVariables, functionValuesAreBoolean) : unknown;
+	}
+
+	if (node.type === 'SequenceExpression') {
+		return getExpressionBooleanState(node.expressions.at(-1), context, visitedVariables, functionValuesAreBoolean);
+	}
+
+	if (node.type === 'ConditionalExpression') {
+		return combineBooleanStates([
+			getExpressionBooleanState(node.consequent, context, visitedVariables, functionValuesAreBoolean),
+			getExpressionBooleanState(node.alternate, context, visitedVariables, functionValuesAreBoolean),
+		]);
+	}
+
+	return unknown;
+}
+
+function getExpressionBooleanState(node, context, visitedVariables = new Set(), functionValuesAreBoolean = true) {
+	if (!node) {
+		return unknown;
+	}
+
+	if (isFunction(node)) {
+		return functionValuesAreBoolean
+			? getFunctionBooleanState(node, context, visitedVariables)
+			: nonBoolean;
 	}
 
-	// A setter parameter's name is positional and dictated by the accessor, not chosen freely.
-	if (definition.type === 'Parameter' && definition.node.parent?.kind === 'set') {
+	const stateFromTypeInformation = getTypeInformationBooleanState(node, context, functionValuesAreBoolean);
+	if (stateFromTypeInformation !== unknown) {
+		return stateFromTypeInformation;
+	}
+
+	const scope = context.sourceCode.getScope(node);
+	const stateFromTypeAnnotation = getTypeAnnotationBooleanState(node.typeAnnotation, context, scope, {functionTypesAreBoolean: functionValuesAreBoolean});
+	if (stateFromTypeAnnotation !== unknown) {
+		return stateFromTypeAnnotation;
+	}
+
+	if (isBooleanExpression(node, context, visitedVariables)) {
+		return boolean;
+	}
+
+	const stateFromStaticValue = getStaticExpressionBooleanState(node, scope);
+	if (stateFromStaticValue !== unknown) {
+		return stateFromStaticValue;
+	}
+
+	const stateFromSimpleExpression = getSimpleExpressionBooleanState(node);
+	if (stateFromSimpleExpression !== unknown) {
+		return stateFromSimpleExpression;
+	}
+
+	return getDerivedExpressionBooleanState(node, context, visitedVariables, functionValuesAreBoolean);
+}
+
+const isBooleanVariable = (variable, context) => {
+	const {sourceCode} = context;
+
+	const functionDefinitions = getFunctionDefinitions(variable);
+	if (functionDefinitions) {
+		return functionDefinitions.every(definition => isBooleanFunctionDefinition(definition, context));
+	}
+
+	const definition = getSupportedVariableDefinition(variable);
+	if (!definition) {
 		return false;
 	}
 
+	const {name} = definition;
+
 	const scope = sourceCode.getScope(name);
 
 	if (name.typeAnnotation) {
@@ -250,12 +688,91 @@ const isBooleanVariable = (variable, context) => {
 		return isBooleanValue(definition.node.init, context);
 	}
 
+	return definition.type === 'FunctionName' && isBooleanFunctionDefinition(definition, context);
+};
+
+function getParameterBooleanState(definition, context, visitedVariables, functionValuesAreBoolean) {
+	if (!isFunction(definition.node)) {
+		return unknown;
+	}
+
+	const parameter = findParameter(definition.node.params, definition.name);
+
+	return parameter?.type === 'AssignmentPattern'
+		? getExpressionBooleanState(parameter.right, context, visitedVariables, functionValuesAreBoolean)
+		: unknown;
+}
+
+function getDefinitionBooleanState(definition, context, visitedVariables, functionValuesAreBoolean) {
+	const scope = context.sourceCode.getScope(definition.name);
+	const stateFromTypeAnnotation = getTypeAnnotationBooleanState(definition.name.typeAnnotation, context, scope, {functionTypesAreBoolean: functionValuesAreBoolean});
+	if (stateFromTypeAnnotation !== unknown) {
+		return stateFromTypeAnnotation;
+	}
+
+	if (definition.type === 'Parameter') {
+		return getParameterBooleanState(definition, context, visitedVariables, functionValuesAreBoolean);
+	}
+
+	if (definition.type === 'Variable') {
+		return getExpressionBooleanState(definition.node.init, context, visitedVariables, functionValuesAreBoolean);
+	}
+
 	if (definition.type === 'FunctionName') {
-		return isBooleanFunctionDefinition(definition, context);
+		return functionValuesAreBoolean
+			? getFunctionBooleanState(definition.node, context, visitedVariables)
+			: nonBoolean;
 	}
 
-	return false;
-};
+	return unknown;
+}
+
+function getVariableBooleanState(variable, context, visitedVariables = new Set(), functionValuesAreBoolean = true) {
+	if (!variable || visitedVariables.has(variable)) {
+		return unknown;
+	}
+
+	visitedVariables.add(variable);
+
+	const functionDefinitions = getFunctionDefinitions(variable);
+	const definition = getSupportedVariableDefinition(variable);
+	if (
+		!functionDefinitions
+		&& !definition
+	) {
+		visitedVariables.delete(variable);
+		return unknown;
+	}
+
+	let result;
+	if (functionDefinitions && !functionValuesAreBoolean) {
+		result = nonBoolean;
+	} else if (functionDefinitions) {
+		result = combineBooleanStates(functionDefinitions.map(definition => getFunctionBooleanState(definition.node, context, visitedVariables)));
+	} else {
+		result = getDefinitionBooleanState(definition, context, visitedVariables, functionValuesAreBoolean);
+	}
+
+	if (variable.references.some(reference => reference.writeExpr)) {
+		result = combineVariableBooleanStates([
+			result,
+			...variable.references
+				.filter(reference => reference.writeExpr)
+				.map(reference => getExpressionBooleanState(reference.writeExpr, context, visitedVariables, functionValuesAreBoolean)),
+		]);
+	}
+
+	if (
+		result === unknown
+		&& functionValuesAreBoolean
+		&& isBooleanVariable(variable, context)
+	) {
+		result = boolean;
+	}
+
+	visitedVariables.delete(variable);
+	return result;
+}
 
 function getBooleanPropertyName(node, sourceCode) {
 	if (
@@ -324,6 +841,53 @@ function isBooleanProperty(node, context) {
 	return false;
 }
 
+function getExplicitPropertyBooleanState(node, context) {
+	const {sourceCode} = context;
+
+	if (node.type === 'Property') {
+		if (
+			node.parent.type !== 'ObjectExpression'
+			|| node.shorthand
+			|| node.kind === 'set'
+		) {
+			return unknown;
+		}
+
+		return getExpressionBooleanState(node.value, context);
+	}
+
+	if (
+		node.type === 'MethodDefinition'
+		|| node.type === 'TSAbstractMethodDefinition'
+	) {
+		return ['constructor', 'set'].includes(node.kind) ? unknown : getFunctionBooleanState(node.value, context);
+	}
+
+	if (propertyDefinitionTypes.has(node.type)) {
+		const scope = sourceCode.getScope(node);
+		const stateFromTypeAnnotation = getTypeAnnotationBooleanState(node.typeAnnotation, context, scope);
+
+		return stateFromTypeAnnotation === unknown
+			? getExpressionBooleanState(node.value, context)
+			: stateFromTypeAnnotation;
+	}
+
+	if (node.type === 'TSPropertySignature') {
+		return getTypeAnnotationBooleanState(node.typeAnnotation, context, sourceCode.getScope(node));
+	}
+
+	if (node.type === 'TSMethodSignature') {
+		return getTypeAnnotationBooleanState(node.returnType, context, sourceCode.getScope(node), {functionTypesAreBoolean: false});
+	}
+
+	return unknown;
+}
+
+function getPropertyBooleanState(node, context) {
+	const state = getExplicitPropertyBooleanState(node, context);
+	return state === unknown && isBooleanProperty(node, context) ? boolean : state;
+}
+
 function getSuggestions(variable, prefixes, context) {
 	if (
 		!shouldSuggestRename(variable)
@@ -414,11 +978,30 @@ const create = context => {
 	}
 
 	const checkVariable = variable => {
-		// `hasBooleanPrefix` and `ignore` are cheap string checks, so run them before
-		// the expensive `isBooleanVariable` analysis.
+		if (isIgnoredName(variable.name, ignore)) {
+			return;
+		}
+
+		const booleanPrefix = getBooleanPrefix(variable.name, prefixes);
+		if (booleanPrefix) {
+			if (getVariableBooleanState(variable, context) === nonBoolean) {
+				const [definition] = variable.defs;
+
+				context.report({
+					node: definition.name,
+					messageId: MESSAGE_ID_NON_BOOLEAN_PREFIX,
+					data: {
+						name: variable.name,
+						prefix: booleanPrefix,
+					},
+				});
+			}
+
+			return;
+		}
+
 		if (
-			hasBooleanPrefix(variable.name, prefixes)
-			|| isIgnoredName(variable.name, ignore)
+			getVariableBooleanState(variable, context) === nonBoolean
 			|| !isBooleanVariable(variable, context)
 		) {
 			return;
@@ -456,13 +1039,31 @@ const create = context => {
 
 		if (
 			!name
-			|| hasBooleanPrefix(name, prefixes)
 			|| isIgnoredName(name, ignore)
-			|| !isBooleanProperty(node, context)
 		) {
 			return;
 		}
 
+		const booleanPrefix = getBooleanPrefix(name, prefixes);
+		if (booleanPrefix) {
+			if (getPropertyBooleanState(node, context) === nonBoolean) {
+				context.report({
+					node: node.key,
+					messageId: MESSAGE_ID_NON_BOOLEAN_PREFIX,
+					data: {
+						name,
+						prefix: booleanPrefix,
+					},
+				});
+			}
+
+			return;
+		}
+
+		if (!isBooleanProperty(node, context)) {
+			return;
+		}
+
 		context.report({
 			node: node.key,
 			messageId: MESSAGE_ID,