eslint-plugin-unicorn 67.0.0 → 69.0.0

package/rules/index.js

@@ -8,6 +8,7 @@ export {default as 'consistent-assert'} from './consistent-assert.js';
 export {default as 'consistent-boolean-name'} from './consistent-boolean-name.js';
 export {default as 'consistent-class-member-order'} from './consistent-class-member-order.js';
 export {default as 'consistent-compound-words'} from './consistent-compound-words.js';
+export {default as 'consistent-conditional-object-spread'} from './consistent-conditional-object-spread.js';
 export {default as 'consistent-date-clone'} from './consistent-date-clone.js';
 export {default as 'consistent-destructuring'} from './consistent-destructuring.js';
 export {default as 'consistent-empty-array-spread'} from './consistent-empty-array-spread.js';
@@ -18,7 +19,9 @@ export {default as 'consistent-function-style'} from './consistent-function-styl
 export {default as 'consistent-json-file-read'} from './consistent-json-file-read.js';
 export {default as 'consistent-optional-chaining'} from './consistent-optional-chaining.js';
 export {default as 'consistent-template-literal-escape'} from './consistent-template-literal-escape.js';
+export {default as 'consistent-tuple-labels'} from './consistent-tuple-labels.js';
 export {default as 'custom-error-definition'} from './custom-error-definition.js';
+export {default as 'default-export-style'} from './default-export-style.js';
 export {default as 'dom-node-dataset'} from './dom-node-dataset.js';
 export {default as 'empty-brace-spaces'} from './empty-brace-spaces.js';
 export {default as 'error-message'} from './error-message.js';
@@ -32,30 +35,42 @@ export {default as 'import-style'} from './import-style.js';
 export {default as 'isolated-functions'} from './isolated-functions.js';
 export {default as 'logical-assignment-operators'} from './logical-assignment-operators.js';
 export {default as 'max-nested-calls'} from './max-nested-calls.js';
+export {default as 'name-replacements'} from './name-replacements.js';
 export {default as 'new-for-builtins'} from './new-for-builtins.js';
 export {default as 'no-abusive-eslint-disable'} from './no-abusive-eslint-disable.js';
 export {default as 'no-accessor-recursion'} from './no-accessor-recursion.js';
+export {default as 'no-accidental-bitwise-operator'} from './no-accidental-bitwise-operator.js';
 export {default as 'no-anonymous-default-export'} from './no-anonymous-default-export.js';
 export {default as 'no-array-callback-reference'} from './no-array-callback-reference.js';
+export {default as 'no-array-concat-in-loop'} from './no-array-concat-in-loop.js';
 export {default as 'no-array-fill-with-reference-type'} from './no-array-fill-with-reference-type.js';
 export {default as 'no-array-from-fill'} from './no-array-from-fill.js';
+export {default as 'no-array-front-mutation'} from './no-array-front-mutation.js';
 export {default as 'no-array-method-this-argument'} from './no-array-method-this-argument.js';
 export {default as 'no-array-reduce'} from './no-array-reduce.js';
 export {default as 'no-array-reverse'} from './no-array-reverse.js';
+export {default as 'no-array-sort-for-min-max'} from './no-array-sort-for-min-max.js';
 export {default as 'no-array-sort'} from './no-array-sort.js';
 export {default as 'no-array-splice'} from './no-array-splice.js';
 export {default as 'no-asterisk-prefix-in-documentation-comments'} from './no-asterisk-prefix-in-documentation-comments.js';
 export {default as 'no-await-expression-member'} from './no-await-expression-member.js';
 export {default as 'no-await-in-promise-methods'} from './no-await-in-promise-methods.js';
 export {default as 'no-blob-to-file'} from './no-blob-to-file.js';
+export {default as 'no-boolean-sort-comparator'} from './no-boolean-sort-comparator.js';
 export {default as 'no-break-in-nested-loop'} from './no-break-in-nested-loop.js';
 export {default as 'no-canvas-to-image'} from './no-canvas-to-image.js';
+export {default as 'no-chained-comparison'} from './no-chained-comparison.js';
+export {default as 'no-collection-bracket-access'} from './no-collection-bracket-access.js';
 export {default as 'no-computed-property-existence-check'} from './no-computed-property-existence-check.js';
 export {default as 'no-confusing-array-splice'} from './no-confusing-array-splice.js';
 export {default as 'no-confusing-array-with'} from './no-confusing-array-with.js';
 export {default as 'no-console-spaces'} from './no-console-spaces.js';
+export {default as 'no-constant-zero-expression'} from './no-constant-zero-expression.js';
 export {default as 'no-declarations-before-early-exit'} from './no-declarations-before-early-exit.js';
 export {default as 'no-document-cookie'} from './no-document-cookie.js';
+export {default as 'no-double-comparison'} from './no-double-comparison.js';
+export {default as 'no-duplicate-if-branches'} from './no-duplicate-if-branches.js';
+export {default as 'no-duplicate-logical-operands'} from './no-duplicate-logical-operands.js';
 export {default as 'no-duplicate-loops'} from './no-duplicate-loops.js';
 export {default as 'no-duplicate-set-values'} from './no-duplicate-set-values.js';
 export {default as 'no-empty-file'} from './no-empty-file.js';
@@ -65,19 +80,25 @@ export {default as 'no-for-each'} from './no-for-each.js';
 export {default as 'no-for-loop'} from './no-for-loop.js';
 export {default as 'no-global-object-property-assignment'} from './no-global-object-property-assignment.js';
 export {default as 'no-immediate-mutation'} from './no-immediate-mutation.js';
+export {default as 'no-impossible-length-comparison'} from './no-impossible-length-comparison.js';
 export {default as 'no-incorrect-query-selector'} from './no-incorrect-query-selector.js';
 export {default as 'no-incorrect-template-string-interpolation'} from './no-incorrect-template-string-interpolation.js';
 export {default as 'no-instanceof-builtins'} from './no-instanceof-builtins.js';
 export {default as 'no-invalid-argument-count'} from './no-invalid-argument-count.js';
+export {default as 'no-invalid-character-comparison'} from './no-invalid-character-comparison.js';
 export {default as 'no-invalid-fetch-options'} from './no-invalid-fetch-options.js';
 export {default as 'no-invalid-file-input-accept'} from './no-invalid-file-input-accept.js';
 export {default as 'no-invalid-remove-event-listener'} from './no-invalid-remove-event-listener.js';
+export {default as 'no-invalid-well-known-symbol-methods'} from './no-invalid-well-known-symbol-methods.js';
 export {default as 'no-keyword-prefix'} from './no-keyword-prefix.js';
 export {default as 'no-late-current-target-access'} from './no-late-current-target-access.js';
+export {default as 'no-late-event-control'} from './no-late-event-control.js';
 export {default as 'no-lonely-if'} from './no-lonely-if.js';
+export {default as 'no-loop-iterable-mutation'} from './no-loop-iterable-mutation.js';
 export {default as 'no-magic-array-flat-depth'} from './no-magic-array-flat-depth.js';
 export {default as 'no-manually-wrapped-comments'} from './no-manually-wrapped-comments.js';
 export {default as 'no-mismatched-map-key'} from './no-mismatched-map-key.js';
+export {default as 'no-misrefactored-assignment'} from './no-misrefactored-assignment.js';
 export {default as 'no-named-default'} from './no-named-default.js';
 export {default as 'no-negated-array-predicate'} from './no-negated-array-predicate.js';
 export {default as 'no-negated-comparison'} from './no-negated-comparison.js';
@@ -87,6 +108,7 @@ export {default as 'no-nested-ternary'} from './no-nested-ternary.js';
 export {default as 'no-new-array'} from './no-new-array.js';
 export {default as 'no-new-buffer'} from './no-new-buffer.js';
 export {default as 'no-non-function-verb-prefix'} from './no-non-function-verb-prefix.js';
+export {default as 'no-nonstandard-builtin-properties'} from './no-nonstandard-builtin-properties.js';
 export {default as 'no-null'} from './no-null.js';
 export {default as 'no-object-as-default-parameter'} from './no-object-as-default-parameter.js';
 export {default as 'no-object-methods-with-collections'} from './no-object-methods-with-collections.js';
@@ -94,6 +116,7 @@ export {default as 'no-optional-chaining-on-undeclared-variable'} from './no-opt
 export {default as 'no-process-exit'} from './no-process-exit.js';
 export {default as 'no-redundant-comparison'} from './no-redundant-comparison.js';
 export {default as 'no-return-array-push'} from './no-return-array-push.js';
+export {default as 'no-selector-as-dom-name'} from './no-selector-as-dom-name.js';
 export {default as 'no-single-promise-in-promise-methods'} from './no-single-promise-in-promise-methods.js';
 export {default as 'no-static-only-class'} from './no-static-only-class.js';
 export {default as 'no-subtraction-comparison'} from './no-subtraction-comparison.js';
@@ -108,6 +131,7 @@ export {default as 'no-undeclared-class-members'} from './no-undeclared-class-me
 export {default as 'no-unnecessary-array-flat-depth'} from './no-unnecessary-array-flat-depth.js';
 export {default as 'no-unnecessary-array-splice-count'} from './no-unnecessary-array-splice-count.js';
 export {default as 'no-unnecessary-await'} from './no-unnecessary-await.js';
+export {default as 'no-unnecessary-boolean-comparison'} from './no-unnecessary-boolean-comparison.js';
 export {default as 'no-unnecessary-global-this'} from './no-unnecessary-global-this.js';
 export {default as 'no-unnecessary-nested-ternary'} from './no-unnecessary-nested-ternary.js';
 export {default as 'no-unnecessary-polyfills'} from './no-unnecessary-polyfills.js';
@@ -127,13 +151,16 @@ export {default as 'no-unused-properties'} from './no-unused-properties.js';
 export {default as 'no-useless-boolean-cast'} from './no-useless-boolean-cast.js';
 export {default as 'no-useless-coercion'} from './no-useless-coercion.js';
 export {default as 'no-useless-collection-argument'} from './no-useless-collection-argument.js';
+export {default as 'no-useless-compound-assignment'} from './no-useless-compound-assignment.js';
 export {default as 'no-useless-concat'} from './no-useless-concat.js';
 export {default as 'no-useless-continue'} from './no-useless-continue.js';
+export {default as 'no-useless-delete-check'} from './no-useless-delete-check.js';
 export {default as 'no-useless-else'} from './no-useless-else.js';
 export {default as 'no-useless-error-capture-stack-trace'} from './no-useless-error-capture-stack-trace.js';
 export {default as 'no-useless-fallback-in-spread'} from './no-useless-fallback-in-spread.js';
 export {default as 'no-useless-iterator-to-array'} from './no-useless-iterator-to-array.js';
 export {default as 'no-useless-length-check'} from './no-useless-length-check.js';
+export {default as 'no-useless-logical-operand'} from './no-useless-logical-operand.js';
 export {default as 'no-useless-override'} from './no-useless-override.js';
 export {default as 'no-useless-promise-resolve-reject'} from './no-useless-promise-resolve-reject.js';
 export {default as 'no-useless-recursion'} from './no-useless-recursion.js';
@@ -141,17 +168,22 @@ export {default as 'no-useless-spread'} from './no-useless-spread.js';
 export {default as 'no-useless-switch-case'} from './no-useless-switch-case.js';
 export {default as 'no-useless-template-literals'} from './no-useless-template-literals.js';
 export {default as 'no-useless-undefined'} from './no-useless-undefined.js';
+export {default as 'no-xor-as-exponentiation'} from './no-xor-as-exponentiation.js';
 export {default as 'no-zero-fractions'} from './no-zero-fractions.js';
 export {default as 'number-literal-case'} from './number-literal-case.js';
 export {default as 'numeric-separators-style'} from './numeric-separators-style.js';
 export {default as 'operator-assignment'} from './operator-assignment.js';
+export {default as 'prefer-abort-signal-timeout'} from './prefer-abort-signal-timeout.js';
 export {default as 'prefer-add-event-listener-options'} from './prefer-add-event-listener-options.js';
 export {default as 'prefer-add-event-listener'} from './prefer-add-event-listener.js';
+export {default as 'prefer-aggregate-error'} from './prefer-aggregate-error.js';
 export {default as 'prefer-array-find'} from './prefer-array-find.js';
 export {default as 'prefer-array-flat-map'} from './prefer-array-flat-map.js';
 export {default as 'prefer-array-flat'} from './prefer-array-flat.js';
+export {default as 'prefer-array-from-async'} from './prefer-array-from-async.js';
 export {default as 'prefer-array-from-map'} from './prefer-array-from-map.js';
 export {default as 'prefer-array-index-of'} from './prefer-array-index-of.js';
+export {default as 'prefer-array-iterable-methods'} from './prefer-array-iterable-methods.js';
 export {default as 'prefer-array-last-methods'} from './prefer-array-last-methods.js';
 export {default as 'prefer-array-slice'} from './prefer-array-slice.js';
 export {default as 'prefer-array-some'} from './prefer-array-some.js';
@@ -159,9 +191,11 @@ export {default as 'prefer-at'} from './prefer-at.js';
 export {default as 'prefer-await'} from './prefer-await.js';
 export {default as 'prefer-bigint-literals'} from './prefer-bigint-literals.js';
 export {default as 'prefer-blob-reading-methods'} from './prefer-blob-reading-methods.js';
+export {default as 'prefer-boolean-return'} from './prefer-boolean-return.js';
 export {default as 'prefer-class-fields'} from './prefer-class-fields.js';
 export {default as 'prefer-classlist-toggle'} from './prefer-classlist-toggle.js';
 export {default as 'prefer-code-point'} from './prefer-code-point.js';
+export {default as 'prefer-continue'} from './prefer-continue.js';
 export {default as 'prefer-date-now'} from './prefer-date-now.js';
 export {default as 'prefer-default-parameters'} from './prefer-default-parameters.js';
 export {default as 'prefer-direct-iteration'} from './prefer-direct-iteration.js';
@@ -169,15 +203,19 @@ export {default as 'prefer-dispose'} from './prefer-dispose.js';
 export {default as 'prefer-dom-node-append'} from './prefer-dom-node-append.js';
 export {default as 'prefer-dom-node-html-methods'} from './prefer-dom-node-html-methods.js';
 export {default as 'prefer-dom-node-remove'} from './prefer-dom-node-remove.js';
+export {default as 'prefer-dom-node-replace-children'} from './prefer-dom-node-replace-children.js';
 export {default as 'prefer-dom-node-text-content'} from './prefer-dom-node-text-content.js';
 export {default as 'prefer-early-return'} from './prefer-early-return.js';
 export {default as 'prefer-else-if'} from './prefer-else-if.js';
+export {default as 'prefer-error-is-error'} from './prefer-error-is-error.js';
 export {default as 'prefer-event-target'} from './prefer-event-target.js';
 export {default as 'prefer-export-from'} from './prefer-export-from.js';
+export {default as 'prefer-flat-math-min-max'} from './prefer-flat-math-min-max.js';
 export {default as 'prefer-get-or-insert-computed'} from './prefer-get-or-insert-computed.js';
 export {default as 'prefer-global-number-constants'} from './prefer-global-number-constants.js';
 export {default as 'prefer-global-this'} from './prefer-global-this.js';
 export {default as 'prefer-has-check'} from './prefer-has-check.js';
+export {default as 'prefer-hoisting-branch-code'} from './prefer-hoisting-branch-code.js';
 export {default as 'prefer-https'} from './prefer-https.js';
 export {default as 'prefer-identifier-import-export-specifiers'} from './prefer-identifier-import-export-specifiers.js';
 export {default as 'prefer-import-meta-properties'} from './prefer-import-meta-properties.js';
@@ -192,6 +230,7 @@ export {default as 'prefer-location-assign'} from './prefer-location-assign.js';
 export {default as 'prefer-logical-operator-over-ternary'} from './prefer-logical-operator-over-ternary.js';
 export {default as 'prefer-map-from-entries'} from './prefer-map-from-entries.js';
 export {default as 'prefer-math-abs'} from './prefer-math-abs.js';
+export {default as 'prefer-math-constants'} from './prefer-math-constants.js';
 export {default as 'prefer-math-min-max'} from './prefer-math-min-max.js';
 export {default as 'prefer-math-trunc'} from './prefer-math-trunc.js';
 export {default as 'prefer-minimal-ternary'} from './prefer-minimal-ternary.js';
@@ -208,17 +247,22 @@ export {default as 'prefer-object-define-properties'} from './prefer-object-defi
 export {default as 'prefer-object-destructuring-defaults'} from './prefer-object-destructuring-defaults.js';
 export {default as 'prefer-object-from-entries'} from './prefer-object-from-entries.js';
 export {default as 'prefer-object-iterable-methods'} from './prefer-object-iterable-methods.js';
+export {default as 'prefer-observer-apis'} from './prefer-observer-apis.js';
 export {default as 'prefer-optional-catch-binding'} from './prefer-optional-catch-binding.js';
 export {default as 'prefer-path2d'} from './prefer-path2d.js';
 export {default as 'prefer-private-class-fields'} from './prefer-private-class-fields.js';
+export {default as 'prefer-promise-try'} from './prefer-promise-try.js';
+export {default as 'prefer-promise-with-resolvers'} from './prefer-promise-with-resolvers.js';
 export {default as 'prefer-prototype-methods'} from './prefer-prototype-methods.js';
 export {default as 'prefer-query-selector'} from './prefer-query-selector.js';
 export {default as 'prefer-queue-microtask'} from './prefer-queue-microtask.js';
 export {default as 'prefer-reflect-apply'} from './prefer-reflect-apply.js';
+export {default as 'prefer-regexp-escape'} from './prefer-regexp-escape.js';
 export {default as 'prefer-regexp-test'} from './prefer-regexp-test.js';
 export {default as 'prefer-response-static-json'} from './prefer-response-static-json.js';
 export {default as 'prefer-scoped-selector'} from './prefer-scoped-selector.js';
 export {default as 'prefer-set-has'} from './prefer-set-has.js';
+export {default as 'prefer-set-methods'} from './prefer-set-methods.js';
 export {default as 'prefer-set-size'} from './prefer-set-size.js';
 export {default as 'prefer-short-arrow-method'} from './prefer-short-arrow-method.js';
 export {default as 'prefer-simple-condition-first'} from './prefer-simple-condition-first.js';
@@ -226,6 +270,7 @@ export {default as 'prefer-simple-sort-comparator'} from './prefer-simple-sort-c
 export {default as 'prefer-single-array-predicate'} from './prefer-single-array-predicate.js';
 export {default as 'prefer-single-call'} from './prefer-single-call.js';
 export {default as 'prefer-single-object-destructuring'} from './prefer-single-object-destructuring.js';
+export {default as 'prefer-single-replace'} from './prefer-single-replace.js';
 export {default as 'prefer-smaller-scope'} from './prefer-smaller-scope.js';
 export {default as 'prefer-split-limit'} from './prefer-split-limit.js';
 export {default as 'prefer-spread'} from './prefer-spread.js';
@@ -241,13 +286,17 @@ export {default as 'prefer-structured-clone'} from './prefer-structured-clone.js
 export {default as 'prefer-switch'} from './prefer-switch.js';
 export {default as 'prefer-temporal'} from './prefer-temporal.js';
 export {default as 'prefer-ternary'} from './prefer-ternary.js';
+export {default as 'prefer-toggle-attribute'} from './prefer-toggle-attribute.js';
 export {default as 'prefer-top-level-await'} from './prefer-top-level-await.js';
 export {default as 'prefer-type-error'} from './prefer-type-error.js';
 export {default as 'prefer-type-literal-last'} from './prefer-type-literal-last.js';
 export {default as 'prefer-uint8array-base64'} from './prefer-uint8array-base64.js';
+export {default as 'prefer-unary-minus'} from './prefer-unary-minus.js';
 export {default as 'prefer-unicode-code-point-escapes'} from './prefer-unicode-code-point-escapes.js';
+export {default as 'prefer-url-can-parse'} from './prefer-url-can-parse.js';
 export {default as 'prefer-url-href'} from './prefer-url-href.js';
-export {default as 'prevent-abbreviations'} from './prevent-abbreviations.js';
+export {default as 'prefer-url-search-parameters'} from './prefer-url-search-parameters.js';
+export {default as 'prefer-while-loop-condition'} from './prefer-while-loop-condition.js';
 export {default as 'relative-url-style'} from './relative-url-style.js';
 export {default as 'require-array-join-separator'} from './require-array-join-separator.js';
 export {default as 'require-array-sort-compare'} from './require-array-sort-compare.js';

package/rules/logical-assignment-operators.js

@@ -3,12 +3,19 @@ import {getBuiltinRule} from './utils/index.js';
 const baseRule = getBuiltinRule('logical-assignment-operators');
 
 const MESSAGE_ID_IF = 'if';
+const MESSAGE_ID_IF_NULLISH = 'ifNullish';
 const MESSAGE_ID_CONVERT_IF = 'convertIf';
 const LOGICAL_OR_ASSIGNMENT_OPERATOR = '||=';
 const LOGICAL_OR_OPERATOR = '||';
 const NULLISH_COALESCING_ASSIGNMENT_OPERATOR = '??=';
 const NULLISH_COALESCING_OPERATOR = '??';
 
+const messages = {
+	...baseRule.meta.messages,
+	// A falsy `if` assignment is offered as both `||=` and `??=`, so name both operators. The phrasing matches the base rule's `if` message, which renders the operator without backticks.
+	[MESSAGE_ID_IF_NULLISH]: '\'if\' statement can be replaced with a logical operator assignment with operator ||= or ??=.',
+};
+
 const getFix = problem => problem.fix ?? problem.suggest?.[0]?.fix;
 
 const shouldAddNullishSuggestion = problem =>
@@ -46,14 +53,20 @@ function getProblem(problem, sourceCode) {
 		return problem;
 	}
 
+	// Both `||=` and `??=` apply here, so the message names both operators.
+	const problemWithMessage = {
+		...withoutFixes(problem),
+		messageId: MESSAGE_ID_IF_NULLISH,
+	};
+
 	if (sourceCode.getCommentsInside(problem.node).length > 0) {
-		return withoutFixes(problem);
+		return problemWithMessage;
 	}
 
 	const fix = getFix(problem);
 
 	return {
-		...withoutFixes(problem),
+		...problemWithMessage,
 		suggest: [
 			{
 				messageId: MESSAGE_ID_CONVERT_IF,
@@ -100,9 +113,9 @@ const config = {
 		hasSuggestions: baseRule.meta.hasSuggestions,
 		schema: baseRule.meta.schema,
 		defaultOptions: [
-			baseRule.meta.defaultOptions[0],
+			baseRule.meta.defaultOptions?.[0],
 		],
-		messages: baseRule.meta.messages,
+		messages,
 		languages: [
 			'js/js',
 		],

package/rules/{prevent-abbreviations.js → name-replacements.js}

@@ -10,7 +10,7 @@ import {
 	lowerFirst,
 	isVirtualFilename,
 } from './utils/index.js';
-import {defaultReplacements, defaultAllowList, defaultIgnore} from './shared/abbreviations.js';
+import {defaultReplacements, defaultAllowList, defaultIgnore} from './shared/name-replacements.js';
 import {
 	isClassVariable,
 	shouldCheckDefaultOrNamespaceImportName,
@@ -465,13 +465,15 @@ const create = context => {
 			return;
 		}
 
-		const identifierReplacements = getNameReplacements(node.name, options);
-
-		if (identifierReplacements.total === 0) {
+		// The cheap AST check filters out non-property identifiers before the more
+		// expensive name analysis in `getNameReplacements`.
+		if (!shouldReportIdentifierAsProperty(node)) {
 			return;
 		}
 
-		if (!shouldReportIdentifierAsProperty(node)) {
+		const identifierReplacements = getNameReplacements(node.name, options);
+
+		if (identifierReplacements.total === 0) {
 			return;
 		}
 
@@ -573,8 +575,8 @@ const schema = {
 					description: 'Whether to extend the default replacements.',
 				},
 				replacements: {
-					$ref: '#/definitions/abbreviations',
-					description: 'Custom abbreviation replacements.',
+					$ref: '#/definitions/nameReplacements',
+					description: 'Custom name replacements.',
 				},
 				extendDefaultAllowList: {
 					type: 'boolean',
@@ -593,7 +595,7 @@ const schema = {
 		},
 	],
 	definitions: {
-		abbreviations: {
+		nameReplacements: {
 			type: 'object',
 			additionalProperties: {
 				$ref: '#/definitions/replacements',
@@ -626,7 +628,7 @@ const config = {
 	meta: {
 		type: 'suggestion',
 		docs: {
-			description: 'Prevent abbreviations.',
+			description: 'Enforce replacements for variable, property, and filenames.',
 			recommended: true,
 		},
 		fixable: 'code',

package/rules/new-for-builtins.js

@@ -1,5 +1,6 @@
 import {GlobalReferenceTracker} from './utils/global-reference-tracker.js';
 import * as builtins from './utils/builtins.js';
+import {hasOptionalChainElement} from './utils/index.js';
 import {
 	switchCallExpressionToNewExpression,
 	switchNewExpressionToCallExpression,
@@ -12,13 +13,23 @@ const MESSAGE_ID_SUGGESTION_DATE = 'suggestion-date';
 const messages = {
 	enforce: 'Use `new {{name}}()` instead of `{{name}}()`.',
 	disallow: 'Use `{{name}}()` instead of `new {{name}}()`.',
+	disallowCallOrNew: '`{{name}}` is not a function or constructor.',
 	[MESSAGE_ID_ERROR_DATE]: 'Use `String(new Date())` instead of `Date()`.',
 	[MESSAGE_ID_SUGGESTION_DATE]: 'Switch to `String(new Date())`.',
 };
 
+const getName = reference => reference.path.join('.');
+const hasOptionalChain = node => node.optional || hasOptionalChainElement(node.callee);
+
 function enforceNewExpression(reference, context) {
-	const {node, path} = reference;
-	const [name] = path;
+	const {node} = reference;
+
+	// An optional chain (`Array?.()` or `Intl?.DateTimeFormat()`) can't be rewritten to a `new` expression, which can't be optional.
+	if (hasOptionalChain(node)) {
+		return;
+	}
+
+	const name = getName(reference);
 
 	if (name === 'Object') {
 		const {parent} = node;
@@ -65,8 +76,8 @@ function enforceNewExpression(reference, context) {
 }
 
 function enforceCallExpression(reference, context) {
-	const {node, path} = reference;
-	const [name] = path;
+	const {node} = reference;
+	const name = getName(reference);
 
 	const problem = {
 		node,
@@ -81,6 +92,17 @@ function enforceCallExpression(reference, context) {
 	return problem;
 }
 
+function disallowCallOrNewExpression(reference) {
+	const {node} = reference;
+	const name = getName(reference);
+
+	return {
+		node,
+		messageId: 'disallowCallOrNew',
+		data: {name},
+	};
+}
+
 const newExpressionTracker = new GlobalReferenceTracker({
 	objects: builtins.disallowNew,
 	type: GlobalReferenceTracker.CONSTRUCT,
@@ -91,11 +113,23 @@ const callExpressionTracker = new GlobalReferenceTracker({
 	type: GlobalReferenceTracker.CALL,
 	handle: enforceNewExpression,
 });
+const callExpressionDisallowTracker = new GlobalReferenceTracker({
+	objects: builtins.disallowCallOrNew,
+	type: GlobalReferenceTracker.CALL,
+	handle: disallowCallOrNewExpression,
+});
+const newExpressionDisallowTracker = new GlobalReferenceTracker({
+	objects: builtins.disallowCallOrNew,
+	type: GlobalReferenceTracker.CONSTRUCT,
+	handle: disallowCallOrNewExpression,
+});
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
 	newExpressionTracker.listen({context});
 	callExpressionTracker.listen({context});
+	callExpressionDisallowTracker.listen({context});
+	newExpressionDisallowTracker.listen({context});
 };
 
 /** @type {import('eslint').Rule.RuleModule} */
@@ -104,7 +138,7 @@ const config = {
 	meta: {
 		type: 'suggestion',
 		docs: {
-			description: 'Enforce the use of `new` for all builtins, except `String`, `Number`, `Boolean`, `Symbol` and `BigInt`.',
+			description: 'Enforce correct use of `new` for builtin constructors.',
 			recommended: 'unopinionated',
 		},
 		fixable: 'code',

package/rules/no-accessor-recursion.js

@@ -101,6 +101,13 @@ const isPropertyWrite = (thisExpression, property) => {
 		|| (parent.type === 'UpdateExpression' && parent.argument === memberExpression)
 		// `[this.foo] = …`
 		|| (parent.type === 'ArrayPattern' && parent.elements.includes(memberExpression))
+		// `[...this.foo] = …`
+		|| (parent.type === 'RestElement' && parent.argument === memberExpression)
+		// `for (this.foo of …) {}` / `for (this.foo in …) {}`
+		|| (
+			(parent.type === 'ForOfStatement' || parent.type === 'ForInStatement')
+			&& parent.left === memberExpression
+		)
 		// `({property: this.foo} = …)`
 		|| (
 			parent.type === 'Property'

package/rules/no-accidental-bitwise-operator.js

@@ -0,0 +1,97 @@
+import {isStringLiteral, isBooleanLiteral, isFunction} from './ast/index.js';
+
+/**
+@import {TSESTree as ESTree} from '@typescript-eslint/types';
+@import * as ESLint from 'eslint';
+*/
+
+const MESSAGE_ID_ERROR = 'no-accidental-bitwise-operator/error';
+const MESSAGE_ID_SUGGESTION = 'no-accidental-bitwise-operator/suggestion';
+const messages = {
+	[MESSAGE_ID_ERROR]: 'Unexpected bitwise operator `{{bitwiseOperator}}`. Did you mean the logical operator `{{logicalOperator}}`?',
+	[MESSAGE_ID_SUGGESTION]: 'Replace `{{bitwiseOperator}}` with `{{logicalOperator}}`.',
+};
+
+const logicalOperators = new Map([
+	['&', '&&'],
+	['|', '||'],
+	['|=', '||='],
+]);
+
+// Value forms that make no sense as a bitwise operand, so the operator is almost
+// certainly a mistyped logical operator. Intentionally excludes `null`, numeric
+// literals, identifiers, and arithmetic expressions, which may be valid numbers.
+const isDefinitelyNonNumeric = node =>
+	node.type === 'ObjectExpression'
+	|| node.type === 'ArrayExpression'
+	|| node.type === 'ClassExpression'
+	|| node.type === 'TemplateLiteral'
+	|| isFunction(node)
+	|| isStringLiteral(node)
+	|| isBooleanLiteral(node);
+
+// `obj & obj.prop` is a mistyped short-circuit guard (`obj && obj.prop`).
+const isShortCircuitGuard = node =>
+	node.operator === '&'
+	&& node.left.type === 'Identifier'
+	&& node.right.type === 'MemberExpression'
+	&& node.right.object.type === 'Identifier'
+	&& node.right.object.name === node.left.name;
+
+// Either a mistyped short-circuit guard (`&`) or a mistyped logical fallback
+// (`options | {}`, `input |= ''`), where the operator was almost certainly meant
+// to be the logical counterpart.
+const isSuspiciousBitwise = node =>
+	isShortCircuitGuard(node)
+	|| ((node.operator === '|' || node.operator === '|=') && isDefinitelyNonNumeric(node.right));
+
+/** @param {ESLint.Rule.RuleContext} context */
+const create = context => {
+	const {sourceCode} = context;
+
+	context.on(['BinaryExpression', 'AssignmentExpression'], node => {
+		if (!isSuspiciousBitwise(node)) {
+			return;
+		}
+
+		const {operator} = node;
+		const logicalOperator = logicalOperators.get(operator);
+		const operatorToken = sourceCode.getTokenAfter(
+			node.left,
+			token => token.type === 'Punctuator' && token.value === operator,
+		);
+
+		return {
+			node: operatorToken,
+			messageId: MESSAGE_ID_ERROR,
+			data: {bitwiseOperator: operator, logicalOperator},
+			suggest: [
+				{
+					messageId: MESSAGE_ID_SUGGESTION,
+					data: {bitwiseOperator: operator, logicalOperator},
+					/** @param {ESLint.Rule.RuleFixer} fixer */
+					fix: fixer => fixer.replaceText(operatorToken, logicalOperator),
+				},
+			],
+		};
+	});
+};
+
+/** @type {ESLint.Rule.RuleModule} */
+const config = {
+	create,
+	meta: {
+		type: 'problem',
+		docs: {
+			description: 'Disallow bitwise operators where a logical operator was likely intended.',
+			recommended: 'unopinionated',
+		},
+		hasSuggestions: true,
+		messages,
+		languages: [
+			'js/js',
+		],
+	},
+};
+
+export default config;

package/rules/no-array-callback-reference.js

@@ -151,13 +151,7 @@ const iteratorMethods = new Map([
 
 		return shouldIgnoreCallExpression?.(callExpression) ?? false;
 	},
-	shouldIgnoreCallback(callback) {
-		if (callback.type === 'Identifier' && ignore.includes(callback.name)) {
-			return true;
-		}
-
-		return false;
-	},
+	shouldIgnoreCallback: callback => Boolean(callback.type === 'Identifier' && ignore.includes(callback.name)),
 }]));
 
 const defaultIgnoredCallees = [

package/rules/no-array-concat-in-loop.js

@@ -0,0 +1,45 @@
+import {getArrayConcatInLoop} from './shared/array-concat-in-loop.js';
+
+/**
+@import * as ESLint from 'eslint';
+*/
+
+const MESSAGE_ID = 'no-array-concat-in-loop';
+const messages = {
+	[MESSAGE_ID]: 'Do not use `Array#concat()` to accumulate an array in a loop.',
+};
+
+/** @param {ESLint.Rule.RuleContext} context */
+const create = context => {
+	context.on('AssignmentExpression', node => {
+		const problem = getArrayConcatInLoop(node, context);
+
+		if (!problem) {
+			return;
+		}
+
+		return {
+			node: problem.property,
+			messageId: MESSAGE_ID,
+		};
+	});
+};
+
+/** @type {ESLint.Rule.RuleModule} */
+const config = {
+	create,
+	meta: {
+		type: 'suggestion',
+		docs: {
+			description: 'Disallow array accumulation with `Array#concat()` in loops.',
+			recommended: true,
+		},
+		schema: [],
+		messages,
+		languages: [
+			'js/js',
+		],
+	},
+};
+
+export default config;