eslint-plugin-unicorn 59.0.0 → 60.0.0

package/index.js

@@ -1,8 +1,11 @@
 import createDeprecatedRules from './rules/utils/create-deprecated-rules.js';
 import flatConfigBase from './configs/flat-config-base.js';
-import rules from './rules/index.js';
+import * as rawRules from './rules/index.js';
+import {createRules} from './rules/utils/rule.js';
 import packageJson from './package.json' with {type: 'json'};
 
+const rules = createRules(rawRules);
+
 const deprecatedRules = createDeprecatedRules({
 	// {ruleId: {message: string, replacedBy: string[]}}
 	'no-instanceof-array': {
@@ -58,7 +61,7 @@ const unicorn = {
 		version: packageJson.version,
 	},
 	rules: {
-		...rules,
+		...createRules(rules),
 		...deprecatedRules,
 	},
 };

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "eslint-plugin-unicorn",
-	"version": "59.0.0",
+	"version": "60.0.0",
 	"description": "More than 100 powerful ESLint rules",
 	"license": "MIT",
 	"repository": "sindresorhus/eslint-plugin-unicorn",
@@ -17,19 +17,18 @@
 	},
 	"sideEffects": false,
 	"engines": {
-		"node": "^18.20.0 || ^20.10.0 || >=21.0.0"
+		"node": "^20.10.0 || >=21.0.0"
 	},
 	"scripts": {
-		"bundle-lodash": "echo export {defaultsDeep, camelCase, kebabCase, snakeCase, upperFirst, lowerFirst} from 'lodash-es'; | npx esbuild --bundle --outfile=rules/utils/lodash.js --format=esm",
 		"create-rule": "node ./scripts/create-rule.js && npm run create-rules-index-file && npm run fix:eslint-docs",
 		"create-rules-index-file": "node ./scripts/create-rules-index-file.js",
-		"fix": "run-p --continue-on-error fix:*",
-		"fix:eslint-docs": "eslint-doc-generator workaround-for-eslint-doc-generator",
+		"fix": "run-p --continue-on-error \"fix:*\"",
+		"fix:eslint-docs": "eslint-doc-generator",
 		"fix:js": "npm run lint:js -- --fix",
 		"fix:markdown": "npm run lint:markdown -- --fix",
 		"fix:snapshots": "ava --update-snapshots",
 		"integration": "node ./test/integration/test.js",
-		"lint": "run-p --continue-on-error lint:*",
+		"lint": "run-p --continue-on-error \"lint:*\"",
 		"lint:eslint-docs": "npm run fix:eslint-docs -- --check",
 		"lint:js": "eslint",
 		"lint:markdown": "markdownlint \"**/*.md\"",
@@ -37,7 +36,7 @@
 		"rename-rule": "node ./scripts/rename-rule.js && npm run create-rules-index-file && npm run fix:eslint-docs",
 		"run-rules-on-codebase": "eslint --config=./eslint.dogfooding.config.js",
 		"smoke": "eslint-remote-tester --config ./test/smoke/eslint-remote-tester.config.js",
-		"test": "npm-run-all --continue-on-error lint test:*",
+		"test": "npm-run-all --continue-on-error lint \"test:*\"",
 		"test:js": "c8 ava"
 	},
 	"files": [
@@ -57,60 +56,60 @@
 		"xo"
 	],
 	"dependencies": {
-		"@babel/helper-validator-identifier": "^7.25.9",
-		"@eslint-community/eslint-utils": "^4.5.1",
-		"@eslint/plugin-kit": "^0.2.7",
-		"ci-info": "^4.2.0",
+		"@babel/helper-validator-identifier": "^7.27.1",
+		"@eslint-community/eslint-utils": "^4.7.0",
+		"@eslint/plugin-kit": "^0.3.3",
+		"change-case": "^5.4.4",
+		"ci-info": "^4.3.0",
 		"clean-regexp": "^1.0.0",
-		"core-js-compat": "^3.41.0",
+		"core-js-compat": "^3.44.0",
 		"esquery": "^1.6.0",
 		"find-up-simple": "^1.0.1",
-		"globals": "^16.0.0",
+		"globals": "^16.3.0",
 		"indent-string": "^5.0.0",
 		"is-builtin-module": "^5.0.0",
 		"jsesc": "^3.1.0",
 		"pluralize": "^8.0.0",
 		"regexp-tree": "^0.1.27",
 		"regjsparser": "^0.12.0",
-		"semver": "^7.7.1",
+		"semver": "^7.7.2",
 		"strip-indent": "^4.0.0"
 	},
 	"devDependencies": {
-		"@babel/code-frame": "^7.26.2",
-		"@babel/core": "^7.26.10",
-		"@babel/eslint-parser": "^7.26.10",
-		"@eslint/eslintrc": "^3.3.0",
+		"@babel/code-frame": "^7.27.1",
+		"@babel/core": "^7.28.0",
+		"@babel/eslint-parser": "^7.28.0",
+		"@eslint/eslintrc": "^3.3.1",
 		"@lubien/fixture-beta-package": "^1.0.0-beta.1",
-		"@typescript-eslint/parser": "^8.26.1",
-		"ava": "^6.2.0",
+		"@typescript-eslint/parser": "^8.37.0",
+		"ava": "^6.4.1",
 		"c8": "^10.1.3",
 		"enquirer": "^2.4.1",
-		"eslint": "^9.22.0",
+		"eslint": "^9.29.0",
 		"eslint-ava-rule-tester": "^5.0.1",
-		"eslint-config-xo": "^0.46.0",
-		"eslint-doc-generator": "^2.1.2",
-		"eslint-plugin-eslint-plugin": "^6.4.0",
-		"eslint-plugin-jsdoc": "^50.6.8",
-		"eslint-remote-tester": "^4.0.1",
-		"eslint-remote-tester-repositories": "^2.0.1",
-		"espree": "^10.3.0",
-		"listr2": "^8.2.5",
+		"eslint-config-xo": "^0.47.0",
+		"eslint-doc-generator": "^2.2.2",
+		"eslint-plugin-eslint-plugin": "^6.5.0",
+		"eslint-plugin-jsdoc": "^51.4.1",
+		"eslint-remote-tester": "^4.0.2",
+		"eslint-remote-tester-repositories": "^2.0.2",
+		"espree": "^10.4.0",
+		"listr2": "^9.0.1",
 		"lodash-es": "^4.17.21",
-		"markdownlint-cli": "^0.44.0",
-		"memoize": "^10.1.0",
-		"nano-spawn": "^0.2.0",
-		"node-style-text": "^0.0.7",
-		"npm-package-json-lint": "^8.0.0",
-		"npm-run-all2": "^7.0.2",
+		"markdownlint-cli": "^0.45.0",
+		"nano-spawn": "^1.0.2",
+		"node-style-text": "^1.0.0",
+		"npm-package-json-lint": "^9.0.0",
+		"npm-run-all2": "^8.0.4",
 		"open-editor": "^5.1.0",
 		"outdent": "^0.8.0",
 		"pretty-ms": "^9.2.0",
-		"typescript": "^5.8.2",
-		"vue-eslint-parser": "^10.1.1",
-		"yaml": "^2.7.0"
+		"typescript": "^5.8.3",
+		"vue-eslint-parser": "^10.2.0",
+		"yaml": "^2.8.0"
 	},
 	"peerDependencies": {
-		"eslint": ">=9.22.0"
+		"eslint": ">=9.29.0"
 	},
 	"ava": {
 		"files": [

package/readme.md

@@ -60,7 +60,7 @@ export default [
 | [catch-error-name](docs/rules/catch-error-name.md)                                               | Enforce a specific parameter name in catch clauses.                                                                                                                                                               | ✅  | 🔧 |    |
 | [consistent-assert](docs/rules/consistent-assert.md)                                             | Enforce consistent assertion style with `node:assert`.                                                                                                                                                            | ✅  | 🔧 |    |
 | [consistent-date-clone](docs/rules/consistent-date-clone.md)                                     | Prefer passing `Date` directly to the constructor when cloning.                                                                                                                                                   | ✅  | 🔧 |    |
-| [consistent-destructuring](docs/rules/consistent-destructuring.md)                               | Use destructured variables over properties.                                                                                                                                                                       |    | 🔧 | 💡 |
+| [consistent-destructuring](docs/rules/consistent-destructuring.md)                               | Use destructured variables over properties.                                                                                                                                                                       |    |    | 💡 |
 | [consistent-empty-array-spread](docs/rules/consistent-empty-array-spread.md)                     | Prefer consistent types when spreading a ternary in an array literal.                                                                                                                                             | ✅  | 🔧 |    |
 | [consistent-existence-index-check](docs/rules/consistent-existence-index-check.md)               | Enforce consistent style for element existence checks with `indexOf()`, `lastIndexOf()`, `findIndex()`, and `findLastIndex()`.                                                                                    | ✅  | 🔧 |    |
 | [consistent-function-scoping](docs/rules/consistent-function-scoping.md)                         | Move function definitions to the highest possible scope.                                                                                                                                                          | ✅  |    |    |
@@ -80,6 +80,7 @@ export default [
 | [no-array-for-each](docs/rules/no-array-for-each.md)                                             | Prefer `for…of` over the `forEach` method.                                                                                                                                                                        | ✅  | 🔧 | 💡 |
 | [no-array-method-this-argument](docs/rules/no-array-method-this-argument.md)                     | Disallow using the `this` argument in array methods.                                                                                                                                                              | ✅  | 🔧 | 💡 |
 | [no-array-reduce](docs/rules/no-array-reduce.md)                                                 | Disallow `Array#reduce()` and `Array#reduceRight()`.                                                                                                                                                              | ✅  |    |    |
+| [no-array-reverse](docs/rules/no-array-reverse.md)                                               | Prefer `Array#toReversed()` over `Array#reverse()`.                                                                                                                                                               | ✅  |    | 💡 |
 | [no-await-expression-member](docs/rules/no-await-expression-member.md)                           | Disallow member access from await expression.                                                                                                                                                                     | ✅  | 🔧 |    |
 | [no-await-in-promise-methods](docs/rules/no-await-in-promise-methods.md)                         | Disallow using `await` in `Promise` method parameters.                                                                                                                                                            | ✅  |    | 💡 |
 | [no-console-spaces](docs/rules/no-console-spaces.md)                                             | Do not use leading/trailing space between `console.log` parameters.                                                                                                                                               | ✅  | 🔧 |    |
@@ -115,6 +116,7 @@ export default [
 | [no-unreadable-array-destructuring](docs/rules/no-unreadable-array-destructuring.md)             | Disallow unreadable array destructuring.                                                                                                                                                                          | ✅  | 🔧 |    |
 | [no-unreadable-iife](docs/rules/no-unreadable-iife.md)                                           | Disallow unreadable IIFEs.                                                                                                                                                                                        | ✅  |    |    |
 | [no-unused-properties](docs/rules/no-unused-properties.md)                                       | Disallow unused object properties.                                                                                                                                                                                |    |    |    |
+| [no-useless-error-capture-stack-trace](docs/rules/no-useless-error-capture-stack-trace.md)       | Disallow unnecessary `Error.captureStackTrace(…)`.                                                                                                                                                                | ✅  | 🔧 |    |
 | [no-useless-fallback-in-spread](docs/rules/no-useless-fallback-in-spread.md)                     | Disallow useless fallback when spreading in object literals.                                                                                                                                                      | ✅  | 🔧 |    |
 | [no-useless-length-check](docs/rules/no-useless-length-check.md)                                 | Disallow useless array length check.                                                                                                                                                                              | ✅  | 🔧 |    |
 | [no-useless-promise-resolve-reject](docs/rules/no-useless-promise-resolve-reject.md)             | Disallow returning/yielding `Promise.resolve/reject()` in async functions or promise callbacks                                                                                                                    | ✅  | 🔧 |    |
@@ -132,9 +134,10 @@ export default [
 | [prefer-array-some](docs/rules/prefer-array-some.md)                                             | Prefer `.some(…)` over `.filter(…).length` check and `.{find,findLast,findIndex,findLastIndex}(…)`.                                                                                                               | ✅  | 🔧 | 💡 |
 | [prefer-at](docs/rules/prefer-at.md)                                                             | Prefer `.at()` method for index access and `String#charAt()`.                                                                                                                                                     | ✅  | 🔧 | 💡 |
 | [prefer-blob-reading-methods](docs/rules/prefer-blob-reading-methods.md)                         | Prefer `Blob#arrayBuffer()` over `FileReader#readAsArrayBuffer(…)` and `Blob#text()` over `FileReader#readAsText(…)`.                                                                                             | ✅  |    |    |
+| [prefer-class-fields](docs/rules/prefer-class-fields.md)                                         | Prefer class field declarations over `this` assignments in constructors.                                                                                                                                          | ✅  | 🔧 | 💡 |
 | [prefer-code-point](docs/rules/prefer-code-point.md)                                             | Prefer `String#codePointAt(…)` over `String#charCodeAt(…)` and `String.fromCodePoint(…)` over `String.fromCharCode(…)`.                                                                                           | ✅  |    | 💡 |
 | [prefer-date-now](docs/rules/prefer-date-now.md)                                                 | Prefer `Date.now()` to get the number of milliseconds since the Unix Epoch.                                                                                                                                       | ✅  | 🔧 |    |
-| [prefer-default-parameters](docs/rules/prefer-default-parameters.md)                             | Prefer default parameters over reassignment.                                                                                                                                                                      | ✅  | 🔧 | 💡 |
+| [prefer-default-parameters](docs/rules/prefer-default-parameters.md)                             | Prefer default parameters over reassignment.                                                                                                                                                                      | ✅  |    | 💡 |
 | [prefer-dom-node-append](docs/rules/prefer-dom-node-append.md)                                   | Prefer `Node#append()` over `Node#appendChild()`.                                                                                                                                                                 | ✅  | 🔧 |    |
 | [prefer-dom-node-dataset](docs/rules/prefer-dom-node-dataset.md)                                 | Prefer using `.dataset` on DOM elements over calling attribute methods.                                                                                                                                           | ✅  | 🔧 |    |
 | [prefer-dom-node-remove](docs/rules/prefer-dom-node-remove.md)                                   | Prefer `childNode.remove()` over `parentNode.removeChild(childNode)`.                                                                                                                                             | ✅  | 🔧 | 💡 |
@@ -179,6 +182,7 @@ export default [
 | [prevent-abbreviations](docs/rules/prevent-abbreviations.md)                                     | Prevent abbreviations.                                                                                                                                                                                            | ✅  | 🔧 |    |
 | [relative-url-style](docs/rules/relative-url-style.md)                                           | Enforce consistent relative URL style.                                                                                                                                                                            | ✅  | 🔧 | 💡 |
 | [require-array-join-separator](docs/rules/require-array-join-separator.md)                       | Enforce using the separator argument with `Array#join()`.                                                                                                                                                         | ✅  | 🔧 |    |
+| [require-module-specifiers](docs/rules/require-module-specifiers.md)                             | Require non-empty specifier list in import and export statements.                                                                                                                                                 | ✅  | 🔧 | 💡 |
 | [require-number-to-fixed-digits-argument](docs/rules/require-number-to-fixed-digits-argument.md) | Enforce using the digits argument with `Number#toFixed()`.                                                                                                                                                        | ✅  | 🔧 |    |
 | [require-post-message-target-origin](docs/rules/require-post-message-target-origin.md)           | Enforce using the `targetOrigin` argument with `window.postMessage()`.                                                                                                                                            |    |    | 💡 |
 | [string-content](docs/rules/string-content.md)                                                   | Enforce better string content.                                                                                                                                                                                    |    | 🔧 | 💡 |

package/rules/ast/call-or-new-expression.js

@@ -11,6 +11,7 @@
 	} | string | string[]
 } CallOrNewExpressionCheckOptions
 */
+// eslint-disable-next-line complexity
 function create(node, options, types) {
 	if (!types.includes(node?.type)) {
 		return false;

package/rules/ast/is-member-expression.js

@@ -1,3 +1,4 @@
+/* eslint-disable complexity */
 /**
 @param {
 	{

package/rules/catch-error-name.js

@@ -1,6 +1,6 @@
 import {isRegExp} from 'node:util/types';
 import {findVariable} from '@eslint-community/eslint-utils';
-import {getAvailableVariableName} from './utils/index.js';
+import {getAvailableVariableName, upperFirst} from './utils/index.js';
 import {renameVariable} from './fix/index.js';
 import {isMethodCall} from './ast/index.js';
 
@@ -47,7 +47,7 @@ const create = context => {
 		name === expectedName
 		|| ignore.some(regexp => regexp.test(name))
 		|| name.endsWith(expectedName)
-		|| name.endsWith(expectedName.charAt(0).toUpperCase() + expectedName.slice(1));
+		|| name.endsWith(upperFirst(expectedName));
 
 	return {
 		Identifier(node) {

package/rules/consistent-destructuring.js

@@ -157,7 +157,6 @@ const config = {
 			description: 'Use destructured variables over properties.',
 			recommended: false,
 		},
-		fixable: 'code',
 		hasSuggestions: true,
 		messages: {
 			[MESSAGE_ID]: 'Use destructured variables over properties.',

package/rules/custom-error-definition.js

@@ -1,4 +1,4 @@
-import {upperFirst} from './utils/lodash.js';
+import {upperFirst} from './utils/index.js';
 
 const MESSAGE_ID_INVALID_EXPORT = 'invalidExport';
 const messages = {

package/rules/error-message.js

@@ -1,5 +1,4 @@
 import {getStaticValue} from '@eslint-community/eslint-utils';
-import isShadowed from './utils/is-shadowed.js';
 import {isCallOrNewExpression} from './ast/index.js';
 import builtinErrors from './shared/builtin-errors.js';
 
@@ -12,23 +11,28 @@ const messages = {
 	[MESSAGE_ID_NOT_STRING]: 'Error message should be a string.',
 };
 
+const messageArgumentIndexes = new Map([
+	['AggregateError', 1],
+	['SuppressedError', 2],
+]);
+
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
 	context.on(['CallExpression', 'NewExpression'], expression => {
-		if (!isCallOrNewExpression(expression, {
-			names: builtinErrors,
-			optional: false,
-		})) {
-			return;
-		}
-
-		const scope = context.sourceCode.getScope(expression);
-		if (isShadowed(scope, expression.callee)) {
+		if (!(
+			isCallOrNewExpression(expression, {
+				names: builtinErrors,
+				optional: false,
+			})
+			&& context.sourceCode.isGlobalReference(expression.callee)
+		)) {
 			return;
 		}
 
 		const constructorName = expression.callee.name;
-		const messageArgumentIndex = constructorName === 'AggregateError' ? 1 : 0;
+		const messageArgumentIndex = messageArgumentIndexes.has(constructorName)
+			? messageArgumentIndexes.get(constructorName)
+			: 0;
 		const callArguments = expression.arguments;
 
 		// If message is `SpreadElement` or there is `SpreadElement` before message
@@ -54,7 +58,7 @@ const create = context => {
 			};
 		}
 
-		const staticResult = getStaticValue(node, scope);
+		const staticResult = getStaticValue(node, context.sourceCode.getScope(node));
 
 		// We don't know the value of `message`
 		if (!staticResult) {

package/rules/expiring-todo-comments.js

@@ -317,6 +317,7 @@ const create = context => {
 	});
 	const rules = baseRule.create(fakeContext);
 
+	// eslint-disable-next-line complexity
 	function processComment(comment) {
 		if (ignoreRegexes.some(ignore => ignore.test(comment.value))) {
 			return;

package/rules/filename-case.js

@@ -4,8 +4,8 @@ import {
 	camelCase,
 	kebabCase,
 	snakeCase,
-	upperFirst,
-} from './utils/lodash.js';
+	pascalCase,
+} from 'change-case';
 import cartesianProductSamples from './utils/cartesian-product-samples.js';
 
 const MESSAGE_ID = 'filename-case';
@@ -15,35 +15,10 @@ const messages = {
 	[MESSAGE_ID_EXTENSION]: 'File extension `{{extension}}` is not in lowercase. Rename it to `{{filename}}`.',
 };
 
-const pascalCase = string => upperFirst(camelCase(string));
-const numberRegex = /\d+/;
-const PLACEHOLDER = '\uFFFF\uFFFF\uFFFF';
-const PLACEHOLDER_REGEX = new RegExp(PLACEHOLDER, 'i');
 const isIgnoredChar = char => !/^[a-z\d-_]$/i.test(char);
 const ignoredByDefault = new Set(['index.js', 'index.mjs', 'index.cjs', 'index.ts', 'index.tsx', 'index.vue']);
 const isLowerCase = string => string === string.toLowerCase();
 
-function ignoreNumbers(caseFunction) {
-	return string => {
-		const stack = [];
-		let execResult = numberRegex.exec(string);
-
-		while (execResult) {
-			stack.push(execResult[0]);
-			string = string.replace(execResult[0], PLACEHOLDER);
-			execResult = numberRegex.exec(string);
-		}
-
-		let withCase = caseFunction(string);
-
-		while (stack.length > 0) {
-			withCase = withCase.replace(PLACEHOLDER_REGEX, stack.shift());
-		}
-
-		return withCase;
-	};
-}
-
 const cases = {
 	camelCase: {
 		fn: camelCase,
@@ -172,7 +147,7 @@ const create = context => {
 		return new RegExp(item, 'u');
 	});
 	const multipleFileExtensions = options.multipleFileExtensions !== false;
-	const chosenCasesFunctions = chosenCases.map(case_ => ignoreNumbers(cases[case_].fn));
+	const chosenCasesFunctions = chosenCases.map(case_ => cases[case_].fn);
 	const filenameWithExtension = context.physicalFilename;
 
 	if (filenameWithExtension === '<input>' || filenameWithExtension === '<text>') {

package/rules/fix/replace-node-or-token-and-spaces-before.js

@@ -1,5 +1,6 @@
 import {getParentheses} from '../utils/parentheses.js';
 
+// eslint-disable-next-line max-params
 export default function * replaceNodeOrTokenAndSpacesBefore(nodeOrToken, replacement, fixer, sourceCode, tokenStore = sourceCode) {
 	const tokens = getParentheses(nodeOrToken, tokenStore);
 

package/rules/import-style.js

@@ -1,5 +1,4 @@
 import {getStringIfConstant} from '@eslint-community/eslint-utils';
-import {defaultsDeep} from './utils/lodash.js';
 import {isCallExpression} from './ast/index.js';
 
 const MESSAGE_ID = 'importStyle';
@@ -141,7 +140,10 @@ const create = context => {
 	] = context.options;
 
 	styles = extendDefaultStyles
-		? defaultsDeep({}, styles, defaultStyles)
+		? Object.fromEntries(
+			[...Object.keys(defaultStyles), ...Object.keys(styles)]
+				.map(name => [name, styles[name] === false ? {} : {...defaultStyles[name], ...styles[name]}]),
+		)
 		: styles;
 
 	styles = new Map(
@@ -153,6 +155,7 @@ const create = context => {
 
 	const {sourceCode} = context;
 
+	// eslint-disable-next-line max-params
 	const report = (node, moduleName, actualImportStyles, allowedImportStyles, isRequire = false) => {
 		if (!allowedImportStyles || allowedImportStyles.size === 0) {
 			return;