eslint-plugin-unicorn 52.0.0 → 54.0.0

package/index.js

@@ -3,8 +3,6 @@ const createDeprecatedRules = require('./rules/utils/create-deprecated-rules.js'
 const {loadRules} = require('./rules/utils/rule.js');
 const legacyConfigBase = require('./configs/legacy-config-base.js');
 const flatConfigBase = require('./configs/flat-config-base.js');
-const recommendedRules = require('./configs/recommended.js');
-const allRules = require('./configs/all.js');
 const {name, version} = require('./package.json');
 
 const deprecatedRules = createDeprecatedRules({
@@ -28,10 +26,34 @@ const deprecatedRules = createDeprecatedRules({
 	'regex-shorthand': 'unicorn/better-regex',
 });
 
-const createConfig = (rules, isLegacyConfig = false) => ({
-	...(isLegacyConfig ? legacyConfigBase : flatConfigBase),
-	plugins: isLegacyConfig ? ['unicorn'] : {unicorn},
-	rules,
+const externalRules = {
+	// Covered by `unicorn/no-negated-condition`
+	'no-negated-condition': 'off',
+	// Covered by `unicorn/no-nested-ternary`
+	'no-nested-ternary': 'off',
+};
+
+const rules = loadRules();
+const recommendedRules = Object.fromEntries(
+	Object.entries(rules).map(([id, rule]) => [
+		`unicorn/${id}`,
+		rule.meta.docs.recommended ? 'error' : 'off',
+	]),
+);
+const allRules = Object.fromEntries(
+	Object.keys(rules).map(id => [
+		`unicorn/${id}`,
+		'error',
+	]),
+);
+
+const createConfig = (rules, flatConfigName = false) => ({
+	...(
+		flatConfigName
+			? {...flatConfigBase, name: flatConfigName, plugins: {unicorn}}
+			: {...legacyConfigBase, plugins: ['unicorn']}
+	),
+	rules: {...externalRules, ...rules},
 });
 
 const unicorn = {
@@ -40,16 +62,16 @@ const unicorn = {
 		version,
 	},
 	rules: {
-		...loadRules(),
+		...rules,
 		...deprecatedRules,
 	},
 };
 
 const configs = {
-	recommended: createConfig(recommendedRules, /* isLegacyConfig */ true),
-	all: createConfig(allRules, /* isLegacyConfig */ true),
-	'flat/recommended': createConfig(recommendedRules),
-	'flat/all': createConfig(allRules),
+	recommended: createConfig(recommendedRules),
+	all: createConfig(allRules),
+	'flat/recommended': createConfig(recommendedRules, 'unicorn/flat/recommended'),
+	'flat/all': createConfig(allRules, 'unicorn/flat/all'),
 };
 
 module.exports = {...unicorn, configs};

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "eslint-plugin-unicorn",
-	"version": "52.0.0",
+	"version": "54.0.0",
 	"description": "More than 100 powerful ESLint rules",
 	"license": "MIT",
 	"repository": "sindresorhus/eslint-plugin-unicorn",
@@ -13,9 +13,10 @@
 	"main": "index.js",
 	"sideEffects": false,
 	"engines": {
-		"node": ">=16"
+		"node": ">=18.18"
 	},
 	"scripts": {
+		"bundle-lodash": "echo \"export {defaultsDeep, camelCase, kebabCase, snakeCase, upperFirst, lowerFirst} from 'lodash-es';\" | npx esbuild --bundle --outfile=rules/utils/lodash.js --format=cjs",
 		"create-rule": "node ./scripts/create-rule.mjs && npm run fix:eslint-docs",
 		"fix": "run-p --continue-on-error fix:*",
 		"fix:eslint-docs": "eslint-doc-generator",
@@ -28,8 +29,7 @@
 		"lint:markdown": "markdownlint \"**/*.md\"",
 		"lint:package-json": "npmPkgJsonLint .",
 		"run-rules-on-codebase": "node ./test/run-rules-on-codebase/lint.mjs",
-		"bundle-lodash": "echo \"export {defaultsDeep, camelCase, kebabCase, snakeCase, upperFirst, lowerFirst} from 'lodash-es';\" | npx esbuild --bundle --outfile=rules/utils/lodash.js --format=cjs",
-		"smoke": "eslint-remote-tester --config ./test/smoke/eslint-remote-tester.config.js",
+		"smoke": "eslint-remote-tester --config ./test/smoke/eslint-remote-tester.config.mjs",
 		"test": "npm-run-all --continue-on-error lint test:*",
 		"test:js": "c8 ava"
 	},
@@ -49,12 +49,12 @@
 		"xo"
 	],
 	"dependencies": {
-		"@babel/helper-validator-identifier": "^7.22.20",
+		"@babel/helper-validator-identifier": "^7.24.5",
 		"@eslint-community/eslint-utils": "^4.4.0",
-		"@eslint/eslintrc": "^2.1.4",
+		"@eslint/eslintrc": "^3.0.2",
 		"ci-info": "^4.0.0",
 		"clean-regexp": "^1.0.0",
-		"core-js-compat": "^3.34.0",
+		"core-js-compat": "^3.37.0",
 		"esquery": "^1.5.0",
 		"indent-string": "^4.0.0",
 		"is-builtin-module": "^3.2.1",
@@ -63,39 +63,40 @@
 		"read-pkg-up": "^7.0.1",
 		"regexp-tree": "^0.1.27",
 		"regjsparser": "^0.10.0",
-		"semver": "^7.5.4",
+		"semver": "^7.6.1",
 		"strip-indent": "^3.0.0"
 	},
 	"devDependencies": {
-		"@babel/code-frame": "^7.23.5",
-		"@babel/core": "^7.23.6",
-		"@babel/eslint-parser": "^7.23.3",
+		"@babel/code-frame": "^7.24.2",
+		"@babel/core": "^7.24.5",
+		"@babel/eslint-parser": "^7.24.5",
 		"@lubien/fixture-beta-package": "^1.0.0-beta.1",
-		"@typescript-eslint/parser": "^6.15.0",
-		"ava": "^6.0.1",
-		"c8": "^8.0.1",
+		"@typescript-eslint/parser": "^8.0.0-alpha.12",
+		"ava": "^6.1.3",
+		"c8": "^9.1.0",
 		"chalk": "^5.3.0",
 		"enquirer": "^2.4.1",
-		"eslint": "^8.56.0",
+		"eslint": "^9.2.0",
 		"eslint-ava-rule-tester": "^5.0.1",
-		"eslint-doc-generator": "^1.7.0",
-		"eslint-plugin-eslint-plugin": "^5.2.1",
+		"eslint-doc-generator": "1.7.0",
+		"eslint-plugin-eslint-plugin": "^6.1.0",
 		"eslint-plugin-internal-rules": "file:./scripts/internal-rules/",
-		"eslint-remote-tester": "^3.0.1",
-		"eslint-remote-tester-repositories": "^1.0.1",
+		"eslint-remote-tester": "^4.0.0",
+		"eslint-remote-tester-repositories": "^2.0.0",
+		"espree": "^10.0.1",
 		"execa": "^8.0.1",
 		"listr": "^0.14.3",
 		"lodash-es": "^4.17.21",
-		"markdownlint-cli": "^0.38.0",
+		"markdownlint-cli": "^0.40.0",
 		"memoize": "^10.0.0",
 		"npm-package-json-lint": "^7.1.0",
-		"npm-run-all2": "^6.1.1",
+		"npm-run-all2": "^6.1.2",
 		"outdent": "^0.8.0",
-		"pretty-ms": "^8.0.0",
-		"typescript": "^5.3.3",
-		"vue-eslint-parser": "^9.3.2",
-		"xo": "^0.56.0",
-		"yaml": "^2.3.4"
+		"pretty-ms": "^9.0.0",
+		"typescript": "^5.4.5",
+		"vue-eslint-parser": "^9.4.2",
+		"xo": "^0.58.0",
+		"yaml": "^2.4.2"
 	},
 	"peerDependencies": {
 		"eslint": ">=8.56.0"
@@ -123,7 +124,9 @@
 			"test/integration/{fixtures,fixtures-local}/**"
 		],
 		"rules": {
+			"unicorn/escape-case": "off",
 			"unicorn/expiring-todo-comments": "off",
+			"unicorn/no-hex-escape": "off",
 			"unicorn/no-null": "error",
 			"unicorn/prefer-array-flat": [
 				"error",
@@ -173,17 +176,5 @@
 				}
 			}
 		]
-	},
-	"npmpackagejsonlint": {
-		"rules": {
-			"prefer-caret-version-devDependencies": [
-				"error",
-				{
-					"exceptions": [
-						"eslint-plugin-internal-rules"
-					]
-				}
-			]
-		}
 	}
 }

package/readme.md

@@ -17,7 +17,7 @@ npm install --save-dev eslint eslint-plugin-unicorn
 
 ## Usage (`eslint.config.js`)
 
-**Requires ESLint `>=8.23.0`.**
+**Requires ESLint `>=8.56.0`.**
 
 Use a [preset config](#preset-configs-eslintconfigjs) or configure each rule in `eslint.config.js`.
 
@@ -103,8 +103,8 @@ If you don't use the preset, ensure you use the same `env` and `parserOptions` c
 <!-- Do not manually modify this list. Run: `npm run fix:eslint-docs` -->
 <!-- begin auto-generated rules list -->
 
-💼 [Configurations](https://github.com/sindresorhus/eslint-plugin-unicorn#preset-configs) enabled in.\
-✅ Set in the `recommended` [configuration](https://github.com/sindresorhus/eslint-plugin-unicorn#preset-configs).\
+💼 [Configurations](https://github.com/sindresorhus/eslint-plugin-unicorn#preset-configs-eslintconfigjs) enabled in.\
+✅ Set in the `recommended` [configuration](https://github.com/sindresorhus/eslint-plugin-unicorn#preset-configs-eslintconfigjs).\
 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).\
 💡 Manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
 
@@ -113,6 +113,7 @@ If you don't use the preset, ensure you use the same `env` and `parserOptions` c
 | [better-regex](docs/rules/better-regex.md)                                                       | Improve regexes by making them shorter, consistent, and safer.                                                                                                                                                    | ✅  | 🔧 |    |
 | [catch-error-name](docs/rules/catch-error-name.md)                                               | Enforce a specific parameter name in catch clauses.                                                                                                                                                               | ✅  | 🔧 |    |
 | [consistent-destructuring](docs/rules/consistent-destructuring.md)                               | Use destructured variables over properties.                                                                                                                                                                       |    | 🔧 | 💡 |
+| [consistent-empty-array-spread](docs/rules/consistent-empty-array-spread.md)                     | Prefer consistent types when spreading a ternary in an array literal.                                                                                                                                             | ✅  | 🔧 |    |
 | [consistent-function-scoping](docs/rules/consistent-function-scoping.md)                         | Move function definitions to the highest possible scope.                                                                                                                                                          | ✅  |    |    |
 | [custom-error-definition](docs/rules/custom-error-definition.md)                                 | Enforce correct `Error` subclassing.                                                                                                                                                                              |    | 🔧 |    |
 | [empty-brace-spaces](docs/rules/empty-brace-spaces.md)                                           | Enforce no spaces between braces.                                                                                                                                                                                 | ✅  | 🔧 |    |
@@ -138,10 +139,13 @@ If you don't use the preset, ensure you use the same `env` and `parserOptions` c
 | [no-for-loop](docs/rules/no-for-loop.md)                                                         | Do not use a `for` loop that can be replaced with a `for-of` loop.                                                                                                                                                | ✅  | 🔧 | 💡 |
 | [no-hex-escape](docs/rules/no-hex-escape.md)                                                     | Enforce the use of Unicode escapes instead of hexadecimal escapes.                                                                                                                                                | ✅  | 🔧 |    |
 | [no-instanceof-array](docs/rules/no-instanceof-array.md)                                         | Require `Array.isArray()` instead of `instanceof Array`.                                                                                                                                                          | ✅  | 🔧 |    |
+| [no-invalid-fetch-options](docs/rules/no-invalid-fetch-options.md)                               | Disallow invalid options in `fetch()` and `new Request()`.                                                                                                                                                        | ✅  |    |    |
 | [no-invalid-remove-event-listener](docs/rules/no-invalid-remove-event-listener.md)               | Prevent calling `EventTarget#removeEventListener()` with the result of an expression.                                                                                                                             | ✅  |    |    |
 | [no-keyword-prefix](docs/rules/no-keyword-prefix.md)                                             | Disallow identifiers starting with `new` or `class`.                                                                                                                                                              |    |    |    |
 | [no-lonely-if](docs/rules/no-lonely-if.md)                                                       | Disallow `if` statements as the only statement in `if` blocks without `else`.                                                                                                                                     | ✅  | 🔧 |    |
+| [no-magic-array-flat-depth](docs/rules/no-magic-array-flat-depth.md)                             | Disallow a magic number as the `depth` argument in `Array#flat(…).`                                                                                                                                               | ✅  |    |    |
 | [no-negated-condition](docs/rules/no-negated-condition.md)                                       | Disallow negated conditions.                                                                                                                                                                                      | ✅  | 🔧 |    |
+| [no-negation-in-equality-check](docs/rules/no-negation-in-equality-check.md)                     | Disallow negated expression in equality check.                                                                                                                                                                    | ✅  |    | 💡 |
 | [no-nested-ternary](docs/rules/no-nested-ternary.md)                                             | Disallow nested ternary expressions.                                                                                                                                                                              | ✅  | 🔧 |    |
 | [no-new-array](docs/rules/no-new-array.md)                                                       | Disallow `new Array()`.                                                                                                                                                                                           | ✅  | 🔧 | 💡 |
 | [no-new-buffer](docs/rules/no-new-buffer.md)                                                     | Enforce the use of `Buffer.from()` and `Buffer.alloc()` instead of the deprecated `new Buffer()`.                                                                                                                 | ✅  | 🔧 | 💡 |
@@ -172,7 +176,7 @@ If you don't use the preset, ensure you use the same `env` and `parserOptions` c
 | [prefer-array-flat](docs/rules/prefer-array-flat.md)                                             | Prefer `Array#flat()` over legacy techniques to flatten arrays.                                                                                                                                                   | ✅  | 🔧 |    |
 | [prefer-array-flat-map](docs/rules/prefer-array-flat-map.md)                                     | Prefer `.flatMap(…)` over `.map(…).flat()`.                                                                                                                                                                       | ✅  | 🔧 |    |
 | [prefer-array-index-of](docs/rules/prefer-array-index-of.md)                                     | Prefer `Array#{indexOf,lastIndexOf}()` over `Array#{findIndex,findLastIndex}()` when looking for the index of an item.                                                                                            | ✅  | 🔧 | 💡 |
-| [prefer-array-some](docs/rules/prefer-array-some.md)                                             | Prefer `.some(…)` over `.filter(…).length` check and `.{find,findLast}(…)`.                                                                                                                                       | ✅  | 🔧 | 💡 |
+| [prefer-array-some](docs/rules/prefer-array-some.md)                                             | Prefer `.some(…)` over `.filter(…).length` check and `.{find,findLast,findIndex,findLastIndex}(…)`.                                                                                                               | ✅  | 🔧 | 💡 |
 | [prefer-at](docs/rules/prefer-at.md)                                                             | Prefer `.at()` method for index access and `String#charAt()`.                                                                                                                                                     | ✅  | 🔧 | 💡 |
 | [prefer-blob-reading-methods](docs/rules/prefer-blob-reading-methods.md)                         | Prefer `Blob#arrayBuffer()` over `FileReader#readAsArrayBuffer(…)` and `Blob#text()` over `FileReader#readAsText(…)`.                                                                                             | ✅  |    |    |
 | [prefer-code-point](docs/rules/prefer-code-point.md)                                             | Prefer `String#codePointAt(…)` over `String#charCodeAt(…)` and `String.fromCodePoint(…)` over `String.fromCharCode(…)`.                                                                                           | ✅  |    | 💡 |
@@ -184,7 +188,7 @@ If you don't use the preset, ensure you use the same `env` and `parserOptions` c
 | [prefer-dom-node-text-content](docs/rules/prefer-dom-node-text-content.md)                       | Prefer `.textContent` over `.innerText`.                                                                                                                                                                          | ✅  |    | 💡 |
 | [prefer-event-target](docs/rules/prefer-event-target.md)                                         | Prefer `EventTarget` over `EventEmitter`.                                                                                                                                                                         | ✅  |    |    |
 | [prefer-export-from](docs/rules/prefer-export-from.md)                                           | Prefer `export…from` when re-exporting.                                                                                                                                                                           | ✅  | 🔧 | 💡 |
-| [prefer-includes](docs/rules/prefer-includes.md)                                                 | Prefer `.includes()` over `.indexOf()` and `Array#some()` when checking for existence or non-existence.                                                                                                           | ✅  | 🔧 | 💡 |
+| [prefer-includes](docs/rules/prefer-includes.md)                                                 | Prefer `.includes()` over `.indexOf()`, `.lastIndexOf()`, and `Array#some()` when checking for existence or non-existence.                                                                                        | ✅  | 🔧 | 💡 |
 | [prefer-json-parse-buffer](docs/rules/prefer-json-parse-buffer.md)                               | Prefer reading a JSON file as a buffer.                                                                                                                                                                           |    | 🔧 |    |
 | [prefer-keyboard-event-key](docs/rules/prefer-keyboard-event-key.md)                             | Prefer `KeyboardEvent#key` over `KeyboardEvent#keyCode`.                                                                                                                                                          | ✅  | 🔧 |    |
 | [prefer-logical-operator-over-ternary](docs/rules/prefer-logical-operator-over-ternary.md)       | Prefer using a logical operator over a ternary.                                                                                                                                                                   | ✅  |    | 💡 |
@@ -205,10 +209,12 @@ If you don't use the preset, ensure you use the same `env` and `parserOptions` c
 | [prefer-set-has](docs/rules/prefer-set-has.md)                                                   | Prefer `Set#has()` over `Array#includes()` when checking for existence or non-existence.                                                                                                                          | ✅  | 🔧 | 💡 |
 | [prefer-set-size](docs/rules/prefer-set-size.md)                                                 | Prefer using `Set#size` instead of `Array#length`.                                                                                                                                                                | ✅  | 🔧 |    |
 | [prefer-spread](docs/rules/prefer-spread.md)                                                     | Prefer the spread operator over `Array.from(…)`, `Array#concat(…)`, `Array#{slice,toSpliced}()` and `String#split('')`.                                                                                           | ✅  | 🔧 | 💡 |
+| [prefer-string-raw](docs/rules/prefer-string-raw.md)                                             | Prefer using the `String.raw` tag to avoid escaping `\`.                                                                                                                                                          | ✅  | 🔧 |    |
 | [prefer-string-replace-all](docs/rules/prefer-string-replace-all.md)                             | Prefer `String#replaceAll()` over regex searches with the global flag.                                                                                                                                            | ✅  | 🔧 |    |
 | [prefer-string-slice](docs/rules/prefer-string-slice.md)                                         | Prefer `String#slice()` over `String#substr()` and `String#substring()`.                                                                                                                                          | ✅  | 🔧 |    |
 | [prefer-string-starts-ends-with](docs/rules/prefer-string-starts-ends-with.md)                   | Prefer `String#startsWith()` & `String#endsWith()` over `RegExp#test()`.                                                                                                                                          | ✅  | 🔧 | 💡 |
 | [prefer-string-trim-start-end](docs/rules/prefer-string-trim-start-end.md)                       | Prefer `String#trimStart()` / `String#trimEnd()` over `String#trimLeft()` / `String#trimRight()`.                                                                                                                 | ✅  | 🔧 |    |
+| [prefer-structured-clone](docs/rules/prefer-structured-clone.md)                                 | Prefer using `structuredClone` to create a deep clone.                                                                                                                                                            | ✅  |    | 💡 |
 | [prefer-switch](docs/rules/prefer-switch.md)                                                     | Prefer `switch` over multiple `else-if`.                                                                                                                                                                          | ✅  | 🔧 |    |
 | [prefer-ternary](docs/rules/prefer-ternary.md)                                                   | Prefer ternary expressions over simple `if-else` statements.                                                                                                                                                      | ✅  | 🔧 |    |
 | [prefer-top-level-await](docs/rules/prefer-top-level-await.md)                                   | Prefer top-level await over top-level promises and async function calls.                                                                                                                                          | ✅  |    | 💡 |
@@ -222,7 +228,7 @@ If you don't use the preset, ensure you use the same `env` and `parserOptions` c
 | [switch-case-braces](docs/rules/switch-case-braces.md)                                           | Enforce consistent brace style for `case` clauses.                                                                                                                                                                | ✅  | 🔧 |    |
 | [template-indent](docs/rules/template-indent.md)                                                 | Fix whitespace-insensitive template indentation.                                                                                                                                                                  | ✅  | 🔧 |    |
 | [text-encoding-identifier-case](docs/rules/text-encoding-identifier-case.md)                     | Enforce consistent case for text encoding identifiers.                                                                                                                                                            | ✅  | 🔧 | 💡 |
-| [throw-new-error](docs/rules/throw-new-error.md)                                                 | Require `new` when throwing an error.                                                                                                                                                                             | ✅  | 🔧 |    |
+| [throw-new-error](docs/rules/throw-new-error.md)                                                 | Require `new` when creating an error.                                                                                                                                                                             | ✅  | 🔧 |    |
 
 <!-- end auto-generated rules list -->
 

package/rules/ast/index.js

@@ -25,6 +25,7 @@ module.exports = {
 	isArrowFunctionBody: require('./is-arrow-function-body.js'),
 	isCallExpression,
 	isCallOrNewExpression,
+	isDirective: require('./is-directive.js'),
 	isEmptyNode: require('./is-empty-node.js'),
 	isExpressionStatement: require('./is-expression-statement.js'),
 	isFunction: require('./is-function.js'),
@@ -33,6 +34,7 @@ module.exports = {
 	isNewExpression,
 	isReferenceIdentifier: require('./is-reference-identifier.js'),
 	isStaticRequire: require('./is-static-require.js'),
+	isTaggedTemplateLiteral: require('./is-tagged-template-literal.js'),
 	isUndefined: require('./is-undefined.js'),
 
 	functionTypes: require('./function-types.js'),

package/rules/ast/is-directive.js

@@ -0,0 +1,7 @@
+'use strict';
+
+const isDirective = node =>
+	node.type === 'ExpressionStatement'
+	&& typeof node.directive === 'string';
+
+module.exports = isDirective;

package/rules/ast/is-reference-identifier.js

@@ -120,11 +120,18 @@ function isNotReference(node) {
 			return parent.parameters.includes(node);
 		}
 
+		// `@typescript-eslint/parse` v7
 		// `type Foo = { [Identifier in keyof string]: number; };`
 		case 'TSTypeParameter': {
 			return parent.name === node;
 		}
 
+		// `@typescript-eslint/parse` v8
+		// `type Foo = { [Identifier in keyof string]: number; };`
+		case 'TSMappedType': {
+			return parent.key === node;
+		}
+
 		// `type Identifier = Foo`
 		case 'TSTypeAliasDeclaration': {
 			return parent.id === node;

package/rules/ast/is-tagged-template-literal.js

@@ -0,0 +1,28 @@
+'use strict';
+
+const {isNodeMatches} = require('../utils/is-node-matches.js');
+
+/**
+Check if the given node is a tagged template literal.
+
+@param {Node} node - The AST node to check.
+@param {string[]} tags - The object name or key paths.
+@returns {boolean}
+*/
+function isTaggedTemplateLiteral(node, tags) {
+	if (
+		node.type !== 'TemplateLiteral'
+		|| node.parent.type !== 'TaggedTemplateExpression'
+		|| node.parent.quasi !== node
+	) {
+		return false;
+	}
+
+	if (tags) {
+		return isNodeMatches(node.parent.tag, tags);
+	}
+
+	return true;
+}
+
+module.exports = isTaggedTemplateLiteral;

package/rules/better-regex.js

@@ -136,6 +136,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Improve regexes by making them shorter, consistent, and safer.',
+			recommended: true,
 		},
 		fixable: 'code',
 		schema,

package/rules/catch-error-name.js

@@ -128,6 +128,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Enforce a specific parameter name in catch clauses.',
+			recommended: true,
 		},
 		fixable: 'code',
 		schema,

package/rules/consistent-destructuring.js

@@ -157,6 +157,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Use destructured variables over properties.',
+			recommended: false,
 		},
 		fixable: 'code',
 		hasSuggestions: true,

package/rules/consistent-empty-array-spread.js

@@ -0,0 +1,126 @@
+'use strict';
+const {getStaticValue} = require('@eslint-community/eslint-utils');
+
+const MESSAGE_ID = 'consistent-empty-array-spread';
+const messages = {
+	[MESSAGE_ID]: 'Prefer using empty {{replacementDescription}} since the {{anotherNodePosition}} is {{anotherNodeDescription}}.',
+};
+
+const isEmptyArrayExpression = node =>
+	node.type === 'ArrayExpression'
+	&& node.elements.length === 0;
+
+const isEmptyStringLiteral = node =>
+	node.type === 'Literal'
+	&& node.value === '';
+
+const isString = (node, context) => {
+	const staticValueResult = getStaticValue(node, context.sourceCode.getScope(node));
+	return typeof staticValueResult?.value === 'string';
+};
+
+const isArray = (node, context) => {
+	if (node.type === 'ArrayExpression') {
+		return true;
+	}
+
+	const staticValueResult = getStaticValue(node, context.sourceCode.getScope(node));
+	return Array.isArray(staticValueResult?.value);
+};
+
+const cases = [
+	{
+		oneSidePredicate: isEmptyStringLiteral,
+		anotherSidePredicate: isArray,
+		anotherNodeDescription: 'an array',
+		replacementDescription: 'array',
+		replacementCode: '[]',
+	},
+	{
+		oneSidePredicate: isEmptyArrayExpression,
+		anotherSidePredicate: isString,
+		anotherNodeDescription: 'a string',
+		replacementDescription: 'string',
+		replacementCode: '\'\'',
+	},
+];
+
+function createProblem({
+	problemNode,
+	anotherNodePosition,
+	anotherNodeDescription,
+	replacementDescription,
+	replacementCode,
+}) {
+	return {
+		node: problemNode,
+		messageId: MESSAGE_ID,
+		data: {
+			replacementDescription,
+			anotherNodePosition,
+			anotherNodeDescription,
+		},
+		fix: fixer => fixer.replaceText(problemNode, replacementCode),
+	};
+}
+
+function getProblem(conditionalExpression, context) {
+	const {
+		consequent,
+		alternate,
+	} = conditionalExpression;
+
+	for (const problemCase of cases) {
+		const {
+			oneSidePredicate,
+			anotherSidePredicate,
+		} = problemCase;
+
+		if (oneSidePredicate(consequent, context) && anotherSidePredicate(alternate, context)) {
+			return createProblem({
+				...problemCase,
+				problemNode: consequent,
+				anotherNodePosition: 'alternate',
+			});
+		}
+
+		if (oneSidePredicate(alternate, context) && anotherSidePredicate(consequent, context)) {
+			return createProblem({
+				...problemCase,
+				problemNode: alternate,
+				anotherNodePosition: 'consequent',
+			});
+		}
+	}
+}
+
+/** @param {import('eslint').Rule.RuleContext} context */
+const create = context => ({
+	* ArrayExpression(arrayExpression) {
+		for (const element of arrayExpression.elements) {
+			if (
+				element?.type !== 'SpreadElement'
+				|| element.argument.type !== 'ConditionalExpression'
+			) {
+				continue;
+			}
+
+			yield getProblem(element.argument, context);
+		}
+	},
+});
+
+/** @type {import('eslint').Rule.RuleModule} */
+module.exports = {
+	create,
+	meta: {
+		type: 'suggestion',
+		docs: {
+			description: 'Prefer consistent types when spreading a ternary in an array literal.',
+			recommended: true,
+		},
+		fixable: 'code',
+
+		messages,
+	},
+};

package/rules/consistent-function-scoping.js

@@ -216,6 +216,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Move function definitions to the highest possible scope.',
+			recommended: true,
 		},
 		schema,
 		messages,

package/rules/custom-error-definition.js

@@ -208,6 +208,7 @@ module.exports = {
 		type: 'problem',
 		docs: {
 			description: 'Enforce correct `Error` subclassing.',
+			recommended: false,
 		},
 		fixable: 'code',
 		messages,

package/rules/empty-brace-spaces.js

@@ -65,6 +65,7 @@ module.exports = {
 		type: 'layout',
 		docs: {
 			description: 'Enforce no spaces between braces.',
+			recommended: true,
 		},
 		fixable: 'whitespace',
 		messages,

package/rules/error-message.js

@@ -98,6 +98,7 @@ module.exports = {
 		type: 'problem',
 		docs: {
 			description: 'Enforce passing a `message` value when creating a built-in error.',
+			recommended: true,
 		},
 		messages,
 	},

package/rules/escape-case.js

@@ -1,6 +1,10 @@
 'use strict';
 const {replaceTemplateElement} = require('./fix/index.js');
-const {isRegexLiteral, isStringLiteral} = require('./ast/index.js');
+const {
+	isRegexLiteral,
+	isStringLiteral,
+	isTaggedTemplateLiteral,
+} = require('./ast/index.js');
 
 const MESSAGE_ID = 'escape-case';
 const messages = {
@@ -42,11 +46,17 @@ const create = context => {
 		}
 	});
 
-	context.on('TemplateElement', node => getProblem({
-		node,
-		original: node.value.raw,
-		fix: (fixer, fixed) => replaceTemplateElement(fixer, node, fixed),
-	}));
+	context.on('TemplateElement', node => {
+		if (isTaggedTemplateLiteral(node.parent, ['String.raw'])) {
+			return;
+		}
+
+		return getProblem({
+			node,
+			original: node.value.raw,
+			fix: (fixer, fixed) => replaceTemplateElement(fixer, node, fixed),
+		});
+	});
 };
 
 /** @type {import('eslint').Rule.RuleModule} */
@@ -56,6 +66,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Require escape sequences to use uppercase values.',
+			recommended: true,
 		},
 		fixable: 'code',
 		messages,

package/rules/expiring-todo-comments.js

@@ -186,7 +186,15 @@ function getPackageHelpers(dirname) {
 		return afterArguments;
 	}
 
-	return {packageResult, hasPackage, packageJson, packageDependencies, parseArgument, parseTodoMessage, parseTodoWithArguments};
+	return {
+		packageResult,
+		hasPackage,
+		packageJson,
+		packageDependencies,
+		parseArgument,
+		parseTodoMessage,
+		parseTodoWithArguments,
+	};
 }
 
 const DEPENDENCY_INCLUSION_RE = /^[+-]\s*@?\S+\/?\S+/;
@@ -197,7 +205,7 @@ const ISO8601_DATE = /\d{4}-\d{2}-\d{2}/;
 function createArgumentGroup(arguments_) {
 	const groups = {};
 	for (const {value, type} of arguments_) {
-		groups[type] = groups[type] || [];
+		groups[type] ??= [];
 		groups[type].push(value);
 	}
 
@@ -573,6 +581,7 @@ module.exports = {
 		type: 'suggestion',
 		docs: {
 			description: 'Add expiration conditions to TODO comments.',
+			recommended: true,
 		},
 		schema,
 		messages,