eslint-plugin-unicorn 43.0.2 → 44.0.0

package/configs/recommended.js

@@ -50,6 +50,7 @@ module.exports = {
 		'unicorn/no-static-only-class': 'error',
 		'unicorn/no-thenable': 'error',
 		'unicorn/no-this-assignment': 'error',
+		'unicorn/no-unnecessary-await': 'error',
 		'unicorn/no-unreadable-array-destructuring': 'error',
 		'unicorn/no-unreadable-iife': 'error',
 		'unicorn/no-unsafe-regex': 'off',
@@ -118,6 +119,7 @@ module.exports = {
 		// See #1396
 		'unicorn/require-post-message-target-origin': 'off',
 		'unicorn/string-content': 'off',
+		'unicorn/switch-case-braces': 'error',
 		'unicorn/template-indent': 'error',
 		'unicorn/text-encoding-identifier-case': 'error',
 		'unicorn/throw-new-error': 'error',

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "eslint-plugin-unicorn",
-	"version": "43.0.2",
+	"version": "44.0.0",
 	"description": "More than 100 powerful ESLint rules",
 	"license": "MIT",
 	"repository": "sindresorhus/eslint-plugin-unicorn",
@@ -46,13 +46,13 @@
 		"xo"
 	],
 	"dependencies": {
-		"@babel/helper-validator-identifier": "^7.18.6",
-		"ci-info": "^3.3.2",
+		"@babel/helper-validator-identifier": "^7.19.1",
+		"ci-info": "^3.4.0",
 		"clean-regexp": "^1.0.0",
 		"eslint-utils": "^3.0.0",
 		"esquery": "^1.4.0",
 		"indent-string": "^4.0.0",
-		"is-builtin-module": "^3.1.0",
+		"is-builtin-module": "^3.2.0",
 		"lodash": "^4.17.21",
 		"pluralize": "^8.0.0",
 		"read-pkg-up": "^7.0.1",
@@ -63,34 +63,35 @@
 	},
 	"devDependencies": {
 		"@babel/code-frame": "^7.18.6",
-		"@babel/core": "^7.18.6",
-		"@babel/eslint-parser": "^7.18.2",
+		"@babel/core": "^7.19.1",
+		"@babel/eslint-parser": "^7.19.1",
 		"@lubien/fixture-beta-package": "^1.0.0-beta.1",
-		"@typescript-eslint/parser": "^5.30.0",
+		"@typescript-eslint/parser": "^5.37.0",
 		"ava": "^3.15.0",
-		"c8": "^7.11.3",
+		"c8": "^7.12.0",
 		"chalk": "^5.0.1",
 		"enquirer": "^2.3.6",
-		"eslint": "^8.18.0",
+		"eslint": "^8.23.1",
 		"eslint-ava-rule-tester": "^4.0.0",
-		"eslint-plugin-eslint-plugin": "^5.0.0",
+		"eslint-plugin-eslint-plugin": "^5.0.6",
 		"eslint-plugin-internal-rules": "file:./scripts/internal-rules/",
 		"eslint-remote-tester": "^3.0.0",
 		"eslint-remote-tester-repositories": "^0.0.6",
 		"execa": "^6.1.0",
 		"listr": "^0.14.3",
 		"lodash-es": "^4.17.21",
-		"markdownlint-cli": "^0.31.1",
+		"markdownlint-cli": "^0.32.2",
 		"mem": "^9.0.2",
 		"npm-package-json-lint": "^6.3.0",
 		"npm-run-all": "^4.1.5",
 		"outdent": "^0.8.0",
-		"typescript": "^4.7.4",
-		"vue-eslint-parser": "^9.0.3",
-		"xo": "^0.50.0"
+		"typescript": "^4.8.3",
+		"vue-eslint-parser": "^9.1.0",
+		"xo": "^0.52.3",
+		"yaml": "^1.10.2"
 	},
 	"peerDependencies": {
-		"eslint": ">=8.18.0"
+		"eslint": ">=8.23.1"
 	},
 	"ava": {
 		"files": [

package/readme.md

@@ -91,6 +91,7 @@ Each rule has emojis denoting:
 | [no-static-only-class](docs/rules/no-static-only-class.md) | Disallow classes that only have static members. | ✅ | 🔧 |  |
 | [no-thenable](docs/rules/no-thenable.md) | Disallow `then` property. | ✅ |  |  |
 | [no-this-assignment](docs/rules/no-this-assignment.md) | Disallow assigning `this` to a variable. | ✅ |  |  |
+| [no-unnecessary-await](docs/rules/no-unnecessary-await.md) | Disallow awaiting non-promise values. | ✅ | 🔧 |  |
 | [no-unreadable-array-destructuring](docs/rules/no-unreadable-array-destructuring.md) | Disallow unreadable array destructuring. | ✅ | 🔧 |  |
 | [no-unreadable-iife](docs/rules/no-unreadable-iife.md) | Disallow unreadable IIFEs. | ✅ |  |  |
 | [no-unsafe-regex](docs/rules/no-unsafe-regex.md) | Disallow unsafe regular expressions. |  |  |  |
@@ -105,11 +106,11 @@ Each rule has emojis denoting:
 | [number-literal-case](docs/rules/number-literal-case.md) | Enforce proper case for numeric literals. | ✅ | 🔧 |  |
 | [numeric-separators-style](docs/rules/numeric-separators-style.md) | Enforce the style of numeric separators by correctly grouping digits. | ✅ | 🔧 |  |
 | [prefer-add-event-listener](docs/rules/prefer-add-event-listener.md) | Prefer `.addEventListener()` and `.removeEventListener()` over `on`-functions. | ✅ | 🔧 |  |
-| [prefer-array-find](docs/rules/prefer-array-find.md) | Prefer `.find(…)` over the first element from `.filter(…)`. | ✅ | 🔧 | 💡 |
+| [prefer-array-find](docs/rules/prefer-array-find.md) | Prefer `.find(…)` and `.findLast(…)` over the first or last element from `.filter(…)`. | ✅ | 🔧 | 💡 |
 | [prefer-array-flat](docs/rules/prefer-array-flat.md) | Prefer `Array#flat()` over legacy techniques to flatten arrays. | ✅ | 🔧 |  |
 | [prefer-array-flat-map](docs/rules/prefer-array-flat-map.md) | Prefer `.flatMap(…)` over `.map(…).flat()`. | ✅ | 🔧 |  |
-| [prefer-array-index-of](docs/rules/prefer-array-index-of.md) | Prefer `Array#indexOf()` over `Array#findIndex()` when looking for the index of an item. | ✅ | 🔧 | 💡 |
-| [prefer-array-some](docs/rules/prefer-array-some.md) | Prefer `.some(…)` over `.filter(…).length` check and `.find(…)`. | ✅ | 🔧 | 💡 |
+| [prefer-array-index-of](docs/rules/prefer-array-index-of.md) | Prefer `Array#{indexOf,lastIndexOf}()` over `Array#{findIndex,findLastIndex}()` when looking for the index of an item. | ✅ | 🔧 | 💡 |
+| [prefer-array-some](docs/rules/prefer-array-some.md) | Prefer `.some(…)` over `.filter(…).length` check and `.{find,findLast}(…)`. | ✅ | 🔧 | 💡 |
 | [prefer-at](docs/rules/prefer-at.md) | Prefer `.at()` method for index access and `String#charAt()`. |  | 🔧 | 💡 |
 | [prefer-code-point](docs/rules/prefer-code-point.md) | Prefer `String#codePointAt(…)` over `String#charCodeAt(…)` and `String.fromCodePoint(…)` over `String.fromCharCode(…)`. | ✅ |  | 💡 |
 | [prefer-date-now](docs/rules/prefer-date-now.md) | Prefer `Date.now()` to get the number of milliseconds since the Unix Epoch. | ✅ | 🔧 |  |
@@ -129,7 +130,7 @@ Each rule has emojis denoting:
 | [prefer-modern-math-apis](docs/rules/prefer-modern-math-apis.md) | Prefer modern `Math` APIs over legacy patterns. | ✅ | 🔧 |  |
 | [prefer-module](docs/rules/prefer-module.md) | Prefer JavaScript modules (ESM) over CommonJS. | ✅ | 🔧 | 💡 |
 | [prefer-native-coercion-functions](docs/rules/prefer-native-coercion-functions.md) | Prefer using `String`, `Number`, `BigInt`, `Boolean`, and `Symbol` directly. | ✅ | 🔧 |  |
-| [prefer-negative-index](docs/rules/prefer-negative-index.md) | Prefer negative index over `.length - index` for `{String,Array,TypedArray}#slice()`, `Array#splice()` and `Array#at()`. | ✅ | 🔧 |  |
+| [prefer-negative-index](docs/rules/prefer-negative-index.md) | Prefer negative index over `.length - index` for `{String,Array,TypedArray}#{slice,at}()` and `Array#splice()`. | ✅ | 🔧 |  |
 | [prefer-node-protocol](docs/rules/prefer-node-protocol.md) | Prefer using the `node:` protocol when importing Node.js builtin modules. | ✅ | 🔧 |  |
 | [prefer-number-properties](docs/rules/prefer-number-properties.md) | Prefer `Number` static properties over global ones. | ✅ | 🔧 | 💡 |
 | [prefer-object-from-entries](docs/rules/prefer-object-from-entries.md) | Prefer using `Object.fromEntries(…)` to transform a list of key-value pairs into an object. | ✅ | 🔧 |  |
@@ -154,6 +155,7 @@ Each rule has emojis denoting:
 | [require-number-to-fixed-digits-argument](docs/rules/require-number-to-fixed-digits-argument.md) | Enforce using the digits argument with `Number#toFixed()`. | ✅ | 🔧 |  |
 | [require-post-message-target-origin](docs/rules/require-post-message-target-origin.md) | Enforce using the `targetOrigin` argument with `window.postMessage()`. |  |  | 💡 |
 | [string-content](docs/rules/string-content.md) | Enforce better string content. |  | 🔧 | 💡 |
+| [switch-case-braces](docs/rules/switch-case-braces.md) | Enforce consistent brace style for `case` clauses. | ✅ | 🔧 |  |
 | [template-indent](docs/rules/template-indent.md) | Fix whitespace-insensitive template indentation. | ✅ | 🔧 |  |
 | [text-encoding-identifier-case](docs/rules/text-encoding-identifier-case.md) | Enforce consistent case for text encoding identifiers. | ✅ | 🔧 | 💡 |
 | [throw-new-error](docs/rules/throw-new-error.md) | Require `new` when throwing an error. | ✅ | 🔧 |  |

package/rules/ast/is-empty-node.js

@@ -10,7 +10,7 @@ function isEmptyNode(node, additionalEmpty) {
 		return true;
 	}
 
-	if (additionalEmpty && additionalEmpty(node)) {
+	if (additionalEmpty?.(node)) {
 		return true;
 	}
 

package/rules/ast/is-static-require.js

@@ -3,9 +3,7 @@
 const {isStringLiteral} = require('./literal.js');
 
 const isStaticRequire = node => Boolean(
-	node
-	&& node.type === 'CallExpression'
-	&& node.callee
+	node?.type === 'CallExpression'
 	&& node.callee.type === 'Identifier'
 	&& node.callee.name === 'require'
 	&& !node.optional

package/rules/better-regex.js

@@ -51,15 +51,32 @@ const create = context => {
 				return;
 			}
 
-			return {
+			const problem = {
 				node,
 				messageId: MESSAGE_ID,
 				data: {
 					original,
 					optimized,
 				},
-				fix: fixer => fixer.replaceText(node, optimized),
 			};
+
+			if (
+				node.parent.type === 'MemberExpression'
+				&& node.parent.object === node
+				&& !node.parent.optional
+				&& !node.parent.computed
+				&& node.parent.property.type === 'Identifier'
+				&& (
+					node.parent.property.name === 'toString'
+					|| node.parent.property.name === 'source'
+				)
+			) {
+				return problem;
+			}
+
+			return Object.assign(problem, {
+				fix: fixer => fixer.replaceText(node, optimized),
+			});
 		},
 		[newRegExp](node) {
 			const [patternNode, flagsNode] = node.arguments;

package/rules/consistent-function-scoping.js

@@ -21,7 +21,7 @@ function checkReferences(scope, parent, scopeManager) {
 		const [definition] = resolved.defs;
 
 		// Skip recursive function name
-		if (definition && definition.type === 'FunctionName' && resolved.name === definition.name.name) {
+		if (definition?.type === 'FunctionName' && resolved.name === definition.name.name) {
 			return false;
 		}
 
@@ -92,23 +92,20 @@ const reactHooks = [
 ].flatMap(hookName => [hookName, `React.${hookName}`]);
 
 const isReactHook = scope =>
-	scope.block
-	&& scope.block.parent
-	&& scope.block.parent.callee
+	scope.block?.parent?.callee
 	&& isNodeMatches(scope.block.parent.callee, reactHooks);
 
 const isArrowFunctionWithThis = scope =>
 	scope.type === 'function'
-	&& scope.block
-	&& scope.block.type === 'ArrowFunctionExpression'
+	&& scope.block?.type === 'ArrowFunctionExpression'
 	&& (scope.thisFound || scope.childScopes.some(scope => isArrowFunctionWithThis(scope)));
 
 const iifeFunctionTypes = new Set([
 	'FunctionExpression',
 	'ArrowFunctionExpression',
 ]);
-const isIife = node => node
-	&& iifeFunctionTypes.has(node.type)
+const isIife = node =>
+	iifeFunctionTypes.has(node.type)
 	&& node.parent.type === 'CallExpression'
 	&& node.parent.callee === node;
 

package/rules/custom-error-definition.js

@@ -137,15 +137,15 @@ function * customErrorDefinition(context, node) {
 	if (!nameExpression) {
 		const nameProperty = body.find(node => isPropertyDefinition(node, 'name'));
 
-		if (!nameProperty || !nameProperty.value || nameProperty.value.value !== name) {
+		if (!nameProperty?.value || nameProperty.value.value !== name) {
 			yield {
-				node: nameProperty && nameProperty.value ? nameProperty.value : constructorBodyNode,
+				node: nameProperty?.value ?? constructorBodyNode,
 				message: `The \`name\` property should be set to \`${name}\`.`,
 			};
 		}
 	} else if (nameExpression.expression.right.value !== name) {
 		yield {
-			node: nameExpression ? nameExpression.expression.right : constructorBodyNode,
+			node: nameExpression?.expression.right ?? constructorBodyNode,
 			message: `The \`name\` property should be set to \`${name}\`.`,
 		};
 	}

package/rules/explicit-length-check.js

@@ -133,7 +133,6 @@ function create(context) {
 			problem.suggest = [
 				{
 					messageId: MESSAGE_ID_SUGGESTION,
-					data: problem.data,
 					fix,
 				},
 			];

package/rules/filename-case.js

@@ -107,7 +107,7 @@ function splitFilename(filename) {
 	for (const char of tailing) {
 		const isIgnored = isIgnoredChar(char);
 
-		if (lastWord && lastWord.ignored === isIgnored) {
+		if (lastWord?.ignored === isIgnored) {
 			lastWord.word += char;
 		} else {
 			lastWord = {
@@ -147,7 +147,7 @@ const create = context => {
 	const filenameWithExtension = context.getPhysicalFilename();
 
 	if (filenameWithExtension === '<input>' || filenameWithExtension === '<text>') {
-		return {};
+		return;
 	}
 
 	return {

package/rules/fix/add-parenthesizes-to-return-or-throw-expression.js

@@ -0,0 +1,21 @@
+'use strict';
+const {isSemicolonToken} = require('eslint-utils');
+
+function * addParenthesizesToReturnOrThrowExpression(fixer, node, sourceCode) {
+	if (node.type !== 'ReturnStatement' && node.type !== 'ThrowStatement') {
+		return;
+	}
+
+	const returnOrThrowToken = sourceCode.getFirstToken(node);
+	yield fixer.insertTextAfter(returnOrThrowToken, ' (');
+
+	const lastToken = sourceCode.getLastToken(node);
+	if (!isSemicolonToken(lastToken)) {
+		yield fixer.insertTextAfter(node, ')');
+		return;
+	}
+
+	yield fixer.insertTextBefore(lastToken, ')');
+}
+
+module.exports = addParenthesizesToReturnOrThrowExpression;

package/rules/fix/index.js

@@ -19,4 +19,5 @@ module.exports = {
 	removeSpacesAfter: require('./remove-spaces-after.js'),
 	fixSpaceAroundKeyword: require('./fix-space-around-keywords.js'),
 	replaceStringLiteral: require('./replace-string-literal.js'),
+	addParenthesizesToReturnOrThrowExpression: require('./add-parenthesizes-to-return-or-throw-expression.js'),
 };

package/rules/fix/remove-spaces-after.js

@@ -1,9 +1,9 @@
 'use strict';
 
-function removeSpacesAfter(indexOrNode, sourceCode, fixer) {
-	let index = indexOrNode;
-	if (typeof indexOrNode === 'object' && Array.isArray(indexOrNode.range)) {
-		index = indexOrNode.range[1];
+function removeSpacesAfter(indexOrNodeOrToken, sourceCode, fixer) {
+	let index = indexOrNodeOrToken;
+	if (typeof indexOrNodeOrToken === 'object' && Array.isArray(indexOrNodeOrToken.range)) {
+		index = indexOrNodeOrToken.range[1];
 	}
 
 	const textAfter = sourceCode.text.slice(index);

package/rules/fix/switch-new-expression-to-call-expression.js

@@ -1,41 +1,17 @@
 'use strict';
 const isNewExpressionWithParentheses = require('../utils/is-new-expression-with-parentheses.js');
 const {isParenthesized} = require('../utils/parentheses.js');
+const isOnSameLine = require('../utils/is-on-same-line.js');
+const addParenthesizesToReturnOrThrowExpression = require('./add-parenthesizes-to-return-or-throw-expression.js');
+const removeSpaceAfter = require('./remove-spaces-after.js');
 
-function * fixReturnOrThrowStatementArgument(newExpression, sourceCode, fixer) {
-	const {parent} = newExpression;
-	if (
-		(parent.type !== 'ReturnStatement' && parent.type !== 'ThrowStatement')
-		|| parent.argument !== newExpression
-		|| isParenthesized(newExpression, sourceCode)
-	) {
-		return;
-	}
-
-	const returnStatement = parent;
-	const returnToken = sourceCode.getFirstToken(returnStatement);
-	const classNode = newExpression.callee;
-
-	// Ideally, we should use first parenthesis of the `callee`, and should check spaces after the `new` token
-	// But adding extra parentheses is harmless, no need to be too complicated
-	if (returnToken.loc.start.line === classNode.loc.start.line) {
-		return;
-	}
+function * switchNewExpressionToCallExpression(newExpression, sourceCode, fixer) {
+	const newToken = sourceCode.getFirstToken(newExpression);
+	yield fixer.remove(newToken);
+	yield removeSpaceAfter(newToken, sourceCode, fixer);
 
-	yield fixer.insertTextAfter(returnToken, ' (');
-	yield fixer.insertTextAfter(newExpression, ')');
-}
-
-function * switchNewExpressionToCallExpression(node, sourceCode, fixer) {
-	const [start] = node.range;
-	let end = start + 3; // `3` = length of `new`
-	const textAfter = sourceCode.text.slice(end);
-	const [leadingSpaces] = textAfter.match(/^\s*/);
-	end += leadingSpaces.length;
-	yield fixer.removeRange([start, end]);
-
-	if (!isNewExpressionWithParentheses(node, sourceCode)) {
-		yield fixer.insertTextAfter(node, '()');
+	if (!isNewExpressionWithParentheses(newExpression, sourceCode)) {
+		yield fixer.insertTextAfter(newExpression, '()');
 	}
 
 	/*
@@ -48,7 +24,11 @@ function * switchNewExpressionToCallExpression(node, sourceCode, fixer) {
 			}
 		```
 	*/
-	yield * fixReturnOrThrowStatementArgument(node, sourceCode, fixer);
+	if (!isOnSameLine(newToken, newExpression.callee) && !isParenthesized(newExpression, sourceCode)) {
+		// Ideally, we should use first parenthesis of the `callee`, and should check spaces after the `new` token
+		// But adding extra parentheses is harmless, no need to be too complicated
+		yield * addParenthesizesToReturnOrThrowExpression(fixer, newExpression.parent, sourceCode);
+	}
 }
 
 module.exports = switchNewExpressionToCallExpression;

package/rules/new-for-builtins.js

@@ -1,5 +1,5 @@
 'use strict';
-const {ReferenceTracker} = require('eslint-utils');
+const {GlobalReferenceTracker} = require('./utils/global-reference-tracker.js');
 const builtins = require('./utils/builtins.js');
 const {
 	switchCallExpressionToNewExpression,
@@ -11,64 +11,65 @@ const messages = {
 	disallow: 'Use `{{name}}()` instead of `new {{name}}()`.',
 };
 
-function * enforceNewExpression({sourceCode, tracker}) {
-	const traceMap = Object.fromEntries(
-		builtins.enforceNew.map(name => [name, {[ReferenceTracker.CALL]: true}]),
-	);
-
-	for (const {node, path: [name]} of tracker.iterateGlobalReferences(traceMap)) {
-		if (name === 'Object') {
-			const {parent} = node;
-			if (
-				parent.type === 'BinaryExpression'
-				&& (parent.operator === '===' || parent.operator === '!==')
-				&& (parent.left === node || parent.right === node)
-			) {
-				continue;
-			}
+function enforceNewExpression({node, path: [name]}, sourceCode) {
+	if (name === 'Object') {
+		const {parent} = node;
+		if (
+			parent.type === 'BinaryExpression'
+			&& (parent.operator === '===' || parent.operator === '!==')
+			&& (parent.left === node || parent.right === node)
+		) {
+			return;
 		}
-
-		yield {
-			node,
-			messageId: 'enforce',
-			data: {name},
-			fix: fixer => switchCallExpressionToNewExpression(node, sourceCode, fixer),
-		};
 	}
+
+	return {
+		node,
+		messageId: 'enforce',
+		data: {name},
+		fix: fixer => switchCallExpressionToNewExpression(node, sourceCode, fixer),
+	};
 }
 
-function * enforceCallExpression({sourceCode, tracker}) {
-	const traceMap = Object.fromEntries(
-		builtins.disallowNew.map(name => [name, {[ReferenceTracker.CONSTRUCT]: true}]),
-	);
+function enforceCallExpression({node, path: [name]}, sourceCode) {
+	const problem = {
+		node,
+		messageId: 'disallow',
+		data: {name},
+	};
 
-	for (const {node, path: [name]} of tracker.iterateGlobalReferences(traceMap)) {
-		const problem = {
-			node,
-			messageId: 'disallow',
-			data: {name},
+	if (name !== 'String' && name !== 'Boolean' && name !== 'Number') {
+		problem.fix = function * (fixer) {
+			yield * switchNewExpressionToCallExpression(node, sourceCode, fixer);
 		};
-
-		if (name !== 'String' && name !== 'Boolean' && name !== 'Number') {
-			problem.fix = function * (fixer) {
-				yield * switchNewExpressionToCallExpression(node, sourceCode, fixer);
-			};
-		}
-
-		yield problem;
 	}
+
+	return problem;
 }
 
 /** @param {import('eslint').Rule.RuleContext} context */
-const create = context => ({
-	* 'Program:exit'() {
-		const sourceCode = context.getSourceCode();
-		const tracker = new ReferenceTracker(context.getScope());
+const create = context => {
+	const sourceCode = context.getSourceCode();
+	const newExpressionTracker = new GlobalReferenceTracker({
+		objects: builtins.disallowNew,
+		type: GlobalReferenceTracker.CONSTRUCT,
+		handle: reference => enforceCallExpression(reference, sourceCode),
+	});
+	const callExpressionTracker = new GlobalReferenceTracker({
+		objects: builtins.enforceNew,
+		type: GlobalReferenceTracker.CALL,
+		handle: reference => enforceNewExpression(reference, sourceCode),
+	});
 
-		yield * enforceNewExpression({sourceCode, tracker});
-		yield * enforceCallExpression({sourceCode, tracker});
-	},
-});
+	return {
+		* 'Program:exit'() {
+			const scope = context.getScope();
+
+			yield * newExpressionTracker.track(scope);
+			yield * callExpressionTracker.track(scope);
+		},
+	};
+};
 
 /** @type {import('eslint').Rule.RuleModule} */
 module.exports = {

package/rules/no-array-callback-reference.js

@@ -39,6 +39,14 @@ const iteratorMethods = [
 			],
 		},
 	],
+	[
+		'findLast',
+		{
+			ignore: [
+				'Boolean',
+			],
+		},
+	],
 	[
 		'findIndex',
 		{
@@ -47,6 +55,14 @@ const iteratorMethods = [
 			],
 		},
 	],
+	[
+		'findLastIndex',
+		{
+			ignore: [
+				'Boolean',
+			],
+		},
+	],
 	[
 		'flatMap',
 	],

package/rules/no-array-for-each.js

@@ -59,8 +59,9 @@ function shouldSwitchReturnStatementToBlockStatement(returnStatement) {
 	const {parent} = returnStatement;
 
 	switch (parent.type) {
-		case 'IfStatement':
+		case 'IfStatement': {
 			return parent.consequent === returnStatement || parent.alternate === returnStatement;
+		}
 
 		// These parent's body need switch to `BlockStatement` too, but since they are "continueAble", won't fix
 		// case 'ForStatement':
@@ -68,11 +69,13 @@ function shouldSwitchReturnStatementToBlockStatement(returnStatement) {
 		// case 'ForOfStatement':
 		// case 'WhileStatement':
 		// case 'DoWhileStatement':
-		case 'WithStatement':
+		case 'WithStatement': {
 			return parent.body === returnStatement;
+		}
 
-		default:
+		default: {
 			return false;
+		}
 	}
 }
 
@@ -315,20 +318,33 @@ function isAssignmentLeftHandSide(node) {
 	switch (parent.type) {
 		case 'AssignmentExpression':
 		case 'ForInStatement':
-		case 'ForOfStatement':
+		case 'ForOfStatement': {
 			return parent.left === node;
-		case 'UpdateExpression':
+		}
+
+		case 'UpdateExpression': {
 			return parent.argument === node;
-		case 'Property':
+		}
+
+		case 'Property': {
 			return parent.value === node && isAssignmentLeftHandSide(parent);
-		case 'AssignmentPattern':
+		}
+
+		case 'AssignmentPattern': {
 			return parent.left === node && isAssignmentLeftHandSide(parent);
-		case 'ArrayPattern':
+		}
+
+		case 'ArrayPattern': {
 			return parent.elements.includes(node) && isAssignmentLeftHandSide(parent);
-		case 'ObjectPattern':
+		}
+
+		case 'ObjectPattern': {
 			return parent.properties.includes(node) && isAssignmentLeftHandSide(parent);
-		default:
+		}
+
+		default: {
 			return false;
+		}
 	}
 }
 

package/rules/no-array-method-this-argument.js

@@ -65,7 +65,9 @@ const selector = [
 			'every',
 			'filter',
 			'find',
+			'findLast',
 			'findIndex',
+			'findLastIndex',
 			'flatMap',
 			'forEach',
 			'map',

package/rules/no-await-expression-member.js

@@ -30,6 +30,7 @@ const create = context => {
 				&& memberExpression.parent.type === 'VariableDeclarator'
 				&& memberExpression.parent.init === memberExpression
 				&& memberExpression.parent.id.type === 'Identifier'
+				&& !memberExpression.parent.id.typeAnnotation
 			) {
 				problem.fix = function * (fixer) {
 					const variable = memberExpression.parent.id;
@@ -52,6 +53,7 @@ const create = context => {
 				&& memberExpression.parent.init === memberExpression
 				&& memberExpression.parent.id.type === 'Identifier'
 				&& memberExpression.parent.id.name === property.name
+				&& !memberExpression.parent.id.typeAnnotation
 			) {
 				problem.fix = function * (fixer) {
 					const variable = memberExpression.parent.id;