eslint-plugin-unicorn 43.0.0 → 43.0.2

package/configs/recommended.js

@@ -78,7 +78,8 @@ module.exports = {
 		'unicorn/prefer-dom-node-dataset': 'error',
 		'unicorn/prefer-dom-node-remove': 'error',
 		'unicorn/prefer-dom-node-text-content': 'error',
-		'unicorn/prefer-event-target': 'error',
+		// TODO: Enable this by default when targeting Node.js 16.
+		'unicorn/prefer-event-target': 'off',
 		'unicorn/prefer-export-from': 'error',
 		'unicorn/prefer-includes': 'error',
 		'unicorn/prefer-json-parse-buffer': 'off',

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "eslint-plugin-unicorn",
-	"version": "43.0.0",
+	"version": "43.0.2",
 	"description": "More than 100 powerful ESLint rules",
 	"license": "MIT",
 	"repository": "sindresorhus/eslint-plugin-unicorn",
@@ -73,7 +73,7 @@
 		"enquirer": "^2.3.6",
 		"eslint": "^8.18.0",
 		"eslint-ava-rule-tester": "^4.0.0",
-		"eslint-plugin-eslint-plugin": "^4.3.0",
+		"eslint-plugin-eslint-plugin": "^5.0.0",
 		"eslint-plugin-internal-rules": "file:./scripts/internal-rules/",
 		"eslint-remote-tester": "^3.0.0",
 		"eslint-remote-tester-repositories": "^0.0.6",

package/readme.md

@@ -118,7 +118,7 @@ Each rule has emojis denoting:
 | [prefer-dom-node-dataset](docs/rules/prefer-dom-node-dataset.md) | Prefer using `.dataset` on DOM elements over calling attribute methods. | ✅ | 🔧 |  |
 | [prefer-dom-node-remove](docs/rules/prefer-dom-node-remove.md) | Prefer `childNode.remove()` over `parentNode.removeChild(childNode)`. | ✅ | 🔧 | 💡 |
 | [prefer-dom-node-text-content](docs/rules/prefer-dom-node-text-content.md) | Prefer `.textContent` over `.innerText`. | ✅ |  | 💡 |
-| [prefer-event-target](docs/rules/prefer-event-target.md) | Prefer `EventTarget` over `EventEmitter`. | ✅ |  |  |
+| [prefer-event-target](docs/rules/prefer-event-target.md) | Prefer `EventTarget` over `EventEmitter`. |  |  |  |
 | [prefer-export-from](docs/rules/prefer-export-from.md) | Prefer `export…from` when re-exporting. | ✅ | 🔧 | 💡 |
 | [prefer-includes](docs/rules/prefer-includes.md) | Prefer `.includes()` over `.indexOf()` and `Array#some()` when checking for existence or non-existence. | ✅ | 🔧 | 💡 |
 | [prefer-json-parse-buffer](docs/rules/prefer-json-parse-buffer.md) | Prefer reading a JSON file as a buffer. |  | 🔧 |  |

package/rules/prefer-spread.js

@@ -1,6 +1,6 @@
 'use strict';
 const {isParenthesized, getStaticValue, isCommaToken, hasSideEffect} = require('eslint-utils');
-const {methodCallSelector, not} = require('./selectors/index.js');
+const {methodCallSelector} = require('./selectors/index.js');
 const needsSemicolon = require('./utils/needs-semicolon.js');
 const {getParenthesizedRange, getParenthesizedText} = require('./utils/parentheses.js');
 const shouldAddParenthesesToSpreadElementArgument = require('./utils/should-add-parentheses-to-spread-element-argument.js');
@@ -11,6 +11,7 @@ const {
 	removeMethodCall,
 } = require('./fix/index.js');
 const {isLiteral} = require('./ast/index.js');
+const isMethodNamed = require('./utils/is-method-named.js');
 
 const ERROR_ARRAY_FROM = 'array-from';
 const ERROR_ARRAY_CONCAT = 'array-concat';
@@ -44,15 +45,7 @@ const arrayFromCallSelector = [
 	'[arguments.0.type!="ObjectExpression"]',
 ].join('');
 
-const arrayConcatCallSelector = [
-	methodCallSelector('concat'),
-	not(
-		[
-			'Literal',
-			'TemplateLiteral',
-		].map(type => `[callee.object.type="${type}"]`),
-	),
-].join('');
+const arrayConcatCallSelector = methodCallSelector('concat');
 
 const arraySliceCallSelector = [
 	methodCallSelector({
@@ -320,6 +313,26 @@ function isClassName(node) {
 	return /^[A-Z]./.test(name) && name.toUpperCase() !== name;
 }
 
+function isNotArray(node, scope) {
+	if (
+		node.type === 'TemplateLiteral'
+		|| node.type === 'Literal'
+		|| node.type === 'BinaryExpression'
+		|| isClassName(node)
+		// `foo.join()`
+		|| (isMethodNamed(node, 'join') && node.arguments.length <= 1)
+	) {
+		return true;
+	}
+
+	const staticValue = getStaticValue(node, scope);
+	if (staticValue && !Array.isArray(staticValue.value)) {
+		return true;
+	}
+
+	return false;
+}
+
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
 	const sourceCode = context.getSourceCode();
@@ -335,7 +348,7 @@ const create = context => {
 		[arrayConcatCallSelector](node) {
 			const {object} = node.callee;
 
-			if (isClassName(object)) {
+			if (isNotArray(object, context.getScope())) {
 				return;
 			}