eslint-plugin-unicorn 42.0.0 → 43.0.0

package/configs/recommended.js

@@ -22,7 +22,6 @@ module.exports = {
 		'unicorn/expiring-todo-comments': 'error',
 		'unicorn/explicit-length-check': 'error',
 		'unicorn/filename-case': 'error',
-		'unicorn/import-index': 'off',
 		'unicorn/import-style': 'error',
 		'unicorn/new-for-builtins': 'error',
 		'unicorn/no-abusive-eslint-disable': 'error',
@@ -79,10 +78,12 @@ module.exports = {
 		'unicorn/prefer-dom-node-dataset': 'error',
 		'unicorn/prefer-dom-node-remove': 'error',
 		'unicorn/prefer-dom-node-text-content': 'error',
+		'unicorn/prefer-event-target': 'error',
 		'unicorn/prefer-export-from': 'error',
 		'unicorn/prefer-includes': 'error',
 		'unicorn/prefer-json-parse-buffer': 'off',
 		'unicorn/prefer-keyboard-event-key': 'error',
+		'unicorn/prefer-logical-operator-over-ternary': 'error',
 		'unicorn/prefer-math-trunc': 'error',
 		'unicorn/prefer-modern-dom-apis': 'error',
 		'unicorn/prefer-modern-math-apis': 'error',
@@ -106,8 +107,7 @@ module.exports = {
 		'unicorn/prefer-string-trim-start-end': 'error',
 		'unicorn/prefer-switch': 'error',
 		'unicorn/prefer-ternary': 'error',
-		// TODO: Enable this by default when targeting Node.js 14.
-		'unicorn/prefer-top-level-await': 'off',
+		'unicorn/prefer-top-level-await': 'error',
 		'unicorn/prefer-type-error': 'error',
 		'unicorn/prevent-abbreviations': 'error',
 		'unicorn/relative-url-style': 'error',

package/index.js

@@ -6,6 +6,7 @@ const allRulesEnabledConfig = require('./configs/all.js');
 
 const deprecatedRules = createDeprecatedRules({
 	// {ruleId: ReplacementRuleId | ReplacementRuleId[]}, if no replacement, use `{ruleId: []}`
+	'import-index': [],
 	'no-array-instanceof': 'unicorn/no-instanceof-array',
 	'no-fn-reference-in-iterator': 'unicorn/no-array-callback-reference',
 	'no-reduce': 'unicorn/no-array-reduce',

package/package.json

@@ -1,7 +1,7 @@
 {
 	"name": "eslint-plugin-unicorn",
-	"version": "42.0.0",
-	"description": "Various awesome ESLint rules",
+	"version": "43.0.0",
+	"description": "More than 100 powerful ESLint rules",
 	"license": "MIT",
 	"repository": "sindresorhus/eslint-plugin-unicorn",
 	"funding": "https://github.com/sindresorhus/eslint-plugin-unicorn?sponsor=1",
@@ -11,7 +11,7 @@
 		"url": "https://sindresorhus.com"
 	},
 	"engines": {
-		"node": ">=12"
+		"node": ">=14.18"
 	},
 	"scripts": {
 		"create-rule": "node ./scripts/create-rule.mjs && npm run generate-rule-notices && npm run generate-rules-table",
@@ -46,8 +46,8 @@
 		"xo"
 	],
 	"dependencies": {
-		"@babel/helper-validator-identifier": "^7.15.7",
-		"ci-info": "^3.3.0",
+		"@babel/helper-validator-identifier": "^7.18.6",
+		"ci-info": "^3.3.2",
 		"clean-regexp": "^1.0.0",
 		"eslint-utils": "^3.0.0",
 		"esquery": "^1.4.0",
@@ -58,39 +58,39 @@
 		"read-pkg-up": "^7.0.1",
 		"regexp-tree": "^0.1.24",
 		"safe-regex": "^2.1.1",
-		"semver": "^7.3.5",
+		"semver": "^7.3.7",
 		"strip-indent": "^3.0.0"
 	},
 	"devDependencies": {
-		"@babel/code-frame": "^7.16.0",
-		"@babel/core": "^7.16.5",
-		"@babel/eslint-parser": "^7.16.5",
+		"@babel/code-frame": "^7.18.6",
+		"@babel/core": "^7.18.6",
+		"@babel/eslint-parser": "^7.18.2",
 		"@lubien/fixture-beta-package": "^1.0.0-beta.1",
-		"@typescript-eslint/parser": "^5.7.0",
+		"@typescript-eslint/parser": "^5.30.0",
 		"ava": "^3.15.0",
-		"c8": "^7.11.0",
-		"chalk": "^5.0.0",
+		"c8": "^7.11.3",
+		"chalk": "^5.0.1",
 		"enquirer": "^2.3.6",
-		"eslint": "^8.8.0",
+		"eslint": "^8.18.0",
 		"eslint-ava-rule-tester": "^4.0.0",
-		"eslint-plugin-eslint-plugin": "^4.1.0",
+		"eslint-plugin-eslint-plugin": "^4.3.0",
 		"eslint-plugin-internal-rules": "file:./scripts/internal-rules/",
-		"eslint-remote-tester": "^2.0.1",
-		"eslint-remote-tester-repositories": "^0.0.3",
-		"execa": "^6.0.0",
+		"eslint-remote-tester": "^3.0.0",
+		"eslint-remote-tester-repositories": "^0.0.6",
+		"execa": "^6.1.0",
 		"listr": "^0.14.3",
 		"lodash-es": "^4.17.21",
-		"markdownlint-cli": "^0.30.0",
-		"mem": "^9.0.1",
-		"npm-package-json-lint": "^5.4.2",
+		"markdownlint-cli": "^0.31.1",
+		"mem": "^9.0.2",
+		"npm-package-json-lint": "^6.3.0",
 		"npm-run-all": "^4.1.5",
 		"outdent": "^0.8.0",
-		"typescript": "^4.5.4",
-		"vue-eslint-parser": "^8.0.1",
-		"xo": "^0.48.0"
+		"typescript": "^4.7.4",
+		"vue-eslint-parser": "^9.0.3",
+		"xo": "^0.50.0"
 	},
 	"peerDependencies": {
-		"eslint": ">=8.8.0"
+		"eslint": ">=8.18.0"
 	},
 	"ava": {
 		"files": [

package/readme.md

@@ -3,7 +3,7 @@
 <!-- markdownlint-disable-next-line no-inline-html -->
 <img src="https://cloud.githubusercontent.com/assets/170270/18659176/1cc373d0-7f33-11e6-890f-0ba35362ee7e.jpg" width="180" align="right">
 
-> Various awesome ESLint rules
+> More than 100 powerful ESLint rules
 
 You might want to check out [XO](https://github.com/xojs/xo), which includes this plugin.
 
@@ -64,12 +64,11 @@ Each rule has emojis denoting:
 | [expiring-todo-comments](docs/rules/expiring-todo-comments.md) | Add expiration conditions to TODO comments. | ✅ |  |  |
 | [explicit-length-check](docs/rules/explicit-length-check.md) | Enforce explicitly comparing the `length` or `size` property of a value. | ✅ | 🔧 | 💡 |
 | [filename-case](docs/rules/filename-case.md) | Enforce a case style for filenames. | ✅ |  |  |
-| [import-index](docs/rules/import-index.md) | Enforce importing index files with `.`. |  | 🔧 |  |
 | [import-style](docs/rules/import-style.md) | Enforce specific import styles per module. | ✅ |  |  |
 | [new-for-builtins](docs/rules/new-for-builtins.md) | Enforce the use of `new` for all builtins, except `String`, `Number`, `Boolean`, `Symbol` and `BigInt`. | ✅ | 🔧 |  |
 | [no-abusive-eslint-disable](docs/rules/no-abusive-eslint-disable.md) | Enforce specifying rules to disable in `eslint-disable` comments. | ✅ |  |  |
 | [no-array-callback-reference](docs/rules/no-array-callback-reference.md) | Prevent passing a function reference directly to iterator methods. | ✅ |  | 💡 |
-| [no-array-for-each](docs/rules/no-array-for-each.md) | Prefer `for…of` over `Array#forEach(…)`. | ✅ | 🔧 | 💡 |
+| [no-array-for-each](docs/rules/no-array-for-each.md) | Prefer `for…of` over the `forEach` method. | ✅ | 🔧 | 💡 |
 | [no-array-method-this-argument](docs/rules/no-array-method-this-argument.md) | Disallow using the `this` argument in array methods. | ✅ | 🔧 | 💡 |
 | [no-array-push-push](docs/rules/no-array-push-push.md) | Enforce combining multiple `Array#push()` into one call. | ✅ | 🔧 | 💡 |
 | [no-array-reduce](docs/rules/no-array-reduce.md) | Disallow `Array#reduce()` and `Array#reduceRight()`. | ✅ |  |  |
@@ -119,10 +118,12 @@ Each rule has emojis denoting:
 | [prefer-dom-node-dataset](docs/rules/prefer-dom-node-dataset.md) | Prefer using `.dataset` on DOM elements over calling attribute methods. | ✅ | 🔧 |  |
 | [prefer-dom-node-remove](docs/rules/prefer-dom-node-remove.md) | Prefer `childNode.remove()` over `parentNode.removeChild(childNode)`. | ✅ | 🔧 | 💡 |
 | [prefer-dom-node-text-content](docs/rules/prefer-dom-node-text-content.md) | Prefer `.textContent` over `.innerText`. | ✅ |  | 💡 |
+| [prefer-event-target](docs/rules/prefer-event-target.md) | Prefer `EventTarget` over `EventEmitter`. | ✅ |  |  |
 | [prefer-export-from](docs/rules/prefer-export-from.md) | Prefer `export…from` when re-exporting. | ✅ | 🔧 | 💡 |
 | [prefer-includes](docs/rules/prefer-includes.md) | Prefer `.includes()` over `.indexOf()` and `Array#some()` when checking for existence or non-existence. | ✅ | 🔧 | 💡 |
 | [prefer-json-parse-buffer](docs/rules/prefer-json-parse-buffer.md) | Prefer reading a JSON file as a buffer. |  | 🔧 |  |
 | [prefer-keyboard-event-key](docs/rules/prefer-keyboard-event-key.md) | Prefer `KeyboardEvent#key` over `KeyboardEvent#keyCode`. | ✅ | 🔧 |  |
+| [prefer-logical-operator-over-ternary](docs/rules/prefer-logical-operator-over-ternary.md) | Prefer using a logical operator over a ternary. | ✅ |  | 💡 |
 | [prefer-math-trunc](docs/rules/prefer-math-trunc.md) | Enforce the use of `Math.trunc` instead of bitwise operators. | ✅ | 🔧 | 💡 |
 | [prefer-modern-dom-apis](docs/rules/prefer-modern-dom-apis.md) | Prefer `.before()` over `.insertBefore()`, `.replaceWith()` over `.replaceChild()`, prefer one of `.before()`, `.after()`, `.append()` or `.prepend()` over `insertAdjacentText()` and `insertAdjacentElement()`. | ✅ | 🔧 |  |
 | [prefer-modern-math-apis](docs/rules/prefer-modern-math-apis.md) | Prefer modern `Math` APIs over legacy patterns. | ✅ | 🔧 |  |
@@ -145,7 +146,7 @@ Each rule has emojis denoting:
 | [prefer-string-trim-start-end](docs/rules/prefer-string-trim-start-end.md) | Prefer `String#trimStart()` / `String#trimEnd()` over `String#trimLeft()` / `String#trimRight()`. | ✅ | 🔧 |  |
 | [prefer-switch](docs/rules/prefer-switch.md) | Prefer `switch` over multiple `else-if`. | ✅ | 🔧 |  |
 | [prefer-ternary](docs/rules/prefer-ternary.md) | Prefer ternary expressions over simple `if-else` statements. | ✅ | 🔧 |  |
-| [prefer-top-level-await](docs/rules/prefer-top-level-await.md) | Prefer top-level await over top-level promises and async function calls. |  |  | 💡 |
+| [prefer-top-level-await](docs/rules/prefer-top-level-await.md) | Prefer top-level await over top-level promises and async function calls. | ✅ |  | 💡 |
 | [prefer-type-error](docs/rules/prefer-type-error.md) | Enforce throwing `TypeError` in type checking conditions. | ✅ | 🔧 |  |
 | [prevent-abbreviations](docs/rules/prevent-abbreviations.md) | Prevent abbreviations. | ✅ | 🔧 |  |
 | [relative-url-style](docs/rules/relative-url-style.md) | Enforce consistent relative URL style. | ✅ | 🔧 | 💡 |

package/rules/ast/index.js

@@ -1,4 +1,24 @@
 'use strict';
+
+const {
+	isLiteral,
+	isStringLiteral,
+	isNumberLiteral,
+	isBigIntLiteral,
+	isNullLiteral,
+	isRegexLiteral,
+} = require('./literal.js');
+
 module.exports = {
+	isLiteral,
+	isStringLiteral,
+	isNumberLiteral,
+	isBigIntLiteral,
+	isNullLiteral,
+	isRegexLiteral,
+
+	isArrowFunctionBody: require('./is-arrow-function-body.js'),
 	isEmptyNode: require('./is-empty-node.js'),
+	isStaticRequire: require('./is-static-require.js'),
+	isUndefined: require('./is-undefined.js'),
 };

package/rules/ast/is-arrow-function-body.js

@@ -0,0 +1,7 @@
+'use strict';
+
+function isArrowFunctionBody(node) {
+	return node.parent.type === 'ArrowFunctionExpression' && node.parent.body === node;
+}
+
+module.exports = isArrowFunctionBody;

package/rules/{utils → ast}/is-static-require.js

@@ -1,5 +1,7 @@
 'use strict';
 
+const {isStringLiteral} = require('./literal.js');
+
 const isStaticRequire = node => Boolean(
 	node
 	&& node.type === 'CallExpression'
@@ -8,8 +10,7 @@ const isStaticRequire = node => Boolean(
 	&& node.callee.name === 'require'
 	&& !node.optional
 	&& node.arguments.length === 1
-	&& node.arguments[0].type === 'Literal'
-	&& typeof node.arguments[0].value === 'string',
+	&& isStringLiteral(node.arguments[0]),
 );
 
 module.exports = isStaticRequire;

package/rules/ast/is-undefined.js

@@ -0,0 +1,7 @@
+'use strict';
+
+function isUndefined(node) {
+	return node.type === 'Identifier' && node.name === 'undefined';
+}
+
+module.exports = isUndefined;

package/rules/ast/literal.js

@@ -0,0 +1,29 @@
+'use strict';
+
+function isLiteral(node, value) {
+	if (node?.type !== 'Literal') {
+		return false;
+	}
+
+	if (value === null) {
+		return node.raw === 'null';
+	}
+
+	return node.value === value;
+}
+
+const isStringLiteral = node => node?.type === 'Literal' && typeof node.value === 'string';
+const isNumberLiteral = node => node.type === 'Literal' && typeof node.value === 'number';
+const isRegexLiteral = node => node.type === 'Literal' && Boolean(node.regex);
+// eslint-disable-next-line unicorn/no-null
+const isNullLiteral = node => isLiteral(node, null);
+const isBigIntLiteral = node => node.type === 'Literal' && Boolean(node.bigint);
+
+module.exports = {
+	isLiteral,
+	isStringLiteral,
+	isNumberLiteral,
+	isBigIntLiteral,
+	isNullLiteral,
+	isRegexLiteral,
+};

package/rules/better-regex.js

@@ -3,16 +3,14 @@ const cleanRegexp = require('clean-regexp');
 const {optimize} = require('regexp-tree');
 const quoteString = require('./utils/quote-string.js');
 const {newExpressionSelector} = require('./selectors/index.js');
+const {isStringLiteral} = require('./ast/index.js');
 
 const MESSAGE_ID = 'better-regex';
 const messages = {
 	[MESSAGE_ID]: '{{original}} can be optimized to {{optimized}}.',
 };
 
-const newRegExp = [
-	newExpressionSelector({name: 'RegExp', minimumArguments: 1}),
-	'[arguments.0.type="Literal"]',
-].join('');
+const newRegExp = newExpressionSelector({name: 'RegExp', minimumArguments: 1});
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
@@ -66,16 +64,12 @@ const create = context => {
 		[newRegExp](node) {
 			const [patternNode, flagsNode] = node.arguments;
 
-			if (typeof patternNode.value !== 'string') {
+			if (!isStringLiteral(patternNode)) {
 				return;
 			}
 
 			const oldPattern = patternNode.value;
-			const flags = (
-				flagsNode
-				&& flagsNode.type === 'Literal'
-				&& typeof flagsNode.value === 'string'
-			)
+			const flags = isStringLiteral(flagsNode)
 				? flagsNode.value
 				: '';
 

package/rules/consistent-function-scoping.js

@@ -109,7 +109,6 @@ const iifeFunctionTypes = new Set([
 ]);
 const isIife = node => node
 	&& iifeFunctionTypes.has(node.type)
-	&& node.parent
 	&& node.parent.type === 'CallExpression'
 	&& node.parent.callee === node;
 

package/rules/explicit-length-check.js

@@ -1,11 +1,11 @@
 'use strict';
 const {isParenthesized, getStaticValue} = require('eslint-utils');
 const {checkVueTemplate} = require('./utils/rule.js');
-const isLiteralValue = require('./utils/is-literal-value.js');
 const isLogicalExpression = require('./utils/is-logical-expression.js');
 const {isBooleanNode, getBooleanAncestor} = require('./utils/boolean.js');
 const {memberExpressionSelector} = require('./selectors/index.js');
 const {fixSpaceAroundKeyword} = require('./fix/index.js');
+const {isLiteral} = require('./ast/index.js');
 
 const TYPE_NON_ZERO = 'non-zero';
 const TYPE_ZERO = 'zero';
@@ -19,11 +19,11 @@ const messages = {
 const isCompareRight = (node, operator, value) =>
 	node.type === 'BinaryExpression'
 	&& node.operator === operator
-	&& isLiteralValue(node.right, value);
+	&& isLiteral(node.right, value);
 const isCompareLeft = (node, operator, value) =>
 	node.type === 'BinaryExpression'
 	&& node.operator === operator
-	&& isLiteralValue(node.left, value);
+	&& isLiteral(node.left, value);
 const nonZeroStyles = new Map([
 	[
 		'greater-than',

package/rules/filename-case.js

@@ -1,5 +1,5 @@
 'use strict';
-const path = require('path');
+const path = require('node:path');
 const {camelCase, kebabCase, snakeCase, upperFirst} = require('lodash');
 const cartesianProductSamples = require('./utils/cartesian-product-samples.js');
 

package/rules/fix/switch-new-expression-to-call-expression.js

@@ -2,10 +2,10 @@
 const isNewExpressionWithParentheses = require('../utils/is-new-expression-with-parentheses.js');
 const {isParenthesized} = require('../utils/parentheses.js');
 
-function * fixReturnStatementArgument(newExpression, sourceCode, fixer) {
+function * fixReturnOrThrowStatementArgument(newExpression, sourceCode, fixer) {
 	const {parent} = newExpression;
 	if (
-		parent.type !== 'ReturnStatement'
+		(parent.type !== 'ReturnStatement' && parent.type !== 'ThrowStatement')
 		|| parent.argument !== newExpression
 		|| isParenthesized(newExpression, sourceCode)
 	) {
@@ -48,7 +48,7 @@ function * switchNewExpressionToCallExpression(node, sourceCode, fixer) {
 			}
 		```
 	*/
-	yield * fixReturnStatementArgument(node, sourceCode, fixer);
+	yield * fixReturnOrThrowStatementArgument(node, sourceCode, fixer);
 }
 
 module.exports = switchNewExpressionToCallExpression;

package/rules/new-for-builtins.js

@@ -1,7 +1,6 @@
 'use strict';
+const {ReferenceTracker} = require('eslint-utils');
 const builtins = require('./utils/builtins.js');
-const isShadowed = require('./utils/is-shadowed.js');
-const {callExpressionSelector, newExpressionSelector} = require('./selectors/index.js');
 const {
 	switchCallExpressionToNewExpression,
 	switchNewExpressionToCallExpression,
@@ -12,60 +11,64 @@ const messages = {
 	disallow: 'Use `{{name}}()` instead of `new {{name}}()`.',
 };
 
-/** @param {import('eslint').Rule.RuleContext} context */
-const create = context => {
-	const sourceCode = context.getSourceCode();
-
-	return {
-		[callExpressionSelector(builtins.enforceNew)](node) {
-			const {callee, parent} = node;
-			if (isShadowed(context.getScope(), callee)) {
-				return;
-			}
-
-			const {name} = callee;
+function * enforceNewExpression({sourceCode, tracker}) {
+	const traceMap = Object.fromEntries(
+		builtins.enforceNew.map(name => [name, {[ReferenceTracker.CALL]: true}]),
+	);
 
+	for (const {node, path: [name]} of tracker.iterateGlobalReferences(traceMap)) {
+		if (name === 'Object') {
+			const {parent} = node;
 			if (
-				name === 'Object'
-				&& parent
-				&& parent.type === 'BinaryExpression'
+				parent.type === 'BinaryExpression'
 				&& (parent.operator === '===' || parent.operator === '!==')
 				&& (parent.left === node || parent.right === node)
 			) {
-				return;
+				continue;
 			}
+		}
 
-			return {
-				node,
-				messageId: 'enforce',
-				data: {name},
-				fix: fixer => switchCallExpressionToNewExpression(node, sourceCode, fixer),
-			};
-		},
-		[newExpressionSelector(builtins.disallowNew)](node) {
-			const {callee} = node;
+		yield {
+			node,
+			messageId: 'enforce',
+			data: {name},
+			fix: fixer => switchCallExpressionToNewExpression(node, sourceCode, fixer),
+		};
+	}
+}
 
-			if (isShadowed(context.getScope(), callee)) {
-				return;
-			}
+function * enforceCallExpression({sourceCode, tracker}) {
+	const traceMap = Object.fromEntries(
+		builtins.disallowNew.map(name => [name, {[ReferenceTracker.CONSTRUCT]: true}]),
+	);
 
-			const {name} = callee;
-			const problem = {
-				node,
-				messageId: 'disallow',
-				data: {name},
+	for (const {node, path: [name]} of tracker.iterateGlobalReferences(traceMap)) {
+		const problem = {
+			node,
+			messageId: 'disallow',
+			data: {name},
+		};
+
+		if (name !== 'String' && name !== 'Boolean' && name !== 'Number') {
+			problem.fix = function * (fixer) {
+				yield * switchNewExpressionToCallExpression(node, sourceCode, fixer);
 			};
+		}
 
-			if (name !== 'String' && name !== 'Boolean' && name !== 'Number') {
-				problem.fix = function * (fixer) {
-					yield * switchNewExpressionToCallExpression(node, sourceCode, fixer);
-				};
-			}
+		yield problem;
+	}
+}
 
-			return problem;
-		},
-	};
-};
+/** @param {import('eslint').Rule.RuleContext} context */
+const create = context => ({
+	* 'Program:exit'() {
+		const sourceCode = context.getSourceCode();
+		const tracker = new ReferenceTracker(context.getScope());
+
+		yield * enforceNewExpression({sourceCode, tracker});
+		yield * enforceCallExpression({sourceCode, tracker});
+	},
+});
 
 /** @type {import('eslint').Rule.RuleModule} */
 module.exports = {