eslint-plugin-unicorn 40.0.0 → 41.0.1

package/configs/all.js

@@ -1,17 +1,9 @@
 'use strict';
-const conflictingRules = require('./conflicting-rules.js');
+const {rules, ...baseConfigs} = require('./recommended.js');
 
 module.exports = {
-	...require('./base.js'),
-	rules: {
-		...Object.fromEntries(
-			Object.entries(require('./recommended.js').rules)
-				.filter(
-					ruleEntry =>
-						!Object.keys(conflictingRules.rules).includes(ruleEntry[0]),
-				)
-				.map(ruleEntry => [ruleEntry[0], 'error']),
-		),
-		...conflictingRules.rules,
-	},
+	...baseConfigs,
+	rules: Object.fromEntries(Object.entries(rules).map(
+		([ruleId, severity]) => [ruleId, ruleId.startsWith('unicorn/') ? 'error' : severity],
+	)),
 };

package/configs/recommended.js

@@ -1,6 +1,15 @@
 'use strict';
 module.exports = {
-	...require('./base.js'),
+	env: {
+		es2022: true,
+	},
+	parserOptions: {
+		ecmaVersion: 'latest',
+		sourceType: 'module',
+	},
+	plugins: [
+		'unicorn',
+	],
 	rules: {
 		'unicorn/better-regex': 'error',
 		'unicorn/catch-error-name': 'error',
@@ -105,7 +114,7 @@ module.exports = {
 		'unicorn/require-post-message-target-origin': 'off',
 		'unicorn/string-content': 'off',
 		'unicorn/template-indent': 'warn',
+		'unicorn/text-encoding-identifier-case': 'error',
 		'unicorn/throw-new-error': 'error',
-		...require('./conflicting-rules.js').rules,
 	},
 };

package/index.js

@@ -2,7 +2,7 @@
 const createDeprecatedRules = require('./rules/utils/create-deprecated-rules.js');
 const {loadRules} = require('./rules/utils/rule.js');
 const recommendedConfig = require('./configs/recommended.js');
-const all = require('./configs/all.js');
+const allRulesEnabledConfig = require('./configs/all.js');
 
 const deprecatedRules = createDeprecatedRules({
 	// {ruleId: ReplacementRuleId | ReplacementRuleId[]}, if no replacement, use `{ruleId: []}`
@@ -30,6 +30,6 @@ module.exports = {
 	},
 	configs: {
 		recommended: recommendedConfig,
-		all,
+		all: allRulesEnabledConfig,
 	},
 };

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "eslint-plugin-unicorn",
-	"version": "40.0.0",
+	"version": "41.0.1",
 	"description": "Various awesome ESLint rules",
 	"license": "MIT",
 	"repository": "sindresorhus/eslint-plugin-unicorn",
@@ -14,12 +14,12 @@
 		"node": ">=12"
 	},
 	"scripts": {
-		"create-rule": "node ./scripts/create-rule.mjs && npm run generate-rules-table && npm run generate-usage-example",
+		"create-rule": "node ./scripts/create-rule.mjs && npm run generate-rule-notices && npm run generate-rules-table",
 		"fix": "run-p --continue-on-error fix:*",
 		"fix:js": "npm run lint:js -- --fix",
 		"fix:md": "npm run lint:md -- --fix",
+		"generate-rule-notices": "node ./scripts/generate-rule-notices.mjs",
 		"generate-rules-table": "node ./scripts/generate-rules-table.mjs",
-		"generate-usage-example": "node ./scripts/generate-usage-example.mjs",
 		"integration": "node ./test/integration/test.mjs",
 		"lint": "run-p --continue-on-error lint:*",
 		"lint:js": "xo",
@@ -28,7 +28,7 @@
 		"run-rules-on-codebase": "node ./test/run-rules-on-codebase/lint.mjs",
 		"smoke": "eslint-remote-tester --config ./test/smoke/eslint-remote-tester.config.js",
 		"test": "npm-run-all --continue-on-error lint test:*",
-		"test:js": "nyc ava"
+		"test:js": "c8 ava"
 	},
 	"files": [
 		"index.js",
@@ -68,11 +68,13 @@
 		"@lubien/fixture-beta-package": "^1.0.0-beta.1",
 		"@typescript-eslint/parser": "^5.7.0",
 		"ava": "^3.15.0",
+		"c8": "^7.11.0",
 		"chalk": "^5.0.0",
 		"enquirer": "^2.3.6",
-		"eslint": "^8.5.0",
+		"eslint": "^8.8.0",
 		"eslint-ava-rule-tester": "^4.0.0",
 		"eslint-plugin-eslint-plugin": "^4.1.0",
+		"eslint-plugin-internal-rules": "file:./scripts/internal-rules/",
 		"eslint-remote-tester": "^2.0.1",
 		"eslint-remote-tester-repositories": "^0.0.3",
 		"execa": "^6.0.0",
@@ -82,14 +84,13 @@
 		"mem": "^9.0.1",
 		"npm-package-json-lint": "^5.4.2",
 		"npm-run-all": "^4.1.5",
-		"nyc": "^15.1.0",
 		"outdent": "^0.8.0",
 		"typescript": "^4.5.4",
 		"vue-eslint-parser": "^8.0.1",
-		"xo": "^0.47.0"
+		"xo": "^0.48.0"
 	},
 	"peerDependencies": {
-		"eslint": ">=7.32.0"
+		"eslint": ">=8.8.0"
 	},
 	"ava": {
 		"files": [
@@ -97,7 +98,7 @@
 			"test/unit/*.mjs"
 		]
 	},
-	"nyc": {
+	"c8": {
 		"reporter": [
 			"text",
 			"lcov"
@@ -110,7 +111,16 @@
 			"test/integration/{fixtures,fixtures-local}/**"
 		],
 		"rules": {
-			"unicorn/no-null": "error"
+			"unicorn/no-null": "error",
+			"unicorn/prefer-array-flat": [
+				"error",
+				{
+					"functions": [
+						"flat",
+						"flatten"
+					]
+				}
+			]
 		},
 		"overrides": [
 			{
@@ -146,7 +156,30 @@
 					"eslint-plugin/require-meta-has-suggestions": "off",
 					"eslint-plugin/require-meta-schema": "off"
 				}
+			},
+			{
+				"files": [
+					"rules/**/*.js"
+				],
+				"plugins": [
+					"internal-rules"
+				],
+				"rules": {
+					"internal-rules/prefer-negative-boolean-attribute": "error"
+				}
 			}
 		]
+	},
+	"npmpackagejsonlint": {
+		"rules": {
+			"prefer-caret-version-devDependencies": [
+				"error",
+				{
+					"exceptions": [
+						"eslint-plugin-internal-rules"
+					]
+				}
+			]
+		}
 	}
 }

package/readme.md

@@ -17,16 +17,14 @@ npm install --save-dev eslint eslint-plugin-unicorn
 
 ## Usage
 
-Configure it in `package.json`.
+Use a [preset config](#preset-configs) or configure each rules in `package.json`.
 
-<!-- Do not manually modify this table. Run: `npm run generate-usage-example` -->
-<!-- USAGE_EXAMPLE_START -->
 ```json
 {
 	"name": "my-awesome-project",
 	"eslintConfig": {
 		"env": {
-			"es6": true
+			"es2022": true
 		},
 		"parserOptions": {
 			"ecmaVersion": "latest",
@@ -37,109 +35,11 @@ Configure it in `package.json`.
 		],
 		"rules": {
 			"unicorn/better-regex": "error",
-			"unicorn/catch-error-name": "error",
-			"unicorn/consistent-destructuring": "error",
-			"unicorn/consistent-function-scoping": "error",
-			"unicorn/custom-error-definition": "off",
-			"unicorn/empty-brace-spaces": "error",
-			"unicorn/error-message": "error",
-			"unicorn/escape-case": "error",
-			"unicorn/expiring-todo-comments": "error",
-			"unicorn/explicit-length-check": "error",
-			"unicorn/filename-case": "error",
-			"unicorn/import-index": "off",
-			"unicorn/import-style": "error",
-			"unicorn/new-for-builtins": "error",
-			"unicorn/no-abusive-eslint-disable": "error",
-			"unicorn/no-array-callback-reference": "error",
-			"unicorn/no-array-for-each": "error",
-			"unicorn/no-array-method-this-argument": "error",
-			"unicorn/no-array-push-push": "error",
-			"unicorn/no-array-reduce": "error",
-			"unicorn/no-await-expression-member": "error",
-			"unicorn/no-console-spaces": "error",
-			"unicorn/no-document-cookie": "error",
-			"unicorn/no-empty-file": "error",
-			"unicorn/no-for-loop": "error",
-			"unicorn/no-hex-escape": "error",
-			"unicorn/no-instanceof-array": "error",
-			"unicorn/no-invalid-remove-event-listener": "error",
-			"unicorn/no-keyword-prefix": "off",
-			"unicorn/no-lonely-if": "error",
-			"no-nested-ternary": "off",
-			"unicorn/no-nested-ternary": "error",
-			"unicorn/no-new-array": "error",
-			"unicorn/no-new-buffer": "error",
-			"unicorn/no-null": "error",
-			"unicorn/no-object-as-default-parameter": "error",
-			"unicorn/no-process-exit": "error",
-			"unicorn/no-static-only-class": "error",
-			"unicorn/no-thenable": "error",
-			"unicorn/no-this-assignment": "error",
-			"unicorn/no-unreadable-array-destructuring": "error",
-			"unicorn/no-unsafe-regex": "off",
-			"unicorn/no-unused-properties": "off",
-			"unicorn/no-useless-fallback-in-spread": "error",
-			"unicorn/no-useless-length-check": "error",
-			"unicorn/no-useless-promise-resolve-reject": "error",
-			"unicorn/no-useless-spread": "error",
-			"unicorn/no-useless-undefined": "error",
-			"unicorn/no-zero-fractions": "error",
-			"unicorn/number-literal-case": "error",
-			"unicorn/numeric-separators-style": "error",
-			"unicorn/prefer-add-event-listener": "error",
-			"unicorn/prefer-array-find": "error",
-			"unicorn/prefer-array-flat": "error",
-			"unicorn/prefer-array-flat-map": "error",
-			"unicorn/prefer-array-index-of": "error",
-			"unicorn/prefer-array-some": "error",
-			"unicorn/prefer-at": "off",
-			"unicorn/prefer-code-point": "error",
-			"unicorn/prefer-date-now": "error",
-			"unicorn/prefer-default-parameters": "error",
-			"unicorn/prefer-dom-node-append": "error",
-			"unicorn/prefer-dom-node-dataset": "error",
-			"unicorn/prefer-dom-node-remove": "error",
-			"unicorn/prefer-dom-node-text-content": "error",
-			"unicorn/prefer-export-from": "error",
-			"unicorn/prefer-includes": "error",
-			"unicorn/prefer-json-parse-buffer": "error",
-			"unicorn/prefer-keyboard-event-key": "error",
-			"unicorn/prefer-math-trunc": "error",
-			"unicorn/prefer-modern-dom-apis": "error",
-			"unicorn/prefer-module": "error",
-			"unicorn/prefer-negative-index": "error",
-			"unicorn/prefer-node-protocol": "error",
-			"unicorn/prefer-number-properties": "error",
-			"unicorn/prefer-object-from-entries": "error",
-			"unicorn/prefer-optional-catch-binding": "error",
-			"unicorn/prefer-prototype-methods": "error",
-			"unicorn/prefer-query-selector": "error",
-			"unicorn/prefer-reflect-apply": "error",
-			"unicorn/prefer-regexp-test": "error",
-			"unicorn/prefer-set-has": "error",
-			"unicorn/prefer-spread": "error",
-			"unicorn/prefer-string-replace-all": "off",
-			"unicorn/prefer-string-slice": "error",
-			"unicorn/prefer-string-starts-ends-with": "error",
-			"unicorn/prefer-string-trim-start-end": "error",
-			"unicorn/prefer-switch": "error",
-			"unicorn/prefer-ternary": "error",
-			"unicorn/prefer-top-level-await": "off",
-			"unicorn/prefer-type-error": "error",
-			"unicorn/prevent-abbreviations": "error",
-			"unicorn/relative-url-style": "error",
-			"unicorn/require-array-join-separator": "error",
-			"unicorn/require-number-to-fixed-digits-argument": "error",
-			"unicorn/require-post-message-target-origin": "off",
-			"unicorn/string-content": "off",
-			"unicorn/template-indent": "warn",
-			"unicorn/throw-new-error": "error"
+			"unicorn/…": "error"
 		}
 	}
 }
 ```
-<!-- USAGE_EXAMPLE_END -->
 
 ## Rules
 
@@ -149,9 +49,8 @@ Each rule has emojis denoting:
 - 🔧 if some problems reported by the rule are automatically fixable by the `--fix` [command line](https://eslint.org/docs/user-guide/command-line-interface#fixing-problems) option
 - 💡 if some problems reported by the rule are manually fixable by editor [suggestions](https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions)
 
-<!-- Do not manually modify this table. Run: `npm run generate-rules-table` -->
-<!-- RULES_TABLE_START -->
-
+<!-- Do not manually modify RULES_TABLE part. Run: `npm run generate-rules-table` -->
+<!-- RULES_TABLE -->
 | Name&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; | Description | ✅ | 🔧 | 💡 |
 | :-- | :-- | :-- | :-- | :-- |
 | [better-regex](docs/rules/better-regex.md) | Improve regexes by making them shorter, consistent, and safer. | ✅ | 🔧 |  |
@@ -245,25 +144,29 @@ Each rule has emojis denoting:
 | [prefer-top-level-await](docs/rules/prefer-top-level-await.md) | Prefer top-level await over top-level promises and async function calls. |  |  | 💡 |
 | [prefer-type-error](docs/rules/prefer-type-error.md) | Enforce throwing `TypeError` in type checking conditions. | ✅ | 🔧 |  |
 | [prevent-abbreviations](docs/rules/prevent-abbreviations.md) | Prevent abbreviations. | ✅ | 🔧 |  |
-| [relative-url-style](docs/rules/relative-url-style.md) | Enforce consistent relative URL style. | ✅ | 🔧 |  |
+| [relative-url-style](docs/rules/relative-url-style.md) | Enforce consistent relative URL style. | ✅ | 🔧 | 💡 |
 | [require-array-join-separator](docs/rules/require-array-join-separator.md) | Enforce using the separator argument with `Array#join()`. | ✅ | 🔧 |  |
 | [require-number-to-fixed-digits-argument](docs/rules/require-number-to-fixed-digits-argument.md) | Enforce using the digits argument with `Number#toFixed()`. | ✅ | 🔧 |  |
 | [require-post-message-target-origin](docs/rules/require-post-message-target-origin.md) | Enforce using the `targetOrigin` argument with `window.postMessage()`. |  |  | 💡 |
 | [string-content](docs/rules/string-content.md) | Enforce better string content. |  | 🔧 | 💡 |
-| [template-indent](docs/rules/template-indent.md) | Fix whitespace-insensitive template indentation. |  | 🔧 |  |
+| [template-indent](docs/rules/template-indent.md) | Fix whitespace-insensitive template indentation. | ✅ | 🔧 |  |
+| [text-encoding-identifier-case](docs/rules/text-encoding-identifier-case.md) | Enforce consistent case for text encoding identifiers. | ✅ |  | 💡 |
 | [throw-new-error](docs/rules/throw-new-error.md) | Require `new` when throwing an error. | ✅ | 🔧 |  |
+<!-- /RULES_TABLE -->
 
-<!-- RULES_TABLE_END -->
-
-## Deprecated Rules
+### Deprecated Rules
 
 See [docs/deprecated-rules.md](docs/deprecated-rules.md)
 
-## Recommended config
+## Preset configs
 
-This plugin exports a [`recommended` config](configs/recommended.js) that enforces good practices.
+See the [ESLint docs](https://eslint.org/docs/user-guide/configuring/configuration-files#extending-configuration-files) for more information about extending config files.
 
-Enable it in your `package.json` with the `extends` option:
+**Note**: Preset configs will also enable the correct [parser options](https://eslint.org/docs/user-guide/configuring/language-options#specifying-parser-options) and [environment](https://eslint.org/docs/user-guide/configuring/language-options#specifying-environments).
+
+### Recommended config
+
+This plugin exports a [`recommended` config](configs/recommended.js) that enforces good practices.
 
 ```json
 {
@@ -274,16 +177,10 @@ Enable it in your `package.json` with the `extends` option:
 }
 ```
 
-See the [ESLint docs](https://eslint.org/docs/user-guide/configuring/configuration-files#extending-configuration-files) for more information about extending config files.
-
-**Note**: This config will also enable the correct [parser options](https://eslint.org/docs/user-guide/configuring/language-options#specifying-parser-options) and [environment](https://eslint.org/docs/user-guide/configuring/language-options#specifying-environments).
-
-## All config
+### All config
 
 This plugin exports an [`all` config](configs/all.js) that makes use of all rules (except for deprecated ones).
 
-Enable it in your `package.json` with the `extends` option:
-
 ```json
 {
 	"name": "my-awesome-project",
@@ -293,8 +190,6 @@ Enable it in your `package.json` with the `extends` option:
 }
 ```
 
-See the [ESLint docs](https://eslint.org/docs/user-guide/configuring/configuration-files#extending-configuration-files) for more information about extending config files.
-
 ## Maintainers
 
 - [Sindre Sorhus](https://github.com/sindresorhus)

package/rules/better-regex.js

@@ -25,7 +25,7 @@ const create = context => {
 	}
 
 	return {
-		'Literal[regex]': node => {
+		'Literal[regex]'(node) {
 			const {raw: original, regex} = node;
 
 			// Regular Expressions with `u` flag are not well handled by `regexp-tree`
@@ -63,7 +63,7 @@ const create = context => {
 				fix: fixer => fixer.replaceText(node, optimized),
 			};
 		},
-		[newRegExp]: node => {
+		[newRegExp](node) {
 			const [patternNode, flagsNode] = node.arguments;
 
 			if (typeof patternNode.value !== 'string') {

package/rules/catch-error-name.js

@@ -50,7 +50,7 @@ const create = context => {
 		|| name.endsWith(expectedName.charAt(0).toUpperCase() + expectedName.slice(1));
 
 	return {
-		[selector]: node => {
+		[selector](node) {
 			const originalName = node.name;
 
 			if (
@@ -65,7 +65,7 @@ const create = context => {
 
 			// This was reported https://github.com/sindresorhus/eslint-plugin-unicorn/issues/1075#issuecomment-768072967
 			// But can't reproduce, just ignore this case
-			/* istanbul ignore next */
+			/* c8 ignore next 3 */
 			if (!variable) {
 				return;
 			}

package/rules/consistent-destructuring.js

@@ -57,7 +57,7 @@ const create = context => {
 	const declarations = new Map();
 
 	return {
-		[declaratorSelector]: node => {
+		[declaratorSelector](node) {
 			// Ignore any complex expressions (e.g. arrays, functions)
 			if (!isSimpleExpression(node.init)) {
 				return;
@@ -69,7 +69,7 @@ const create = context => {
 				objectPattern: node.id,
 			});
 		},
-		[memberSelector]: node => {
+		[memberSelector](node) {
 			const declaration = declarations.get(source.getText(node.object));
 
 			if (!declaration) {

package/rules/consistent-function-scoping.js

@@ -1,6 +1,7 @@
 'use strict';
 const {getFunctionHeadLocation, getFunctionNameWithKind} = require('eslint-utils');
 const getReferences = require('./utils/get-references.js');
+const {isNodeMatches} = require('./utils/is-node-matches.js');
 
 const MESSAGE_ID = 'consistent-function-scoping';
 const messages = {
@@ -45,13 +46,13 @@ function checkReferences(scope, parent, scopeManager) {
 		const identifierScope = scopeManager.acquire(identifier);
 
 		// If we have a scope, the earlier checks should have worked so ignore them here
-		/* istanbul ignore next: Hard to test */
+		/* c8 ignore next 3 */
 		if (identifierScope) {
 			return false;
 		}
 
 		const identifierParentScope = scopeManager.acquire(identifier.parent);
-		/* istanbul ignore next: Hard to test */
+		/* c8 ignore next 3 */
 		if (!identifierParentScope) {
 			return false;
 		}
@@ -77,7 +78,7 @@ function checkReferences(scope, parent, scopeManager) {
 }
 
 // https://reactjs.org/docs/hooks-reference.html
-const reactHooks = new Set([
+const reactHooks = [
 	'useState',
 	'useEffect',
 	'useContext',
@@ -88,13 +89,13 @@ const reactHooks = new Set([
 	'useImperativeHandle',
 	'useLayoutEffect',
 	'useDebugValue',
-]);
+].flatMap(hookName => [hookName, `React.${hookName}`]);
+
 const isReactHook = scope =>
 	scope.block
 	&& scope.block.parent
 	&& scope.block.parent.callee
-	&& scope.block.parent.callee.type === 'Identifier'
-	&& reactHooks.has(scope.block.parent.callee.name);
+	&& isNodeMatches(scope.block.parent.callee, reactHooks);
 
 const isArrowFunctionWithThis = scope =>
 	scope.type === 'function'
@@ -158,17 +159,17 @@ const create = context => {
 	const functions = [];
 
 	return {
-		':function': () => {
+		':function'() {
 			functions.push(false);
 		},
-		JSXElement: () => {
+		JSXElement() {
 			// Turn off this rule if we see a JSX element because scope
 			// references does not include JSXElement nodes.
 			if (functions.length > 0) {
 				functions[functions.length - 1] = true;
 			}
 		},
-		':function:exit': node => {
+		':function:exit'(node) {
 			const currentFunctionHasJsx = functions.pop();
 			if (currentFunctionHasJsx) {
 				return;

package/rules/expiring-todo-comments.js

@@ -186,13 +186,13 @@ function parseTodoMessage(todoString) {
 	return afterArguments;
 }
 
-function reachedDate(past) {
-	const now = new Date().toISOString().slice(0, 10);
+function reachedDate(past, now) {
 	return Date.parse(past) < Date.parse(now);
 }
 
 function tryToCoerceVersion(rawVersion) {
-	/* istanbul ignore if: version in `package.json` and comment can't be empty */
+	// `version` in `package.json` and comment can't be empty
+	/* c8 ignore next 3 */
 	if (!rawVersion) {
 		return false;
 	}
@@ -215,12 +215,14 @@ function tryToCoerceVersion(rawVersion) {
 
 	// Get only the first member for cases such as `1.0.0 - 2.9999.9999`
 	const parts = version.split(' ');
-	/* istanbul ignore if: We don't have this `package.json` to test */
+	// We don't have this `package.json` to test
+	/* c8 ignore next 3 */
 	if (parts.length > 1) {
 		version = parts[0];
 	}
 
-	/* istanbul ignore if: We don't have this `package.json` to test */
+	// We don't have this `package.json` to test
+	/* c8 ignore next 3 */
 	if (semver.valid(version)) {
 		return version;
 	}
@@ -230,7 +232,8 @@ function tryToCoerceVersion(rawVersion) {
 		// But coerce can't parse pre-releases.
 		return semver.parse(version) || semver.coerce(version);
 	} catch {
-		/* istanbul ignore next: We don't have this `package.json` to test */
+		// We don't have this `package.json` to test
+		/* c8 ignore next 3 */
 		return false;
 	}
 }
@@ -249,6 +252,7 @@ const create = context => {
 		ignore: [],
 		ignoreDatesOnPullRequests: true,
 		allowWarningComments: true,
+		date: new Date().toISOString().slice(0, 10),
 		...context.options[0],
 	};
 
@@ -325,15 +329,15 @@ const create = context => {
 			});
 		} else if (dates.length === 1) {
 			uses++;
-			const [date] = dates;
+			const [expirationDate] = dates;
 
 			const shouldIgnore = options.ignoreDatesOnPullRequests && ci.isPR;
-			if (!shouldIgnore && reachedDate(date)) {
+			if (!shouldIgnore && reachedDate(expirationDate, options.date)) {
 				context.report({
 					loc: comment.loc,
 					messageId: MESSAGE_ID_EXPIRED_TODO,
 					data: {
-						expirationDate: date,
+						expirationDate,
 						message: parseTodoMessage(comment.value),
 					},
 				});
@@ -403,11 +407,12 @@ const create = context => {
 			const todoVersion = tryToCoerceVersion(dependency.version);
 			const targetPackageVersion = tryToCoerceVersion(targetPackageRawVersion);
 
-			/* istanbul ignore if: Can't test in Node.js */
+			/* c8 ignore start */
 			if (!hasTargetPackage || !targetPackageVersion) {
 				// Can't compare `¯\_(ツ)_/¯`
 				continue;
 			}
+			/* c8 ignore end */
 
 			const compare = semverComparisonForOperator(dependency.condition);
 
@@ -431,7 +436,7 @@ const create = context => {
 			const targetPackageRawEngineVersion = packageEngines.node;
 			const hasTargetEngine = Boolean(targetPackageRawEngineVersion);
 
-			/* istanbul ignore if: Can't test in this repo */
+			/* c8 ignore next 3 */
 			if (!hasTargetEngine) {
 				continue;
 			}
@@ -531,6 +536,10 @@ const schema = [
 				type: 'boolean',
 				default: false,
 			},
+			date: {
+				type: 'string',
+				format: 'date',
+			},
 		},
 	},
 ];

package/rules/filename-case.js

@@ -130,17 +130,7 @@ Turns `[a, b, c]` into `a, b, or c`.
 @param {string[]} words
 @returns {string}
 */
-function englishishJoinWords(words) {
-	if (words.length === 1) {
-		return words[0];
-	}
-
-	if (words.length === 2) {
-		return `${words[0]} or ${words[1]}`;
-	}
-
-	return `${words.slice(0, -1).join(', ')}, or ${words[words.length - 1]}`;
-}
+const englishishJoinWords = words => new Intl.ListFormat('en-US', {type: 'disjunction'}).format(words);
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {

package/rules/fix/append-argument.js

@@ -4,7 +4,7 @@ const {isCommaToken} = require('eslint-utils');
 function appendArgument(fixer, node, text, sourceCode) {
 	// This function should also work for `NewExpression`
 	// But parentheses of `NewExpression` could be omitted, add this check to prevent accident use on it
-	/* istanbul ignore next */
+	/* c8 ignore next 3 */
 	if (node.type !== 'CallExpression') {
 		throw new Error(`Unexpected node "${node.type}".`);
 	}

package/rules/fix/remove-argument.js

@@ -17,13 +17,14 @@ function removeArgument(fixer, node, sourceCode) {
 	}
 
 	// If the removed argument is the only argument, the trailing comma must be removed too
-	/* istanbul ignore next: Not reachable for now */
+	/* c8 ignore start */
 	if (callExpression.arguments.length === 1) {
 		const tokenAfter = sourceCode.getTokenBefore(lastToken);
 		if (isCommaToken(tokenAfter)) {
 			end = tokenAfter[1];
 		}
 	}
+	/* c8 ignore end */
 
 	return fixer.replaceTextRange([start, end], '');
 }