eslint-plugin-unicorn 26.0.1 → 28.0.2

package/index.js

@@ -55,6 +55,8 @@ module.exports = {
 				'unicorn/new-for-builtins': 'error',
 				'unicorn/no-abusive-eslint-disable': 'error',
 				'unicorn/no-array-callback-reference': 'error',
+				'unicorn/no-array-for-each': 'error',
+				'unicorn/no-array-push-push': 'error',
 				'unicorn/no-array-reduce': 'error',
 				'unicorn/no-console-spaces': 'error',
 				'unicorn/no-for-loop': 'error',
@@ -69,6 +71,7 @@ module.exports = {
 				'unicorn/no-null': 'error',
 				'unicorn/no-object-as-default-parameter': 'error',
 				'unicorn/no-process-exit': 'error',
+				'unicorn/no-this-assignment': 'error',
 				'unicorn/no-unreadable-array-destructuring': 'error',
 				'unicorn/no-unsafe-regex': 'off',
 				'unicorn/no-unused-properties': 'off',

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "eslint-plugin-unicorn",
-	"version": "26.0.1",
+	"version": "28.0.2",
 	"description": "Various awesome ESLint rules",
 	"license": "MIT",
 	"repository": "sindresorhus/eslint-plugin-unicorn",
@@ -16,7 +16,7 @@
 	"scripts": {
 		"test": "xo && nyc ava",
 		"create-rule": "node ./scripts/create-rule.js",
-		"lint": "node ./test/lint/lint.js",
+		"run-rules-on-codebase": "node ./test/run-rules-on-codebase/lint.js",
 		"integration": "node ./test/integration/test.js",
 		"smoke": "eslint-remote-tester --config ./test/smoke/eslint-remote-tester.config.js"
 	},
@@ -37,21 +37,23 @@
 	"dependencies": {
 		"ci-info": "^2.0.0",
 		"clean-regexp": "^1.0.0",
-		"eslint-ast-utils": "^1.1.0",
 		"eslint-template-visitor": "^2.2.2",
 		"eslint-utils": "^2.1.0",
+		"eslint-visitor-keys": "^2.0.0",
 		"import-modules": "^2.1.0",
 		"lodash": "^4.17.20",
 		"pluralize": "^8.0.0",
 		"read-pkg-up": "^7.0.1",
-		"regexp-tree": "^0.1.21",
+		"regexp-tree": "^0.1.22",
 		"reserved-words": "^0.1.2",
 		"safe-regex": "^2.1.1",
 		"semver": "^7.3.4"
 	},
 	"devDependencies": {
 		"@ava/babel": "^1.0.1",
-		"@babel/code-frame": "7.12.11",
+		"@babel/code-frame": "7.12.13",
+		"@babel/core": "7.12.10",
+		"@babel/eslint-parser": "7.12.1",
 		"@lubien/fixture-beta-package": "^1.0.0-beta.1",
 		"@typescript-eslint/parser": "^4.12.0",
 		"ava": "^3.15.0",
@@ -61,7 +63,7 @@
 		"eslint": "^7.15.0",
 		"eslint-ava-rule-tester": "^4.0.0",
 		"eslint-plugin-eslint-plugin": "^2.3.0",
-		"eslint-remote-tester": "^0.4.0",
+		"eslint-remote-tester": "^1.1.0",
 		"execa": "^5.0.0",
 		"listr": "^0.14.3",
 		"mem": "8.0.0",
@@ -98,7 +100,7 @@
 			"plugin:eslint-plugin/all"
 		],
 		"ignores": [
-			"test/integration/{fixtures,unicorn}/**",
+			"test/integration/{fixtures,fixtures-local}/**",
 			".cache-eslint-remote-tester",
 			"eslint-remote-tester-results"
 		],

package/readme.md

@@ -1,4 +1,4 @@
-# eslint-plugin-unicorn [![Coverage Status](https://codecov.io/gh/sindresorhus/eslint-plugin-unicorn/branch/master/graph/badge.svg)](https://codecov.io/gh/sindresorhus/eslint-plugin-unicorn/branch/master)
+# eslint-plugin-unicorn [![Coverage Status](https://codecov.io/gh/sindresorhus/eslint-plugin-unicorn/branch/main/graph/badge.svg)](https://codecov.io/gh/sindresorhus/eslint-plugin-unicorn/branch/main)
 
 <img src="https://cloud.githubusercontent.com/assets/170270/18659176/1cc373d0-7f33-11e6-890f-0ba35362ee7e.jpg" width="180" align="right">
 
@@ -49,6 +49,8 @@ Configure it in `package.json`.
 			"unicorn/new-for-builtins": "error",
 			"unicorn/no-abusive-eslint-disable": "error",
 			"unicorn/no-array-callback-reference": "error",
+			"unicorn/no-array-for-each": "error",
+			"unicorn/no-array-push-push": "error",
 			"unicorn/no-array-reduce": "error",
 			"unicorn/no-console-spaces": "error",
 			"unicorn/no-for-loop": "error",
@@ -63,6 +65,7 @@ Configure it in `package.json`.
 			"unicorn/no-null": "error",
 			"unicorn/no-object-as-default-parameter": "error",
 			"unicorn/no-process-exit": "error",
+			"unicorn/no-this-assignment": "error",
 			"unicorn/no-unreadable-array-destructuring": "error",
 			"unicorn/no-unsafe-regex": "off",
 			"unicorn/no-unused-properties": "off",
@@ -125,6 +128,8 @@ Configure it in `package.json`.
 - [new-for-builtins](docs/rules/new-for-builtins.md) - Enforce the use of `new` for all builtins, except `String`, `Number`, `Boolean`, `Symbol` and `BigInt`. *(partly fixable)*
 - [no-abusive-eslint-disable](docs/rules/no-abusive-eslint-disable.md) - Enforce specifying rules to disable in `eslint-disable` comments.
 - [no-array-callback-reference](docs/rules/no-array-callback-reference.md) - Prevent passing a function reference directly to iterator methods.
+- [no-array-for-each](docs/rules/no-array-for-each.md) - Prefer `for…of` over `Array#forEach(…)`. *(partly fixable)*
+- [no-array-push-push](docs/rules/no-array-push-push.md) - Enforce combining multiple `Array#push()` into one call. *(partly fixable)*
 - [no-array-reduce](docs/rules/no-array-reduce.md) - Disallow `Array#reduce()` and `Array#reduceRight()`.
 - [no-console-spaces](docs/rules/no-console-spaces.md) - Do not use leading/trailing space between `console.log` parameters. *(fixable)*
 - [no-for-loop](docs/rules/no-for-loop.md) - Do not use a `for` loop that can be replaced with a `for-of` loop. *(partly fixable)*
@@ -134,11 +139,12 @@ Configure it in `package.json`.
 - [no-lonely-if](docs/rules/no-lonely-if.md) - Disallow `if` statements as the only statement in `if` blocks without `else`. *(fixable)*
 - [no-nested-ternary](docs/rules/no-nested-ternary.md) - Disallow nested ternary expressions. *(partly fixable)*
 - [no-new-array](docs/rules/no-new-array.md) - Disallow `new Array()`. *(partly fixable)*
-- [no-new-buffer](docs/rules/no-new-buffer.md) - Enforce the use of `Buffer.from()` and `Buffer.alloc()` instead of the deprecated `new Buffer()`. *(fixable)*
+- [no-new-buffer](docs/rules/no-new-buffer.md) - Enforce the use of `Buffer.from()` and `Buffer.alloc()` instead of the deprecated `new Buffer()`. *(partly fixable)*
 - [no-null](docs/rules/no-null.md) - Disallow the use of the `null` literal.
 - [no-object-as-default-parameter](docs/rules/no-object-as-default-parameter.md) - Disallow the use of objects as default parameters.
 - [no-process-exit](docs/rules/no-process-exit.md) - Disallow `process.exit()`.
-- [no-unreadable-array-destructuring](docs/rules/no-unreadable-array-destructuring.md) - Disallow unreadable array destructuring.
+- [no-this-assignment](docs/rules/no-this-assignment.md) - Disallow assigning `this` to a variable.
+- [no-unreadable-array-destructuring](docs/rules/no-unreadable-array-destructuring.md) - Disallow unreadable array destructuring. *(partly fixable)*
 - [no-unsafe-regex](docs/rules/no-unsafe-regex.md) - Disallow unsafe regular expressions.
 - [no-unused-properties](docs/rules/no-unused-properties.md) - Disallow unused object properties.
 - [no-useless-undefined](docs/rules/no-useless-undefined.md) - Disallow useless `undefined`. *(fixable)*
@@ -156,7 +162,7 @@ Configure it in `package.json`.
 - [prefer-dom-node-dataset](docs/rules/prefer-dom-node-dataset.md) - Prefer using `.dataset` on DOM elements over `.setAttribute(…)`. *(fixable)*
 - [prefer-dom-node-remove](docs/rules/prefer-dom-node-remove.md) - Prefer `childNode.remove()` over `parentNode.removeChild(childNode)`. *(fixable)*
 - [prefer-dom-node-text-content](docs/rules/prefer-dom-node-text-content.md) - Prefer `.textContent` over `.innerText`. *(fixable)*
-- [prefer-includes](docs/rules/prefer-includes.md) - Prefer `.includes()` over `.indexOf()` when checking for existence or non-existence. *(fixable)*
+- [prefer-includes](docs/rules/prefer-includes.md) - Prefer `.includes()` over `.indexOf()` and `Array#some()` when checking for existence or non-existence. *(partly fixable)*
 - [prefer-keyboard-event-key](docs/rules/prefer-keyboard-event-key.md) - Prefer `KeyboardEvent#key` over `KeyboardEvent#keyCode`. *(partly fixable)*
 - [prefer-math-trunc](docs/rules/prefer-math-trunc.md) - Enforce the use of `Math.trunc` instead of bitwise operators. *(partly fixable)*
 - [prefer-modern-dom-apis](docs/rules/prefer-modern-dom-apis.md) - Prefer `.before()` over `.insertBefore()`, `.replaceWith()` over `.replaceChild()`, prefer one of `.before()`, `.after()`, `.append()` or `.prepend()` over `insertAdjacentText()` and `insertAdjacentElement()`. *(fixable)*
@@ -167,7 +173,7 @@ Configure it in `package.json`.
 - [prefer-reflect-apply](docs/rules/prefer-reflect-apply.md) - Prefer `Reflect.apply()` over `Function#apply()`. *(fixable)*
 - [prefer-regexp-test](docs/rules/prefer-regexp-test.md) - Prefer `RegExp#test()` over `String#match()` and `RegExp#exec()`. *(fixable)*
 - [prefer-set-has](docs/rules/prefer-set-has.md) - Prefer `Set#has()` over `Array#includes()` when checking for existence or non-existence. *(fixable)*
-- [prefer-spread](docs/rules/prefer-spread.md) - Prefer the spread operator over `Array.from()`. *(fixable)*
+- [prefer-spread](docs/rules/prefer-spread.md) - Prefer the spread operator over `Array.from()` and `Array#concat()`. *(partly fixable)*
 - [prefer-string-replace-all](docs/rules/prefer-string-replace-all.md) - Prefer `String#replaceAll()` over regex searches with the global flag. *(fixable)*
 - [prefer-string-slice](docs/rules/prefer-string-slice.md) - Prefer `String#slice()` over `String#substr()` and `String#substring()`. *(partly fixable)*
 - [prefer-string-starts-ends-with](docs/rules/prefer-string-starts-ends-with.md) - Prefer `String#startsWith()` & `String#endsWith()` over `RegExp#test()`. *(fixable)*

package/rules/catch-error-name.js

@@ -69,6 +69,13 @@ const create = context => {
 		const scope = context.getScope();
 		const variable = findVariable(scope, node);
 
+		// This was reported https://github.com/sindresorhus/eslint-plugin-unicorn/issues/1075#issuecomment-768072967
+		// But can't reproduce, just ignore this case
+		/* istanbul ignore next */
+		if (!variable) {
+			return;
+		}
+
 		if (originalName === '_' && variable.references.length === 0) {
 			return;
 		}

package/rules/consistent-destructuring.js

@@ -92,7 +92,10 @@ const create = context => {
 				property.value.type === 'Identifier'
 			);
 			const lastProperty = objectPattern.properties[objectPattern.properties.length - 1];
-			const hasRest = lastProperty && lastProperty.type === 'RestElement';
+
+			// TODO: Remove `ExperimentalRestProperty` check when we drop support for `babel-eslint` #1040
+			const hasRest = lastProperty &&
+				(lastProperty.type === 'RestElement' || lastProperty.type === 'ExperimentalRestProperty');
 
 			const expression = source.getText(node);
 			const member = source.getText(node.property);

package/rules/new-for-builtins.js

@@ -2,6 +2,7 @@
 const getDocumentationUrl = require('./utils/get-documentation-url');
 const builtins = require('./utils/builtins');
 const isShadowed = require('./utils/is-shadowed');
+const switchNewExpressionToCallExpression = require('./utils/switch-new-expression-to-call-expression');
 
 const messages = {
 	enforce: 'Use `new {{name}}()` instead of `{{name}}()`.',
@@ -12,6 +13,8 @@ const enforceNew = new Set(builtins.enforceNew);
 const disallowNew = new Set(builtins.disallowNew);
 
 const create = context => {
+	const sourceCode = context.getSourceCode();
+
 	return {
 		CallExpression: node => {
 			const {callee, parent} = node;
@@ -37,8 +40,8 @@ const create = context => {
 			}
 		},
 		NewExpression: node => {
-			const {callee, range} = node;
-			const {name, range: calleeRange} = callee;
+			const {callee} = node;
+			const {name} = callee;
 
 			if (disallowNew.has(name) && !isShadowed(context.getScope(), callee)) {
 				const problem = {
@@ -48,10 +51,9 @@ const create = context => {
 				};
 
 				if (name !== 'String' && name !== 'Boolean' && name !== 'Number') {
-					problem.fix = fixer => fixer.removeRange([
-						range[0],
-						calleeRange[0]
-					]);
+					problem.fix = function * (fixer) {
+						yield * switchNewExpressionToCallExpression(node, sourceCode, fixer);
+					};
 				}
 
 				context.report(problem);

package/rules/no-array-callback-reference.js

@@ -3,6 +3,7 @@ const {isParenthesized} = require('eslint-utils');
 const getDocumentationUrl = require('./utils/get-documentation-url');
 const methodSelector = require('./utils/method-selector');
 const {notFunctionSelector} = require('./utils/not-function');
+const isNodeMatches = require('./utils/is-node-matches');
 
 const ERROR_WITH_NAME_MESSAGE_ID = 'error-with-name';
 const ERROR_WITHOUT_NAME_MESSAGE_ID = 'error-without-name';
@@ -25,7 +26,11 @@ const iteratorMethods = [
 	['find'],
 	['findIndex'],
 	['flatMap'],
-	['forEach'],
+	[
+		'forEach', {
+			returnsUndefined: true
+		}
+	],
 	['map'],
 	[
 		'reduce', {
@@ -58,14 +63,16 @@ const iteratorMethods = [
 		ignore: ['Boolean'],
 		minParameters: 1,
 		extraSelector: '',
+		returnsUndefined: false,
 		...options
 	};
 	return [method, options];
 });
 
 const ignoredCallee = [
+	// http://bluebirdjs.com/docs/api/promise.map.html
 	'Promise',
-	'React.children',
+	'React.Children',
 	'Children',
 	'lodash',
 	'underscore',
@@ -74,18 +81,6 @@ const ignoredCallee = [
 	'async'
 ];
 
-const toSelector = name => {
-	const splitted = name.split('.');
-	return `[callee.${'object.'.repeat(splitted.length)}name!="${splitted.shift()}"]`;
-};
-
-// Select all the call expressions except the ones present in the ignore list.
-const ignoredCalleeSelector = [
-	// `this.{map, filter, …}()`
-	'[callee.object.type!="ThisExpression"]',
-	...ignoredCallee.map(name => toSelector(name))
-].join('');
-
 function check(context, node, method, options) {
 	const {type} = node;
 
@@ -105,7 +100,7 @@ function check(context, node, method, options) {
 		suggest: []
 	};
 
-	const {parameters, minParameters} = options;
+	const {parameters, minParameters, returnsUndefined} = options;
 	for (let parameterLength = minParameters; parameterLength <= parameters.length; parameterLength++) {
 		const suggestionParameters = parameters.slice(0, parameterLength).join(', ');
 
@@ -124,7 +119,9 @@ function check(context, node, method, options) {
 
 				return fixer.replaceText(
 					node,
-					`(${suggestionParameters}) => ${nodeText}(${suggestionParameters})`
+					returnsUndefined ?
+						`(${suggestionParameters}) => { ${nodeText}(${suggestionParameters}); }` :
+						`(${suggestionParameters}) => ${nodeText}(${suggestionParameters})`
 				);
 			}
 		};
@@ -154,11 +151,17 @@ const create = context => {
 				max: 2
 			}),
 			options.extraSelector,
-			ignoredCalleeSelector,
 			ignoredFirstArgumentSelector
 		].join('');
 
 		rules[selector] = node => {
+			if (
+				isNodeMatches(node.callee.object, ignoredCallee) ||
+				node.callee.object.type === 'ThisExpression'
+			) {
+				return;
+			}
+
 			const [iterator] = node.arguments;
 			check(context, iterator, method, options, sourceCode);
 		};