eslint-plugin-ts-data-forge 0.9.0 → 0.10.1

package/dist/rules/prefer-pipe-map-nullable.mjs

@@ -0,0 +1,266 @@
+import { AST_NODE_TYPES, } from '@typescript-eslint/utils';
+import { buildCalleeResolver, getArgumentText, getImportDeclarations, hasForeignBinding, isTypeWrapper, skipTypeWrappers, } from 'eslint-rule-forge';
+import { Arr } from 'ts-data-forge';
+import * as ts from 'typescript';
+import { TS_DATA_FORGE_MODULE } from './constants.mjs';
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+export const preferPipeMapNullable = {
+    meta: {
+        type: 'suggestion',
+        docs: {
+            description: 'Replace `pipe(x).map(mapNullable(fn))` with `pipe(x).mapNullable(fn)`.',
+        },
+        fixable: 'code',
+        hasSuggestions: true,
+        schema: [],
+        messages: {
+            useMapNullable: 'Replace `.map({{mapNullableName}}(…))` with `.mapNullable(…)`.',
+            suggestMapNullable: 'Replace `.map({{mapNullableName}}(…))` with `.mapNullable(…)` (the inferred type may be widened, or a comment or type assertion dropped).',
+        },
+    },
+    create: (context) => {
+        const sourceCode = context.sourceCode;
+        const program = sourceCode.ast;
+        const resolveTsDataForge = buildCalleeResolver(getImportDeclarations(program, TS_DATA_FORGE_MODULE));
+        const pipeResolvers = PIPE_MODULES.map((moduleName) => [
+            moduleName,
+            buildCalleeResolver(getImportDeclarations(program, moduleName)),
+        ]);
+        const services = sourceCode.parserServices;
+        const checker = services?.program?.getTypeChecker();
+        const esTreeNodeToTSNodeMap = services?.esTreeNodeToTSNodeMap;
+
+
+
+
+        const calls = (resolve, 
+
+        callee, name, moduleName) => {
+            if (resolve(callee)?.canonicalName !== name) {
+                return false;
+            }
+            const unwrapped = skipTypeWrappers(callee);
+
+            const binding = unwrapped.type === AST_NODE_TYPES.MemberExpression
+                ? skipTypeWrappers(unwrapped.object)
+                : unwrapped;
+            return (binding.type === AST_NODE_TYPES.Identifier &&
+                !hasForeignBinding(sourceCode, binding, binding.name, moduleName));
+        };
+
+
+
+
+        const isPipe = (
+
+        wrapped) => {
+            const node = skipTypeWrappers(wrapped);
+            if (node.type !== AST_NODE_TYPES.CallExpression || node.optional) {
+                return false;
+            }
+            if (pipeResolvers.some(([moduleName, resolve]) => calls(resolve, node.callee, 'pipe', moduleName))) {
+                return true;
+            }
+            const { callee } = node;
+            return (callee.type === AST_NODE_TYPES.MemberExpression &&
+                !callee.computed &&
+                !callee.optional &&
+                callee.property.type === AST_NODE_TYPES.Identifier &&
+                PIPE_CHAIN_METHODS.has(callee.property.name) &&
+                isPipe(callee.object));
+        };
+
+
+
+
+        const keepsResultType = (
+
+        mapNullableCall, 
+
+        mapFn) => {
+
+            const fn = skipSatisfies(mapFn);
+            if ((fn.type !== AST_NODE_TYPES.ArrowFunctionExpression &&
+                fn.type !== AST_NODE_TYPES.FunctionExpression) ||
+                fn.returnType !== undefined) {
+
+                return true;
+            }
+            if (checker === undefined || esTreeNodeToTSNodeMap === undefined) {
+                return false;
+            }
+
+
+
+
+            const signatures = checker
+                .getTypeAtLocation(esTreeNodeToTSNodeMap.get(mapNullableCall))
+                .getCallSignatures();
+            return (Arr.isFixedLengthTuple(1, signatures) &&
+                !hasConstInferredPart(checker, checker.getReturnTypeOfSignature(signatures[0]), 0));
+        };
+        return {
+            CallExpression: (node) => {
+
+                if (node.optional ||
+                    node.typeArguments !== undefined ||
+                    node.callee.type !== AST_NODE_TYPES.MemberExpression ||
+                    node.callee.computed ||
+                    node.callee.optional ||
+                    node.callee.property.type !== AST_NODE_TYPES.Identifier ||
+                    node.callee.property.name !== 'map' ||
+                    !Arr.isFixedLengthTuple(1, node.arguments)) {
+                    return;
+                }
+                const mapNullableCall = node.arguments[0];
+                if (mapNullableCall.type !== AST_NODE_TYPES.CallExpression ||
+                    mapNullableCall.optional ||
+
+
+                    mapNullableCall.typeArguments !== undefined ||
+
+
+                    !Arr.isFixedLengthTuple(1, mapNullableCall.arguments)) {
+                    return;
+                }
+                const mapFn = mapNullableCall.arguments[0];
+                if (mapFn.type === AST_NODE_TYPES.SpreadElement ||
+                    !calls(resolveTsDataForge, mapNullableCall.callee, 'mapNullable', TS_DATA_FORGE_MODULE) ||
+                    !isPipe(node.callee.object)) {
+                    return;
+                }
+
+                const droppedRanges = [
+                    [mapNullableCall.range[0], mapFn.range[0]],
+                    [mapFn.range[1], mapNullableCall.range[1]],
+                ];
+                const dropsComment = sourceCode
+                    .getCommentsInside(mapNullableCall)
+                    .some((comment) => droppedRanges.some(([start, end]) => start <= comment.range[0] && comment.range[1] <= end));
+                const autofixable = !dropsComment &&
+                    !isTypeWrapper(mapNullableCall.callee) &&
+                    keepsResultType(mapNullableCall, mapFn);
+                const mapProperty = node.callee.property;
+                const fix = (fixer) => [
+                    fixer.replaceText(mapProperty, 'mapNullable'),
+                    fixer.replaceText(mapNullableCall, getArgumentText(sourceCode, mapFn)),
+                ];
+                const data = {
+                    mapNullableName: sourceCode.getText(mapNullableCall.callee),
+                };
+                if (autofixable) {
+                    context.report({
+                        node,
+                        messageId: 'useMapNullable',
+                        data,
+                        fix,
+                    });
+                }
+                else {
+                    context.report({
+                        node,
+                        messageId: 'useMapNullable',
+                        data,
+                        suggest: [{ messageId: 'suggestMapNullable', data, fix }],
+                    });
+                }
+            },
+        };
+    },
+    defaultOptions: [],
+};
+
+
+
+
+
+const PIPE_MODULES = [TS_DATA_FORGE_MODULE, 'ts-std-forge'];
+
+const PIPE_CHAIN_METHODS = new Set([
+    'map',
+    'mapNullable',
+    'mapOptional',
+]);
+
+const literalTypeFlags = ts.TypeFlags.StringLiteral |
+    ts.TypeFlags.NumberLiteral |
+    ts.TypeFlags.BigIntLiteral |
+    ts.TypeFlags.BooleanLiteral |
+    ts.TypeFlags.EnumLiteral |
+    ts.TypeFlags.TemplateLiteral |
+    ts.TypeFlags.UniqueESSymbol;
+
+const MAX_DEPTH = 4;
+
+
+
+
+
+
+
+
+const hasConstInferredPart = (
+
+checker, 
+
+type, depth) => {
+    if (depth > MAX_DEPTH) {
+        return true;
+    }
+
+    if ((type.flags & ts.TypeFlags.Boolean) !== 0) {
+        return false;
+    }
+    if (type.isUnion() || type.isIntersection()) {
+        return type.types.some((t) => hasConstInferredPart(checker, t, depth + 1));
+    }
+    if ((type.flags & literalTypeFlags) !== 0 || checker.isTupleType(type)) {
+        return true;
+    }
+    if ((type.flags & ts.TypeFlags.Object) === 0) {
+        return false;
+    }
+
+    const { objectFlags } = type;
+
+    if ((objectFlags & ts.ObjectFlags.Reference) !== 0 &&
+        checker
+
+            .getTypeArguments(type)
+            .some((t) => hasConstInferredPart(checker, t, depth + 1))) {
+        return true;
+    }
+    return (
+
+
+    (objectFlags &
+        (ts.ObjectFlags.ObjectLiteral | ts.ObjectFlags.Anonymous)) !==
+        0 &&
+        type
+            .getProperties()
+            .some((property) => hasConstInferredPart(checker, checker.getTypeOfSymbol(property), depth + 1)));
+};
+
+const skipSatisfies = (
+
+node) => node.type === AST_NODE_TYPES.TSSatisfiesExpression
+    ? skipSatisfies(node.expression)
+    : node;
+//# sourceMappingURL=prefer-pipe-map-nullable.mjs.map

package/dist/rules/prefer-pipe-map-nullable.mjs.map

@@ -0,0 +1 @@
+{"version":3,"file":"prefer-pipe-map-nullable.mjs","sourceRoot":"","sources":["../../src/rules/prefer-pipe-map-nullable.mts"],"names":[],"mappings":"AAAA,OAAO,EACL,cAAc,GAGf,MAAM,0BAA0B,CAAC;AAClC,OAAO,EACL,mBAAmB,EACnB,eAAe,EACf,qBAAqB,EACrB,iBAAiB,EACjB,aAAa,EACb,gBAAgB,GACjB,MAAM,mBAAmB,CAAC;AAC3B,OAAO,EAAE,GAAG,EAAE,MAAM,eAAe,CAAC;AACpC,OAAO,KAAK,EAAE,MAAM,YAAY,CAAC;AACjC,OAAO,EAAE,oBAAoB,EAAE,MAAM,iBAAiB,CAAC;AAMvD;;;;;;;;;;;;;;;;;GAiBG;AACH,MAAM,CAAC,MAAM,qBAAqB,GAA6C;IAC7E,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,IAAI,EAAE;YACJ,WAAW,EACT,wEAAwE;SAC3E;QACD,OAAO,EAAE,MAAM;QACf,cAAc,EAAE,IAAI;QACpB,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,cAAc,EACZ,gEAAgE;YAClE,kBAAkB,EAChB,2IAA2I;SAC9I;KACF;IAED,MAAM,EAAE,CAAC,OAAO,EAAE,EAAE;QAClB,MAAM,UAAU,GAAG,OAAO,CAAC,UAAU,CAAC;QAEtC,MAAM,OAAO,GAAG,UAAU,CAAC,GAAG,CAAC;QAE/B,MAAM,kBAAkB,GAAG,mBAAmB,CAC5C,qBAAqB,CAAC,OAAO,EAAE,oBAAoB,CAAC,CACrD,CAAC;QAEF,MAAM,aAAa,GAAG,YAAY,CAAC,GAAG,CACpC,CAAC,UAAU,EAAE,EAAE,CACb;YACE,UAAU;YACV,mBAAmB,CAAC,qBAAqB,CAAC,OAAO,EAAE,UAAU,CAAC,CAAC;SACvD,CACb,CAAC;QAEF,MAAM,QAAQ,GAAG,UAAU,CAAC,cAAc,CAAC;QAE3C,MAAM,OAAO,GAAG,QAAQ,EAAE,OAAO,EAAE,cAAc,EAAE,CAAC;QAEpD,MAAM,qBAAqB,GAAG,QAAQ,EAAE,qBAAqB,CAAC;QAE9D;;;WAGG;QACH,MAAM,KAAK,GAAG,CACZ,OAA+C;QAC/C,8EAA8E;QAC9E,MAA2B,EAC3B,IAAY,EACZ,UAAkB,EACT,EAAE;YACX,IAAI,OAAO,CAAC,MAAM,CAAC,EAAE,aAAa,KAAK,IAAI,EAAE,CAAC;gBAC5C,OAAO,KAAK,CAAC;YACf,CAAC;YAED,MAAM,SAAS,GAAG,gBAAgB,CAAC,MAAM,CAAC,CAAC;YAE3C,sDAAsD;YACtD,MAAM,OAAO,GACX,SAAS,CAAC,IAAI,KAAK,cAAc,CAAC,gBAAgB;gBAChD,CAAC,CAAC,gBAAgB,CAAC,SAAS,CAAC,MAAM,CAAC;gBACpC,CAAC,CAAC,SAAS,CAAC;YAEhB,OAAO,CACL,OAAO,CAAC,IAAI,KAAK,cAAc,CAAC,UAAU;gBAC1C,CAAC,iBAAiB,CAAC,UAAU,EAAE,OAAO,EAAE,OAAO,CAAC,IAAI,EAAE,UAAU,CAAC,CAClE,CAAC;QACJ,CAAC,CAAC;QAEF;;;WAGG;QACH,MAAM,MAAM,GAAG;QACb,8EAA8E;QAC9E,OAAsB,EACb,EAAE;YACX,MAAM,IAAI,GAAG,gBAAgB,CAAC,OAAO,CAAC,CAAC;YAEvC,IAAI,IAAI,CAAC,IAAI,KAAK,cAAc,CAAC,cAAc,IAAI,IAAI,CAAC,QAAQ,EAAE,CAAC;gBACjE,OAAO,KAAK,CAAC;YACf,CAAC;YAED,IACE,aAAa,CAAC,IAAI,CAAC,CAAC,CAAC,UAAU,EAAE,OAAO,CAAC,EAAE,EAAE,CAC3C,KAAK,CAAC,OAAO,EAAE,IAAI,CAAC,MAAM,EAAE,MAAM,EAAE,UAAU,CAAC,CAChD,EACD,CAAC;gBACD,OAAO,IAAI,CAAC;YACd,CAAC;YAED,MAAM,EAAE,MAAM,EAAE,GAAG,IAAI,CAAC;YAExB,OAAO,CACL,MAAM,CAAC,IAAI,KAAK,cAAc,CAAC,gBAAgB;gBAC/C,CAAC,MAAM,CAAC,QAAQ;gBAChB,CAAC,MAAM,CAAC,QAAQ;gBAChB,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,cAAc,CAAC,UAAU;gBAClD,kBAAkB,CAAC,GAAG,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,CAAC;gBAC5C,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CACtB,CAAC;QACJ,CAAC,CAAC;QAEF;;;WAGG;QACH,MAAM,eAAe,GAAG;QACtB,8EAA8E;QAC9E,eAAwC;QACxC,8EAA8E;QAC9E,KAA0B,EACjB,EAAE;YACX,2DAA2D;YAC3D,MAAM,EAAE,GAAG,aAAa,CAAC,KAAK,CAAC,CAAC;YAEhC,IACE,CAAC,EAAE,CAAC,IAAI,KAAK,cAAc,CAAC,uBAAuB;gBACjD,EAAE,CAAC,IAAI,KAAK,cAAc,CAAC,kBAAkB,CAAC;gBAChD,EAAE,CAAC,UAAU,KAAK,SAAS,EAC3B,CAAC;gBACD,yDAAyD;gBACzD,OAAO,IAAI,CAAC;YACd,CAAC;YAED,IAAI,OAAO,KAAK,SAAS,IAAI,qBAAqB,KAAK,SAAS,EAAE,CAAC;gBACjE,OAAO,KAAK,CAAC;YACf,CAAC;YAED,sEAAsE;YACtE,qEAAqE;YACrE,qEAAqE;YACrE,2DAA2D;YAC3D,MAAM,UAAU,GAAG,OAAO;iBACvB,iBAAiB,CAAC,qBAAqB,CAAC,GAAG,CAAC,eAAe,CAAC,CAAC;iBAC7D,iBAAiB,EAAE,CAAC;YAEvB,OAAO,CACL,GAAG,CAAC,kBAAkB,CAAC,CAAC,EAAE,UAAU,CAAC;gBACrC,CAAC,oBAAoB,CACnB,OAAO,EACP,OAAO,CAAC,wBAAwB,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,EAC/C,CAAC,CACF,CACF,CAAC;QACJ,CAAC,CAAC;QAEF,OAAO;YACL,cAAc,EAAE,CAAC,IAAI,EAAE,EAAE;gBACvB,8BAA8B;gBAC9B,IACE,IAAI,CAAC,QAAQ;oBACb,IAAI,CAAC,aAAa,KAAK,SAAS;oBAChC,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,cAAc,CAAC,gBAAgB;oBACpD,IAAI,CAAC,MAAM,CAAC,QAAQ;oBACpB,IAAI,CAAC,MAAM,CAAC,QAAQ;oBACpB,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,cAAc,CAAC,UAAU;oBACvD,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,KAAK;oBACnC,CAAC,GAAG,CAAC,kBAAkB,CAAC,CAAC,EAAE,IAAI,CAAC,SAAS,CAAC,EAC1C,CAAC;oBACD,OAAO;gBACT,CAAC;gBAED,MAAM,eAAe,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;gBAE1C,IACE,eAAe,CAAC,IAAI,KAAK,cAAc,CAAC,cAAc;oBACtD,eAAe,CAAC,QAAQ;oBACxB,kEAAkE;oBAClE,aAAa;oBACb,eAAe,CAAC,aAAa,KAAK,SAAS;oBAC3C,mEAAmE;oBACnE,uCAAuC;oBACvC,CAAC,GAAG,CAAC,kBAAkB,CAAC,CAAC,EAAE,eAAe,CAAC,SAAS,CAAC,EACrD,CAAC;oBACD,OAAO;gBACT,CAAC;gBAED,MAAM,KAAK,GAAG,eAAe,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;gBAE3C,IACE,KAAK,CAAC,IAAI,KAAK,cAAc,CAAC,aAAa;oBAC3C,CAAC,KAAK,CACJ,kBAAkB,EAClB,eAAe,CAAC,MAAM,EACtB,aAAa,EACb,oBAAoB,CACrB;oBACD,CAAC,MAAM,CAAC,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,EAC3B,CAAC;oBACD,OAAO;gBACT,CAAC;gBAED,kEAAkE;gBAClE,MAAM,aAAa,GAAG;oBACpB,CAAC,eAAe,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,KAAK,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;oBAC1C,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,eAAe,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC;iBAClC,CAAC;gBAEX,MAAM,YAAY,GAAG,UAAU;qBAC5B,iBAAiB,CAAC,eAAe,CAAC;qBAClC,IAAI,CAAC,CAAC,OAAO,EAAE,EAAE,CAChB,aAAa,CAAC,IAAI,CAChB,CAAC,CAAC,KAAK,EAAE,GAAG,CAAC,EAAE,EAAE,CACf,KAAK,IAAI,OAAO,CAAC,KAAK,CAAC,CAAC,CAAC,IAAI,OAAO,CAAC,KAAK,CAAC,CAAC,CAAC,IAAI,GAAG,CACvD,CACF,CAAC;gBAEJ,MAAM,WAAW,GACf,CAAC,YAAY;oBACb,CAAC,aAAa,CAAC,eAAe,CAAC,MAAM,CAAC;oBACtC,eAAe,CAAC,eAAe,EAAE,KAAK,CAAC,CAAC;gBAE1C,MAAM,WAAW,GAAG,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC;gBAEzC,MAAM,GAAG,GAA+B,CAAC,KAAK,EAAE,EAAE,CAAC;oBACjD,KAAK,CAAC,WAAW,CAAC,WAAW,EAAE,aAAa,CAAC;oBAC7C,KAAK,CAAC,WAAW,CACf,eAAe,EACf,eAAe,CAAC,UAAU,EAAE,KAAK,CAAC,CACnC;iBACF,CAAC;gBAEF,MAAM,IAAI,GAAG;oBACX,eAAe,EAAE,UAAU,CAAC,OAAO,CAAC,eAAe,CAAC,MAAM,CAAC;iBACnD,CAAC;gBAEX,IAAI,WAAW,EAAE,CAAC;oBAChB,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI;wBACJ,SAAS,EAAE,gBAAgB;wBAC3B,IAAI;wBACJ,GAAG;qBACJ,CAAC,CAAC;gBACL,CAAC;qBAAM,CAAC;oBACN,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI;wBACJ,SAAS,EAAE,gBAAgB;wBAC3B,IAAI;wBACJ,OAAO,EAAE,CAAC,EAAE,SAAS,EAAE,oBAAoB,EAAE,IAAI,EAAE,GAAG,EAAE,CAAC;qBAC1D,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;IACD,cAAc,EAAE,EAAE;CACV,CAAC;AAEX;;;;GAIG;AACH,MAAM,YAAY,GAAG,CAAC,oBAAoB,EAAE,cAAc,CAAU,CAAC;AAErE,0DAA0D;AAC1D,MAAM,kBAAkB,GAAwB,IAAI,GAAG,CAAC;IACtD,KAAK;IACL,aAAa;IACb,aAAa;CACd,CAAC,CAAC;AAEH,kFAAkF;AAClF,MAAM,gBAAgB,GACpB,EAAE,CAAC,SAAS,CAAC,aAAa;IAC1B,EAAE,CAAC,SAAS,CAAC,aAAa;IAC1B,EAAE,CAAC,SAAS,CAAC,aAAa;IAC1B,EAAE,CAAC,SAAS,CAAC,cAAc;IAC3B,EAAE,CAAC,SAAS,CAAC,WAAW;IACxB,EAAE,CAAC,SAAS,CAAC,eAAe;IAC5B,EAAE,CAAC,SAAS,CAAC,cAAc,CAAC;AAE9B,2EAA2E;AAC3E,MAAM,SAAS,GAAG,CAAC,CAAC;AAEpB;;;;;;;GAOG;AACH,MAAM,oBAAoB,GAAG;AAC3B,8EAA8E;AAC9E,OAAuB;AACvB,8EAA8E;AAC9E,IAAa,EACb,KAAa,EACJ,EAAE;IACX,IAAI,KAAK,GAAG,SAAS,EAAE,CAAC;QACtB,OAAO,IAAI,CAAC;IACd,CAAC;IAED,iEAAiE;IACjE,IAAI,CAAC,IAAI,CAAC,KAAK,GAAG,EAAE,CAAC,SAAS,CAAC,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC;QAC9C,OAAO,KAAK,CAAC;IACf,CAAC;IAED,IAAI,IAAI,CAAC,OAAO,EAAE,IAAI,IAAI,CAAC,cAAc,EAAE,EAAE,CAAC;QAC5C,OAAO,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,oBAAoB,CAAC,OAAO,EAAE,CAAC,EAAE,KAAK,GAAG,CAAC,CAAC,CAAC,CAAC;IAC7E,CAAC;IAED,IAAI,CAAC,IAAI,CAAC,KAAK,GAAG,gBAAgB,CAAC,KAAK,CAAC,IAAI,OAAO,CAAC,WAAW,CAAC,IAAI,CAAC,EAAE,CAAC;QACvE,OAAO,IAAI,CAAC;IACd,CAAC;IAED,IAAI,CAAC,IAAI,CAAC,KAAK,GAAG,EAAE,CAAC,SAAS,CAAC,MAAM,CAAC,KAAK,CAAC,EAAE,CAAC;QAC7C,OAAO,KAAK,CAAC;IACf,CAAC;IAED,oEAAoE;IACpE,MAAM,EAAE,WAAW,EAAE,GAAG,IAAqB,CAAC;IAE9C,oCAAoC;IACpC,IACE,CAAC,WAAW,GAAG,EAAE,CAAC,WAAW,CAAC,SAAS,CAAC,KAAK,CAAC;QAC9C,OAAO;YACL,oEAAoE;aACnE,gBAAgB,CAAC,IAAwB,CAAC;aAC1C,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,oBAAoB,CAAC,OAAO,EAAE,CAAC,EAAE,KAAK,GAAG,CAAC,CAAC,CAAC,EAC3D,CAAC;QACD,OAAO,IAAI,CAAC;IACd,CAAC;IAED,OAAO;IACL,0EAA0E;IAC1E,uCAAuC;IACvC,CAAC,WAAW;QACV,CAAC,EAAE,CAAC,WAAW,CAAC,aAAa,GAAG,EAAE,CAAC,WAAW,CAAC,SAAS,CAAC,CAAC;QAC1D,CAAC;QACH,IAAI;aACD,aAAa,EAAE;aACf,IAAI,CAAC,CAAC,QAAQ,EAAE,EAAE,CACjB,oBAAoB,CAClB,OAAO,EACP,OAAO,CAAC,eAAe,CAAC,QAAQ,CAAC,EACjC,KAAK,GAAG,CAAC,CACV,CACF,CACJ,CAAC;AACJ,CAAC,CAAC;AAEF,yDAAyD;AACzD,MAAM,aAAa,GAAG;AACpB,8EAA8E;AAC9E,IAAyB,EACJ,EAAE,CACvB,IAAI,CAAC,IAAI,KAAK,cAAc,CAAC,qBAAqB;IAChD,CAAC,CAAC,aAAa,CAAC,IAAI,CAAC,UAAU,CAAC;IAChC,CAAC,CAAC,IAAI,CAAC"}

package/dist/rules/rules.d.mts

@@ -3,7 +3,7 @@ export declare const tsDataForgeRules: {
     readonly 'prefer-canonical-length-guard': import("@typescript-eslint/utils/ts-eslint").RuleModule<"useCanonicalGuard" | "useIsBoundedLengthArray" | "useIsFixedLengthArray" | "useIsMaxLengthArray" | "useIsMinLengthArray" | "useIsNonEmpty", readonly [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
     readonly 'prefer-canonical-length-cast': import("@typescript-eslint/utils/ts-eslint").RuleModule<"useCanonicalCast", readonly [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
     readonly 'prefer-arr-generate': import("@typescript-eslint/utils/ts-eslint").RuleModule<"suggestArrGenerate" | "useArrGenerate", readonly [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
-    readonly 'prefer-arr-is-array': import("@typescript-eslint/utils/ts-eslint").RuleModule<"useArrIsArray", readonly [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    readonly 'prefer-arr-is-array': import("@typescript-eslint/utils/ts-eslint").RuleModule<"useIsArray", readonly [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
     readonly 'prefer-arr-scan': import("@typescript-eslint/utils/ts-eslint").RuleModule<"preferArrScanAccumulate" | "preferArrScanPrefix", readonly [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
     readonly 'prefer-arr-sum': import("@typescript-eslint/utils/ts-eslint").RuleModule<"useArrSum" | "useArrSumBy", readonly [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
     readonly 'prefer-arr-uniq': import("@typescript-eslint/utils/ts-eslint").RuleModule<"suggestArrUniq" | "useArrUniq", readonly [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
@@ -19,5 +19,6 @@ export declare const tsDataForgeRules: {
     }> | undefined)?], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
     readonly 'prefer-comparison-over-nullish-guard': import("@typescript-eslint/utils/ts-eslint").RuleModule<"preferComparison", readonly [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
     readonly 'prefer-obj-over-entries-round-trip': import("@typescript-eslint/utils/ts-eslint").RuleModule<"useObjFilter" | "useObjFilterMap" | "useObjMap", readonly [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    readonly 'prefer-pipe-map-nullable': import("@typescript-eslint/utils/ts-eslint").RuleModule<"suggestMapNullable" | "useMapNullable", readonly [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
 };
 //# sourceMappingURL=rules.d.mts.map

package/dist/rules/rules.d.mts.map

@@ -1 +1 @@
-{"version":3,"file":"rules.d.mts","sourceRoot":"","sources":["../../src/rules/rules.mts"],"names":[],"mappings":"AAoBA,eAAO,MAAM,gBAAgB;;;;;;;;;;;;;;;;;;;;;CAmBa,CAAC"}
+{"version":3,"file":"rules.d.mts","sourceRoot":"","sources":["../../src/rules/rules.mts"],"names":[],"mappings":"AAqBA,eAAO,MAAM,gBAAgB;;;;;;;;;;;;;;;;;;;;;;CAoBa,CAAC"}

package/dist/rules/rules.mjs

@@ -15,6 +15,7 @@ import { preferIsRecordAndHasKey } from './prefer-is-record-and-has-key.mjs';
 import { preferNumSafeParseFloat } from './prefer-num-safe-parse-float.mjs';
 import { preferNumSafeParseInt } from './prefer-num-safe-parse-int.mjs';
 import { preferObjOverEntriesRoundTrip } from './prefer-obj-over-entries-round-trip.mjs';
+import { preferPipeMapNullable } from './prefer-pipe-map-nullable.mjs';
 import { preferRangeForLoop } from './prefer-range-for-loop.mjs';
 export const tsDataForgeRules = {
     'prefer-canonical-array-slicing': preferCanonicalArraySlicing,
@@ -35,5 +36,6 @@ export const tsDataForgeRules = {
     'no-unnecessary-type-guard': noUnnecessaryTypeGuard,
     'prefer-comparison-over-nullish-guard': preferComparisonOverNullishGuard,
     'prefer-obj-over-entries-round-trip': preferObjOverEntriesRoundTrip,
+    'prefer-pipe-map-nullable': preferPipeMapNullable,
 };
 //# sourceMappingURL=rules.mjs.map

package/dist/rules/rules.mjs.map

@@ -1 +1 @@
-{"version":3,"file":"rules.mjs","sourceRoot":"","sources":["../../src/rules/rules.mts"],"names":[],"mappings":"AACA,OAAO,EAAE,kBAAkB,EAAE,MAAM,6BAA6B,CAAC;AACjE,OAAO,EAAE,sBAAsB,EAAE,MAAM,iCAAiC,CAAC;AACzE,OAAO,EAAE,iBAAiB,EAAE,MAAM,2BAA2B,CAAC;AAC9D,OAAO,EAAE,gBAAgB,EAAE,MAAM,2BAA2B,CAAC;AAC7D,OAAO,EAAE,aAAa,EAAE,MAAM,uBAAuB,CAAC;AACtD,OAAO,EAAE,YAAY,EAAE,MAAM,sBAAsB,CAAC;AACpD,OAAO,EAAE,aAAa,EAAE,MAAM,uBAAuB,CAAC;AACtD,OAAO,EAAE,WAAW,EAAE,MAAM,qBAAqB,CAAC;AAClD,OAAO,EAAE,2BAA2B,EAAE,MAAM,sCAAsC,CAAC;AACnF,OAAO,EAAE,yBAAyB,EAAE,MAAM,oCAAoC,CAAC;AAC/E,OAAO,EAAE,0BAA0B,EAAE,MAAM,qCAAqC,CAAC;AACjF,OAAO,EAAE,gCAAgC,EAAE,MAAM,4CAA4C,CAAC;AAC9F,OAAO,EAAE,qBAAqB,EAAE,MAAM,iCAAiC,CAAC;AACxE,OAAO,EAAE,uBAAuB,EAAE,MAAM,oCAAoC,CAAC;AAC7E,OAAO,EAAE,uBAAuB,EAAE,MAAM,mCAAmC,CAAC;AAC5E,OAAO,EAAE,qBAAqB,EAAE,MAAM,iCAAiC,CAAC;AACxE,OAAO,EAAE,6BAA6B,EAAE,MAAM,0CAA0C,CAAC;AACzF,OAAO,EAAE,kBAAkB,EAAE,MAAM,6BAA6B,CAAC;AAEjE,MAAM,CAAC,MAAM,gBAAgB,GAAG;IAC9B,gCAAgC,EAAE,2BAA2B;IAC7D,+BAA+B,EAAE,0BAA0B;IAC3D,8BAA8B,EAAE,yBAAyB;IACzD,qBAAqB,EAAE,iBAAiB;IACxC,qBAAqB,EAAE,gBAAgB;IACvC,iBAAiB,EAAE,aAAa;IAChC,gBAAgB,EAAE,YAAY;IAC9B,iBAAiB,EAAE,aAAa;IAChC,eAAe,EAAE,WAAW;IAC5B,2BAA2B,EAAE,qBAAqB;IAClD,uBAAuB,EAAE,kBAAkB;IAC3C,8BAA8B,EAAE,uBAAuB;IACvD,2BAA2B,EAAE,qBAAqB;IAClD,6BAA6B,EAAE,uBAAuB;IACtD,uBAAuB,EAAE,kBAAkB;IAC3C,2BAA2B,EAAE,sBAAsB;IACnD,sCAAsC,EAAE,gCAAgC;IACxE,oCAAoC,EAAE,6BAA6B;CAC3B,CAAC"}
+{"version":3,"file":"rules.mjs","sourceRoot":"","sources":["../../src/rules/rules.mts"],"names":[],"mappings":"AACA,OAAO,EAAE,kBAAkB,EAAE,MAAM,6BAA6B,CAAC;AACjE,OAAO,EAAE,sBAAsB,EAAE,MAAM,iCAAiC,CAAC;AACzE,OAAO,EAAE,iBAAiB,EAAE,MAAM,2BAA2B,CAAC;AAC9D,OAAO,EAAE,gBAAgB,EAAE,MAAM,2BAA2B,CAAC;AAC7D,OAAO,EAAE,aAAa,EAAE,MAAM,uBAAuB,CAAC;AACtD,OAAO,EAAE,YAAY,EAAE,MAAM,sBAAsB,CAAC;AACpD,OAAO,EAAE,aAAa,EAAE,MAAM,uBAAuB,CAAC;AACtD,OAAO,EAAE,WAAW,EAAE,MAAM,qBAAqB,CAAC;AAClD,OAAO,EAAE,2BAA2B,EAAE,MAAM,sCAAsC,CAAC;AACnF,OAAO,EAAE,yBAAyB,EAAE,MAAM,oCAAoC,CAAC;AAC/E,OAAO,EAAE,0BAA0B,EAAE,MAAM,qCAAqC,CAAC;AACjF,OAAO,EAAE,gCAAgC,EAAE,MAAM,4CAA4C,CAAC;AAC9F,OAAO,EAAE,qBAAqB,EAAE,MAAM,iCAAiC,CAAC;AACxE,OAAO,EAAE,uBAAuB,EAAE,MAAM,oCAAoC,CAAC;AAC7E,OAAO,EAAE,uBAAuB,EAAE,MAAM,mCAAmC,CAAC;AAC5E,OAAO,EAAE,qBAAqB,EAAE,MAAM,iCAAiC,CAAC;AACxE,OAAO,EAAE,6BAA6B,EAAE,MAAM,0CAA0C,CAAC;AACzF,OAAO,EAAE,qBAAqB,EAAE,MAAM,gCAAgC,CAAC;AACvE,OAAO,EAAE,kBAAkB,EAAE,MAAM,6BAA6B,CAAC;AAEjE,MAAM,CAAC,MAAM,gBAAgB,GAAG;IAC9B,gCAAgC,EAAE,2BAA2B;IAC7D,+BAA+B,EAAE,0BAA0B;IAC3D,8BAA8B,EAAE,yBAAyB;IACzD,qBAAqB,EAAE,iBAAiB;IACxC,qBAAqB,EAAE,gBAAgB;IACvC,iBAAiB,EAAE,aAAa;IAChC,gBAAgB,EAAE,YAAY;IAC9B,iBAAiB,EAAE,aAAa;IAChC,eAAe,EAAE,WAAW;IAC5B,2BAA2B,EAAE,qBAAqB;IAClD,uBAAuB,EAAE,kBAAkB;IAC3C,8BAA8B,EAAE,uBAAuB;IACvD,2BAA2B,EAAE,qBAAqB;IAClD,6BAA6B,EAAE,uBAAuB;IACtD,uBAAuB,EAAE,kBAAkB;IAC3C,2BAA2B,EAAE,sBAAsB;IACnD,sCAAsC,EAAE,gCAAgC;IACxE,oCAAoC,EAAE,6BAA6B;IACnE,0BAA0B,EAAE,qBAAqB;CACT,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-ts-data-forge",
-  "version": "0.9.0",
+  "version": "0.10.1",
   "private": false,
   "description": "ESLint rules that steer code toward ts-data-forge idioms.",
   "keywords": [
@@ -35,17 +35,17 @@
   ],
   "dependencies": {
     "@typescript-eslint/utils": "^8.71.1",
-    "eslint-rule-forge": "^0.2.0",
-    "ts-data-forge": "14.8.0",
+    "eslint-rule-forge": "^0.3.0",
+    "ts-data-forge": "14.9.0",
     "ts-type-forge": "~9.2.2"
   },
   "devDependencies": {
     "@typescript-eslint/parser": "8.71.1",
     "@typescript-eslint/rule-tester": "8.71.1",
     "dedent": "1.7.2",
-    "eslint-config-typed": "5.19.0",
-    "eslint-plugin-ts-fortress": "1.3.4",
-    "eslint-plugin-ts-type-forge": "0.8.9",
+    "eslint-config-typed": "5.19.1",
+    "eslint-plugin-ts-fortress": "1.3.6",
+    "eslint-plugin-ts-type-forge": "0.8.11",
     "prettier": "3.9.9",
     "prettier-plugin-organize-imports": "4.3.0",
     "prettier-plugin-packagejson": "3.0.2",

package/src/plugin.mts

@@ -28,6 +28,7 @@ const recommendedRules = {
   'ts-data-forge/no-unnecessary-type-guard': 'error',
   'ts-data-forge/prefer-comparison-over-nullish-guard': 'error',
   'ts-data-forge/prefer-obj-over-entries-round-trip': 'error',
+  'ts-data-forge/prefer-pipe-map-nullable': 'error',
 } as const satisfies ReadonlyRecord<
   `ts-data-forge/${keyof typeof tsDataForgeRules}`,
   'error'

package/src/rule-types.mts

@@ -208,7 +208,7 @@ namespace PreferIsRecordAndHasKey {
 }
 
 /**
- * @description Replace `parseInt(x, 10)` with `Result.unwrapOkOr(Num.safeParseInt(x), Number.NaN)` from ts-data-forge.
+ * @description Replace `parseInt(x)` or `Number.parseInt(x, 10)` with `Result.unwrapOkOr(Num.safeParseInt(x), Number.NaN)` from ts-data-forge.
  *
  *  ```md
  *  | key        | value      |
@@ -325,6 +325,21 @@ namespace PreferObjOverEntriesRoundTrip {
   export type RuleEntry = Linter.StringSeverity;
 }
 
+/**
+ * @description Replace `pipe(x).map(mapNullable(fn))` with `pipe(x).mapNullable(fn)`.
+ *
+ *  ```md
+ *  | key        | value      |
+ *  | :--------- | :--------- |
+ *  | type       | suggestion |
+ *  | deprecated | false      |
+ *  | fixable    | code       |
+ *  ```
+ */
+namespace PreferPipeMapNullable {
+  export type RuleEntry = Linter.StringSeverity;
+}
+
 export type EslintTsDataForgeRules = Readonly<{
   'ts-data-forge/prefer-canonical-array-slicing': PreferCanonicalArraySlicing.RuleEntry;
   'ts-data-forge/prefer-canonical-length-guard': PreferCanonicalLengthGuard.RuleEntry;
@@ -344,6 +359,7 @@ export type EslintTsDataForgeRules = Readonly<{
   'ts-data-forge/no-unnecessary-type-guard': NoUnnecessaryTypeGuard.RuleEntry;
   'ts-data-forge/prefer-comparison-over-nullish-guard': PreferComparisonOverNullishGuard.RuleEntry;
   'ts-data-forge/prefer-obj-over-entries-round-trip': PreferObjOverEntriesRoundTrip.RuleEntry;
+  'ts-data-forge/prefer-pipe-map-nullable': PreferPipeMapNullable.RuleEntry;
 }>;
 
 export type EslintTsDataForgeRulesOption = Readonly<{

package/src/rules/ast-utils.mts

@@ -10,7 +10,6 @@ import {
   typeWrapperLayers,
 } from 'eslint-rule-forge';
 import type { DeepReadonly } from 'ts-type-forge';
-import type * as ts from 'typescript';
 
 const isIntegerLiteral = (node: DeepReadonly<TSESTree.Expression>): boolean =>
   node.type === AST_NODE_TYPES.Literal &&
@@ -265,53 +264,3 @@ const isVariableDefinition = (
   def: TSESLint.Scope.Definition,
 ): def is TSESLint.Scope.Definition & VariableDefinition =>
   (def.type as string) === 'Variable';
-
-/**
- * Whether `node`, read through its type wrappers, is the identifier `name`:
- * `Number`, `(Number as NumberConstructor)` and `Number!` are the same object.
- */
-export const isIdentifierNamed = (
-  // eslint-disable-next-line @typescript-eslint/prefer-readonly-parameter-types
-  node: TSESTree.Node,
-  name: string,
-): boolean => {
-  const unwrapped = skipTypeWrappers(node);
-
-  return (
-    unwrapped.type === AST_NODE_TYPES.Identifier && unwrapped.name === name
-  );
-};
-
-/**
- * Whether `holds` is true of the type of every layer of type wrappers around
- * `node` (see {@link typeWrapperLayers}), outermost to innermost; `false`
- * without type information. A widening cast (`s as string | number`) is the
- * author saying the value may be more than it is, and is respected; a
- * narrowing one (`s!`, `v as unknown as string`) cannot vouch for what the
- * value's own type does not, and the fix, which keeps the wrapper, has to
- * type-check at every layer too.
- */
-export const typeHoldsAtEveryLayer = (
-  // eslint-disable-next-line @typescript-eslint/prefer-readonly-parameter-types
-  sourceCode: TSESLint.SourceCode,
-  // eslint-disable-next-line @typescript-eslint/prefer-readonly-parameter-types
-  node: TSESTree.Node,
-  // eslint-disable-next-line @typescript-eslint/prefer-readonly-parameter-types
-  holds: (type: ts.Type, typeChecker: ts.TypeChecker) => boolean,
-): boolean => {
-  const services = sourceCode.parserServices;
-
-  const checker = services?.program?.getTypeChecker();
-
-  if (checker === undefined) {
-    return false;
-  }
-
-  return typeWrapperLayers(node).every((layer) => {
-    const tsNode = services?.esTreeNodeToTSNodeMap?.get(layer);
-
-    return (
-      tsNode !== undefined && holds(checker.getTypeAtLocation(tsNode), checker)
-    );
-  });
-};

package/src/rules/no-side-effect-import.mts

@@ -1,11 +1,6 @@
-import type { TSESLint, TSESTree } from '@typescript-eslint/utils';
-import { Arr } from 'ts-data-forge';
+import { createNoSideEffectImport } from 'eslint-rule-forge';
 import { TS_DATA_FORGE_MODULE } from './constants.mjs';
 
-type Options = readonly [];
-
-type MessageIds = 'removeSideEffectImport';
-
 /**
  * `import 'ts-data-forge';` binds nothing and runs nothing: every export is a
  * pure value or function, and the package declares `sideEffects: false`, which
@@ -13,59 +8,10 @@ type MessageIds = 'removeSideEffectImport';
  * a side-effect import in the emitted JavaScript — that is the one kind it
  * never elides — so what is left is a module loaded for no reason, and a
  * bundler that trusts the flag drops it anyway.
- *
- * The rule matches the bare specifier exactly; an import of some other module
- * is none of its business.
  */
-export const noSideEffectImport: TSESLint.RuleModule<MessageIds, Options> = {
-  meta: {
-    type: 'suggestion',
-    docs: {
-      description: `Remove a side-effect-only \`import '${TS_DATA_FORGE_MODULE}';\`, which binds no name and, the package being \`sideEffects: false\`, does nothing.`,
-    },
-    fixable: 'code',
-    schema: [],
-    messages: {
-      removeSideEffectImport: `\`import '${TS_DATA_FORGE_MODULE}';\` binds no name, and \`${TS_DATA_FORGE_MODULE}\` declares \`sideEffects: false\`, so loading it does nothing. Remove it, and import what you need by name.`,
-    },
-  },
-
-  create: (context) => ({
-    ImportDeclaration: (node) => {
-      if (
-        node.source.value !== TS_DATA_FORGE_MODULE ||
-        !Arr.isEmpty(node.specifiers)
-      ) {
-        return;
-      }
-
-      context.report({
-        node,
-        messageId: 'removeSideEffectImport',
-        fix: (fixer) => removeStatement(fixer, context.sourceCode, node),
-      });
-    },
-  }),
-  defaultOptions: [],
-} as const;
-
-/* eslint-disable @typescript-eslint/prefer-readonly-parameter-types */
-
-/**
- * Removes a statement along with the rest of its line, so that deleting it does
- * not leave a blank line where it was.
- */
-const removeStatement = (
-  fixer: TSESLint.RuleFixer,
-  sourceCode: TSESLint.SourceCode,
-  node: TSESTree.Node,
-): TSESLint.RuleFix => {
-  const restOfLine = /^[^\S\n]*\n/u.exec(
-    sourceCode.getText().slice(node.range[1]),
-  );
-
-  return fixer.removeRange([
-    node.range[0],
-    node.range[1] + (restOfLine?.[0].length ?? 0),
-  ]);
-};
+export const noSideEffectImport = createNoSideEffectImport({
+  moduleName: TS_DATA_FORGE_MODULE,
+  type: 'suggestion',
+  description: `Remove a side-effect-only \`import '${TS_DATA_FORGE_MODULE}';\`, which binds no name and, the package being \`sideEffects: false\`, does nothing.`,
+  message: `\`import '${TS_DATA_FORGE_MODULE}';\` binds no name, and \`${TS_DATA_FORGE_MODULE}\` declares \`sideEffects: false\`, so loading it does nothing. Remove it, and import what you need by name.`,
+});