eslint-plugin-th-rules 3.0.0 → 3.1.1

package/dist/index.js

@@ -3,7 +3,9 @@ import { rules } from './plugin.js';
 import { recommended } from './configs/bundles/recommended.js';
 import { recommendedReact } from './configs/bundles/recommended-react.js';
 import { recommendedTypescript } from './configs/bundles/recommended-typescript.js';
+import { recommendedTypescriptReact } from './configs/bundles/recommended-typescript-react.js';
 // Internal layers (named exports only)
+export { rules } from './plugin.js';
 export { coreBase } from './configs/core/base.js';
 export { coreTypescript } from './configs/core/typescript.js';
 export { coreReact } from './configs/core/react.js';
@@ -11,11 +13,8 @@ export { externalsBase } from './configs/externals/base.js';
 export { externalsOpinionated } from './configs/externals/opinionated.js';
 export const configs = {
     recommended,
-    'recommended-react': recommendedReact,
-    'recommended-typescript': recommendedTypescript,
-};
-export default {
-    rules,
-    configs,
+    recommendedReact,
+    recommendedTypescript,
+    recommendedTypescriptReact,
 };
-export { rules } from './plugin.js';
+export default { rules, configs };

package/dist/rules/no-comments.d.ts

@@ -5,7 +5,7 @@ type Options = [
         disallow?: string[];
     }?
 ];
-declare const _default: ESLintUtils.RuleModule<"commentNotAllowed", Options, unknown, ESLintUtils.RuleListener> & {
+declare const noComments: ESLintUtils.RuleModule<"commentNotAllowed", Options, unknown, ESLintUtils.RuleListener> & {
     name: string;
 };
-export default _default;
+export default noComments;

package/dist/rules/no-comments.js

@@ -6,7 +6,7 @@ const DEFAULT_ALLOWED_PATTERNS = [
     /info/i, // Allow INFO (case-insensitive)
     /^\s*eslint-(disable|enable|env|globals|ignore|directive)/,
 ];
-export default ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/no-comments.md')({
+const noComments = ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/no-comments.md')({
     name: 'no-comments',
     meta: {
         type: 'problem',
@@ -43,7 +43,6 @@ export default ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/esli
         const userDisallowedPatterns = (option.disallow ?? []).map(pattern => new RegExp(pattern));
         function isCommentAllowed(comment) {
             const text = comment.value.trim();
-            // Allow JSDoc
             if (comment.type === 'Block' && comment.value.startsWith('*')) {
                 return true;
             }
@@ -81,3 +80,4 @@ export default ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/esli
         };
     },
 });
+export default noComments;

package/dist/rules/no-default-export.d.ts

@@ -1,5 +1,5 @@
 import { ESLintUtils } from '@typescript-eslint/utils';
-declare const _default: ESLintUtils.RuleModule<"unnamed", [], unknown, ESLintUtils.RuleListener> & {
+declare const noDefaultExport: ESLintUtils.RuleModule<"unnamed", [], unknown, ESLintUtils.RuleListener> & {
     name: string;
 };
-export default _default;
+export default noDefaultExport;

package/dist/rules/no-default-export.js

@@ -1,6 +1,6 @@
 import * as path from 'node:path';
 import { ESLintUtils } from '@typescript-eslint/utils';
-export default ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/no-default-export.md')({
+const noDefaultExport = ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/no-default-export.md')({
     name: 'no-default-export',
     meta: {
         type: 'problem',
@@ -16,9 +16,7 @@ export default ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/esli
     defaultOptions: [],
     create(context) {
         function generateExportNameFromFileName(fileName) {
-            // Remove all invalid characters, replace with spaces
             const cleaned = fileName.replaceAll(/[^a-zA-Z\d]+/g, ' ');
-            // Split into tokens
             const parts = cleaned
                 .trim()
                 .split(/\s+/g)
@@ -26,7 +24,6 @@ export default ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/esli
             if (parts.length === 0) {
                 return 'defaultExport';
             }
-            // Build camelCase
             const [first, ...rest] = parts;
             return (first.charAt(0).toLowerCase() + first.slice(1)) + rest
                 .map(p => p.charAt(0).toUpperCase() + p.slice(1))
@@ -34,11 +31,9 @@ export default ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/esli
         }
         return {
             ExportDefaultDeclaration(node) {
-                // 1. skip `export default Foo`
                 if (node.declaration.type === 'Identifier') {
                     return;
                 }
-                // 2. skip named function/class: `export default function Foo() {}`
                 if ('id' in node.declaration && node.declaration.id != null) {
                     return;
                 }
@@ -59,3 +54,4 @@ export default ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/esli
         };
     },
 });
+export default noDefaultExport;

package/dist/rules/no-destructuring.d.ts

@@ -1,8 +1,8 @@
 import { ESLintUtils } from '@typescript-eslint/utils';
-declare const _default: ESLintUtils.RuleModule<"tooDeep" | "tooMany" | "tooLong", [{
+declare const noDestructuring: ESLintUtils.RuleModule<"tooDeep" | "tooMany" | "tooLong", [{
     maximumDestructuredVariables: number;
     maximumLineLength: number;
 }], unknown, ESLintUtils.RuleListener> & {
     name: string;
 };
-export default _default;
+export default noDestructuring;

package/dist/rules/no-destructuring.js

@@ -1,6 +1,6 @@
 import { ESLintUtils } from '@typescript-eslint/utils';
 const MAX_TAB_COUNT = 3;
-export default ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/no-destructuring.md')({
+const noDestructuring = ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/no-destructuring.md')({
     name: 'no-destructuring',
     meta: {
         type: 'problem',
@@ -85,7 +85,6 @@ export default ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/esli
                 if (!p) {
                     continue;
                 }
-                // (...args = {}) pattern
                 if (p.type === 'AssignmentPattern') {
                     reportIfNeeded(p.left, p);
                     continue;
@@ -119,3 +118,4 @@ export default ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/esli
         };
     },
 });
+export default noDestructuring;

package/dist/rules/prefer-is-empty.d.ts

@@ -1,5 +1,5 @@
-import { ESLintUtils } from "@typescript-eslint/utils";
-declare const _default: ESLintUtils.RuleModule<"useIsEmpty", [], unknown, ESLintUtils.RuleListener> & {
+import { ESLintUtils } from '@typescript-eslint/utils';
+declare const preferIsEmpty: ESLintUtils.RuleModule<"useIsEmpty", [], unknown, ESLintUtils.RuleListener> & {
     name: string;
 };
-export default _default;
+export default preferIsEmpty;

package/dist/rules/prefer-is-empty.js

@@ -1,31 +1,31 @@
-import { ESLintUtils } from "@typescript-eslint/utils";
-export default ESLintUtils.RuleCreator(() => "https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/prefer-is-empty.md")({
-    name: "prefer-is-empty",
+import { ESLintUtils } from '@typescript-eslint/utils';
+const preferIsEmpty = ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/prefer-is-empty.md')({
+    name: 'prefer-is-empty',
     meta: {
-        type: "problem",
+        type: 'problem',
         docs: {
-            description: "Require _.isEmpty instead of length comparisons."
+            description: 'Require _.isEmpty instead of length comparisons.',
         },
         hasSuggestions: true,
         schema: [],
         messages: {
-            useIsEmpty: "Use _.isEmpty({{collection}}) instead of checking {{collection}}.length {{operator}} {{value}}."
-        }
+            useIsEmpty: 'Use _.isEmpty({{collection}}) instead of checking {{collection}}.length {{operator}} {{value}}.',
+        },
     },
     defaultOptions: [],
     create(context) {
         const sourceCode = context.getSourceCode();
         function isLengthAccess(node) {
-            return (!!node &&
-                node.type === "MemberExpression" &&
-                node.property.type === "Identifier" &&
-                node.property.name === "length" &&
-                node.computed === false);
+            return (Boolean(node)
+                && node.type === 'MemberExpression'
+                && node.property.type === 'Identifier'
+                && node.property.name === 'length'
+                && !node.computed);
         }
         function isNumericLiteral(node) {
-            return (!!node &&
-                node.type === "Literal" &&
-                typeof node.value === "number");
+            return (Boolean(node)
+                && node.type === 'Literal'
+                && typeof node.value === 'number');
         }
         function report(node, collectionNode, operator, value, isEmptyCheck) {
             const collectionText = sourceCode.getText(collectionNode.object);
@@ -34,68 +34,59 @@ export default ESLintUtils.RuleCreator(() => "https://github.com/tomerh2001/esli
                 : `!_.isEmpty(${collectionText})`;
             context.report({
                 node,
-                messageId: "useIsEmpty",
+                messageId: 'useIsEmpty',
                 data: {
                     collection: collectionText,
                     operator,
-                    value
+                    value,
                 },
                 suggest: [
                     {
-                        messageId: "useIsEmpty",
+                        messageId: 'useIsEmpty',
                         data: {
                             collection: collectionText,
                             operator,
-                            value
+                            value,
                         },
                         fix(fixer) {
                             return fixer.replaceText(node, replacement);
-                        }
-                    }
-                ]
+                        },
+                    },
+                ],
             });
         }
         return {
             BinaryExpression(node) {
                 const { left, right, operator } = node;
-                //
-                // Case 1: values.length <op> N
-                //
                 if (isLengthAccess(left) && isNumericLiteral(right)) {
-                    const value = right.value;
-                    // EMPTY checks
-                    if ((operator === "===" && value === 0) ||
-                        (operator === "<=" && value === 0) ||
-                        (operator === "<" && value === 1)) {
+                    const { value } = right;
+                    if ((operator === '===' && value === 0)
+                        || (operator === '<=' && value === 0)
+                        || (operator === '<' && value === 1)) {
                         report(node, left, operator, value, true);
                         return;
                     }
-                    // NOT EMPTY checks
-                    if ((operator === ">" && value === 0) ||
-                        (operator === ">=" && value === 1) ||
-                        ((operator === "!=" || operator === "!==") && value === 0)) {
+                    if ((operator === '>' && value === 0)
+                        || (operator === '>=' && value === 1)
+                        || ((operator === '!=' || operator === '!==') && value === 0)) {
                         report(node, left, operator, value, false);
                     }
                 }
-                //
-                // Case 2: N <op> values.length (reverse order)
-                //
                 if (isNumericLiteral(left) && isLengthAccess(right)) {
-                    const value = left.value;
-                    // EMPTY checks
-                    if ((operator === "===" && value === 0) ||
-                        (operator === ">=" && value === 0) ||
-                        (operator === ">" && value === 0)) {
+                    const { value } = left;
+                    if ((operator === '===' && value === 0)
+                        || (operator === '>=' && value === 0)
+                        || (operator === '>' && value === 0)) {
                         report(node, right, operator, value, true);
                         return;
                     }
-                    // NOT EMPTY checks
-                    if ((operator === "<" && value === 1) ||
-                        (operator === "<=" && value === 0)) {
+                    if ((operator === '<' && value === 1)
+                        || (operator === '<=' && value === 0)) {
                         report(node, right, operator, value, false);
                     }
                 }
-            }
+            },
         };
-    }
+    },
 });
+export default preferIsEmpty;

package/dist/rules/schemas-in-schemas-file.d.ts

@@ -1,9 +1,9 @@
 import { ESLintUtils } from '@typescript-eslint/utils';
-declare const _default: ESLintUtils.RuleModule<"moveSchema", [{
+declare const schemasInSchemasFile: ESLintUtils.RuleModule<"moveSchema", [{
     allowedSuffixes: string[];
     onlyWhenAssigned: boolean;
     allowInTests: boolean;
 }], unknown, ESLintUtils.RuleListener> & {
     name: string;
 };
-export default _default;
+export default schemasInSchemasFile;

package/dist/rules/schemas-in-schemas-file.js

@@ -1,5 +1,5 @@
 import { ESLintUtils } from '@typescript-eslint/utils';
-export default ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/schemas-in-schemas-file.md')({
+const schemasInSchemasFile = ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/schemas-in-schemas-file.md')({
     name: 'schemas-in-schemas-file',
     meta: {
         type: 'problem',
@@ -139,3 +139,4 @@ export default ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/esli
         };
     },
 });
+export default schemasInSchemasFile;

package/dist/rules/top-level-functions.d.ts

@@ -1,5 +1,5 @@
 import { ESLintUtils } from '@typescript-eslint/utils';
-declare const _default: ESLintUtils.RuleModule<"arrow" | "funcExpr" | "anonDecl", [], unknown, ESLintUtils.RuleListener> & {
+declare const topLevelFunctions: ESLintUtils.RuleModule<"arrow" | "funcExpr" | "anonDecl", [], unknown, ESLintUtils.RuleListener> & {
     name: string;
 };
-export default _default;
+export default topLevelFunctions;

package/dist/rules/top-level-functions.js

@@ -1,5 +1,5 @@
 import { ESLintUtils } from '@typescript-eslint/utils';
-export default ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/top-level-functions.md')({
+const topLevelFunctions = ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/top-level-functions.md')({
     name: 'top-level-functions',
     meta: {
         type: 'suggestion',
@@ -17,9 +17,6 @@ export default ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/esli
     defaultOptions: [],
     create(context) {
         const sourceCode = context.getSourceCode();
-        //
-        // Helpers
-        //
         function buildArrowFunctionReplacement(functionName, arrow, isExport) {
             const asyncKeyword = arrow.async ? 'async ' : '';
             const exportKeyword = isExport ? 'export ' : '';
@@ -31,7 +28,6 @@ export default ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/esli
                 bodyText = sourceCode.getText(arrow.body);
             }
             else {
-                // Expression → convert to return
                 const expressionText = sourceCode.getText(arrow.body);
                 bodyText = `{ return ${expressionText}; }`;
             }
@@ -63,9 +59,6 @@ export default ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/esli
             }
             return replaced;
         }
-        //
-        // Utility
-        //
         function isTopLevel(node) {
             const { parent } = node;
             return (parent?.type === 'Program'
@@ -77,9 +70,6 @@ export default ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/esli
             return (p?.type === 'ExportNamedDeclaration'
                 || p?.type === 'ExportDefaultDeclaration');
         }
-        //
-        // Rule
-        //
         return {
             VariableDeclarator(node) {
                 const declParent = node.parent;
@@ -102,9 +92,6 @@ export default ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/esli
                 if (!functionName) {
                     return;
                 }
-                //
-                // Arrow functions
-                //
                 if (node.init.type === 'ArrowFunctionExpression') {
                     const arrowFunc = node.init;
                     context.report({
@@ -116,9 +103,6 @@ export default ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/esli
                         },
                     });
                 }
-                //
-                // Function expressions
-                //
                 if (node.init.type === 'FunctionExpression') {
                     const funcExpr = node.init;
                     context.report({
@@ -134,7 +118,7 @@ export default ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/esli
             FunctionDeclaration(node) {
                 if (node.id) {
                     return;
-                } // Already named
+                }
                 if (!isTopLevel(node)) {
                     return;
                 }
@@ -151,3 +135,4 @@ export default ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/esli
         };
     },
 });
+export default topLevelFunctions;

package/dist/rules/types-in-dts.d.ts

@@ -1,8 +1,8 @@
-import { ESLintUtils } from "@typescript-eslint/utils";
-declare const _default: ESLintUtils.RuleModule<"moveToDts", [{
+import { ESLintUtils } from '@typescript-eslint/utils';
+declare const typesInDts: ESLintUtils.RuleModule<"moveToDts", [{
     allowEnums: boolean;
     allowDeclare: boolean;
 }], unknown, ESLintUtils.RuleListener> & {
     name: string;
 };
-export default _default;
+export default typesInDts;

package/dist/rules/types-in-dts.js

@@ -1,49 +1,48 @@
-import { ESLintUtils } from "@typescript-eslint/utils";
-export default ESLintUtils.RuleCreator(() => "https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/types-in-dts.md")({
-    name: "types-in-dts",
+import { ESLintUtils } from '@typescript-eslint/utils';
+const typesInDts = ESLintUtils.RuleCreator(() => 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/types-in-dts.md')({
+    name: 'types-in-dts',
     meta: {
-        type: "problem",
+        type: 'problem',
         docs: {
-            description: "Require TypeScript type declarations (type/interface/enum) to be placed in .d.ts files."
+            description: 'Require TypeScript type declarations (type/interface/enum) to be placed in .d.ts files.',
         },
         schema: [
             {
-                type: "object",
+                type: 'object',
                 properties: {
-                    allowEnums: { type: "boolean" },
-                    allowDeclare: { type: "boolean" }
+                    allowEnums: { type: 'boolean' },
+                    allowDeclare: { type: 'boolean' },
                 },
-                additionalProperties: false
-            }
+                additionalProperties: false,
+            },
         ],
         messages: {
-            moveToDts: "Type declarations must be defined in a .d.ts file."
-        }
+            moveToDts: 'Type declarations must be defined in a .d.ts file.',
+        },
     },
     defaultOptions: [
         {
             allowEnums: false,
-            allowDeclare: false
-        }
+            allowDeclare: false,
+        },
     ],
     create(context, [options]) {
         const allowEnums = Boolean(options.allowEnums);
         const allowDeclare = Boolean(options.allowDeclare);
         function isDtsFile(filename) {
-            if (!filename || filename === "<input>") {
+            if (!filename || filename === '<input>') {
                 return false;
             }
-            return filename.endsWith(".d.ts");
+            return filename.endsWith('.d.ts');
         }
         function hasDeclareModifier(node) {
-            // `declare type Foo = ...`
-            if ("declare" in node && node.declare === true) {
+            if ('declare' in node && node.declare) {
                 return true;
             }
-            const modifiers = "modifiers" in node && Array.isArray(node.modifiers)
+            const modifiers = 'modifiers' in node && Array.isArray(node.modifiers)
                 ? node.modifiers
                 : [];
-            return modifiers.some(m => m?.type === "TSDeclareKeyword");
+            return modifiers.some(m => m?.type === 'TSDeclareKeyword');
         }
         function reportIfNotDts(node) {
             const filename = context.getFilename();
@@ -55,7 +54,7 @@ export default ESLintUtils.RuleCreator(() => "https://github.com/tomerh2001/esli
             }
             context.report({
                 node,
-                messageId: "moveToDts"
+                messageId: 'moveToDts',
             });
         }
         return {
@@ -70,7 +69,8 @@ export default ESLintUtils.RuleCreator(() => "https://github.com/tomerh2001/esli
                     return;
                 }
                 reportIfNotDts(node);
-            }
+            },
         };
-    }
+    },
 });
+export default typesInDts;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-th-rules",
-  "version": "3.0.0",
+  "version": "3.1.1",
   "description": "A List of custom ESLint rules created by Tomer Horowitz",
   "keywords": [
     "eslint",
@@ -44,6 +44,7 @@
   "devDependencies": {
     "@codedependant/semantic-release-docker": "^5.1.1",
     "@eslint/js": "^9.39.2",
+    "@leancodepl/resolve-eslint-flat-config": "^9.7.0",
     "@semantic-release/changelog": "^6.0.3",
     "@semantic-release/commit-analyzer": "^13.0.1",
     "@semantic-release/git": "^10.0.1",