eslint-plugin-th-rules 2.7.1 → 2.8.0

package/src/rules/no-boolean-coercion.js

@@ -1,124 +0,0 @@
-const meta = {
-	type: 'problem',
-	docs: {
-		description:
-			'Disallow Boolean(value) or !!value. Enforce explicit checks: !_.isNil(value) for scalar values and !_.isEmpty(value) for strings, arrays, and objects.',
-		category: 'Best Practices',
-		recommended: true,
-		url: 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/no-boolean-coercion.md',
-	},
-	hasSuggestions: true,
-	schema: [],
-	messages: {
-		useIsEmpty:
-			'Boolean coercion is not allowed. Use !_.isEmpty(value) for strings, arrays, and objects.',
-		useIsNil:
-			'Boolean coercion is not allowed. Use !_.isNil(value) for scalar values.',
-	},
-};
-
-function create(context) {
-	const sourceCode = context.getSourceCode();
-	const services = context.parserServices;
-	const checker = services?.program?.getTypeChecker?.();
-
-	function isBooleanCall(node) {
-		return (
-			node.type === 'CallExpression'
-			&& node.callee.type === 'Identifier'
-			&& node.callee.name === 'Boolean'
-			&& node.arguments.length === 1
-		);
-	}
-
-	function isDoubleNegation(node) {
-		return (
-			node.type === 'UnaryExpression'
-			&& node.operator === '!'
-			&& node.argument?.type === 'UnaryExpression'
-			&& node.argument.operator === '!'
-		);
-	}
-
-	function isCollectionLikeByTS(node) {
-		if (!checker || !services?.esTreeNodeToTSNodeMap) {
-			return false;
-		}
-
-		const tsNode = services.esTreeNodeToTSNodeMap.get(node);
-		if (!tsNode) {
-			return false;
-		}
-
-		const type = checker.getTypeAtLocation(tsNode);
-		const typeString = checker.typeToString(type);
-
-		return (
-			typeString.includes('[]')
-			|| typeString === 'string'
-			|| typeString === 'object'
-			|| typeString.startsWith('Array<')
-			|| typeString.startsWith('ReadonlyArray<')
-		);
-	}
-
-	function isCollectionLikeBySyntax(node) {
-		return (
-			node.type === 'ArrayExpression'
-			|| node.type === 'ObjectExpression'
-			|| (node.type === 'Literal' && typeof node.value === 'string')
-		);
-	}
-
-	function report(node, valueNode) {
-		const isCollection
-			= isCollectionLikeBySyntax(valueNode)
-				|| isCollectionLikeByTS(valueNode);
-
-		const suggestedFn = isCollection ? '_.isEmpty' : '_.isNil';
-		const replacement = `!${suggestedFn}(${sourceCode.getText(valueNode)})`;
-
-		context.report({
-			node,
-			messageId: isCollection ? 'useIsEmpty' : 'useIsNil',
-			suggest: [
-				{
-					desc: `Replace with ${replacement}`,
-					fix(fixer) {
-						return fixer.replaceText(node, replacement);
-					},
-				},
-			],
-		});
-	}
-
-	return {
-		CallExpression(node) {
-			if (!isBooleanCall(node)) {
-				return;
-			}
-
-			const arg = node.arguments[0];
-			if (!arg) {
-				return;
-			}
-
-			report(node, arg);
-		},
-
-		UnaryExpression(node) {
-			if (!isDoubleNegation(node)) {
-				return;
-			}
-
-			const valueNode = node.argument.argument;
-			if (!valueNode) {
-				return;
-			}
-
-			report(node, valueNode);
-		},
-	};
-}
-
-module.exports = {meta, create};

package/src/rules/no-comments.js

@@ -1,94 +0,0 @@
-/* eslint-disable unicorn/prefer-module */
-
-const allowedPatterns = [
-	/todo/i, // Allow TODO (case-insensitive)
-	/warning/i, // Allow WARNING (case-insensitive)
-	/error/i, // Allow ERROR (case-insensitive)
-	/info/i, // Allow INFO (case-insensitive)
-	/^\s*eslint-(disable|enable|env|globals|ignore|directive)/,
-];
-
-const meta = {
-	type: 'problem',
-	docs: {
-		description: 'Disallow comments except for specified allowed patterns.',
-		url: 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/no-comments.md',
-	},
-	fixable: 'code',
-	schema: [
-		{
-			type: 'object',
-			properties: {
-				allow: {
-					type: 'array',
-					items: {
-						type: 'string',
-					},
-					description: 'Additional patterns to allow in comments.',
-				},
-				disallow: {
-					type: 'array',
-					items: {
-						type: 'string',
-					},
-					description: 'Additional patterns to disallow in comments.',
-				},
-			},
-			additionalProperties: false,
-		},
-	],
-};
-
-function create(context) {
-	const options = context.options[0] || {};
-	const userAllowedPatterns = (options.allow || []).map(pattern => new RegExp(pattern));
-	const userDisallowedPatterns = (options.disallow || []).map(pattern => new RegExp(pattern));
-
-	function isCommentAllowed(comment) {
-		const text = comment.value.trim();
-
-		if (comment.type === 'Block' && comment.value.startsWith('*')) {
-			return true;
-		}
-
-		for (const pattern of [...allowedPatterns, ...userAllowedPatterns]) {
-			if (pattern.test(text)) {
-				return true;
-			}
-		}
-
-		for (const pattern of userDisallowedPatterns) {
-			if (pattern.test(text)) {
-				return false;
-			}
-		}
-
-		return false;
-	}
-
-	return {
-		Program() {
-			const sourceCode = context.getSourceCode();
-			const comments = sourceCode.getAllComments();
-
-			for (const comment of comments) {
-				if (!isCommentAllowed(comment)) {
-					context.report({
-						node: comment,
-						message: 'Comment not allowed.',
-						fix(fixer) {
-							return fixer.remove(comment);
-						},
-					});
-				}
-			}
-		},
-	};
-}
-
-const rule = {
-	meta,
-	create,
-};
-
-module.exports = rule;

package/src/rules/no-default-export.js

@@ -1,64 +0,0 @@
-/* eslint-disable unicorn/prefer-module */
-
-const path = require('node:path');
-
-const meta = {
-	type: 'problem',
-	docs: {
-		description: 'Convert unnamed default exports to named default exports based on the file name.',
-		url: 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/no-default-export.md',
-	},
-	fixable: 'code',
-	schema: [],
-};
-
-function create(context) {
-	function generateExportNameFromFileName(fileName) {
-		return fileName.replaceAll(/^\w|[A-Z]|\b\w|\s+/g, (match, index) => {
-			if (match === ' ') {
-				return '';
-			}
-
-			if (index === 0) {
-				return match.toLowerCase();
-			}
-
-			return match.toUpperCase();
-		})
-			.replaceAll(/[-_<>\\. ]/g, '');
-	}
-
-	return {
-		ExportDefaultDeclaration(node) {
-			if (node.declaration.type === 'Identifier') {
-				return;
-			}
-
-			if (node.declaration.id) {
-				return;
-			}
-
-			const fileName = context.getFilename();
-			const exportName = generateExportNameFromFileName(path.basename(fileName, path.extname(fileName)));
-
-			context.report({
-				node,
-				message: 'Unnamed default export should be named based on the file name.',
-				fix(fixer) {
-					const sourceCode = context.getSourceCode();
-					const declarationText = sourceCode.getText(node.declaration);
-					const fixedCode = `const ${exportName} = ${declarationText};\nexport default ${exportName};`;
-
-					return fixer.replaceText(node, fixedCode);
-				},
-			});
-		},
-	};
-}
-
-const rule = {
-	meta,
-	create,
-};
-
-module.exports = rule;

package/src/rules/no-destructuring.js

@@ -1,114 +0,0 @@
-const MAX_TAB_COUNT = 3;
-
-const meta = {
-	type: 'problem',
-	docs: {
-		description: 'Disallow destructuring that does not meet certain conditions',
-		category: 'Possible Errors',
-		recommended: true,
-		url: 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/no-destructuring.md',
-	},
-	schema: [
-		{
-			type: 'object',
-			properties: {
-				maximumDestructuredVariables: {type: 'integer', minimum: 0},
-				maximumLineLength: {type: 'integer', minimum: 0},
-			},
-			additionalProperties: false,
-		},
-	],
-};
-
-function create(context) {
-	const MAX_VARIABLES = context?.options?.[0]?.maximumDestructuredVariables ?? 2;
-	const MAX_LINE_LENGTH = context?.options?.[0]?.maximumLineLength ?? 100;
-
-	const sourceCode = context.getSourceCode();
-
-	function reportIfNeeded(patternNode, reportNode = patternNode) {
-		if (!patternNode || patternNode.type !== 'ObjectPattern' || !patternNode.loc) {
-			return;
-		}
-
-		const lineText = sourceCode.lines[patternNode.loc.start.line - 1] ?? '';
-		const indentCount = lineText.search(/\S|$/);
-
-		const propertyCount = patternNode.properties?.length ?? 0;
-
-		const startLine = patternNode.loc.start.line;
-		const endLine = patternNode.loc.end.line;
-		let maxSpannedLineLength = 0;
-		for (let i = startLine; i <= endLine; i++) {
-			const t = sourceCode.lines[i - 1] ?? '';
-			if (t.length > maxSpannedLineLength) {
-				maxSpannedLineLength = t.length;
-			}
-		}
-
-		if (indentCount > MAX_TAB_COUNT) {
-			context.report({
-				node: reportNode,
-				message: `destructuring at a nesting level above ${MAX_TAB_COUNT} is not allowed, instead saw ${indentCount} levels of nesting`,
-			});
-		}
-
-		if (propertyCount > MAX_VARIABLES) {
-			context.report({
-				node: reportNode,
-				message: `destructuring of more than ${MAX_VARIABLES} variables is not allowed`,
-			});
-		}
-
-		if (maxSpannedLineLength > MAX_LINE_LENGTH) {
-			context.report({
-				node: reportNode,
-				message: `destructuring on a line exceeding ${MAX_LINE_LENGTH} characters is not allowed`,
-			});
-		}
-	}
-
-	function checkParameters(parameters) {
-		for (const p of parameters || []) {
-			if (!p) {
-				continue;
-			}
-
-			if (p.type === 'AssignmentPattern') {
-				reportIfNeeded(p.left, p);
-				continue;
-			}
-
-			reportIfNeeded(p, p);
-		}
-	}
-
-	return {
-
-		VariableDeclarator(node) {
-			reportIfNeeded(node?.id, node);
-		},
-
-		FunctionDeclaration(node) {
-			checkParameters(node.params);
-		},
-		FunctionExpression(node) {
-			checkParameters(node.params);
-		},
-		ArrowFunctionExpression(node) {
-			checkParameters(node.params);
-		},
-
-		MethodDefinition(node) {
-			if (node?.value?.params) {
-				checkParameters(node.value.params);
-			}
-		},
-
-		TSDeclareFunction(node) {
-			checkParameters(node.params);
-		},
-	};
-}
-
-module.exports = {meta, create};

package/src/rules/prefer-is-empty.js

@@ -1,104 +0,0 @@
-const meta = {
-	type: 'problem',
-	docs: {
-		description: 'Require _.isEmpty instead of length comparisons',
-		category: 'Best Practices',
-		recommended: true,
-		url: 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/prefer-is-empty.md',
-	},
-	hasSuggestions: true,
-	schema: [],
-};
-
-function create(context) {
-	const sourceCode = context.getSourceCode();
-
-	function isLengthAccess(node) {
-		return (
-			node
-			&& node.type === 'MemberExpression'
-			&& !node.computed
-			&& node.property.type === 'Identifier'
-			&& node.property.name === 'length'
-		);
-	}
-
-	function isNumericLiteral(node) {
-		return node && node.type === 'Literal' && typeof node.value === 'number';
-	}
-
-	function report(node, collectionNode, operator, value, isEmptyCheck) {
-		const collectionText = sourceCode.getText(collectionNode.object);
-		const replacement = isEmptyCheck
-			? `_.isEmpty(${collectionText})`
-			: `!_.isEmpty(${collectionText})`;
-
-		context.report({
-			node,
-			message: `Use _.isEmpty(${collectionText}) instead of checking ${collectionText}.length ${operator} ${value}`,
-			suggest: [
-				{
-					desc: `Replace with ${replacement}`,
-					fix(fixer) {
-						return fixer.replaceText(node, replacement);
-					},
-				},
-			],
-		});
-	}
-
-	return {
-		BinaryExpression(node) {
-			const {left, right, operator} = node;
-
-			// Values.length <op> N
-			if (isLengthAccess(left) && isNumericLiteral(right)) {
-				const {value} = right;
-
-				// EMPTY checks
-				if (
-					(operator === '===' && value === 0)
-					|| (operator === '<=' && value === 0)
-					|| (operator === '<' && value === 1)
-				) {
-					report(node, left, operator, value, true);
-					return;
-				}
-
-				// NOT EMPTY checks
-				if (
-					(operator === '>' && value === 0)
-					|| (operator === '>=' && value === 1)
-					|| ((operator === '!=' || operator === '!==') && value === 0)
-				) {
-					report(node, left, operator, value, false);
-				}
-			}
-
-			// N <op> values.length (reversed)
-			if (isNumericLiteral(left) && isLengthAccess(right)) {
-				const {value} = left;
-
-				// EMPTY checks
-				if (
-					(operator === '===' && value === 0)
-					|| (operator === '>=' && value === 0)
-					|| (operator === '>' && value === 0)
-				) {
-					report(node, right, operator, value, true);
-					return;
-				}
-
-				// NOT EMPTY checks
-				if (
-					(operator === '<' && value === 1)
-					|| (operator === '<=' && value === 0)
-				) {
-					report(node, right, operator, value, false);
-				}
-			}
-		},
-	};
-}
-
-module.exports = {meta, create};

package/src/rules/schemas-in-schemas-file.js

@@ -1,191 +0,0 @@
-const meta = {
-	type: 'problem',
-	docs: {
-		description: 'Require Zod schema declarations to be placed in a .schemas.ts file',
-		category: 'Stylistic Issues',
-		recommended: false,
-		url: 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/schemas-in-schemas-file.md',
-	},
-	schema: [
-		{
-			type: 'object',
-			properties: {
-				allowedSuffixes: {
-					type: 'array',
-					items: {type: 'string', minLength: 1},
-					minItems: 1,
-				},
-				/**
-				 * If true, only report when the Zod call is assigned to a variable
-				 * (e.g. const userSchema = z.object(...)).
-				 * If false, report any Zod schema-building call expression.
-				 */
-				onlyWhenAssigned: {type: 'boolean'},
-
-				/**
-				 * If true, allow Zod calls inside *.test.* / *.spec.* files.
-				 */
-				allowInTests: {type: 'boolean'},
-			},
-			additionalProperties: false,
-		},
-	],
-	messages: {
-		moveSchema:
-			'Zod schemas must be defined in a dedicated schemas file ({{suffixes}}).',
-	},
-};
-
-function create(context) {
-	const options = context.options?.[0] ?? {};
-	const allowedSuffixes = options.allowedSuffixes ?? ['.schemas.ts'];
-	const onlyWhenAssigned = Boolean(options.onlyWhenAssigned);
-	const allowInTests = Boolean(options.allowInTests);
-
-	/** @type {Set<string>} */
-	const zodIdentifiers = new Set();
-
-	function filenameAllowed(filename) {
-		if (!filename || filename === '<input>') {
-			return false;
-		}
-
-		if (allowInTests
-			&& /\.(test|spec)\.[jt]sx?$/.test(filename)) {
-			return true;
-		}
-
-		return allowedSuffixes.some(suffix => filename.endsWith(suffix));
-	}
-
-	function isZodModuleImport(node) {
-		return node?.source?.type === 'Literal' && node.source.value === 'zod';
-	}
-
-	function collectZodIdentifiersFromImport(node) {
-		if (!isZodModuleImport(node)) {
-			return;
-		}
-
-		for (const spec of node.specifiers ?? []) {
-			if (spec.type === 'ImportSpecifier') {
-				const imported = spec.imported;
-				const local = spec.local;
-
-				if (imported?.type === 'Identifier' && imported.name === 'z' && local?.type === 'Identifier') {
-					zodIdentifiers.add(local.name);
-				}
-			}
-
-			if (spec.type === 'ImportNamespaceSpecifier' && spec.local?.type === 'Identifier') {
-				zodIdentifiers.add(spec.local.name);
-			}
-		}
-	}
-
-	function isZodBuilderCall(node) {
-		const callee = node?.callee;
-		if (!callee || callee.type !== 'MemberExpression') {
-			return false;
-		}
-
-		if (callee.computed) {
-			return false;
-		}
-
-		const object = callee.object;
-		const property = callee.property;
-
-		if (object?.type !== 'Identifier') {
-			return false;
-		}
-
-		if (!zodIdentifiers.has(object.name)) {
-			return false;
-		}
-
-		return property?.type === 'Identifier';
-	}
-
-	function isZodChainedBuilderCall(node) {
-		const callee = node?.callee;
-		if (!callee || callee.type !== 'MemberExpression') {
-			return false;
-		}
-
-		if (callee.computed) {
-			return false;
-		}
-
-		let current = callee.object;
-		while (current && current.type === 'MemberExpression' && !current.computed) {
-			current = current.object;
-		}
-
-		return current?.type === 'Identifier' && zodIdentifiers.has(current.name);
-	}
-
-	function getAssignmentTargetName(callNode) {
-		const p = callNode.parent;
-
-		if (p?.type === 'VariableDeclarator') {
-			if (p.id?.type === 'Identifier') {
-				return p.id.name;
-			}
-
-			return null;
-		}
-
-		if (p?.type === 'AssignmentExpression') {
-			if (p.left?.type === 'Identifier') {
-				return p.left.name;
-			}
-
-			return null;
-		}
-
-		return null;
-	}
-
-	function report(node) {
-		const filename = context.getFilename();
-		if (filenameAllowed(filename)) {
-			return;
-		}
-
-		const targetName = getAssignmentTargetName(node);
-		if (onlyWhenAssigned && !targetName) {
-			return;
-		}
-
-		const target = targetName ? ` "${targetName}"` : '';
-
-		context.report({
-			node,
-			messageId: 'moveSchema',
-			data: {
-				filename,
-				suffixes: allowedSuffixes.join(' or '),
-				target,
-			},
-		});
-	}
-
-	return {
-		ImportDeclaration(node) {
-			collectZodIdentifiersFromImport(node);
-		},
-
-		CallExpression(node) {
-			if (zodIdentifiers.size === 0) {
-				return;
-			}
-
-			if (isZodBuilderCall(node) || isZodChainedBuilderCall(node)) {
-				report(node);
-			}
-		},
-	};
-}
-
-module.exports = {meta, create};