eslint-plugin-th-rules 2.7.0 → 2.7.1

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [2.7.1](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v2.7.0...v2.7.1) (2026-01-14)
+
+
+### Bug Fixes
+
+* update no-boolean-coercion rule to enforce explicit checks with negation ([a9e7752](https://github.com/tomerh2001/eslint-plugin-th-rules/commit/a9e77524035efbd023330168e2d070a6419cde70))
+
 # [2.7.0](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v2.6.1...v2.7.0) (2026-01-14)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-th-rules",
-  "version": "2.7.0",
+  "version": "2.7.1",
   "description": "A List of custom ESLint rules created by Tomer Horowitz",
   "keywords": [
     "eslint",

package/src/rules/no-boolean-coercion.js

@@ -2,7 +2,7 @@ const meta = {
 	type: 'problem',
 	docs: {
 		description:
-    'Disallow Boolean(value) or !!value. Enforce _.isNil(value) for scalar values and _.isEmpty(value) for strings, arrays, and objects.',
+			'Disallow Boolean(value) or !!value. Enforce explicit checks: !_.isNil(value) for scalar values and !_.isEmpty(value) for strings, arrays, and objects.',
 		category: 'Best Practices',
 		recommended: true,
 		url: 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/no-boolean-coercion.md',
@@ -11,9 +11,9 @@ const meta = {
 	schema: [],
 	messages: {
 		useIsEmpty:
-      'Boolean coercion is not allowed. Use _.isEmpty(value) for strings, arrays, and objects.',
+			'Boolean coercion is not allowed. Use !_.isEmpty(value) for strings, arrays, and objects.',
 		useIsNil:
-      'Boolean coercion is not allowed. Use _.isNil(value) for scalar values.',
+			'Boolean coercion is not allowed. Use !_.isNil(value) for scalar values.',
 	},
 };
 
@@ -51,7 +51,6 @@ function create(context) {
 		}
 
 		const type = checker.getTypeAtLocation(tsNode);
-
 		const typeString = checker.typeToString(type);
 
 		return (
@@ -67,7 +66,7 @@ function create(context) {
 		return (
 			node.type === 'ArrayExpression'
 			|| node.type === 'ObjectExpression'
-			|| node.type === 'Literal' && typeof node.value === 'string'
+			|| (node.type === 'Literal' && typeof node.value === 'string')
 		);
 	}
 
@@ -77,7 +76,7 @@ function create(context) {
 				|| isCollectionLikeByTS(valueNode);
 
 		const suggestedFn = isCollection ? '_.isEmpty' : '_.isNil';
-		const replacement = `${suggestedFn}(${sourceCode.getText(valueNode)})`;
+		const replacement = `!${suggestedFn}(${sourceCode.getText(valueNode)})`;
 
 		context.report({
 			node,

package/tests/no-boolean-coercion.test.ts

@@ -27,8 +27,8 @@ ruleTester.run('no-boolean-coercion', rule, {
 					messageId: 'useIsNil',
 					suggestions: [
 						{
-							desc: 'Replace with _.isNil(foo)',
-							output: '_.isNil(foo);',
+							desc: 'Replace with !_.isNil(foo)',
+							output: '!_.isNil(foo);',
 						},
 					],
 				},
@@ -42,8 +42,8 @@ ruleTester.run('no-boolean-coercion', rule, {
 					messageId: 'useIsNil',
 					suggestions: [
 						{
-							desc: 'Replace with _.isNil(bar)',
-							output: 'const x = _.isNil(bar);',
+							desc: 'Replace with !_.isNil(bar)',
+							output: 'const x = !_.isNil(bar);',
 						},
 					],
 				},
@@ -57,8 +57,8 @@ ruleTester.run('no-boolean-coercion', rule, {
 					messageId: 'useIsNil',
 					suggestions: [
 						{
-							desc: 'Replace with _.isNil(value)',
-							output: '_.isNil(value);',
+							desc: 'Replace with !_.isNil(value)',
+							output: '!_.isNil(value);',
 						},
 					],
 				},
@@ -72,8 +72,8 @@ ruleTester.run('no-boolean-coercion', rule, {
 					messageId: 'useIsEmpty',
 					suggestions: [
 						{
-							desc: 'Replace with _.isEmpty([])',
-							output: '_.isEmpty([]);',
+							desc: 'Replace with !_.isEmpty([])',
+							output: '!_.isEmpty([]);',
 						},
 					],
 				},