eslint-plugin-th-rules 2.6.1 → 2.7.0

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+# [2.7.0](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v2.6.1...v2.7.0) (2026-01-14)
+
+
+### Features
+
+* remove prefer-explicit-nil-or-empty-check rule and associated tests ([2aded48](https://github.com/tomerh2001/eslint-plugin-th-rules/commit/2aded48d6f7df8d205cf7817afe3c0fdca39601c))
+
 ## [2.6.1](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v2.6.0...v2.6.1) (2026-01-14)
 
 

package/README.md

@@ -11,24 +11,22 @@ This repository contains custom ESLint rules to enhance code quality and consist
 <!-- begin auto-generated rules list -->
 
 💼 Configurations enabled in.\
-🚫 Configurations disabled in.\
 ✅ Set in the `recommended` configuration.\
 ⚛️ Set in the `recommended-react` configuration.\
 🟦 Set in the `recommended-typescript` configuration.\
 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).\
 💡 Manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
 
-| Name                                                                                   | Description                                                                                                                         | 💼      | 🚫 | 🔧 | 💡 |
-| :------------------------------------------------------------------------------------- | :---------------------------------------------------------------------------------------------------------------------------------- | :------ | :- | :- | :- |
-| [no-boolean-coercion](docs/rules/no-boolean-coercion.md)                               | Disallow Boolean(value) or !!value. Enforce _.isNil(value) for scalar values and _.isEmpty(value) for strings, arrays, and objects. | ✅ ⚛️ 🟦 |    |    | 💡 |
-| [no-comments](docs/rules/no-comments.md)                                               | Disallow comments except for specified allowed patterns.                                                                            | ✅ ⚛️ 🟦 |    | 🔧 |    |
-| [no-default-export](docs/rules/no-default-export.md)                                   | Convert unnamed default exports to named default exports based on the file name.                                                    | ✅ ⚛️ 🟦 |    | 🔧 |    |
-| [no-destructuring](docs/rules/no-destructuring.md)                                     | Disallow destructuring that does not meet certain conditions                                                                        | ✅ ⚛️ 🟦 |    |    |    |
-| [prefer-explicit-nil-or-empty-check](docs/rules/prefer-explicit-nil-or-empty-check.md) | Disallow implicit truthy/falsy checks on non-boolean values; require _.isNil or _.isEmpty                                           |         | 🟦 |    | 💡 |
-| [prefer-is-empty](docs/rules/prefer-is-empty.md)                                       | Require _.isEmpty instead of length comparisons                                                                                     | ✅ ⚛️ 🟦 |    |    | 💡 |
-| [schemas-in-schemas-file](docs/rules/schemas-in-schemas-file.md)                       | Require Zod schema declarations to be placed in a .schemas.ts file                                                                  | ✅ ⚛️ 🟦 |    |    |    |
-| [top-level-functions](docs/rules/top-level-functions.md)                               | Require all top-level functions to be named/regular functions.                                                                      | ✅ ⚛️ 🟦 |    | 🔧 |    |
-| [types-in-dts](docs/rules/types-in-dts.md)                                             | Require TypeScript type declarations (type/interface/enum) to be placed in .d.ts files                                              | ✅ ⚛️ 🟦 |    |    |    |
+| Name                                                             | Description                                                                                                                         | 💼      | 🔧 | 💡 |
+| :--------------------------------------------------------------- | :---------------------------------------------------------------------------------------------------------------------------------- | :------ | :- | :- |
+| [no-boolean-coercion](docs/rules/no-boolean-coercion.md)         | Disallow Boolean(value) or !!value. Enforce _.isNil(value) for scalar values and _.isEmpty(value) for strings, arrays, and objects. | ✅ ⚛️ 🟦 |    | 💡 |
+| [no-comments](docs/rules/no-comments.md)                         | Disallow comments except for specified allowed patterns.                                                                            | ✅ ⚛️ 🟦 | 🔧 |    |
+| [no-default-export](docs/rules/no-default-export.md)             | Convert unnamed default exports to named default exports based on the file name.                                                    | ✅ ⚛️ 🟦 | 🔧 |    |
+| [no-destructuring](docs/rules/no-destructuring.md)               | Disallow destructuring that does not meet certain conditions                                                                        | ✅ ⚛️ 🟦 |    |    |
+| [prefer-is-empty](docs/rules/prefer-is-empty.md)                 | Require _.isEmpty instead of length comparisons                                                                                     | ✅ ⚛️ 🟦 |    | 💡 |
+| [schemas-in-schemas-file](docs/rules/schemas-in-schemas-file.md) | Require Zod schema declarations to be placed in a .schemas.ts file                                                                  | ✅ ⚛️ 🟦 |    |    |
+| [top-level-functions](docs/rules/top-level-functions.md)         | Require all top-level functions to be named/regular functions.                                                                      | ✅ ⚛️ 🟦 | 🔧 |    |
+| [types-in-dts](docs/rules/types-in-dts.md)                       | Require TypeScript type declarations (type/interface/enum) to be placed in .d.ts files                                              | ✅ ⚛️ 🟦 |    |    |
 
 <!-- end auto-generated rules list -->
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-th-rules",
-  "version": "2.6.1",
+  "version": "2.7.0",
   "description": "A List of custom ESLint rules created by Tomer Horowitz",
   "keywords": [
     "eslint",

package/src/index.js

@@ -67,7 +67,6 @@ const baseRecommended = {
 		'th-rules/types-in-dts': 'error',
 		'th-rules/no-boolean-coercion': 'error',
 		'th-rules/prefer-is-empty': 'error',
-		'th-rules/prefer-explicit-nil-or-empty-check': 'off',
 		'unicorn/filename-case': 'off',
 		'unicorn/no-array-callback-reference': 'off',
 		'import/extensions': 'off',

package/docs/rules/prefer-explicit-nil-or-empty-check.md

@@ -1,9 +0,0 @@
-# th-rules/prefer-explicit-nil-or-empty-check
-
-📝 Disallow implicit truthy/falsy checks on non-boolean values; require _.isNil or _.isEmpty.
-
-🚫 This rule is _disabled_ in the 🟦 `recommended-typescript` config.
-
-💡 This rule is manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
-
-<!-- end auto-generated rule header -->

package/src/rules/prefer-explicit-nil-or-empty-check.js

@@ -1,102 +0,0 @@
-const meta = {
-	type: 'problem',
-	docs: {
-		description:
-			'Disallow implicit truthy/falsy checks on non-boolean values; require _.isNil or _.isEmpty',
-		category: 'Best Practices',
-		recommended: true,
-		url: 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/prefer-explicit-nil-or-empty-check.md',
-	},
-	hasSuggestions: true,
-	schema: [],
-};
-
-function create(context) {
-	const sourceCode = context.getSourceCode();
-
-	function isBooleanLiteral(node) {
-		return node.type === 'Literal' && typeof node.value === 'boolean';
-	}
-
-	function isUnaryNot(node) {
-		return node.type === 'UnaryExpression' && node.operator === '!';
-	}
-
-	function isImplicitTruthyTarget(node) {
-		return (
-			node.type === 'Identifier'
-			|| node.type === 'MemberExpression'
-		);
-	}
-
-	function report(node, testedNode, negated) {
-		const text = sourceCode.getText(testedNode);
-
-		const isNilExpr = negated
-			? `!_.isNil(${text})`
-			: `_.isNil(${text})`;
-
-		const isEmptyExpr = negated
-			? `!_.isEmpty(${text})`
-			: `_.isEmpty(${text})`;
-
-		context.report({
-			node,
-			message:
-				'Implicit truthy/falsy check on a non-boolean value is not allowed; use explicit _.isNil or _.isEmpty checks',
-			suggest: [
-				{
-					desc: `Replace with ${isNilExpr}`,
-					fix: fixer => fixer.replaceText(node, isNilExpr),
-				},
-				{
-					desc: `Replace with ${isEmptyExpr}`,
-					fix: fixer => fixer.replaceText(node, isEmptyExpr),
-				},
-			],
-		});
-	}
-
-	function checkTestExpression(node) {
-		// If (dataObject)
-		if (isImplicitTruthyTarget(node)) {
-			report(node, node, true);
-			return;
-		}
-
-		// If (!dataObject)
-		if (
-			isUnaryNot(node)
-			&& isImplicitTruthyTarget(node.argument)
-			&& !isBooleanLiteral(node.argument)
-		) {
-			report(node, node.argument, false);
-		}
-	}
-
-	return {
-		IfStatement(node) {
-			checkTestExpression(node.test);
-		},
-
-		WhileStatement(node) {
-			checkTestExpression(node.test);
-		},
-
-		DoWhileStatement(node) {
-			checkTestExpression(node.test);
-		},
-
-		ConditionalExpression(node) {
-			checkTestExpression(node.test);
-		},
-
-		LogicalExpression(node) {
-			if (node.operator === '&&' || node.operator === '||') {
-				checkTestExpression(node.left);
-			}
-		},
-	};
-}
-
-module.exports = {meta, create};

package/tests/prefer-explicit-nil-or-empty-check.test.ts

@@ -1,113 +0,0 @@
-const {RuleTester} = require('@typescript-eslint/rule-tester');
-const rule = require('../src/rules/prefer-explicit-nil-or-empty-check');
-
-const ruleTester = new RuleTester({
-	languageOptions: {
-		ecmaVersion: 2020,
-		sourceType: 'module',
-	},
-});
-
-ruleTester.run('prefer-explicit-nil-or-empty-check', rule, {
-	valid: [
-		// Explicit checks – allowed
-		'if (_.isNil(value)) {}',
-		'if (!_.isNil(value)) {}',
-		'if (_.isEmpty(list)) {}',
-		'if (!_.isEmpty(list)) {}',
-
-		// Explicit comparisons – allowed
-		'if (value != null) {}',
-		'if (list.length > 0) {}',
-
-		// Boolean values – allowed
-		'if (true) {}',
-		'if (false) {}',
-
-		// Non-control-flow usage – allowed
-		'value;',
-		'doSomething(value);',
-	],
-
-	invalid: [
-		{
-			code: 'if (dataObject) {}',
-			errors: [
-				{
-					message:
-						'Implicit truthy/falsy check on a non-boolean value is not allowed; use explicit _.isNil or _.isEmpty checks',
-					suggestions: [
-						{
-							desc: 'Replace with !_.isNil(dataObject)',
-							output: 'if (!_.isNil(dataObject)) {}',
-						},
-						{
-							desc: 'Replace with !_.isEmpty(dataObject)',
-							output: 'if (!_.isEmpty(dataObject)) {}',
-						},
-					],
-				},
-			],
-		},
-
-		{
-			code: 'if (!dataObject) {}',
-			errors: [
-				{
-					message:
-						'Implicit truthy/falsy check on a non-boolean value is not allowed; use explicit _.isNil or _.isEmpty checks',
-					suggestions: [
-						{
-							desc: 'Replace with _.isNil(dataObject)',
-							output: 'if (_.isNil(dataObject)) {}',
-						},
-						{
-							desc: 'Replace with _.isEmpty(dataObject)',
-							output: 'if (_.isEmpty(dataObject)) {}',
-						},
-					],
-				},
-			],
-		},
-
-		{
-			code: 'while (items) {}',
-			errors: [
-				{
-					message:
-						'Implicit truthy/falsy check on a non-boolean value is not allowed; use explicit _.isNil or _.isEmpty checks',
-					suggestions: [
-						{
-							desc: 'Replace with !_.isNil(items)',
-							output: 'while (!_.isNil(items)) {}',
-						},
-						{
-							desc: 'Replace with !_.isEmpty(items)',
-							output: 'while (!_.isEmpty(items)) {}',
-						},
-					],
-				},
-			],
-		},
-
-		{
-			code: 'data && doSomething();',
-			errors: [
-				{
-					message:
-						'Implicit truthy/falsy check on a non-boolean value is not allowed; use explicit _.isNil or _.isEmpty checks',
-					suggestions: [
-						{
-							desc: 'Replace with !_.isNil(data)',
-							output: '!_.isNil(data) && doSomething();',
-						},
-						{
-							desc: 'Replace with !_.isEmpty(data)',
-							output: '!_.isEmpty(data) && doSomething();',
-						},
-					],
-				},
-			],
-		},
-	],
-});