eslint-plugin-th-rules 2.6.0 → 2.7.0

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+# [2.7.0](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v2.6.1...v2.7.0) (2026-01-14)
+
+
+### Features
+
+* remove prefer-explicit-nil-or-empty-check rule and associated tests ([2aded48](https://github.com/tomerh2001/eslint-plugin-th-rules/commit/2aded48d6f7df8d205cf7817afe3c0fdca39601c))
+
+## [2.6.1](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v2.6.0...v2.6.1) (2026-01-14)
+
+
+### Bug Fixes
+
+* refactor prefer-explicit-nil-or-empty-check rule and add tests for implicit checks ([d153066](https://github.com/tomerh2001/eslint-plugin-th-rules/commit/d1530664708cf31025d5ebf1b92f6b68401c5448))
+
 # [2.6.0](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v2.5.1...v2.6.0) (2026-01-14)
 
 

package/README.md

@@ -23,7 +23,7 @@ This repository contains custom ESLint rules to enhance code quality and consist
 | [no-comments](docs/rules/no-comments.md)                         | Disallow comments except for specified allowed patterns.                                                                            | ✅ ⚛️ 🟦 | 🔧 |    |
 | [no-default-export](docs/rules/no-default-export.md)             | Convert unnamed default exports to named default exports based on the file name.                                                    | ✅ ⚛️ 🟦 | 🔧 |    |
 | [no-destructuring](docs/rules/no-destructuring.md)               | Disallow destructuring that does not meet certain conditions                                                                        | ✅ ⚛️ 🟦 |    |    |
-| [prefer-is-empty](docs/rules/prefer-is-empty.md)                 | Require _.isEmpty instead of length comparisons                                                                                     |         |    |    |
+| [prefer-is-empty](docs/rules/prefer-is-empty.md)                 | Require _.isEmpty instead of length comparisons                                                                                     | ✅ ⚛️ 🟦 |    | 💡 |
 | [schemas-in-schemas-file](docs/rules/schemas-in-schemas-file.md) | Require Zod schema declarations to be placed in a .schemas.ts file                                                                  | ✅ ⚛️ 🟦 |    |    |
 | [top-level-functions](docs/rules/top-level-functions.md)         | Require all top-level functions to be named/regular functions.                                                                      | ✅ ⚛️ 🟦 | 🔧 |    |
 | [types-in-dts](docs/rules/types-in-dts.md)                       | Require TypeScript type declarations (type/interface/enum) to be placed in .d.ts files                                              | ✅ ⚛️ 🟦 |    |    |

package/docs/rules/prefer-is-empty.md

@@ -2,4 +2,8 @@
 
 📝 Require _.isEmpty instead of length comparisons.
 
+💼 This rule is enabled in the following configs: ✅ `recommended`, ⚛️ `recommended-react`, 🟦 `recommended-typescript`.
+
+💡 This rule is manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
+
 <!-- end auto-generated rule header -->

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-th-rules",
-  "version": "2.6.0",
+  "version": "2.7.0",
   "description": "A List of custom ESLint rules created by Tomer Horowitz",
   "keywords": [
     "eslint",

package/src/index.js

@@ -115,7 +115,6 @@ plugin.configs['recommended-typescript'] = flatConfigs(
 			},
 		},
 		rules: {
-			'th-rules/prefer-explicit-nil-or-empty-check': 'off',
 			'@typescript-eslint/consistent-type-definitions': 'off',
 			'@typescript-eslint/no-extraneous-class': 'off',
 			'@typescript-eslint/no-duplicate-type-constituents': 'off',

package/tests/no-boolean-coercion.test.ts

@@ -1,7 +1,12 @@
 const {RuleTester} = require('@typescript-eslint/rule-tester');
 const rule = require('../src/rules/no-boolean-coercion');
 
-const ruleTester = new RuleTester({});
+const ruleTester = new RuleTester({
+	languageOptions: {
+		ecmaVersion: 2020,
+		sourceType: 'module',
+	},
+});
 
 ruleTester.run('no-boolean-coercion', rule, {
 	valid: [

package/tests/prefer-is-empty.test.ts

@@ -1,7 +1,12 @@
 const {RuleTester} = require('@typescript-eslint/rule-tester');
 const rule = require('../src/rules/prefer-is-empty');
 
-const ruleTester = new RuleTester({});
+const ruleTester = new RuleTester({
+	languageOptions: {
+		ecmaVersion: 2020,
+		sourceType: 'module',
+	},
+});
 
 ruleTester.run('prefer-is-empty', rule, {
 	valid: [

package/src/rules/prefer-explicit-nil-or-empty-check.js

@@ -1,115 +0,0 @@
-'use strict';
-
-const ts = require('typescript');
-
-const meta = {
-	type: 'problem',
-	docs: {
-		description:
-			'Disallow implicit truthy/falsy checks on non-boolean values; require _.isNil or _.isEmpty',
-		category: 'Best Practices',
-		recommended: true,
-		url: 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/prefer-explicit-nil-or-empty-check.md',
-	},
-	hasSuggestions: true,
-	schema: [],
-	requiresTypeChecking: true,
-};
-
-function create(context) {
-	const sourceCode = context.getSourceCode();
-	const {parserServices} = context;
-
-	// Safety: rule is disabled if type info is unavailable
-	if (!parserServices?.program || !parserServices.esTreeNodeToTSNodeMap) {
-		return {};
-	}
-
-	const checker = parserServices.program.getTypeChecker();
-
-	function isImplicitTruthyTarget(node) {
-		return (
-			node.type === 'Identifier'
-			|| node.type === 'MemberExpression'
-		);
-	}
-
-	function isBooleanType(node) {
-		const tsNode = parserServices.esTreeNodeToTSNodeMap.get(node);
-		if (!tsNode) {
-			return false;
-		}
-
-		const type = checker.getTypeAtLocation(tsNode);
-
-		return (
-			(type.flags & ts.TypeFlags.Boolean) !== 0
-			|| (type.flags & ts.TypeFlags.BooleanLiteral) !== 0
-		);
-	}
-
-	function report(node, testedNode, negated) {
-		const text = sourceCode.getText(testedNode);
-
-		const isNilExpr = negated
-			? `!_.isNil(${text})`
-			: `_.isNil(${text})`;
-
-		const isEmptyExpr = negated
-			? `!_.isEmpty(${text})`
-			: `_.isEmpty(${text})`;
-
-		context.report({
-			node,
-			message:
-				'Avoid implicit truthy/falsy checks on non-boolean values; use _.isNil or _.isEmpty instead',
-			suggest: [
-				{
-					desc: `Replace with ${isNilExpr}`,
-					fix(fixer) {
-						return fixer.replaceText(node, isNilExpr);
-					},
-				},
-				{
-					desc: `Replace with ${isEmptyExpr}`,
-					fix(fixer) {
-						return fixer.replaceText(node, isEmptyExpr);
-					},
-				},
-			],
-		});
-	}
-
-	return {
-		IfStatement(node) {
-			const {test} = node;
-
-			// If (!value)
-			if (test.type === 'UnaryExpression' && test.operator === '!') {
-				const arg = test.argument;
-
-				if (!isImplicitTruthyTarget(arg)) {
-					return;
-				}
-
-				if (isBooleanType(arg)) {
-					return;
-				}
-
-				report(test, arg, true);
-				return;
-			}
-
-			// If (value)
-			if (isImplicitTruthyTarget(test)) {
-				if (isBooleanType(test)) {
-					return;
-				}
-
-				report(test, test, false);
-			}
-		},
-	};
-}
-
-module.exports = {meta, create};