eslint-plugin-th-rules 2.6.0 → 2.6.1

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [2.6.1](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v2.6.0...v2.6.1) (2026-01-14)
+
+
+### Bug Fixes
+
+* refactor prefer-explicit-nil-or-empty-check rule and add tests for implicit checks ([d153066](https://github.com/tomerh2001/eslint-plugin-th-rules/commit/d1530664708cf31025d5ebf1b92f6b68401c5448))
+
 # [2.6.0](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v2.5.1...v2.6.0) (2026-01-14)
 
 

package/README.md

@@ -11,22 +11,24 @@ This repository contains custom ESLint rules to enhance code quality and consist
 <!-- begin auto-generated rules list -->
 
 💼 Configurations enabled in.\
+🚫 Configurations disabled in.\
 ✅ Set in the `recommended` configuration.\
 ⚛️ Set in the `recommended-react` configuration.\
 🟦 Set in the `recommended-typescript` configuration.\
 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).\
 💡 Manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
 
-| Name                                                             | Description                                                                                                                         | 💼      | 🔧 | 💡 |
-| :--------------------------------------------------------------- | :---------------------------------------------------------------------------------------------------------------------------------- | :------ | :- | :- |
-| [no-boolean-coercion](docs/rules/no-boolean-coercion.md)         | Disallow Boolean(value) or !!value. Enforce _.isNil(value) for scalar values and _.isEmpty(value) for strings, arrays, and objects. | ✅ ⚛️ 🟦 |    | 💡 |
-| [no-comments](docs/rules/no-comments.md)                         | Disallow comments except for specified allowed patterns.                                                                            | ✅ ⚛️ 🟦 | 🔧 |    |
-| [no-default-export](docs/rules/no-default-export.md)             | Convert unnamed default exports to named default exports based on the file name.                                                    | ✅ ⚛️ 🟦 | 🔧 |    |
-| [no-destructuring](docs/rules/no-destructuring.md)               | Disallow destructuring that does not meet certain conditions                                                                        | ✅ ⚛️ 🟦 |    |    |
-| [prefer-is-empty](docs/rules/prefer-is-empty.md)                 | Require _.isEmpty instead of length comparisons                                                                                     |         |    |    |
-| [schemas-in-schemas-file](docs/rules/schemas-in-schemas-file.md) | Require Zod schema declarations to be placed in a .schemas.ts file                                                                  | ✅ ⚛️ 🟦 |    |    |
-| [top-level-functions](docs/rules/top-level-functions.md)         | Require all top-level functions to be named/regular functions.                                                                      | ✅ ⚛️ 🟦 | 🔧 |    |
-| [types-in-dts](docs/rules/types-in-dts.md)                       | Require TypeScript type declarations (type/interface/enum) to be placed in .d.ts files                                              | ✅ ⚛️ 🟦 |    |    |
+| Name                                                                                   | Description                                                                                                                         | 💼      | 🚫 | 🔧 | 💡 |
+| :------------------------------------------------------------------------------------- | :---------------------------------------------------------------------------------------------------------------------------------- | :------ | :- | :- | :- |
+| [no-boolean-coercion](docs/rules/no-boolean-coercion.md)                               | Disallow Boolean(value) or !!value. Enforce _.isNil(value) for scalar values and _.isEmpty(value) for strings, arrays, and objects. | ✅ ⚛️ 🟦 |    |    | 💡 |
+| [no-comments](docs/rules/no-comments.md)                                               | Disallow comments except for specified allowed patterns.                                                                            | ✅ ⚛️ 🟦 |    | 🔧 |    |
+| [no-default-export](docs/rules/no-default-export.md)                                   | Convert unnamed default exports to named default exports based on the file name.                                                    | ✅ ⚛️ 🟦 |    | 🔧 |    |
+| [no-destructuring](docs/rules/no-destructuring.md)                                     | Disallow destructuring that does not meet certain conditions                                                                        | ✅ ⚛️ 🟦 |    |    |    |
+| [prefer-explicit-nil-or-empty-check](docs/rules/prefer-explicit-nil-or-empty-check.md) | Disallow implicit truthy/falsy checks on non-boolean values; require _.isNil or _.isEmpty                                           |         | 🟦 |    | 💡 |
+| [prefer-is-empty](docs/rules/prefer-is-empty.md)                                       | Require _.isEmpty instead of length comparisons                                                                                     | ✅ ⚛️ 🟦 |    |    | 💡 |
+| [schemas-in-schemas-file](docs/rules/schemas-in-schemas-file.md)                       | Require Zod schema declarations to be placed in a .schemas.ts file                                                                  | ✅ ⚛️ 🟦 |    |    |    |
+| [top-level-functions](docs/rules/top-level-functions.md)                               | Require all top-level functions to be named/regular functions.                                                                      | ✅ ⚛️ 🟦 |    | 🔧 |    |
+| [types-in-dts](docs/rules/types-in-dts.md)                                             | Require TypeScript type declarations (type/interface/enum) to be placed in .d.ts files                                              | ✅ ⚛️ 🟦 |    |    |    |
 
 <!-- end auto-generated rules list -->
 

package/docs/rules/prefer-explicit-nil-or-empty-check.md

@@ -0,0 +1,9 @@
+# th-rules/prefer-explicit-nil-or-empty-check
+
+📝 Disallow implicit truthy/falsy checks on non-boolean values; require _.isNil or _.isEmpty.
+
+🚫 This rule is _disabled_ in the 🟦 `recommended-typescript` config.
+
+💡 This rule is manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
+
+<!-- end auto-generated rule header -->

package/docs/rules/prefer-is-empty.md

@@ -2,4 +2,8 @@
 
 📝 Require _.isEmpty instead of length comparisons.
 
+💼 This rule is enabled in the following configs: ✅ `recommended`, ⚛️ `recommended-react`, 🟦 `recommended-typescript`.
+
+💡 This rule is manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
+
 <!-- end auto-generated rule header -->

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-th-rules",
-  "version": "2.6.0",
+  "version": "2.6.1",
   "description": "A List of custom ESLint rules created by Tomer Horowitz",
   "keywords": [
     "eslint",

package/src/index.js

@@ -67,6 +67,7 @@ const baseRecommended = {
 		'th-rules/types-in-dts': 'error',
 		'th-rules/no-boolean-coercion': 'error',
 		'th-rules/prefer-is-empty': 'error',
+		'th-rules/prefer-explicit-nil-or-empty-check': 'off',
 		'unicorn/filename-case': 'off',
 		'unicorn/no-array-callback-reference': 'off',
 		'import/extensions': 'off',
@@ -115,7 +116,6 @@ plugin.configs['recommended-typescript'] = flatConfigs(
 			},
 		},
 		rules: {
-			'th-rules/prefer-explicit-nil-or-empty-check': 'off',
 			'@typescript-eslint/consistent-type-definitions': 'off',
 			'@typescript-eslint/no-extraneous-class': 'off',
 			'@typescript-eslint/no-duplicate-type-constituents': 'off',

package/src/rules/prefer-explicit-nil-or-empty-check.js

@@ -1,7 +1,3 @@
-'use strict';
-
-const ts = require('typescript');
-
 const meta = {
 	type: 'problem',
 	docs: {
@@ -13,19 +9,18 @@ const meta = {
 	},
 	hasSuggestions: true,
 	schema: [],
-	requiresTypeChecking: true,
 };
 
 function create(context) {
 	const sourceCode = context.getSourceCode();
-	const {parserServices} = context;
 
-	// Safety: rule is disabled if type info is unavailable
-	if (!parserServices?.program || !parserServices.esTreeNodeToTSNodeMap) {
-		return {};
+	function isBooleanLiteral(node) {
+		return node.type === 'Literal' && typeof node.value === 'boolean';
 	}
 
-	const checker = parserServices.program.getTypeChecker();
+	function isUnaryNot(node) {
+		return node.type === 'UnaryExpression' && node.operator === '!';
+	}
 
 	function isImplicitTruthyTarget(node) {
 		return (
@@ -34,20 +29,6 @@ function create(context) {
 		);
 	}
 
-	function isBooleanType(node) {
-		const tsNode = parserServices.esTreeNodeToTSNodeMap.get(node);
-		if (!tsNode) {
-			return false;
-		}
-
-		const type = checker.getTypeAtLocation(tsNode);
-
-		return (
-			(type.flags & ts.TypeFlags.Boolean) !== 0
-			|| (type.flags & ts.TypeFlags.BooleanLiteral) !== 0
-		);
-	}
-
 	function report(node, testedNode, negated) {
 		const text = sourceCode.getText(testedNode);
 
@@ -62,51 +43,57 @@ function create(context) {
 		context.report({
 			node,
 			message:
-				'Avoid implicit truthy/falsy checks on non-boolean values; use _.isNil or _.isEmpty instead',
+				'Implicit truthy/falsy check on a non-boolean value is not allowed; use explicit _.isNil or _.isEmpty checks',
 			suggest: [
 				{
 					desc: `Replace with ${isNilExpr}`,
-					fix(fixer) {
-						return fixer.replaceText(node, isNilExpr);
-					},
+					fix: fixer => fixer.replaceText(node, isNilExpr),
 				},
 				{
 					desc: `Replace with ${isEmptyExpr}`,
-					fix(fixer) {
-						return fixer.replaceText(node, isEmptyExpr);
-					},
+					fix: fixer => fixer.replaceText(node, isEmptyExpr),
 				},
 			],
 		});
 	}
 
-	return {
-		IfStatement(node) {
-			const {test} = node;
+	function checkTestExpression(node) {
+		// If (dataObject)
+		if (isImplicitTruthyTarget(node)) {
+			report(node, node, true);
+			return;
+		}
 
-			// If (!value)
-			if (test.type === 'UnaryExpression' && test.operator === '!') {
-				const arg = test.argument;
+		// If (!dataObject)
+		if (
+			isUnaryNot(node)
+			&& isImplicitTruthyTarget(node.argument)
+			&& !isBooleanLiteral(node.argument)
+		) {
+			report(node, node.argument, false);
+		}
+	}
 
-				if (!isImplicitTruthyTarget(arg)) {
-					return;
-				}
+	return {
+		IfStatement(node) {
+			checkTestExpression(node.test);
+		},
 
-				if (isBooleanType(arg)) {
-					return;
-				}
+		WhileStatement(node) {
+			checkTestExpression(node.test);
+		},
 
-				report(test, arg, true);
-				return;
-			}
+		DoWhileStatement(node) {
+			checkTestExpression(node.test);
+		},
 
-			// If (value)
-			if (isImplicitTruthyTarget(test)) {
-				if (isBooleanType(test)) {
-					return;
-				}
+		ConditionalExpression(node) {
+			checkTestExpression(node.test);
+		},
 
-				report(test, test, false);
+		LogicalExpression(node) {
+			if (node.operator === '&&' || node.operator === '||') {
+				checkTestExpression(node.left);
 			}
 		},
 	};

package/tests/no-boolean-coercion.test.ts

@@ -1,7 +1,12 @@
 const {RuleTester} = require('@typescript-eslint/rule-tester');
 const rule = require('../src/rules/no-boolean-coercion');
 
-const ruleTester = new RuleTester({});
+const ruleTester = new RuleTester({
+	languageOptions: {
+		ecmaVersion: 2020,
+		sourceType: 'module',
+	},
+});
 
 ruleTester.run('no-boolean-coercion', rule, {
 	valid: [

package/tests/prefer-explicit-nil-or-empty-check.test.ts

@@ -0,0 +1,113 @@
+const {RuleTester} = require('@typescript-eslint/rule-tester');
+const rule = require('../src/rules/prefer-explicit-nil-or-empty-check');
+
+const ruleTester = new RuleTester({
+	languageOptions: {
+		ecmaVersion: 2020,
+		sourceType: 'module',
+	},
+});
+
+ruleTester.run('prefer-explicit-nil-or-empty-check', rule, {
+	valid: [
+		// Explicit checks – allowed
+		'if (_.isNil(value)) {}',
+		'if (!_.isNil(value)) {}',
+		'if (_.isEmpty(list)) {}',
+		'if (!_.isEmpty(list)) {}',
+
+		// Explicit comparisons – allowed
+		'if (value != null) {}',
+		'if (list.length > 0) {}',
+
+		// Boolean values – allowed
+		'if (true) {}',
+		'if (false) {}',
+
+		// Non-control-flow usage – allowed
+		'value;',
+		'doSomething(value);',
+	],
+
+	invalid: [
+		{
+			code: 'if (dataObject) {}',
+			errors: [
+				{
+					message:
+						'Implicit truthy/falsy check on a non-boolean value is not allowed; use explicit _.isNil or _.isEmpty checks',
+					suggestions: [
+						{
+							desc: 'Replace with !_.isNil(dataObject)',
+							output: 'if (!_.isNil(dataObject)) {}',
+						},
+						{
+							desc: 'Replace with !_.isEmpty(dataObject)',
+							output: 'if (!_.isEmpty(dataObject)) {}',
+						},
+					],
+				},
+			],
+		},
+
+		{
+			code: 'if (!dataObject) {}',
+			errors: [
+				{
+					message:
+						'Implicit truthy/falsy check on a non-boolean value is not allowed; use explicit _.isNil or _.isEmpty checks',
+					suggestions: [
+						{
+							desc: 'Replace with _.isNil(dataObject)',
+							output: 'if (_.isNil(dataObject)) {}',
+						},
+						{
+							desc: 'Replace with _.isEmpty(dataObject)',
+							output: 'if (_.isEmpty(dataObject)) {}',
+						},
+					],
+				},
+			],
+		},
+
+		{
+			code: 'while (items) {}',
+			errors: [
+				{
+					message:
+						'Implicit truthy/falsy check on a non-boolean value is not allowed; use explicit _.isNil or _.isEmpty checks',
+					suggestions: [
+						{
+							desc: 'Replace with !_.isNil(items)',
+							output: 'while (!_.isNil(items)) {}',
+						},
+						{
+							desc: 'Replace with !_.isEmpty(items)',
+							output: 'while (!_.isEmpty(items)) {}',
+						},
+					],
+				},
+			],
+		},
+
+		{
+			code: 'data && doSomething();',
+			errors: [
+				{
+					message:
+						'Implicit truthy/falsy check on a non-boolean value is not allowed; use explicit _.isNil or _.isEmpty checks',
+					suggestions: [
+						{
+							desc: 'Replace with !_.isNil(data)',
+							output: '!_.isNil(data) && doSomething();',
+						},
+						{
+							desc: 'Replace with !_.isEmpty(data)',
+							output: '!_.isEmpty(data) && doSomething();',
+						},
+					],
+				},
+			],
+		},
+	],
+});

package/tests/prefer-is-empty.test.ts

@@ -1,7 +1,12 @@
 const {RuleTester} = require('@typescript-eslint/rule-tester');
 const rule = require('../src/rules/prefer-is-empty');
 
-const ruleTester = new RuleTester({});
+const ruleTester = new RuleTester({
+	languageOptions: {
+		ecmaVersion: 2020,
+		sourceType: 'module',
+	},
+});
 
 ruleTester.run('prefer-is-empty', rule, {
 	valid: [