eslint-plugin-th-rules 2.4.0 → 2.5.1

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+## [2.5.1](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v2.5.0...v2.5.1) (2026-01-14)
+
+
+### Bug Fixes
+
+* add prefer-is-empty rule to enforce _.isEmpty over length comparisons and update documentation ([06ee673](https://github.com/tomerh2001/eslint-plugin-th-rules/commit/06ee673a0fde79b7cc2af1f72807d9716576310c))
+
+# [2.5.0](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v2.4.0...v2.5.0) (2026-01-14)
+
+
+### Features
+
+* add prefer-is-empty rule to enforce _.isEmpty over length comparisons and update documentation ([5bc671f](https://github.com/tomerh2001/eslint-plugin-th-rules/commit/5bc671f35599d69a5a1432d173df408082da2db6))
+
 # [2.4.0](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v2.3.0...v2.4.0) (2026-01-14)
 
 

package/README.md

@@ -17,15 +17,16 @@ This repository contains custom ESLint rules to enhance code quality and consist
 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).\
 💡 Manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
 
-| Name                                                             | Description                                                                              | 💼      | 🔧 | 💡 |
-| :--------------------------------------------------------------- | :--------------------------------------------------------------------------------------- | :------ | :- | :- |
-| [no-boolean-coercion](docs/rules/no-boolean-coercion.md)         | Disallow Boolean(variable) or !!variable and enforce explicit _.isNil / _.isEmpty checks | ✅ ⚛️ 🟦 |    | 💡 |
-| [no-comments](docs/rules/no-comments.md)                         | Disallow comments except for specified allowed patterns.                                 | ✅ ⚛️ 🟦 | 🔧 |    |
-| [no-default-export](docs/rules/no-default-export.md)             | Convert unnamed default exports to named default exports based on the file name.         | ✅ ⚛️ 🟦 | 🔧 |    |
-| [no-destructuring](docs/rules/no-destructuring.md)               | Disallow destructuring that does not meet certain conditions                             | ✅ ⚛️ 🟦 |    |    |
-| [schemas-in-schemas-file](docs/rules/schemas-in-schemas-file.md) | Require Zod schema declarations to be placed in a .schemas.ts file                       | ✅ ⚛️ 🟦 |    |    |
-| [top-level-functions](docs/rules/top-level-functions.md)         | Require all top-level functions to be named/regular functions.                           | ✅ ⚛️ 🟦 | 🔧 |    |
-| [types-in-dts](docs/rules/types-in-dts.md)                       | Require TypeScript type declarations (type/interface/enum) to be placed in .d.ts files   | ✅ ⚛️ 🟦 |    |    |
+| Name                                                             | Description                                                                                                                         | 💼      | 🔧 | 💡 |
+| :--------------------------------------------------------------- | :---------------------------------------------------------------------------------------------------------------------------------- | :------ | :- | :- |
+| [no-boolean-coercion](docs/rules/no-boolean-coercion.md)         | Disallow Boolean(value) or !!value. Enforce _.isNil(value) for scalar values and _.isEmpty(value) for strings, arrays, and objects. | ✅ ⚛️ 🟦 |    | 💡 |
+| [no-comments](docs/rules/no-comments.md)                         | Disallow comments except for specified allowed patterns.                                                                            | ✅ ⚛️ 🟦 | 🔧 |    |
+| [no-default-export](docs/rules/no-default-export.md)             | Convert unnamed default exports to named default exports based on the file name.                                                    | ✅ ⚛️ 🟦 | 🔧 |    |
+| [no-destructuring](docs/rules/no-destructuring.md)               | Disallow destructuring that does not meet certain conditions                                                                        | ✅ ⚛️ 🟦 |    |    |
+| [prefer-is-empty](docs/rules/prefer-is-empty.md)                 | Require _.isEmpty instead of length comparisons                                                                                     |         |    |    |
+| [schemas-in-schemas-file](docs/rules/schemas-in-schemas-file.md) | Require Zod schema declarations to be placed in a .schemas.ts file                                                                  | ✅ ⚛️ 🟦 |    |    |
+| [top-level-functions](docs/rules/top-level-functions.md)         | Require all top-level functions to be named/regular functions.                                                                      | ✅ ⚛️ 🟦 | 🔧 |    |
+| [types-in-dts](docs/rules/types-in-dts.md)                       | Require TypeScript type declarations (type/interface/enum) to be placed in .d.ts files                                              | ✅ ⚛️ 🟦 |    |    |
 
 <!-- end auto-generated rules list -->
 

package/docs/rules/no-boolean-coercion.md

@@ -1,6 +1,6 @@
 # th-rules/no-boolean-coercion
 
-📝 Disallow Boolean(variable) or !!variable and enforce explicit _.isNil / _.isEmpty checks.
+📝 Disallow Boolean(value) or !!value. Enforce _.isNil(value) for scalar values and _.isEmpty(value) for strings, arrays, and objects.
 
 💼 This rule is enabled in the following configs: ✅ `recommended`, ⚛️ `recommended-react`, 🟦 `recommended-typescript`.
 

package/docs/rules/prefer-is-empty.md

@@ -0,0 +1,5 @@
+# th-rules/prefer-is-empty
+
+📝 Require _.isEmpty instead of length comparisons.
+
+<!-- end auto-generated rule header -->

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-th-rules",
-  "version": "2.4.0",
+  "version": "2.5.1",
   "description": "A List of custom ESLint rules created by Tomer Horowitz",
   "keywords": [
     "eslint",

package/src/index.js

@@ -66,6 +66,7 @@ const baseRecommended = {
 		'th-rules/schemas-in-schemas-file': 'error',
 		'th-rules/types-in-dts': 'error',
 		'th-rules/no-boolean-coercion': 'error',
+		'th-rules/prefer-is-empty': 'error',
 		'unicorn/filename-case': 'off',
 		'unicorn/no-array-callback-reference': 'off',
 		'import/extensions': 'off',

package/src/rules/prefer-is-empty.js

@@ -0,0 +1,104 @@
+const meta = {
+	type: 'problem',
+	docs: {
+		description: 'Require _.isEmpty instead of length comparisons',
+		category: 'Best Practices',
+		recommended: true,
+		url: 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/prefer-is-empty.md',
+	},
+	hasSuggestions: true,
+	schema: [],
+};
+
+function create(context) {
+	const sourceCode = context.getSourceCode();
+
+	function isLengthAccess(node) {
+		return (
+			node
+			&& node.type === 'MemberExpression'
+			&& !node.computed
+			&& node.property.type === 'Identifier'
+			&& node.property.name === 'length'
+		);
+	}
+
+	function isNumericLiteral(node) {
+		return node && node.type === 'Literal' && typeof node.value === 'number';
+	}
+
+	function report(node, collectionNode, operator, value, isEmptyCheck) {
+		const collectionText = sourceCode.getText(collectionNode.object);
+		const replacement = isEmptyCheck
+			? `_.isEmpty(${collectionText})`
+			: `!_.isEmpty(${collectionText})`;
+
+		context.report({
+			node,
+			message: `Use _.isEmpty(${collectionText}) instead of checking ${collectionText}.length ${operator} ${value}`,
+			suggest: [
+				{
+					desc: `Replace with ${replacement}`,
+					fix(fixer) {
+						return fixer.replaceText(node, replacement);
+					},
+				},
+			],
+		});
+	}
+
+	return {
+		BinaryExpression(node) {
+			const {left, right, operator} = node;
+
+			// Values.length <op> N
+			if (isLengthAccess(left) && isNumericLiteral(right)) {
+				const {value} = right;
+
+				// EMPTY checks
+				if (
+					(operator === '===' && value === 0)
+					|| (operator === '<=' && value === 0)
+					|| (operator === '<' && value === 1)
+				) {
+					report(node, left, operator, value, true);
+					return;
+				}
+
+				// NOT EMPTY checks
+				if (
+					(operator === '>' && value === 0)
+					|| (operator === '>=' && value === 1)
+					|| ((operator === '!=' || operator === '!==') && value === 0)
+				) {
+					report(node, left, operator, value, false);
+				}
+			}
+
+			// N <op> values.length (reversed)
+			if (isNumericLiteral(left) && isLengthAccess(right)) {
+				const {value} = left;
+
+				// EMPTY checks
+				if (
+					(operator === '===' && value === 0)
+					|| (operator === '>=' && value === 0)
+					|| (operator === '>' && value === 0)
+				) {
+					report(node, right, operator, value, true);
+					return;
+				}
+
+				// NOT EMPTY checks
+				if (
+					(operator === '<' && value === 1)
+					|| (operator === '<=' && value === 0)
+				) {
+					report(node, right, operator, value, false);
+				}
+			}
+		},
+	};
+}
+
+module.exports = {meta, create};

package/tests/prefer-is-empty.test.ts

@@ -0,0 +1,143 @@
+const {RuleTester} = require('eslint');
+const rule = require('../src/rules/prefer-is-empty');
+
+const ruleTester = new RuleTester({});
+
+ruleTester.run('prefer-is-empty', rule, {
+	valid: [
+		'_.isEmpty(values);',
+		'!_.isEmpty(values);',
+		'Array.isArray(values);',
+		'values.size > 0;', // Non-length property
+	],
+
+	invalid: [
+		{
+			code: 'values.length === 0;',
+			errors: [
+				{
+					message:
+						'Use _.isEmpty(values) instead of checking values.length === 0',
+					suggestions: [
+						{
+							desc: 'Replace with _.isEmpty(values)',
+							output: '_.isEmpty(values);',
+						},
+					],
+				},
+			],
+		},
+
+		{
+			code: 'values.length < 1;',
+			errors: [
+				{
+					message:
+						'Use _.isEmpty(values) instead of checking values.length < 1',
+					suggestions: [
+						{
+							desc: 'Replace with _.isEmpty(values)',
+							output: '_.isEmpty(values);',
+						},
+					],
+				},
+			],
+		},
+
+		{
+			code: 'values.length <= 0;',
+			errors: [
+				{
+					message:
+						'Use _.isEmpty(values) instead of checking values.length <= 0',
+					suggestions: [
+						{
+							desc: 'Replace with _.isEmpty(values)',
+							output: '_.isEmpty(values);',
+						},
+					],
+				},
+			],
+		},
+
+		{
+			code: 'values.length > 0;',
+			errors: [
+				{
+					message:
+						'Use _.isEmpty(values) instead of checking values.length > 0',
+					suggestions: [
+						{
+							desc: 'Replace with !_.isEmpty(values)',
+							output: '!_.isEmpty(values);',
+						},
+					],
+				},
+			],
+		},
+
+		{
+			code: 'values.length >= 1;',
+			errors: [
+				{
+					message:
+						'Use _.isEmpty(values) instead of checking values.length >= 1',
+					suggestions: [
+						{
+							desc: 'Replace with !_.isEmpty(values)',
+							output: '!_.isEmpty(values);',
+						},
+					],
+				},
+			],
+		},
+
+		{
+			code: 'values.length !== 0;',
+			errors: [
+				{
+					message:
+						'Use _.isEmpty(values) instead of checking values.length !== 0',
+					suggestions: [
+						{
+							desc: 'Replace with !_.isEmpty(values)',
+							output: '!_.isEmpty(values);',
+						},
+					],
+				},
+			],
+		},
+
+		{
+			code: 'if (items.length > 0) {}',
+			errors: [
+				{
+					message:
+						'Use _.isEmpty(items) instead of checking items.length > 0',
+					suggestions: [
+						{
+							desc: 'Replace with !_.isEmpty(items)',
+							output: 'if (!_.isEmpty(items)) {}',
+						},
+					],
+				},
+			],
+		},
+
+		{
+			code: '0 === items.length;',
+			errors: [
+				{
+					message:
+						'Use _.isEmpty(items) instead of checking items.length === 0',
+					suggestions: [
+						{
+							desc: 'Replace with _.isEmpty(items)',
+							output: '_.isEmpty(items);',
+						},
+					],
+				},
+			],
+		},
+	],
+});