eslint-plugin-th-rules 2.2.0 → 2.5.0

package/CHANGELOG.md

@@ -1,6 +1,38 @@
+# [2.5.0](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v2.4.0...v2.5.0) (2026-01-14)
+
+
+### Features
+
+* add prefer-is-empty rule to enforce _.isEmpty over length comparisons and update documentation ([5bc671f](https://github.com/tomerh2001/eslint-plugin-th-rules/commit/5bc671f35599d69a5a1432d173df408082da2db6))
+
+# [2.4.0](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v2.3.0...v2.4.0) (2026-01-14)
+
+
+### Features
+
+* fixed git tags ([822f503](https://github.com/tomerh2001/eslint-plugin-th-rules/commit/822f5033769f89fabbd6cf7177ccef74311ec2e5))
+
 # [2.2.0](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v2.1.1...v2.2.0) (2026-01-14)
 
 
+### Bug Fixes
+
+* enhance no-boolean-coercion rule with detailed messages and update tests ([c79ad92](https://github.com/tomerh2001/eslint-plugin-th-rules/commit/c79ad921e2a6c4dabe0f0e74b80393b01525c3d7))
+* enhance no-boolean-coercion rule with detailed messages and update tests ([686d620](https://github.com/tomerh2001/eslint-plugin-th-rules/commit/686d6204bd46f757a4490656521b1094f3e3237e))
+
+
+### Features
+
+* created new rule no-boolean-coercion ([f9b0803](https://github.com/tomerh2001/eslint-plugin-th-rules/commit/f9b08039f6275e363da10e8e3ca49fb75ad2e48a))
+
+# [2.2.0](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v2.1.1...v2.2.0) (2026-01-14)
+
+
+### Bug Fixes
+
+* enhance no-boolean-coercion rule with detailed messages and update tests ([686d620](https://github.com/tomerh2001/eslint-plugin-th-rules/commit/686d6204bd46f757a4490656521b1094f3e3237e))
+
+
 ### Features
 
 * created new rule no-boolean-coercion ([f9b0803](https://github.com/tomerh2001/eslint-plugin-th-rules/commit/f9b08039f6275e363da10e8e3ca49fb75ad2e48a))

package/README.md

@@ -17,15 +17,16 @@ This repository contains custom ESLint rules to enhance code quality and consist
 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).\
 💡 Manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
 
-| Name                                                             | Description                                                                              | 💼      | 🔧 | 💡 |
-| :--------------------------------------------------------------- | :--------------------------------------------------------------------------------------- | :------ | :- | :- |
-| [no-boolean-coercion](docs/rules/no-boolean-coercion.md)         | Disallow Boolean(variable) or !!variable and enforce explicit _.isNil / _.isEmpty checks | ✅ ⚛️ 🟦 |    | 💡 |
-| [no-comments](docs/rules/no-comments.md)                         | Disallow comments except for specified allowed patterns.                                 | ✅ ⚛️ 🟦 | 🔧 |    |
-| [no-default-export](docs/rules/no-default-export.md)             | Convert unnamed default exports to named default exports based on the file name.         | ✅ ⚛️ 🟦 | 🔧 |    |
-| [no-destructuring](docs/rules/no-destructuring.md)               | Disallow destructuring that does not meet certain conditions                             | ✅ ⚛️ 🟦 |    |    |
-| [schemas-in-schemas-file](docs/rules/schemas-in-schemas-file.md) | Require Zod schema declarations to be placed in a .schemas.ts file                       | ✅ ⚛️ 🟦 |    |    |
-| [top-level-functions](docs/rules/top-level-functions.md)         | Require all top-level functions to be named/regular functions.                           | ✅ ⚛️ 🟦 | 🔧 |    |
-| [types-in-dts](docs/rules/types-in-dts.md)                       | Require TypeScript type declarations (type/interface/enum) to be placed in .d.ts files   | ✅ ⚛️ 🟦 |    |    |
+| Name                                                             | Description                                                                                                                         | 💼      | 🔧 | 💡 |
+| :--------------------------------------------------------------- | :---------------------------------------------------------------------------------------------------------------------------------- | :------ | :- | :- |
+| [no-boolean-coercion](docs/rules/no-boolean-coercion.md)         | Disallow Boolean(value) or !!value. Enforce _.isNil(value) for scalar values and _.isEmpty(value) for strings, arrays, and objects. | ✅ ⚛️ 🟦 |    | 💡 |
+| [no-comments](docs/rules/no-comments.md)                         | Disallow comments except for specified allowed patterns.                                                                            | ✅ ⚛️ 🟦 | 🔧 |    |
+| [no-default-export](docs/rules/no-default-export.md)             | Convert unnamed default exports to named default exports based on the file name.                                                    | ✅ ⚛️ 🟦 | 🔧 |    |
+| [no-destructuring](docs/rules/no-destructuring.md)               | Disallow destructuring that does not meet certain conditions                                                                        | ✅ ⚛️ 🟦 |    |    |
+| [prefer-is-empty](docs/rules/prefer-is-empty.md)                 | Require _.isEmpty instead of length comparisons                                                                                     |         |    |    |
+| [schemas-in-schemas-file](docs/rules/schemas-in-schemas-file.md) | Require Zod schema declarations to be placed in a .schemas.ts file                                                                  | ✅ ⚛️ 🟦 |    |    |
+| [top-level-functions](docs/rules/top-level-functions.md)         | Require all top-level functions to be named/regular functions.                                                                      | ✅ ⚛️ 🟦 | 🔧 |    |
+| [types-in-dts](docs/rules/types-in-dts.md)                       | Require TypeScript type declarations (type/interface/enum) to be placed in .d.ts files                                              | ✅ ⚛️ 🟦 |    |    |
 
 <!-- end auto-generated rules list -->
 

package/docs/rules/no-boolean-coercion.md

@@ -1,6 +1,6 @@
 # th-rules/no-boolean-coercion
 
-📝 Disallow Boolean(variable) or !!variable and enforce explicit _.isNil / _.isEmpty checks.
+📝 Disallow Boolean(value) or !!value. Enforce _.isNil(value) for scalar values and _.isEmpty(value) for strings, arrays, and objects.
 
 💼 This rule is enabled in the following configs: ✅ `recommended`, ⚛️ `recommended-react`, 🟦 `recommended-typescript`.
 

package/docs/rules/prefer-is-empty.md

@@ -0,0 +1,5 @@
+# th-rules/prefer-is-empty
+
+📝 Require _.isEmpty instead of length comparisons.
+
+<!-- end auto-generated rule header -->

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-th-rules",
-  "version": "2.2.0",
+  "version": "2.5.0",
   "description": "A List of custom ESLint rules created by Tomer Horowitz",
   "keywords": [
     "eslint",

package/src/rules/no-boolean-coercion.js

@@ -2,13 +2,19 @@ const meta = {
 	type: 'problem',
 	docs: {
 		description:
-			'Disallow Boolean(variable) or !!variable and enforce explicit _.isNil / _.isEmpty checks',
+    'Disallow Boolean(value) or !!value. Enforce _.isNil(value) for scalar values and _.isEmpty(value) for strings, arrays, and objects.',
 		category: 'Best Practices',
 		recommended: true,
 		url: 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/no-boolean-coercion.md',
 	},
 	hasSuggestions: true,
 	schema: [],
+	messages: {
+		useIsEmpty:
+      'Boolean coercion is not allowed. Use _.isEmpty(value) for strings, arrays, and objects.',
+		useIsNil:
+      'Boolean coercion is not allowed. Use _.isNil(value) for scalar values.',
+	},
 };
 
 function create(context) {
@@ -75,8 +81,7 @@ function create(context) {
 
 		context.report({
 			node,
-			message:
-				'Boolean coercion is not allowed. Use an explicit null/empty check instead.',
+			messageId: isCollection ? 'useIsEmpty' : 'useIsNil',
 			suggest: [
 				{
 					desc: `Replace with ${replacement}`,

package/src/rules/prefer-is-empty.js

@@ -0,0 +1,66 @@
+const meta = {
+	type: 'problem',
+	docs: {
+		description: 'Require _.isEmpty instead of length comparisons',
+		category: 'Best Practices',
+		recommended: true,
+		url: 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/prefer-is-empty.md',
+	},
+	schema: [],
+};
+
+function create(context) {
+	function isLengthAccess(node) {
+		return (
+			node
+			&& node.type === 'MemberExpression'
+			&& !node.computed
+			&& node.property.type === 'Identifier'
+			&& node.property.name === 'length'
+		);
+	}
+
+	function isZeroOrOneLiteral(node) {
+		return (
+			node
+			&& node.type === 'Literal'
+			&& (node.value === 0 || node.value === 1)
+		);
+	}
+
+	function report(node, collectionNode, operator, literalValue) {
+		const sourceCode = context.getSourceCode();
+		const collectionText = sourceCode.getText(collectionNode.object);
+
+		context.report({
+			node,
+			message: `Use _.isEmpty(${collectionText}) instead of checking ${collectionText}.length ${operator} ${literalValue}`,
+		});
+	}
+
+	return {
+		BinaryExpression(node) {
+			const {left, right, operator} = node;
+
+			if (
+				(operator === '>' || operator === '>=')
+				&& isLengthAccess(left)
+				&& isZeroOrOneLiteral(right)
+			) {
+				report(node, left, operator, right.value);
+				return;
+			}
+
+			if (
+				(operator === '!=' || operator === '!==')
+				&& isLengthAccess(left)
+				&& right?.type === 'Literal'
+				&& right.value === 0
+			) {
+				report(node, left, operator, 0);
+			}
+		},
+	};
+}
+
+module.exports = {meta, create};

package/tests/no-boolean-coercion.test.ts

@@ -3,9 +3,6 @@ const rule = require('../src/rules/no-boolean-coercion');
 
 const ruleTester = new RuleTester({});
 
-const ERROR_MESSAGE
-	= 'Boolean coercion is not allowed. Use an explicit null/empty check instead.';
-
 ruleTester.run('no-boolean-coercion', rule, {
 	valid: [
 		'_.isNil(value);',
@@ -22,7 +19,7 @@ ruleTester.run('no-boolean-coercion', rule, {
 			code: 'Boolean(foo);',
 			errors: [
 				{
-					message: ERROR_MESSAGE,
+					messageId: 'useIsNil',
 					suggestions: [
 						{
 							desc: 'Replace with _.isNil(foo)',
@@ -37,7 +34,7 @@ ruleTester.run('no-boolean-coercion', rule, {
 			code: 'const x = Boolean(bar);',
 			errors: [
 				{
-					message: ERROR_MESSAGE,
+					messageId: 'useIsNil',
 					suggestions: [
 						{
 							desc: 'Replace with _.isNil(bar)',
@@ -52,7 +49,7 @@ ruleTester.run('no-boolean-coercion', rule, {
 			code: '!!value;',
 			errors: [
 				{
-					message: ERROR_MESSAGE,
+					messageId: 'useIsNil',
 					suggestions: [
 						{
 							desc: 'Replace with _.isNil(value)',
@@ -67,7 +64,7 @@ ruleTester.run('no-boolean-coercion', rule, {
 			code: 'Boolean([]);',
 			errors: [
 				{
-					message: ERROR_MESSAGE,
+					messageId: 'useIsEmpty',
 					suggestions: [
 						{
 							desc: 'Replace with _.isEmpty([])',
@@ -77,6 +74,5 @@ ruleTester.run('no-boolean-coercion', rule, {
 				},
 			],
 		},
-
 	],
 });

package/tests/prefer-is-empty.test.ts

@@ -0,0 +1,68 @@
+const {RuleTester} = require('eslint');
+const rule = require('../src/rules/prefer-is-empty');
+
+const ruleTester = new RuleTester({});
+
+ruleTester.run('prefer-is-empty', rule, {
+	valid: [
+		'_.isEmpty(values);',
+		'!_.isEmpty(values);',
+		'values.length === 0;',
+		'values.length <= 0;',
+		'values.length < 1;',
+		'Array.isArray(values);',
+		'values.size > 0;', // Non-length property
+	],
+
+	invalid: [
+		{
+			code: 'values.length > 0;',
+			errors: [
+				{
+					message:
+						'Use _.isEmpty(values) instead of checking values.length > 0',
+				},
+			],
+		},
+
+		{
+			code: 'values.length >= 1;',
+			errors: [
+				{
+					message:
+						'Use _.isEmpty(values) instead of checking values.length >= 1',
+				},
+			],
+		},
+
+		{
+			code: 'values.length != 0;',
+			errors: [
+				{
+					message:
+						'Use _.isEmpty(values) instead of checking values.length != 0',
+				},
+			],
+		},
+
+		{
+			code: 'values.length !== 0;',
+			errors: [
+				{
+					message:
+						'Use _.isEmpty(values) instead of checking values.length !== 0',
+				},
+			],
+		},
+
+		{
+			code: 'if (items.length > 0) {}',
+			errors: [
+				{
+					message:
+						'Use _.isEmpty(items) instead of checking items.length > 0',
+				},
+			],
+		},
+	],
+});