eslint-plugin-th-rules 2.1.0 → 2.2.0

package/.github/workflows/main.yml

@@ -32,6 +32,9 @@ jobs:
     - name: Verify ESLint flat configs
       run: node ./scripts/verify.mjs
 
+    - name: Run Tests
+      run: bun test
+
     - name: Semantic Release
       run: bunx semantic-release
       env:

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+# [2.2.0](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v2.1.1...v2.2.0) (2026-01-14)
+
+
+### Features
+
+* created new rule no-boolean-coercion ([f9b0803](https://github.com/tomerh2001/eslint-plugin-th-rules/commit/f9b08039f6275e363da10e8e3ca49fb75ad2e48a))
+
+## [2.1.1](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v2.1.0...v2.1.1) (2026-01-10)
+
+
+### Bug Fixes
+
+* update base recommended rules to disable specific TypeScript and lodash rules ([6b4c240](https://github.com/tomerh2001/eslint-plugin-th-rules/commit/6b4c24062199bd8dda59407a844ae545903f8ddc))
+
 # [2.1.0](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v2.0.4...v2.1.0) (2026-01-09)
 
 

package/README.md

@@ -14,16 +14,18 @@ This repository contains custom ESLint rules to enhance code quality and consist
 ✅ Set in the `recommended` configuration.\
 ⚛️ Set in the `recommended-react` configuration.\
 🟦 Set in the `recommended-typescript` configuration.\
-🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).
+🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).\
+💡 Manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
 
-| Name                                                             | Description                                                                            | 💼      | 🔧 |
-| :--------------------------------------------------------------- | :------------------------------------------------------------------------------------- | :------ | :- |
-| [no-comments](docs/rules/no-comments.md)                         | Disallow comments except for specified allowed patterns.                               | ✅ ⚛️ 🟦 | 🔧 |
-| [no-default-export](docs/rules/no-default-export.md)             | Convert unnamed default exports to named default exports based on the file name.       | ✅ ⚛️ 🟦 | 🔧 |
-| [no-destructuring](docs/rules/no-destructuring.md)               | Disallow destructuring that does not meet certain conditions                           | ✅ ⚛️ 🟦 |    |
-| [schemas-in-schemas-file](docs/rules/schemas-in-schemas-file.md) | Require Zod schema declarations to be placed in a .schemas.ts file                     | ✅ ⚛️ 🟦 |    |
-| [top-level-functions](docs/rules/top-level-functions.md)         | Require all top-level functions to be named/regular functions.                         | ✅ ⚛️ 🟦 | 🔧 |
-| [types-in-dts](docs/rules/types-in-dts.md)                       | Require TypeScript type declarations (type/interface/enum) to be placed in .d.ts files | ✅ ⚛️ 🟦 |    |
+| Name                                                             | Description                                                                              | 💼      | 🔧 | 💡 |
+| :--------------------------------------------------------------- | :--------------------------------------------------------------------------------------- | :------ | :- | :- |
+| [no-boolean-coercion](docs/rules/no-boolean-coercion.md)         | Disallow Boolean(variable) or !!variable and enforce explicit _.isNil / _.isEmpty checks | ✅ ⚛️ 🟦 |    | 💡 |
+| [no-comments](docs/rules/no-comments.md)                         | Disallow comments except for specified allowed patterns.                                 | ✅ ⚛️ 🟦 | 🔧 |    |
+| [no-default-export](docs/rules/no-default-export.md)             | Convert unnamed default exports to named default exports based on the file name.         | ✅ ⚛️ 🟦 | 🔧 |    |
+| [no-destructuring](docs/rules/no-destructuring.md)               | Disallow destructuring that does not meet certain conditions                             | ✅ ⚛️ 🟦 |    |    |
+| [schemas-in-schemas-file](docs/rules/schemas-in-schemas-file.md) | Require Zod schema declarations to be placed in a .schemas.ts file                       | ✅ ⚛️ 🟦 |    |    |
+| [top-level-functions](docs/rules/top-level-functions.md)         | Require all top-level functions to be named/regular functions.                           | ✅ ⚛️ 🟦 | 🔧 |    |
+| [types-in-dts](docs/rules/types-in-dts.md)                       | Require TypeScript type declarations (type/interface/enum) to be placed in .d.ts files   | ✅ ⚛️ 🟦 |    |    |
 
 <!-- end auto-generated rules list -->
 

package/docs/rules/no-boolean-coercion.md

@@ -0,0 +1,9 @@
+# th-rules/no-boolean-coercion
+
+📝 Disallow Boolean(variable) or !!variable and enforce explicit _.isNil / _.isEmpty checks.
+
+💼 This rule is enabled in the following configs: ✅ `recommended`, ⚛️ `recommended-react`, 🟦 `recommended-typescript`.
+
+💡 This rule is manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).
+
+<!-- end auto-generated rule header -->

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-th-rules",
-  "version": "2.1.0",
+  "version": "2.2.0",
   "description": "A List of custom ESLint rules created by Tomer Horowitz",
   "keywords": [
     "eslint",
@@ -14,7 +14,6 @@
     "lint": "npm-run-all \"lint:*\"",
     "lint:eslint-docs": "npm-run-all \"update:eslint-docs -- --check\"",
     "lint:js": "eslint .",
-    "test": "xo && mocha tests --recursive",
     "update:eslint-docs": "eslint-doc-generator --config-emoji \"recommended,✅\" --config-emoji \"recommended-react,⚛️\" --config-emoji \"recommended-typescript,🟦\""
   },
   "dependencies": {
@@ -34,6 +33,7 @@
     "eslint-plugin-sonarjs": "^3.0.5",
     "eslint-plugin-unicorn": "^62.0.0",
     "globals": "^17.0.0",
+    "jest": "^30.2.0",
     "lodash": "^4.17.21",
     "requireindex": "^1.2.0"
   },

package/src/index.js

@@ -65,7 +65,7 @@ const baseRecommended = {
 		'th-rules/top-level-functions': 'error',
 		'th-rules/schemas-in-schemas-file': 'error',
 		'th-rules/types-in-dts': 'error',
-
+		'th-rules/no-boolean-coercion': 'error',
 		'unicorn/filename-case': 'off',
 		'unicorn/no-array-callback-reference': 'off',
 		'import/extensions': 'off',
@@ -78,7 +78,6 @@ const baseRecommended = {
 		'n/prefer-global/process': 'off',
 		'import/no-cycle': 'off',
 		camelcase: 'warn',
-
 		'sonarjs/mouse-events-a11y': 'off',
 		'sonarjs/no-unstable-nested-components': 'off',
 		'unicorn/prefer-global-this': 'off',
@@ -86,6 +85,11 @@ const baseRecommended = {
 		'sonarjs/no-clear-text-protocols': 'off',
 		'security/detect-unsafe-regex': 'off',
 		'lodash/import-scope': [2, 'full'],
+		'@typescript-eslint/ban-types': 'off',
+		'@typescript-eslint/naming-convention': 'off',
+		'@typescript-eslint/no-restricted-types': 'off',
+		'import-x/extensions': 'off',
+		'lodash/chaining': ['error', 'implicit'],
 	},
 };
 
@@ -110,7 +114,6 @@ plugin.configs['recommended-typescript'] = flatConfigs(
 			},
 		},
 		rules: {
-			'@typescript-eslint/naming-convention': 'warn',
 			'@typescript-eslint/consistent-type-definitions': 'off',
 			'@typescript-eslint/no-extraneous-class': 'off',
 			'@typescript-eslint/no-duplicate-type-constituents': 'off',

package/src/rules/no-boolean-coercion.js

@@ -0,0 +1,120 @@
+const meta = {
+	type: 'problem',
+	docs: {
+		description:
+			'Disallow Boolean(variable) or !!variable and enforce explicit _.isNil / _.isEmpty checks',
+		category: 'Best Practices',
+		recommended: true,
+		url: 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/no-boolean-coercion.md',
+	},
+	hasSuggestions: true,
+	schema: [],
+};
+
+function create(context) {
+	const sourceCode = context.getSourceCode();
+	const services = context.parserServices;
+	const checker = services?.program?.getTypeChecker?.();
+
+	function isBooleanCall(node) {
+		return (
+			node.type === 'CallExpression'
+			&& node.callee.type === 'Identifier'
+			&& node.callee.name === 'Boolean'
+			&& node.arguments.length === 1
+		);
+	}
+
+	function isDoubleNegation(node) {
+		return (
+			node.type === 'UnaryExpression'
+			&& node.operator === '!'
+			&& node.argument?.type === 'UnaryExpression'
+			&& node.argument.operator === '!'
+		);
+	}
+
+	function isCollectionLikeByTS(node) {
+		if (!checker || !services?.esTreeNodeToTSNodeMap) {
+			return false;
+		}
+
+		const tsNode = services.esTreeNodeToTSNodeMap.get(node);
+		if (!tsNode) {
+			return false;
+		}
+
+		const type = checker.getTypeAtLocation(tsNode);
+
+		const typeString = checker.typeToString(type);
+
+		return (
+			typeString.includes('[]')
+			|| typeString === 'string'
+			|| typeString === 'object'
+			|| typeString.startsWith('Array<')
+			|| typeString.startsWith('ReadonlyArray<')
+		);
+	}
+
+	function isCollectionLikeBySyntax(node) {
+		return (
+			node.type === 'ArrayExpression'
+			|| node.type === 'ObjectExpression'
+			|| node.type === 'Literal' && typeof node.value === 'string'
+		);
+	}
+
+	function report(node, valueNode) {
+		const isCollection
+			= isCollectionLikeBySyntax(valueNode)
+				|| isCollectionLikeByTS(valueNode);
+
+		const suggestedFn = isCollection ? '_.isEmpty' : '_.isNil';
+		const replacement = `${suggestedFn}(${sourceCode.getText(valueNode)})`;
+
+		context.report({
+			node,
+			message:
+				'Boolean coercion is not allowed. Use an explicit null/empty check instead.',
+			suggest: [
+				{
+					desc: `Replace with ${replacement}`,
+					fix(fixer) {
+						return fixer.replaceText(node, replacement);
+					},
+				},
+			],
+		});
+	}
+
+	return {
+		CallExpression(node) {
+			if (!isBooleanCall(node)) {
+				return;
+			}
+
+			const arg = node.arguments[0];
+			if (!arg) {
+				return;
+			}
+
+			report(node, arg);
+		},
+
+		UnaryExpression(node) {
+			if (!isDoubleNegation(node)) {
+				return;
+			}
+
+			const valueNode = node.argument.argument;
+			if (!valueNode) {
+				return;
+			}
+
+			report(node, valueNode);
+		},
+	};
+}
+
+module.exports = {meta, create};

package/tests/no-boolean-coercion.test.ts

@@ -0,0 +1,82 @@
+const {RuleTester} = require('eslint');
+const rule = require('../src/rules/no-boolean-coercion');
+
+const ruleTester = new RuleTester({});
+
+const ERROR_MESSAGE
+	= 'Boolean coercion is not allowed. Use an explicit null/empty check instead.';
+
+ruleTester.run('no-boolean-coercion', rule, {
+	valid: [
+		'_.isNil(value);',
+		'_.isEmpty(list);',
+		'if (value != null) {}',
+		'if (list.length > 0) {}',
+		'Boolean;',
+		'const BooleanValue = true;',
+		'const fn = Boolean;',
+	],
+
+	invalid: [
+		{
+			code: 'Boolean(foo);',
+			errors: [
+				{
+					message: ERROR_MESSAGE,
+					suggestions: [
+						{
+							desc: 'Replace with _.isNil(foo)',
+							output: '_.isNil(foo);',
+						},
+					],
+				},
+			],
+		},
+
+		{
+			code: 'const x = Boolean(bar);',
+			errors: [
+				{
+					message: ERROR_MESSAGE,
+					suggestions: [
+						{
+							desc: 'Replace with _.isNil(bar)',
+							output: 'const x = _.isNil(bar);',
+						},
+					],
+				},
+			],
+		},
+
+		{
+			code: '!!value;',
+			errors: [
+				{
+					message: ERROR_MESSAGE,
+					suggestions: [
+						{
+							desc: 'Replace with _.isNil(value)',
+							output: '_.isNil(value);',
+						},
+					],
+				},
+			],
+		},
+
+		{
+			code: 'Boolean([]);',
+			errors: [
+				{
+					message: ERROR_MESSAGE,
+					suggestions: [
+						{
+							desc: 'Replace with _.isEmpty([])',
+							output: '_.isEmpty([]);',
+						},
+					],
+				},
+			],
+		},
+
+	],
+});