eslint-plugin-th-rules 1.5.4 → 1.6.0

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+# [1.6.0](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v1.5.5...v1.6.0) (2024-06-14)
+
+
+### Features
+
+* Added eslint-plugin-sonarjs to recommended config ([13176f3](https://github.com/tomerh2001/eslint-plugin-th-rules/commit/13176f3ededa543f3b5f05789a5deed6f0f5cdb1))
+
+## [1.5.5](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v1.5.4...v1.5.5) (2024-06-14)
+
+
+### Bug Fixes
+
+* fixed CI ([36f1e36](https://github.com/tomerh2001/eslint-plugin-th-rules/commit/36f1e36c95debb7360455bf0d00cdbffd07be77b))
+
 ## [1.5.4](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v1.5.3...v1.5.4) (2024-06-14)
 
 

package/README.md

@@ -52,7 +52,7 @@ To add all of the rules into your project, add the following configuration into
 
 ## Rules
 
-### 1. No-Destruction Rule
+### 1. No-destructuring Rule
 
 **Rule ID:** `th-rules/no-destructuring`
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-th-rules",
-  "version": "1.5.4",
+  "version": "1.6.0",
   "description": "A List of custom ESLint rules created by Tomer Horowitz",
   "keywords": [
     "eslint",
@@ -42,6 +42,7 @@
     "eslint-doc-generator": "^1.7.1",
     "eslint-plugin-eslint-plugin": "^6.1.0",
     "eslint-plugin-node": "^11.1.0",
+    "eslint-plugin-sonarjs": "^1.0.3",
     "eslint-plugin-unicorn": "^54.0.0",
     "mocha": "^10.4.0",
     "npm-run-all": "^4.1.5",

package/src/index.js

@@ -4,8 +4,9 @@
 'use strict';
 const requireIndex = require('requireindex');
 
-const base = {
-	plugins: ['th-rules'],
+const recommended = {
+	plugins: ['th-rules', 'sonarjs'],
+	extends: ['plugin:sonarjs/recommended-legacy'],
 	rules: {
 		'th-rules/no-destructuring': 'error',
 		'th-rules/no-default-export': 'error',
@@ -32,6 +33,6 @@ const base = {
 module.exports = {
 	rules: requireIndex(`${__dirname}/rules`),
 	configs: {
-		base,
+		base: recommended,
 	},
 };

package/src/rules/no-destructuring.js

@@ -63,7 +63,7 @@ function create(context) {
 			if (tabCount > MAX_TAB_COUNT) {
 				context.report({
 					node,
-					message: `Destruction at a nesting level above ${MAX_TAB_COUNT} is not allowed, instead saw ${tabCount} levels of nesting`,
+					message: `destructuring at a nesting level above ${MAX_TAB_COUNT} is not allowed, instead saw ${tabCount} levels of nesting`,
 				});
 			}
 
@@ -71,7 +71,7 @@ function create(context) {
 			if (node?.id?.properties?.length > MAX_VARIABLES) {
 				context.report({
 					node,
-					message: `Destruction of more than ${MAX_VARIABLES} variables is not allowed`,
+					message: `destructuring of more than ${MAX_VARIABLES} variables is not allowed`,
 				});
 			}
 
@@ -79,7 +79,7 @@ function create(context) {
 			if (lineLength > MAX_LINE_LENGTH) {
 				context.report({
 					node,
-					message: `Destruction on a line exceeding ${MAX_LINE_LENGTH} characters is not allowed`,
+					message: `destructuring on a line exceeding ${MAX_LINE_LENGTH} characters is not allowed`,
 				});
 			}
 		},

package/src/tests/no-destructuring.js

@@ -8,7 +8,7 @@ const ruleTester = new RuleTester({
 	},
 });
 
-ruleTester.run('no-destruction', rule, {
+ruleTester.run('no-destructuring', rule, {
 	valid: [
 		{
 			code: 'const { a, b } = obj;',
@@ -35,17 +35,17 @@ ruleTester.run('no-destruction', rule, {
 		{
 			code: 'const { a, b, c } = obj;',
 			options: [{maximumDestructuredVariables: 2, maximumLineLength: 80}],
-			errors: [{message: 'Destruction of more than 2 variables is not allowed'}],
+			errors: [{message: 'destructuring of more than 2 variables is not allowed'}],
 		},
 		{
 			code: 'const { a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p, q, r, s, t, u, v, w, x, y, z } = obj;',
 			options: [{maximumDestructuredVariables: 3, maximumLineLength: 80}],
-			errors: [{message: 'Destruction of more than 3 variables is not allowed'}, {message: 'Destruction on a line exceeding 80 characters is not allowed'}],
+			errors: [{message: 'destructuring of more than 3 variables is not allowed'}, {message: 'destructuring on a line exceeding 80 characters is not allowed'}],
 		},
 		{
 			code: 'function foo() {\n\t\t\t\t\t\t\tconst { a, b } = obj;\n}',
 			options: [{maximumDestructuredVariables: 3, maximumLineLength: 80}],
-			errors: [{message: 'Destruction at a nesting level above 3 is not allowed, instead saw 7 levels of nesting'}],
+			errors: [{message: 'destructuring at a nesting level above 3 is not allowed, instead saw 7 levels of nesting'}],
 		},
 	],
 });