eslint-plugin-th-rules 1.20.3 → 1.20.5

package/.github/workflows/main.yml

@@ -3,16 +3,16 @@ name: Semantic Versioning
 on:
   push:
     branches:
-      - main # or master, or whichever branch you want this to run on
+    - main
 
 jobs:
   release:
     runs-on: ubuntu-latest
     permissions:
-      contents: write # to be able to publish a GitHub release
-      issues: write # to be able to comment on released issues
-      pull-requests: write # to be able to comment on released pull requests
-      id-token: write # to enable use of OIDC for npm provenance
+      contents: write
+      issues: write
+      pull-requests: write
+      id-token: write
 
     steps:
     - name: Checkout
@@ -20,15 +20,18 @@ jobs:
 
     - name: Setup Bun
       uses: oven-sh/setup-bun@v1
-    
-    - name: Install Dependencies
-      run: bun i --dev
 
     - name: Setup Node.js environment
-      uses: actions/setup-node@v4.0.2
+      uses: actions/setup-node@v4
       with:
-        node-version: "20.x"
-    
+        node-version: "22.x"
+
+    - name: Install Dependencies
+      run: bun install --dev
+
+    - name: Verify ESLint flat configs
+      run: node ./scripts/verify.mjs
+
     - name: Semantic Release
       run: bunx semantic-release
       env:

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+## [1.20.5](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v1.20.4...v1.20.5) (2026-01-06)
+
+
+### Bug Fixes
+
+* update GitHub Actions workflow and add ESLint verification script ([9e3c40e](https://github.com/tomerh2001/eslint-plugin-th-rules/commit/9e3c40ee1c5500589e5463d997c832165666e6f6))
+
+## [1.20.4](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v1.20.3...v1.20.4) (2026-01-06)
+
+
+### Bug Fixes
+
+* fixed xo error ([056e708](https://github.com/tomerh2001/eslint-plugin-th-rules/commit/056e7083ac33a4727b8664ac28b6838d5070de3f))
+
 ## [1.20.3](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v1.20.2...v1.20.3) (2026-01-06)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-th-rules",
-  "version": "1.20.3",
+  "version": "1.20.5",
   "description": "A List of custom ESLint rules created by Tomer Horowitz",
   "keywords": [
     "eslint",
@@ -19,15 +19,20 @@
   },
   "dependencies": {
     "@babel/eslint-parser": "^7.28.5",
+    "@eslint/eslintrc": "^3.3.3",
     "eslint-config-jsdoc": "^15.4.0",
     "eslint-config-xo": "^0.49.0",
     "eslint-config-xo-react": "^0.29.0",
+    "eslint-plugin-import": "^2.32.0",
     "eslint-plugin-jsdoc": "^61.5.0",
+    "eslint-plugin-n": "^17.23.1",
     "eslint-plugin-react": "^7.37.5",
     "eslint-plugin-react-hooks": "^7.0.1",
     "eslint-plugin-react-native": "^5.0.0",
     "eslint-plugin-security": "^3.0.1",
     "eslint-plugin-sonarjs": "^3.0.5",
+    "eslint-plugin-unicorn": "^62.0.0",
+    "globals": "^17.0.0",
     "requireindex": "^1.2.0"
   },
   "devDependencies": {
@@ -48,9 +53,7 @@
     "eslint-doc-generator": "^3.0.2",
     "eslint-plugin-eslint-plugin": "^7.2.0",
     "eslint-plugin-node": "^11.1.0",
-    "eslint-plugin-sonarjs": "^3.0.5",
     "eslint-plugin-th-rules": "1.19.3",
-    "eslint-plugin-unicorn": "^62.0.0",
     "mocha": "^11.7.5",
     "npm-run-all": "^4.1.5",
     "typescript": "^5.9.3",

package/scripts/verify.mjs

@@ -0,0 +1,16 @@
+import {ESLint} from 'eslint';
+import thRules from '../src/index.js';
+
+const run = async (name, config) => {
+	const eslint = new ESLint({
+		overrideConfigFile: true,
+		overrideConfig: config,
+	});
+
+	const results = await eslint.lintText('const x = 1;\n', {filePath: 'fixtures/test.js'});
+	console.log(`OK: ${name} (${results[0].messages.length} messages)`);
+};
+
+await run('recommended', thRules.configs.recommended);
+await run('recommended-typescript', thRules.configs['recommended-typescript']);
+await run('recommended-react', thRules.configs['recommended-react']);

package/src/index.js

@@ -1,3 +1,4 @@
+/* eslint-disable import-x/order */
 /* eslint-disable import-x/no-extraneous-dependencies */
 /* eslint-disable n/no-path-concat */
 /* eslint-disable unicorn/prefer-module */
@@ -11,6 +12,13 @@ const reactPlugin = require('eslint-plugin-react');
 const reactHooks = require('eslint-plugin-react-hooks');
 const tseslint = require('typescript-eslint');
 
+// Plugins referenced by rule names in this config
+const unicornPlugin = require('eslint-plugin-unicorn');
+const importPlugin = require('eslint-plugin-import');
+const nPlugin = require('eslint-plugin-n');
+const sonarjsPlugin = require('eslint-plugin-sonarjs');
+const securityPlugin = require('eslint-plugin-security');
+
 const plugin = {
 	rules: requireIndex(`${__dirname}/rules`),
 	configs: {},
@@ -27,10 +35,23 @@ const compat = new FlatCompat({
 
 const baseRecommended = {
 	plugins: {
+		// Local rules
 		'th-rules': plugin,
+
+		// Third-party plugins used by rule names below
+		unicorn: unicornPlugin,
+		import: importPlugin,
+		n: nPlugin,
+		sonarjs: sonarjsPlugin,
+		security: securityPlugin,
+
+		// Included so consumers can use react/react-hooks rules as well
+		react: reactPlugin,
+		'react-hooks': reactHooks,
 	},
 	languageOptions: {
 		ecmaVersion: 2024,
+		sourceType: 'module',
 		globals: {
 			...globals.node,
 			...globals.es2024,
@@ -48,7 +69,6 @@ const baseRecommended = {
 		'th-rules/schemas-in-schemas-file': 'error',
 		'th-rules/types-in-dts': 'error',
 
-		'unicorn/prefer-module': 'warn',
 		'unicorn/filename-case': 'off',
 		'unicorn/no-array-callback-reference': 'off',
 		'import/extensions': 'off',
@@ -70,15 +90,18 @@ const baseRecommended = {
 
 /** @type {import('eslint').Linter.FlatConfig[]} */
 plugin.configs.recommended = flatConfigs(
-	// These are legacy configs -> convert them
+	// Legacy configs -> convert them
 	compat.extends('plugin:sonarjs/recommended-legacy', 'plugin:security/recommended-legacy'),
 	baseRecommended,
 );
 
 plugin.configs['recommended-typescript'] = flatConfigs(
 	plugin.configs.recommended,
+
+	// Typescript-eslint exports flat configs (arrays of flat config objects)
 	tseslint.configs.strictTypeChecked,
 	tseslint.configs.stylisticTypeChecked,
+
 	{
 		languageOptions: {
 			parserOptions: {
@@ -103,11 +126,10 @@ plugin.configs['recommended-typescript'] = flatConfigs(
 plugin.configs['recommended-react'] = flatConfigs(
 	plugin.configs.recommended,
 
-	// React: flat config supported
-	reactPlugin.configs?.flat?.recommended ?? reactPlugin.configs?.recommended,
-
-	// React-hooks: if you suspect this is legacy in your version, swap to compat.extends('plugin:react-hooks/recommended')
-	reactHooks.configs?.['recommended-latest'] ?? reactHooks.configs?.recommended,
+	// IMPORTANT: Always use compat here so we never accidentally inject eslintrc-style
+	// { plugins: ["react"] } into flat config (which causes the exact error you hit).
+	compat.extends('plugin:react/recommended'),
+	compat.extends('plugin:react-hooks/recommended'),
 
 	{
 		rules: {