eslint-plugin-th-rules 1.19.0 → 1.19.2

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+## [1.19.2](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v1.19.1...v1.19.2) (2026-01-05)
+
+
+### Bug Fixes
+
+* clean up JSDoc comments and improve code readability in no-destructuring rule ([f7c2547](https://github.com/tomerh2001/eslint-plugin-th-rules/commit/f7c2547e71d41d19c874b1713c62bed25018803c))
+
+## [1.19.1](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v1.19.0...v1.19.1) (2026-01-05)
+
+
+### Bug Fixes
+
+* remove jsdoc plugin from recommended configs and clean up extends ([de220ac](https://github.com/tomerh2001/eslint-plugin-th-rules/commit/de220acd3d0c80340c7ee9b5bc2bfe2967c1c4c5))
+
 # [1.19.0](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v1.18.0...v1.19.0) (2026-01-05)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-th-rules",
-  "version": "1.19.0",
+  "version": "1.19.2",
   "description": "A List of custom ESLint rules created by Tomer Horowitz",
   "keywords": [
     "eslint",

package/src/index.js

@@ -9,12 +9,10 @@ const configs = {
 		plugins: [
 			'th-rules',
 			'sonarjs',
-			'jsdoc',
 		],
 		extends: [
 			'plugin:sonarjs/recommended-legacy',
 			'plugin:security/recommended-legacy',
-			'plugin:jsdoc/recommended',
 		],
 		rules: {
 			'th-rules/no-destructuring': 'error',
@@ -24,7 +22,6 @@ const configs = {
 			'th-rules/styles-in-styles-file': 'error',
 			'th-rules/schemas-in-schemas-file': 'error',
 			'th-rules/types-in-dts': 'error',
-
 			'unicorn/prefer-module': 'warn',
 			'unicorn/filename-case': 'off',
 			'unicorn/no-array-callback-reference': 'off',
@@ -56,10 +53,7 @@ for (const configName of Object.keys(configs)) {
 		extends: [
 			'plugin:@typescript-eslint/strict-type-checked',
 			'plugin:@typescript-eslint/stylistic-type-checked',
-
-			...configs[configName].extends
-				.filter(x => x !== 'plugin:jsdoc/recommended'),
-			'plugin:jsdoc/recommended-typescript',
+			...configs[configName].extends,
 		],
 		rules: {
 			...configs[configName].rules,
@@ -75,7 +69,6 @@ for (const configName of Object.keys(configs)) {
 			'@typescript-eslint/no-unsafe-argument': 'off',
 		},
 	};
-
 	configs[`${configName}-react`] = {
 		...configs[configName],
 		extends: [

package/src/rules/no-destructuring.js

@@ -1,19 +1,5 @@
 const MAX_TAB_COUNT = 3;
 
-/**
- * Represents the metadata for the "no-destructuring" ESLint rule.
- *
- * @type {Object}
- * @property {string} type - The type of the rule.
- * @property {Object} docs - The documentation for the rule.
- * @property {string} docs.description - The description of the rule.
- * @property {string} docs.category - The category of the rule.
- * @property {boolean} docs.recommended - Indicates if the rule is recommended.
- * @property {Object[]} schema - The schema for the rule options.
- * @property {Object} schema[].properties - The properties of the rule options.
- * @property {number} schema[].properties.maximumDestructuredVariables - The maximum number of destructured variables allowed.
- * @property {number} schema[].properties.maximumLineLength - The maximum line length allowed.
- */
 const meta = {
 	type: 'problem',
 	docs: {
@@ -26,67 +12,103 @@ const meta = {
 		{
 			type: 'object',
 			properties: {
-				maximumDestructuredVariables: {
-					type: 'integer',
-					minimum: 0,
-				},
-				maximumLineLength: {
-					type: 'integer',
-					minimum: 0,
-				},
+				maximumDestructuredVariables: {type: 'integer', minimum: 0},
+				maximumLineLength: {type: 'integer', minimum: 0},
 			},
 			additionalProperties: false,
 		},
 	],
 };
 
-/**
- * Creates an ESLint rule that checks for excessive destructuring in variable declarations.
- * @param {Object} context - The ESLint rule context.
- * @returns {Object} - The ESLint rule object.
- */
 function create(context) {
-	const MAX_VARIABLES = context?.options[0]?.maximumDestructuredVariables || 2;
-	const MAX_LINE_LENGTH = context?.options[0]?.maximumLineLength || 100;
+	const MAX_VARIABLES = context?.options?.[0]?.maximumDestructuredVariables ?? 2;
+	const MAX_LINE_LENGTH = context?.options?.[0]?.maximumLineLength ?? 100;
 
-	return {
-		VariableDeclarator(node) {
-			const sourceCode = context.getSourceCode();
-			const line = sourceCode.lines[node.loc.start.line - 1];
-			const lineLength = line.length;
-			const tabCount = line.search(/\S|$/);
+	const sourceCode = context.getSourceCode();
+
+	function reportIfNeeded(patternNode, reportNode = patternNode) {
+		if (!patternNode || patternNode.type !== 'ObjectPattern' || !patternNode.loc) {
+			return;
+		}
 
-			if (node?.id?.type !== 'ObjectPattern') {
-				return;
+		const lineText = sourceCode.lines[patternNode.loc.start.line - 1] ?? '';
+		const indentCount = lineText.search(/\S|$/);
+
+		const propertyCount = patternNode.properties?.length ?? 0;
+
+		const startLine = patternNode.loc.start.line;
+		const endLine = patternNode.loc.end.line;
+		let maxSpannedLineLength = 0;
+		for (let i = startLine; i <= endLine; i++) {
+			const t = sourceCode.lines[i - 1] ?? '';
+			if (t.length > maxSpannedLineLength) {
+				maxSpannedLineLength = t.length;
 			}
+		}
+
+		if (indentCount > MAX_TAB_COUNT) {
+			context.report({
+				node: reportNode,
+				message: `destructuring at a nesting level above ${MAX_TAB_COUNT} is not allowed, instead saw ${indentCount} levels of nesting`,
+			});
+		}
 
-			if (tabCount > MAX_TAB_COUNT) {
-				context.report({
-					node,
-					message: `destructuring at a nesting level above ${MAX_TAB_COUNT} is not allowed, instead saw ${tabCount} levels of nesting`,
-				});
+		if (propertyCount > MAX_VARIABLES) {
+			context.report({
+				node: reportNode,
+				message: `destructuring of more than ${MAX_VARIABLES} variables is not allowed`,
+			});
+		}
+
+		if (maxSpannedLineLength > MAX_LINE_LENGTH) {
+			context.report({
+				node: reportNode,
+				message: `destructuring on a line exceeding ${MAX_LINE_LENGTH} characters is not allowed`,
+			});
+		}
+	}
+
+	function checkParameters(parameters) {
+		for (const p of parameters || []) {
+			if (!p) {
+				continue;
 			}
 
-			if (node?.id?.properties?.length > MAX_VARIABLES) {
-				context.report({
-					node,
-					message: `destructuring of more than ${MAX_VARIABLES} variables is not allowed`,
-				});
+			if (p.type === 'AssignmentPattern') {
+				reportIfNeeded(p.left, p);
+				continue;
 			}
 
-			if (lineLength > MAX_LINE_LENGTH) {
-				context.report({
-					node,
-					message: `destructuring on a line exceeding ${MAX_LINE_LENGTH} characters is not allowed`,
-				});
+			reportIfNeeded(p, p);
+		}
+	}
+
+	return {
+
+		VariableDeclarator(node) {
+			reportIfNeeded(node?.id, node);
+		},
+
+		FunctionDeclaration(node) {
+			checkParameters(node.params);
+		},
+		FunctionExpression(node) {
+			checkParameters(node.params);
+		},
+		ArrowFunctionExpression(node) {
+			checkParameters(node.params);
+		},
+
+		MethodDefinition(node) {
+			if (node?.value?.params) {
+				checkParameters(node.value.params);
 			}
 		},
+
+		TSDeclareFunction(node) {
+			checkParameters(node.params);
+		},
 	};
 }
 
-const rule = {
-	meta,
-	create,
-};
-
-module.exports = rule;
+module.exports = {meta, create};