eslint-plugin-th-rules 1.17.0 → 1.17.1

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [1.17.1](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v1.17.0...v1.17.1) (2026-01-05)
+
+
+### Bug Fixes
+
+* improve style file validation messages and simplify code structure ([5c165b4](https://github.com/tomerh2001/eslint-plugin-th-rules/commit/5c165b4fcbc103df752e7c56f988c725dae6a62c))
+
 # [1.17.0](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v1.16.0...v1.17.0) (2026-01-05)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-th-rules",
-  "version": "1.17.0",
+  "version": "1.17.1",
   "description": "A List of custom ESLint rules created by Tomer Horowitz",
   "keywords": [
     "eslint",

package/src/rules/styles-in-styles-file.js

@@ -10,19 +10,11 @@ const meta = {
 		{
 			type: 'object',
 			properties: {
-				/**
-				 * Allowed style file suffixes. Defaults:
-				 * [".styles.ts", ".styles.tsx"]
-				 */
 				allowedSuffixes: {
 					type: 'array',
 					items: {type: 'string', minLength: 1},
 					minItems: 1,
 				},
-
-				/**
-				 * If true, also flag `StyleSheet.compose(...)` (optional).
-				 */
 				includeCompose: {type: 'boolean'},
 			},
 			additionalProperties: false,
@@ -30,7 +22,7 @@ const meta = {
 	],
 	messages: {
 		moveStyles:
-			'React-Native styles must be moved to a .styles.ts/.styles.tsx file (for example "{{filename}}.styles.ts").',
+			'React-Native styles{{target}} must be defined in a dedicated styles file ({{suffixes}}). Current file: "{{filename}}".',
 	},
 };
 
@@ -56,18 +48,62 @@ function create(context) {
 		const object = callee.object;
 		const property = callee.property;
 
-		const isStyleSheet
-			= object
-			&& object.type === 'Identifier'
-			&& object.name === 'StyleSheet';
+		return (
+			object?.type === 'Identifier'
+			&& object.name === 'StyleSheet'
+			&& !callee.computed
+			&& property?.type === 'Identifier'
+			&& property.name === memberName
+		);
+	}
+
+	/**
+	 * Try to infer the “name” of the style object, e.g.:
+	 *   const styles = StyleSheet.create(...)      -> "styles"
+	 *   styles = StyleSheet.create(...)            -> "styles"
+	 *   exports.styles = StyleSheet.create(...)    -> "exports.styles"
+	 */
+	function getAssignmentTargetName(callNode) {
+		const p = callNode.parent;
+
+		if (p?.type === 'VariableDeclarator') {
+			const id = p.id;
+			if (id?.type === 'Identifier') {
+				return id.name;
+			}
+
+			return null;
+		}
+
+		if (p?.type === 'AssignmentExpression') {
+			const left = p.left;
+
+			if (left?.type === 'Identifier') {
+				return left.name;
+			}
+
+			if (left?.type === 'MemberExpression' && !left.computed) {
+				const object = left.object;
+				const property = left.property;
+
+				const objectName
+					= object?.type === 'Identifier'
+						? object.name
+						: (object?.type === 'ThisExpression'
+							? 'this'
+							: null);
 
-		const isMember
-			= !callee.computed
-			&& property
-			&& property.type === 'Identifier'
-			&& property.name === memberName;
+				const propertyName = property?.type === 'Identifier' ? property.name : null;
+
+				if (objectName && propertyName) {
+					return `${objectName}.${propertyName}`;
+				}
+			}
 
-		return isStyleSheet && isMember;
+			return null;
+		}
+
+		return null;
 	}
 
 	function report(node) {
@@ -76,12 +112,16 @@ function create(context) {
 			return;
 		}
 
+		const targetName = getAssignmentTargetName(node);
+		const target = targetName ? ` "${targetName}"` : '';
+
 		context.report({
 			node,
 			messageId: 'moveStyles',
 			data: {
 				filename,
 				suffixes: allowedSuffixes.join(' or '),
+				target,
 			},
 		});
 	}
@@ -100,7 +140,4 @@ function create(context) {
 	};
 }
 
-module.exports = {
-	meta,
-	create,
-};
+module.exports = {meta, create};