eslint-plugin-th-rules 1.15.6 → 1.17.0

package/.yarnrc.yml

@@ -1,3 +1,3 @@
 nodeLinker: node-modules
 
-yarnPath: .yarn/releases/yarn-4.6.0.cjs
+yarnPath: .yarn/releases/yarn-4.12.0.cjs

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+# [1.17.0](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v1.16.0...v1.17.0) (2026-01-05)
+
+
+### Features
+
+* add 'styles-in-styles-file' rule to enforce React-Native styles in dedicated files ([eca8af0](https://github.com/tomerh2001/eslint-plugin-th-rules/commit/eca8af0850aa197a35fb47cf08a9f04839a6a3cb))
+
+# [1.16.0](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v1.15.6...v1.16.0) (2026-01-05)
+
+
+### Features
+
+* add new rule 'types-in-dts' to enforce TypeScript type declarations in .d.ts files ([00c4769](https://github.com/tomerh2001/eslint-plugin-th-rules/commit/00c4769f9a025642f7c72023df1dea82dbf33e72))
+
 ## [1.15.6](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v1.15.5...v1.15.6) (2024-12-30)
 
 

package/README.md

@@ -7,10 +7,6 @@
 
 This repository contains custom ESLint rules to enhance code quality and consistency across projects.
 
-# Custom ESLint Rules
-
-This repository contains custom ESLint rules to enhance code quality and consistency across projects, created by Tomer Horowitz.
-
 ## Rules
 <!-- begin auto-generated rules list -->
 
@@ -18,12 +14,14 @@ This repository contains custom ESLint rules to enhance code quality and consist
 ✅ Set in the `recommended` configuration.\
 🔧 Automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/user-guide/command-line-interface#--fix).
 
-| Name                                                     | Description                                                                      | 💼                                                               | 🔧 |
-| :------------------------------------------------------- | :------------------------------------------------------------------------------- | :--------------------------------------------------------------- | :- |
-| [no-comments](docs/rules/no-comments.md)                 | Disallow comments except for specified allowed patterns.                         | ✅ ![badge-recommended-react][] ![badge-recommended-typescript][] | 🔧 |
-| [no-default-export](docs/rules/no-default-export.md)     | Convert unnamed default exports to named default exports based on the file name. | ✅ ![badge-recommended-react][] ![badge-recommended-typescript][] | 🔧 |
-| [no-destructuring](docs/rules/no-destructuring.md)       | Disallow destructuring that does not meet certain conditions                     | ✅ ![badge-recommended-react][] ![badge-recommended-typescript][] |    |
-| [top-level-functions](docs/rules/top-level-functions.md) | Require all top-level functions to be named/regular functions.                   |                                                                  | 🔧 |
+| Name                                                         | Description                                                                               | 💼                                                               | 🔧 |
+| :----------------------------------------------------------- | :---------------------------------------------------------------------------------------- | :--------------------------------------------------------------- | :- |
+| [no-comments](docs/rules/no-comments.md)                     | Disallow comments except for specified allowed patterns.                                  | ✅ ![badge-recommended-react][] ![badge-recommended-typescript][] | 🔧 |
+| [no-default-export](docs/rules/no-default-export.md)         | Convert unnamed default exports to named default exports based on the file name.          | ✅ ![badge-recommended-react][] ![badge-recommended-typescript][] | 🔧 |
+| [no-destructuring](docs/rules/no-destructuring.md)           | Disallow destructuring that does not meet certain conditions                              | ✅ ![badge-recommended-react][] ![badge-recommended-typescript][] |    |
+| [styles-in-styles-file](docs/rules/styles-in-styles-file.md) | Require React-Native StyleSheet.create(...) to be placed in a .styles.ts/.styles.tsx file | ✅ ![badge-recommended-react][] ![badge-recommended-typescript][] |    |
+| [top-level-functions](docs/rules/top-level-functions.md)     | Require all top-level functions to be named/regular functions.                            | ✅ ![badge-recommended-react][] ![badge-recommended-typescript][] | 🔧 |
+| [types-in-dts](docs/rules/types-in-dts.md)                   | Require TypeScript type declarations (type/interface/enum) to be placed in .d.ts files    | ✅ ![badge-recommended-react][] ![badge-recommended-typescript][] |    |
 
 <!-- end auto-generated rules list -->
 

package/docs/rules/styles-in-styles-file.md

@@ -0,0 +1,142 @@
+<pre>
+# Require React-Native StyleSheet.create(...) to be placed in a .styles.ts/.styles.tsx file (`th-rules/styles-in-styles-file`)
+
+💼 This rule is enabled in the following configs: ✅ `recommended`, `recommended-react`, `recommended-typescript`.
+
+<!-- end auto-generated rule header -->
+
+This rule enforces that React-Native stylesheet declarations created via `StyleSheet.create(...)` live in a dedicated styles file, typically ending with `.styles.ts` or `.styles.tsx`.
+
+In practice, this prevents implementation/component files from containing large style objects, and encourages consistent separation of concerns.
+
+## Rationale
+
+Keeping styles in dedicated files:
+- improves readability of component files by reducing visual noise,
+- encourages reuse and consistency across components,
+- makes style changes easier to review (diffs focus only on styles),
+- standardizes project structure and naming conventions.
+
+## What the rule reports
+
+The rule reports any `StyleSheet.create(...)` call in files whose names do **not** match one of the allowed suffixes (by default, `.styles.ts` and `.styles.tsx`).
+
+Optionally, it can also report `StyleSheet.compose(...)` calls.
+
+## Examples
+
+### ❌ Incorrect
+
+```ts
+// ArticleCard.tsx
+import {StyleSheet} from 'react-native';
+
+const styles = StyleSheet.create({
+	container: {padding: 12},
+});
+```
+
+```ts
+// AnyOtherFile.ts
+import {StyleSheet} from 'react-native';
+
+export default StyleSheet.create({
+	row: {flexDirection: 'row'},
+});
+```
+
+### ✅ Correct
+
+```ts
+// ArticleCard.styles.ts
+import {StyleSheet} from 'react-native';
+
+export const styles = StyleSheet.create({
+	container: {padding: 12},
+});
+```
+
+```ts
+// ArticleCard.tsx
+import React from 'react';
+import {View} from 'react-native';
+import {styles} from './ArticleCard.styles';
+
+export function ArticleCard() {
+	return <View style={styles.container} />;
+}
+```
+
+### `includeCompose` example
+
+When `includeCompose: true`, the following becomes invalid outside a `.styles.ts(x)` file:
+
+```ts
+// ArticleCard.tsx
+import {StyleSheet} from 'react-native';
+
+const combined = StyleSheet.compose(
+	{padding: 12},
+	{margin: 8},
+);
+```
+
+With the same code moved to `ArticleCard.styles.ts`, it becomes valid.
+
+## Options
+
+<!-- begin auto-generated rule options list -->
+
+| Name              | Type     |
+| :---------------- | :------- |
+| `allowedSuffixes` | String[] |
+| `includeCompose`  | Boolean  |
+
+<!-- end auto-generated rule options list -->
+
+### `allowedSuffixes`
+
+An array of filename suffixes that are allowed to contain `StyleSheet.create(...)`.
+
+Default:
+- `.styles.ts`
+- `.styles.tsx`
+
+Example:
+
+```json
+{
+  "rules": {
+    "th-rules/styles-in-styles-file": ["error", {
+      "allowedSuffixes": [".styles.ts", ".styles.tsx", ".native-styles.ts"]
+    }]
+  }
+}
+```
+
+### `includeCompose`
+
+When set to `true`, the rule also enforces the file restriction for `StyleSheet.compose(...)`.
+
+Default: `false`
+
+Example:
+
+```json
+{
+  "rules": {
+    "th-rules/styles-in-styles-file": ["error", {
+      "includeCompose": true
+    }]
+  }
+}
+```
+
+## Notes
+
+- This rule only targets `StyleSheet.create(...)` (and optionally `StyleSheet.compose(...)`). It does not restrict:
+  - plain object styles (e.g., `const styles = { ... }`),
+  - other styling systems (e.g., styled-components, Tamagui, Emotion),
+  - calls to other `StyleSheet.*` helpers (e.g., `flatten`, `hairlineWidth`).
+- The rule is filename-based. If ESLint is invoked with `<input>` (stdin), the rule will treat it as not being an allowed styles file.
+</pre>

package/docs/rules/top-level-functions.md

@@ -1,5 +1,7 @@
 # Require all top-level functions to be named/regular functions (`th-rules/top-level-functions`)
 
+💼 This rule is enabled in the following configs: ✅ `recommended`, `recommended-react`, `recommended-typescript`.
+
 🔧 This rule is automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/latest/user-guide/command-line-interface#--fix).
 
 <!-- end auto-generated rule header -->
@@ -38,9 +40,6 @@ function myFunction() {
 }
 ```
 
-## Options
-
-This rule has no options.
 
 ## When Not To Use It
 

package/docs/rules/types-in-dts.md

@@ -0,0 +1,112 @@
+<pre>
+# Require TypeScript type declarations (type/interface/enum) to be placed in .d.ts files (`th-rules/types-in-dts`)
+
+💼 This rule is enabled in the following configs: ✅ `recommended`, `recommended-react`, `recommended-typescript`.
+
+<!-- end auto-generated rule header -->
+
+💼 This rule is enabled in the following configs: ✅ `recommended`, `recommended-react`, `recommended-typescript`.
+
+&lt;!-- end auto-generated rule header --&gt;
+
+This rule enforces a strict separation between **runtime code** and **type declarations** by requiring all top-level TypeScript type declarations to be defined in `.d.ts` files.
+
+The rule applies to:
+- `type` aliases
+- `interface` declarations
+- `enum` declarations
+
+Any of these constructs declared outside of a `.d.ts` file will be reported, unless explicitly allowed via configuration.
+
+## Rationale
+
+Keeping type declarations in `.d.ts` files provides several benefits:
+
+- Enforces a clean architectural boundary between runtime logic and type definitions
+- Improves file readability by reducing noise in implementation files
+- Encourages intentional, centralized ownership of public and shared types
+- Prevents accidental runtime coupling with type-only constructs
+- Aligns well with library-oriented or API-driven codebases
+
+This rule is especially useful in large TypeScript projects, shared packages, or monorepos where type contracts are meant to be consumed independently of implementation.
+
+## Examples
+
+### ❌ Incorrect
+
+```ts
+// user.ts
+type UserId = string;
+
+interface User {
+  id: UserId;
+  name: string;
+}
+
+enum Role {
+  Admin,
+  User,
+}
+```
+
+### ✅ Correct
+
+```ts
+// user.d.ts
+type UserId = string;
+
+interface User {
+  id: UserId;
+  name: string;
+}
+
+enum Role {
+  Admin,
+  User,
+}
+```
+
+```ts
+// user.ts
+import type { User, UserId, Role } from './user';
+```
+
+### Allowed usage
+
+Using types, interfaces, or enums is always allowed in any file:
+
+```ts
+function getUser(id: UserId): User {
+  // ...
+}
+```
+
+## Options
+
+&lt;!-- begin auto-generated rule options list --&gt;
+
+| Name           | Type    |
+| :------------- | :------ |
+| `allowDeclare` | Boolean |
+| `allowEnums`   | Boolean |
+
+&lt;!-- end auto-generated rule options list --&gt;
+
+### `allowDeclare`
+
+When set to `true`, the rule allows `declare` type declarations in non-`.d.ts` files.
+
+This is useful when working with ambient declarations, global augmentations, or compatibility shims that must live alongside implementation code.
+
+### `allowEnums`
+
+When set to `true`, the rule allows `enum` declarations in non-`.d.ts` files.
+
+This can be helpful in codebases that rely on runtime enums while still wanting to enforce `.d.ts` placement for interfaces and type aliases.
+
+## Notes
+
+- This rule does not enforce how types are imported or re-exported.
+- It does not attempt to auto-fix violations, as moving declarations across files is not safe to do automatically.
+- The rule operates purely at the syntax level and does not require type information.
+</pre>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-th-rules",
-  "version": "1.15.6",
+  "version": "1.17.0",
   "description": "A List of custom ESLint rules created by Tomer Horowitz",
   "keywords": [
     "eslint",
@@ -49,7 +49,7 @@
     "eslint-plugin-eslint-plugin": "^6.4.0",
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-sonarjs": "^3.0.1",
-    "eslint-plugin-th-rules": "1.14.1",
+    "eslint-plugin-th-rules": "1.15.6",
     "eslint-plugin-unicorn": "^56.0.1",
     "mocha": "^11.0.1",
     "npm-run-all": "^4.1.5",
@@ -62,5 +62,5 @@
     "typescript": "^5.7.2"
   },
   "license": "ISC",
-  "packageManager": "yarn@4.6.0"
+  "packageManager": "yarn@4.12.0"
 }

package/src/index.js

@@ -19,6 +19,8 @@ const configs = {
 			'th-rules/no-default-export': 'error',
 			'th-rules/no-comments': 'error',
 			'th-rules/top-level-functions': 'error',
+			'th-rules/styles-in-styles-file': 'error',
+			'th-rules/types-in-dts': 'error',
 			'unicorn/prefer-module': 'warn',
 			'unicorn/filename-case': 'off',
 			'unicorn/no-array-callback-reference': 'off',
@@ -72,6 +74,7 @@ for (const configName of Object.keys(configs)) {
 			'plugin:react/recommended',
 			'plugin:react-hooks/recommended',
 			...configs[configName].extends,
+
 		],
 		rules: {
 			...configs[configName].rules,

package/src/rules/styles-in-styles-file.js

@@ -0,0 +1,106 @@
+const meta = {
+	type: 'problem',
+	docs: {
+		description: 'Require React-Native StyleSheet.create(...) to be placed in a .styles.ts/.styles.tsx file',
+		category: 'Stylistic Issues',
+		recommended: false,
+		url: 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/styles-in-styles-file.md',
+	},
+	schema: [
+		{
+			type: 'object',
+			properties: {
+				/**
+				 * Allowed style file suffixes. Defaults:
+				 * [".styles.ts", ".styles.tsx"]
+				 */
+				allowedSuffixes: {
+					type: 'array',
+					items: {type: 'string', minLength: 1},
+					minItems: 1,
+				},
+
+				/**
+				 * If true, also flag `StyleSheet.compose(...)` (optional).
+				 */
+				includeCompose: {type: 'boolean'},
+			},
+			additionalProperties: false,
+		},
+	],
+	messages: {
+		moveStyles:
+			'React-Native styles must be moved to a .styles.ts/.styles.tsx file (for example "{{filename}}.styles.ts").',
+	},
+};
+
+function create(context) {
+	const options = context.options?.[0] ?? {};
+	const allowedSuffixes = options.allowedSuffixes ?? ['.styles.ts', '.styles.tsx'];
+	const includeCompose = Boolean(options.includeCompose);
+
+	function isAllowedStyleFile(filename) {
+		if (!filename || filename === '<input>') {
+			return false;
+		}
+
+		return allowedSuffixes.some(suffix => filename.endsWith(suffix));
+	}
+
+	function isStyleSheetMemberCall(node, memberName) {
+		const callee = node?.callee;
+		if (!callee || callee.type !== 'MemberExpression') {
+			return false;
+		}
+
+		const object = callee.object;
+		const property = callee.property;
+
+		const isStyleSheet
+			= object
+			&& object.type === 'Identifier'
+			&& object.name === 'StyleSheet';
+
+		const isMember
+			= !callee.computed
+			&& property
+			&& property.type === 'Identifier'
+			&& property.name === memberName;
+
+		return isStyleSheet && isMember;
+	}
+
+	function report(node) {
+		const filename = context.getFilename();
+		if (isAllowedStyleFile(filename)) {
+			return;
+		}
+
+		context.report({
+			node,
+			messageId: 'moveStyles',
+			data: {
+				filename,
+				suffixes: allowedSuffixes.join(' or '),
+			},
+		});
+	}
+
+	return {
+		CallExpression(node) {
+			if (isStyleSheetMemberCall(node, 'create')) {
+				report(node);
+				return;
+			}
+
+			if (includeCompose && isStyleSheetMemberCall(node, 'compose')) {
+				report(node);
+			}
+		},
+	};
+}
+
+module.exports = {
+	meta,
+	create,
+};

package/src/rules/top-level-functions.js

@@ -67,7 +67,6 @@ function buildFunctionExpressionReplacement(functionName, functionExprNode, sour
  */
 function buildAnonymousFunctionDeclarationReplacement(sourceCode, node, functionName = 'defaultFunction', isExport = false) {
 	const originalText = sourceCode.getText(node);
-	const asyncKeyword = node.async ? 'async ' : '';
 	const exportKeyword = isExport ? 'export ' : '';
 
 	let replaced = originalText;

package/src/rules/types-in-dts.js

@@ -0,0 +1,94 @@
+/**
+ * @fileoverview Enforce that TypeScript type declarations exist only in .d.ts files.
+ */
+
+const meta = {
+	type: 'problem',
+	docs: {
+		description: 'Require TypeScript type declarations (type/interface/enum) to be placed in .d.ts files',
+		category: 'Best Practices',
+		recommended: true,
+		url: 'https://github.com/tomerh2001/eslint-plugin-th-rules/blob/main/docs/rules/types-in-dts.md',
+	},
+	schema: [
+		{
+			type: 'object',
+			properties: {
+				allowEnums: {type: 'boolean'},
+				allowDeclare: {type: 'boolean'},
+			},
+			additionalProperties: false,
+		},
+	],
+	messages: {
+		moveToDts:
+			'Type declarations must be moved to a .d.ts file (for example "{{filename}}.d.ts").',
+	},
+};
+
+/**
+ * @param {import('eslint').Rule.RuleContext} context
+ */
+function create(context) {
+	const options = context.options?.[0] ?? {};
+	const allowEnums = Boolean(options.allowEnums);
+	const allowDeclare = Boolean(options.allowDeclare);
+
+	function isDtsFile(filename) {
+		if (!filename || filename === '<input>') {
+			return false;
+		}
+
+		return filename.endsWith('.d.ts');
+	}
+
+	function hasDeclareModifier(node) {
+		if (node && node.declare === true) {
+			return true;
+		}
+
+		const mods = node && Array.isArray(node.modifiers) ? node.modifiers : [];
+		return mods.some(m => m && m.type === 'TSDeclareKeyword');
+	}
+
+	function reportIfNotDts(node) {
+		const filename = context.getFilename();
+		if (isDtsFile(filename)) {
+			return;
+		}
+
+		if (allowDeclare && hasDeclareModifier(node)) {
+			return;
+		}
+
+		context.report({
+			node,
+			messageId: 'moveToDts',
+			data: {filename},
+		});
+	}
+
+	return {
+		TSTypeAliasDeclaration(node) {
+			reportIfNotDts(node);
+		},
+
+		TSInterfaceDeclaration(node) {
+			reportIfNotDts(node);
+		},
+
+		TSEnumDeclaration(node) {
+			if (allowEnums) {
+				return;
+			}
+
+			reportIfNotDts(node);
+		},
+
+	};
+}
+
+module.exports = {
+	meta,
+	create,
+};