eslint-plugin-th-rules 1.15.2 → 1.15.3

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [1.15.3](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v1.15.2...v1.15.3) (2024-12-30)
+
+
+### Bug Fixes
+
+* enhance top-level functions rule to handle arrow and function expressions ([0bdcc2c](https://github.com/tomerh2001/eslint-plugin-th-rules/commit/0bdcc2cbe2bd9e790ca2965001c786e3a8518a60))
+
 ## [1.15.2](https://github.com/tomerh2001/eslint-plugin-th-rules/compare/v1.15.1...v1.15.2) (2024-12-30)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-th-rules",
-  "version": "1.15.2",
+  "version": "1.15.3",
   "description": "A List of custom ESLint rules created by Tomer Horowitz",
   "keywords": [
     "eslint",

package/src/rules/top-level-functions.js

@@ -17,22 +17,35 @@ function create(context) {
 				return;
 			}
 
-			if (!(node.init && (node.init.type === 'ArrowFunctionExpression' || node.init.type === 'FunctionExpression'))) {
-				return;
+			const sourceCode = context.getSourceCode();
+
+			if (node.init && node.init.type === 'ArrowFunctionExpression') {
+				const functionName = node.id.name;
+				const functionText = sourceCode.getText(node.init);
+
+				context.report({
+					node: node.init,
+					message: 'Top-level functions must be named/regular functions.',
+					fix(fixer) {
+						const fixedCode = `function ${functionName}${functionText.slice(functionText.indexOf('('))}`;
+						return fixer.replaceText(node.parent, fixedCode);
+					},
+				});
 			}
 
-			const sourceCode = context.getSourceCode();
-			const functionText = sourceCode.getText(node.init);
-			const functionName = node.id.name;
+			if (node.init && node.init.type === 'FunctionExpression') {
+				const functionName = node.id.name;
+				const functionText = sourceCode.getText(node.init);
 
-			context.report({
-				node: node.init,
-				message: 'Top-level functions must be named/regular functions.',
-				fix(fixer) {
-					const fixedCode = `function ${functionName}${functionText.slice(functionText.indexOf('('))}`;
-					return fixer.replaceText(node, fixedCode);
-				},
-			});
+				context.report({
+					node: node.init,
+					message: 'Top-level functions must be named/regular functions.',
+					fix(fixer) {
+						const fixedCode = `function ${functionName}${functionText.slice(functionText.indexOf('('))}`;
+						return fixer.replaceText(node.parent, fixedCode);
+					},
+				});
+			}
 		},
 
 		FunctionDeclaration(node) {
@@ -48,6 +61,7 @@ function create(context) {
 						const functionName = 'defaultFunction';
 						const sourceCode = context.getSourceCode();
 						const functionText = sourceCode.getText(node);
+
 						const fixedCode = functionText.replace('function (', `function ${functionName}(`);
 
 						return fixer.replaceText(node, fixedCode);

package/tests/top-level-functions.test.js

@@ -1,30 +0,0 @@
-const {RuleTester} = require('eslint');
-const rule = require('../src/rules/top-level-functions');
-
-const ruleTester = new RuleTester({
-	parserOptions: {ecmaVersion: 2021, sourceType: 'module'},
-});
-
-ruleTester.run('top-level-functions', rule, {
-	valid: [
-		'function test() {}',
-		'function anotherFunction() {}',
-	],
-	invalid: [
-		{
-			code: 'const test = () => {};',
-			errors: [{message: 'Top-level functions must be named/regular functions.'}],
-			output: 'function test() {}',
-		},
-		{
-			code: 'const response = (res, parameters = {}) => {};',
-			errors: [{message: 'Top-level functions must be named/regular functions.'}],
-			output: 'function response(res, parameters = {}) {}',
-		},
-		{
-			code: 'const func = function () {};',
-			errors: [{message: 'Top-level functions must be named/regular functions.'}],
-			output: 'function func() {}',
-		},
-	],
-});