eslint-plugin-test-governance 0.8.0 → 0.8.1

package/CHANGELOG.md

@@ -6,6 +6,16 @@ All notable changes to this project are documented here. The format follows
 
 ## [Unreleased]
 
+## [0.8.1] - 2026-10-22
+
+### Fixed
+
+- In Playwright files, `const pw = require('@playwright/test')` and `import pw from '@playwright/test'`
+  are `test` itself, so `pw.skip(...)`, `pw.describe.fixme(...)` and `pw.test.skip(...)` are checked.
+  They were missed.
+- In Mocha, Cypress and WebdriverIO files, `mocha.it.skip(...)` after `import mocha from 'mocha'` is
+  checked, as it already was after `import * as mocha from 'mocha'` and `require('mocha')`.
+
 ## [0.8.0] - 2026-10-22
 
 ### Added
@@ -347,7 +357,8 @@ First release.
 - Support for ESLint 9 and 10 flat config, JavaScript and TypeScript test files, `.extend()`
   fixtures, describe blocks, runtime skips and tags in titles or the `tag` option.
 
-[Unreleased]: https://github.com/Huldoser/eslint-plugin-test-governance/compare/v0.8.0...HEAD
+[Unreleased]: https://github.com/Huldoser/eslint-plugin-test-governance/compare/v0.8.1...HEAD
+[0.8.1]: https://github.com/Huldoser/eslint-plugin-test-governance/compare/v0.8.0...v0.8.1
 [0.8.0]: https://github.com/Huldoser/eslint-plugin-test-governance/compare/v0.7.0...v0.8.0
 [0.7.0]: https://github.com/Huldoser/eslint-plugin-test-governance/compare/v0.6.2...v0.7.0
 [0.6.2]: https://github.com/Huldoser/eslint-plugin-test-governance/compare/v0.6.1...v0.6.2

package/README.md

@@ -302,8 +302,9 @@ In Playwright files:
 - `test` imported from `@playwright/test`, `playwright/test` or a component-testing package such as
   `@playwright/experimental-ct-react`, including the default import, aliases such as
   `import { test as it }` or `const it = test`, and `const { test } = require('@playwright/test')`.
-- `pw.test` on the whole module, after `import * as pw from '@playwright/test'` or
-  `const pw = require('@playwright/test')`.
+- `pw.test` on the whole module, after `import * as pw from '@playwright/test'`. The default import
+  and `const pw = require('@playwright/test')` are `test` itself, so `pw.skip(...)` and
+  `pw.test.skip(...)` both count.
 - Fixtures made with `.extend()` or `mergeTests()` in the same file, such as
   `const test = base.extend({...})`.
 - Any name in `testFunctions`, for fixtures imported from your own modules. The default `['test']`
@@ -322,7 +323,8 @@ In Mocha, Cypress and WebdriverIO files:
 - The globals `it`, `specify`, `describe` and `context`, their `x` forms, the TDD names `suite` and
   `test`, and the hooks `before`, `beforeEach`, `after`, `afterEach`, `suiteSetup`, `setup`,
   `suiteTeardown` and `teardown`.
-- The names imported or required from `mocha`, including aliases and `import * as mocha from 'mocha'`.
+- The names imported or required from `mocha`, including aliases, and the whole module, as `mocha.it`
+  after `import * as mocha from 'mocha'`, `import mocha from 'mocha'` or `const mocha = require('mocha')`.
 - Any name in `testFunctions`, which defaults to `['it', 'specify', 'test']`.
 
 In `node:test` files:

package/dist/utils/analyze.js

@@ -138,7 +138,7 @@ function collectTestNames(program, framework, configured) {
                     else if (spec.type === 'ImportDefaultSpecifier') {
                         if (framework.defaultExport)
                             roots.set(local, framework.defaultExport);
-                        // `import test from 'node:test'` also has `test.describe`.
+                        // `import test from 'node:test'` also has `test.describe`, and `import mocha from 'mocha'` has `mocha.it`.
                         if (framework.moduleIsDefault)
                             modules.add(local);
                     }
@@ -170,8 +170,8 @@ function collectTestNames(program, framework, configured) {
                 else if (isOtherFramework(init))
                     setOther(name);
                 else {
-                    // `const pw = require('@playwright/test')`, used as `pw.test`, or `const test = require('node:test')`,
-                    // which is `test` itself.
+                    // `const mocha = require('mocha')`, used as `mocha.it`, or `const pw = require('@playwright/test')`,
+                    // which is `test` itself, as `require('node:test')` is.
                     const source = requireSource(init);
                     if (source !== undefined && framework.ownsModule(source)) {
                         modules.add(name);

package/dist/utils/frameworks.d.ts

@@ -30,8 +30,8 @@ export interface Framework {
     /** What a default import from the framework's module is. */
     defaultExport?: Root;
     /**
-     * Whether the module itself is its default export with the other functions as members, as
-     * `require('node:test')`, which is `test` and has `test.describe`.
+     * Whether the default export is the module itself, with the other functions as members: node:test's and
+     * Playwright's are `test`, which has `test.describe`, and Mocha's has `mocha.it`.
      */
     moduleIsDefault: boolean;
     /** Test functions that exist without an import, besides `testFunctions`. */

package/dist/utils/frameworks.js

@@ -16,7 +16,7 @@ const playwright = {
     ownsModule: isPlaywrightModule,
     exports: new Map([['test', TEST]]),
     defaultExport: TEST,
-    moduleIsDefault: false,
+    moduleIsDefault: true,
     globals: new Map(),
     testFunctions: ['test'],
     testMembers: new Set(['only', 'skip', 'fixme', 'fail']),
@@ -143,7 +143,7 @@ const MOCHA_EXPORTS = new Map([
 const mocha = {
     ownsModule: (source) => source === 'mocha',
     exports: MOCHA_EXPORTS,
-    moduleIsDefault: false,
+    moduleIsDefault: true,
     globals: new Map([
         ...[...MOCHA_EXPORTS].filter(([name]) => name !== 'it' && name !== 'test'),
         ['context', DESCRIBE],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-test-governance",
-  "version": "0.8.0",
+  "version": "0.8.1",
   "description": "ESLint rules that require a ticket comment above skipped, fixme, todo and tagged Playwright, Jest, Vitest, Mocha, Cypress, WebdriverIO and node:test tests.",
   "keywords": [
     "eslint",