eslint-plugin-test-governance 0.3.0 → 0.3.1

package/CHANGELOG.md

@@ -6,6 +6,19 @@ All notable changes to this project are documented here. The format follows
 
 ## [Unreleased]
 
+## [0.3.1] - 2026-10-06
+
+### Fixed
+
+- A `test` bound to another test runner without an import, as in `const test = require('node:test')`,
+  `const test = require('ava')` or `const test = anyTest as TestFn<Context>`, is no longer mistaken
+  for Playwright's `test`. Before, skipped tests in those files were reported as missing a ticket.
+- `require-ticket-in-comments` reads a ticket in parentheses after a space, as in `// TODO (WEB-123)`.
+  Before, such comments were reported as having no ticket at all.
+- A test or describe whose body is not written inline, such as `test.skip('pays', payWithCard)` or
+  `test('pays @new', withPage(async () => {}))`, is checked like any other. Before, it was ignored,
+  so a skipped test written this way needed no ticket.
+
 ## [0.3.0] - 2026-10-06
 
 ### Added
@@ -121,7 +134,8 @@ First release.
 - Support for ESLint 9 and 10 flat config, JavaScript and TypeScript test files, `.extend()`
   fixtures, describe blocks, runtime skips and tags in titles or the `tag` option.
 
-[Unreleased]: https://github.com/Huldoser/eslint-plugin-test-governance/compare/v0.3.0...HEAD
+[Unreleased]: https://github.com/Huldoser/eslint-plugin-test-governance/compare/v0.3.1...HEAD
+[0.3.1]: https://github.com/Huldoser/eslint-plugin-test-governance/compare/v0.3.0...v0.3.1
 [0.3.0]: https://github.com/Huldoser/eslint-plugin-test-governance/compare/v0.2.1...v0.3.0
 [0.2.1]: https://github.com/Huldoser/eslint-plugin-test-governance/compare/v0.2.0...v0.2.1
 [0.2.0]: https://github.com/Huldoser/eslint-plugin-test-governance/compare/v0.1.1...v0.2.0

package/README.md

@@ -172,8 +172,9 @@ so keep it free of nested quantifiers.
 - Any name in `testFunctions`, for fixtures imported from your own modules. The default `['test']`
   covers the common `import { test } from './fixtures'`.
 
-A name imported from another test runner (`vitest`, `@jest/globals`, `node:test`, `bun:test`,
-`mocha`, `ava`, `tap`, `uvu`) is never treated as Playwright's `test`, and neither is a local
+A name imported or required from another test runner (`vitest`, `@jest/globals`, `node:test`,
+`bun:test`, `mocha`, `ava`, `tap`, `uvu`), or a variable set from one such as
+`const test = require('ava')`, is never treated as Playwright's `test`, and neither is a local
 variable declared inside a function that happens to be called `test`.
 
 ### Syntax the rules understand

package/dist/index.d.ts

@@ -1,7 +1,7 @@
 import type { ESLint, Rule } from 'eslint';
-import { type GovernanceOptions } from './utils/options.js';
-export type { CustomState, GovernanceOptions, StateOverride } from './utils/options.js';
-export type { TicketSpec } from './utils/tickets.js';
+import { type GovernanceOptions } from './utils/options.ts';
+export type { CustomState, GovernanceOptions, StateOverride } from './utils/options.ts';
+export type { TicketSpec } from './utils/tickets.ts';
 export type RuleName = 'require-ticket' | 'marker-matches-state' | 'no-orphaned-marker' | 'no-conflicting-states' | 'require-ticket-in-comments';
 export declare const rules: Record<RuleName, Rule.RuleModule>;
 export interface FlatConfig {

package/dist/index.js

@@ -1,10 +1,10 @@
 import { createRequire } from 'node:module';
-import markerMatchesState from './rules/marker-matches-state.js';
-import noConflictingStates from './rules/no-conflicting-states.js';
-import noOrphanedMarker from './rules/no-orphaned-marker.js';
-import requireTicketInComments from './rules/require-ticket-in-comments.js';
-import requireTicket from './rules/require-ticket.js';
-import { compileOptions, SETTINGS_KEY } from './utils/options.js';
+import markerMatchesState from "./rules/marker-matches-state.js";
+import noConflictingStates from "./rules/no-conflicting-states.js";
+import noOrphanedMarker from "./rules/no-orphaned-marker.js";
+import requireTicketInComments from "./rules/require-ticket-in-comments.js";
+import requireTicket from "./rules/require-ticket.js";
+import { compileOptions, SETTINGS_KEY } from "./utils/options.js";
 const PLUGIN_NAME = 'test-governance';
 // Read at load time so the reported version always matches the published package.
 const { version: VERSION } = createRequire(import.meta.url)('../package.json');

package/dist/rules/marker-matches-state.d.ts

@@ -1,3 +1,3 @@
-declare const _default: import("../utils/create-rule.js").Rule<"wrongMarker" | "sharedMarker" | "renameMarker" | "addMarker">;
+declare const _default: import("../utils/create-rule.ts").Rule<"wrongMarker" | "sharedMarker" | "renameMarker" | "addMarker">;
 export default _default;
 //# sourceMappingURL=marker-matches-state.d.ts.map

package/dist/rules/marker-matches-state.js

@@ -1,6 +1,6 @@
-import { appliesTo, describeSubject, isStateMarker, missingStates, strayMarkers } from '../utils/analyze.js';
-import { createRule } from '../utils/create-rule.js';
-import { indentOf, keywordRange } from '../utils/fix.js';
+import { appliesTo, describeSubject, isStateMarker, missingStates, strayMarkers } from "../utils/analyze.js";
+import { createRule } from "../utils/create-rule.js";
+import { indentOf, keywordRange } from "../utils/fix.js";
 export default createRule({
     name: 'marker-matches-state',
     meta: {

package/dist/rules/no-conflicting-states.d.ts

@@ -1,3 +1,3 @@
-declare const _default: import("../utils/create-rule.js").Rule<"newAndUnstable" | "newSkipped" | "tagCase" | "tagTypo">;
+declare const _default: import("../utils/create-rule.ts").Rule<"newAndUnstable" | "newSkipped" | "tagCase" | "tagTypo">;
 export default _default;
 //# sourceMappingURL=no-conflicting-states.d.ts.map

package/dist/rules/no-conflicting-states.js

@@ -1,8 +1,8 @@
-import { headLoc } from '../utils/analyze.js';
-import { createRule } from '../utils/create-rule.js';
-import { isTagState } from '../utils/options.js';
-import { editDistance, typoThreshold } from '../utils/distance.js';
-import { tagRange } from '../utils/fix.js';
+import { headLoc } from "../utils/analyze.js";
+import { createRule } from "../utils/create-rule.js";
+import { isTagState } from "../utils/options.js";
+import { editDistance, typoThreshold } from "../utils/distance.js";
+import { tagRange } from "../utils/fix.js";
 export default createRule({
     name: 'no-conflicting-states',
     meta: {

package/dist/rules/no-orphaned-marker.d.ts

@@ -1,3 +1,3 @@
-declare const _default: import("../utils/create-rule.js").Rule<"orphaned" | "detached" | "removeMarker">;
+declare const _default: import("../utils/create-rule.ts").Rule<"orphaned" | "detached" | "removeMarker">;
 export default _default;
 //# sourceMappingURL=no-orphaned-marker.d.ts.map

package/dist/rules/no-orphaned-marker.js

@@ -1,6 +1,6 @@
-import { describeSubject, isProse, missingStates, strayMarkers } from '../utils/analyze.js';
-import { createRule } from '../utils/create-rule.js';
-import { removeComment } from '../utils/fix.js';
+import { describeSubject, isProse, missingStates, strayMarkers } from "../utils/analyze.js";
+import { createRule } from "../utils/create-rule.js";
+import { removeComment } from "../utils/fix.js";
 export default createRule({
     name: 'no-orphaned-marker',
     meta: {

package/dist/rules/require-ticket-in-comments.d.ts

@@ -1,3 +1,3 @@
-declare const _default: import("../utils/create-rule.js").Rule<"missingTicket" | "invalidTicket" | "placeholderTicket" | "extraText" | "removeExtraText">;
+declare const _default: import("../utils/create-rule.ts").Rule<"missingTicket" | "invalidTicket" | "placeholderTicket" | "extraText" | "removeExtraText">;
 export default _default;
 //# sourceMappingURL=require-ticket-in-comments.d.ts.map

package/dist/rules/require-ticket-in-comments.js

@@ -1,6 +1,6 @@
-import { appliesTo, isStateMarker, parseTickets } from '../utils/analyze.js';
-import { createRule } from '../utils/create-rule.js';
-import { compileTicketSpec } from '../utils/tickets.js';
+import { appliesTo, isStateMarker, parseTickets } from "../utils/analyze.js";
+import { createRule } from "../utils/create-rule.js";
+import { compileTicketSpec } from "../utils/tickets.js";
 /** Recognises anything shaped like a ticket, to tell a wrong-format ticket from plain prose. */
 const ticketShape = compileTicketSpec([{ preset: 'any' }], []);
 function escapeRegExp(text) {
@@ -40,9 +40,9 @@ export default createRule({
         // `TODO`/`FIXME` in capitals counts with or without a colon. Other casings need the colon, so a
         // sentence that happens to start with "Todo" is not mistaken for a work comment. The keyword can
         // carry its ticket in parentheses, `TODO(WEB-123): ...`, a common style that tools also use for
-        // a name, `TODO(alice)`, which is not a ticket.
+        // a name, `TODO(alice)`, which is not a ticket. Some teams put a space before the parenthesis.
         const alternatives = keywords.map(escapeRegExp).join('|');
-        const keywordRe = new RegExp(`^(\\s*\\*?\\s*)(${alternatives})(?:\\(([^)]*)\\))?(?:\\s*:|(?=\\s|$))`, 'i');
+        const keywordRe = new RegExp(`^(\\s*\\*?\\s*)(${alternatives})(?:\\s*\\(([^)]*)\\))?(?:\\s*:|(?=\\s|$))`, 'i');
         /**
          * `TODO(WEB-1, WEB-2): text`: the tickets are in the parentheses, and anything after them, from the
          * closing parenthesis on, is a note.
@@ -78,7 +78,7 @@ export default createRule({
                     continue;
                 const { tickets, extra } = inParens === undefined
                     ? parseTickets(line.slice(whole.length), start + whole.length, matcher)
-                    : parseParenthesized(line, start, indent.length + keyword.length, inParens);
+                    : parseParenthesized(line, start, whole.indexOf('(', indent.length + keyword.length), inParens);
                 const loc = {
                     start: sourceCode.getLocFromIndex(start + indent.length),
                     end: sourceCode.getLocFromIndex(start + line.trimEnd().length),

package/dist/rules/require-ticket.d.ts

@@ -1,3 +1,3 @@
-declare const _default: import("../utils/create-rule.js").Rule<"missingTicket" | "invalidTicket" | "placeholderTicket" | "extraText" | "removeExtraText" | "missingMarker" | "markerCase" | "dynamicTitle">;
+declare const _default: import("../utils/create-rule.ts").Rule<"missingTicket" | "invalidTicket" | "placeholderTicket" | "extraText" | "removeExtraText" | "missingMarker" | "markerCase" | "dynamicTitle">;
 export default _default;
 //# sourceMappingURL=require-ticket.d.ts.map

package/dist/rules/require-ticket.js

@@ -1,5 +1,5 @@
-import { appliesTo, describeSubject, evaluate, headLoc } from '../utils/analyze.js';
-import { createRule } from '../utils/create-rule.js';
+import { appliesTo, describeSubject, evaluate, headLoc } from "../utils/analyze.js";
+import { createRule } from "../utils/create-rule.js";
 export default createRule({
     name: 'require-ticket',
     meta: {

package/dist/utils/analyze.d.ts

@@ -1,6 +1,6 @@
 import type { TSESLint, TSESTree } from '@typescript-eslint/utils';
-import type { ResolvedOptions, StateDef } from './options.js';
-import type { TicketCheck, TicketMatcher } from './tickets.js';
+import type { ResolvedOptions, StateDef } from './options.ts';
+import type { TicketCheck, TicketMatcher } from './tickets.ts';
 type Node = TSESTree.Node;
 type Comment = TSESTree.Comment;
 type SourceCode = Readonly<TSESLint.SourceCode>;

package/dist/utils/analyze.js

@@ -49,6 +49,8 @@ function isFunction(node) {
 function collectTestNames(program, configured) {
     const names = new Set(configured);
     const mergeTests = new Set();
+    /** Names bound to another test runner, such as `ava` in `import ava from 'ava'`. */
+    const others = new Set();
     const isTestExpression = (node) => {
         const target = unwrap(node);
         if (target.type === 'Identifier')
@@ -62,12 +64,24 @@ function collectTestNames(program, configured) {
             return false;
         return memberName(target.callee) === 'extend' && isTestExpression(target.callee.object);
     };
+    // require('node:test'), ava, ava.serial or `ava as TestFn<Context>`
+    const isOtherFramework = (node) => {
+        const target = unwrap(node);
+        const source = requireSource(target);
+        if (source !== undefined)
+            return OTHER_FRAMEWORKS.has(source);
+        if (target.type === 'Identifier')
+            return others.has(target.name);
+        return target.type === 'MemberExpression' && isOtherFramework(target.object);
+    };
     for (const statement of program.body) {
         if (statement.type === 'ImportDeclaration') {
             const source = statement.source.value;
             if (OTHER_FRAMEWORKS.has(source)) {
-                for (const spec of statement.specifiers)
+                for (const spec of statement.specifiers) {
                     names.delete(spec.local.name);
+                    others.add(spec.local.name);
+                }
             }
             else if (isPlaywrightModule(source)) {
                 for (const spec of statement.specifiers) {
@@ -91,6 +105,11 @@ function collectTestNames(program, configured) {
             if (declarator.id.type === 'Identifier' && init.type === 'CallExpression' && isTestExpression(init)) {
                 names.add(declarator.id.name);
             }
+            else if (declarator.id.type === 'Identifier' && isOtherFramework(init)) {
+                // `const test = require('node:test')` is another runner's `test`, like an import from it.
+                names.delete(declarator.id.name);
+                others.add(declarator.id.name);
+            }
             else if (declarator.id.type === 'ObjectPattern') {
                 const source = requireSource(init);
                 if (source === undefined)
@@ -98,8 +117,10 @@ function collectTestNames(program, configured) {
                 for (const prop of declarator.id.properties) {
                     if (prop.type !== 'Property' || prop.key.type !== 'Identifier' || prop.value.type !== 'Identifier')
                         continue;
-                    if (OTHER_FRAMEWORKS.has(source))
+                    if (OTHER_FRAMEWORKS.has(source)) {
                         names.delete(prop.value.name);
+                        others.add(prop.value.name);
+                    }
                     else if (isPlaywrightModule(source) && prop.key.name === 'test')
                         names.add(prop.value.name);
                 }
@@ -374,11 +395,16 @@ function runAnalysis(sourceCode, options) {
                 if (param?.type === 'Identifier')
                     testInfo = param.name;
             }
-            const isDeclaration = args.length >= 2 && isFunction(last) && !isFunction(args[0]);
+            // The body is usually written inline, but can be a function defined elsewhere:
+            // `test.skip('pays', payWithCard)`. A string title tells that apart from `test.skip(cond, 'why')`.
+            const titled = args.length >= 2 && isStaticText(args[0]);
+            const isDeclaration = args.length >= 2 && !isFunction(args[0]) && (isFunction(last) || titled);
             if (path.every((p) => TEST_MODIFIERS.has(p)) && isDeclaration) {
                 return { subject: makeSubject('test', call, path, collectTags(call, true)), testInfo };
             }
-            if (path[0] === 'describe' && path.slice(1).every((p) => DESCRIBE_MODIFIERS.has(p)) && isFunction(last)) {
+            if (path[0] === 'describe' &&
+                path.slice(1).every((p) => DESCRIBE_MODIFIERS.has(p)) &&
+                (isFunction(last) || titled)) {
                 const tagInfo = collectTags(call, args.length >= 2);
                 return { subject: makeSubject('describe', call, path.slice(1), tagInfo), testInfo };
             }
@@ -433,7 +459,7 @@ function runAnalysis(sourceCode, options) {
             }
         }
         // Parsers provide visitor keys for every node type they produce; the fallback is only defensive.
-        /* v8 ignore next */
+        /* node:coverage ignore next */
         for (const key of keys[node.type] ?? []) {
             const child = node[key];
             if (Array.isArray(child)) {

package/dist/utils/create-rule.d.ts

@@ -1,6 +1,6 @@
 import type { TSESLint } from '@typescript-eslint/utils';
-import { type Analysis } from './analyze.js';
-import { type ResolvedOptions } from './options.js';
+import { type Analysis } from './analyze.ts';
+import { type ResolvedOptions } from './options.ts';
 export declare const REPO_URL = "https://github.com/Huldoser/eslint-plugin-test-governance";
 /** Rules take no options of their own: everything is shared through `settings['test-governance']`. */
 export type RuleOptions = [];

package/dist/utils/create-rule.js

@@ -1,5 +1,5 @@
-import { analyze } from './analyze.js';
-import { resolveOptions } from './options.js';
+import { analyze } from "./analyze.js";
+import { resolveOptions } from "./options.js";
 export const REPO_URL = 'https://github.com/Huldoser/eslint-plugin-test-governance';
 /**
  * Builds a rule that reads its options from `settings['test-governance']`.

package/dist/utils/options.d.ts

@@ -1,5 +1,5 @@
-import { type BuiltinStateName } from './constants.js';
-import { type TicketMatcher, type TicketSpec } from './tickets.js';
+import { type BuiltinStateName } from './constants.ts';
+import { type TicketMatcher, type TicketSpec } from './tickets.ts';
 export declare const SETTINGS_KEY = "test-governance";
 /** A state override in `states`. `false` turns a state off, `true` turns it on. */
 export interface StateOverride {
@@ -14,7 +14,7 @@ export interface CustomState {
     marker: string;
     ticket?: TicketSpec | TicketSpec[];
 }
-export type { BuiltinStateName } from './constants.js';
+export type { BuiltinStateName } from './constants.ts';
 /** Options shared by every rule. Set them once in `settings['test-governance']`. */
 export interface GovernanceOptions {
     /** Names that are treated as the Playwright `test` function. Defaults to `['test']`. */
@@ -78,7 +78,7 @@ export interface ResolvedOptions {
     /** Ticket format for comments: the shared default format. */
     commentTicket: TicketMatcher;
 }
-export { ConfigError } from './errors.js';
+export { ConfigError } from './errors.ts';
 /**
  * Compiles `settings['test-governance']`. Every rule reads the same settings, so they always agree,
  * and the result is cached per settings object, so the rules share one compile.

package/dist/utils/options.js

@@ -1,8 +1,8 @@
-import { BUILTIN_STATE_NAMES, DEFAULT_COMMENT_KEYWORDS } from './constants.js';
-import { ConfigError } from './errors.js';
-import { optionsSchema } from './schema.js';
-import { compileTicketSpec, DEFAULT_PLACEHOLDERS } from './tickets.js';
-import { validate } from './validate.js';
+import { BUILTIN_STATE_NAMES, DEFAULT_COMMENT_KEYWORDS } from "./constants.js";
+import { ConfigError } from "./errors.js";
+import { optionsSchema } from "./schema.js";
+import { compileTicketSpec, DEFAULT_PLACEHOLDERS } from "./tickets.js";
+import { validate } from "./validate.js";
 export const SETTINGS_KEY = 'test-governance';
 export function isTagState(state) {
     return state.tag !== undefined;
@@ -15,7 +15,7 @@ const BUILTIN_STATES = {
     new: { marker: 'NEW', tag: '@new', lifecycle: true, enabled: false },
     unstable: { marker: 'UNSTABLE', tag: '@unstable', lifecycle: true, enabled: false },
 };
-export { ConfigError } from './errors.js';
+export { ConfigError } from "./errors.js";
 function toSpecs(spec) {
     return Array.isArray(spec) ? spec : [spec];
 }

package/dist/utils/schema.d.ts

@@ -1,4 +1,4 @@
-import type { Schema } from './validate.js';
+import type { Schema } from './validate.ts';
 /** The shape of `settings['test-governance']`, the options of `configure()`. */
 export declare const optionsSchema: Schema;
 //# sourceMappingURL=schema.d.ts.map

package/dist/utils/schema.js

@@ -1,4 +1,4 @@
-import { BUILTIN_STATE_NAMES, MARKER_RE, TAG_RE, TICKET_PRESETS } from './constants.js';
+import { BUILTIN_STATE_NAMES, MARKER_RE, TAG_RE, TICKET_PRESETS } from "./constants.js";
 const MARKER_HINT = 'an uppercase keyword such as NEEDS-DATA (letters, digits, "-" and "_")';
 const TAG_HINT = 'a tag such as @needs-data';
 /** Jira project and Linear team keys, as they appear in tickets: `WEB` in `WEB-123`. */

package/dist/utils/tickets.js

@@ -1,4 +1,4 @@
-import { ConfigError } from './errors.js';
+import { ConfigError } from "./errors.js";
 export const DEFAULT_PLACEHOLDERS = ['TODO', 'TBD', 'XXX-*', '0', '123', '1234', '12345'];
 // Every pattern below is anchored and has no nested or overlapping quantifiers, so matching is
 // linear in the token length. URLs are parsed with `new URL` rather than a regex.

package/dist/utils/validate.js

@@ -1,4 +1,4 @@
-import { editDistance } from './distance.js';
+import { editDistance } from "./distance.js";
 function kindOf(value) {
     if (value === null)
         return 'null';

package/docs/rules/require-ticket-in-comments.md

@@ -26,8 +26,8 @@ How comments are read:
 - The keyword starts the comment (or a line of a block comment). `TODO` and `FIXME` in capitals
   count with or without a colon. Other casings, such as `todo:`, need the colon, so a sentence that
   happens to start with "Todo" is left alone.
-- The tickets can also go in parentheses straight after the keyword, `TODO(WEB-512)`, a style many
-  teams already use. Anything after the parentheses is a note, as it would be after `TODO: WEB-512`.
+- The tickets can also go in parentheses after the keyword, `TODO(WEB-512)` or `TODO (WEB-512)`, a
+  style many teams already use. Anything after the parentheses is a note, as it would be after `TODO: WEB-512`.
 - The tickets follow the same rules as markers: the shared ticket format, placeholders such as `TBD`
   rejected, and no text after the tickets unless `allowNotes` is set.
 - A `// FIXME:` marker directly above a `test.fixme(...)` is checked by

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-test-governance",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "description": "ESLint rules that require a ticket comment above skipped, fixme and tagged Playwright tests.",
   "keywords": [
     "eslint",
@@ -45,8 +45,8 @@
   "scripts": {
     "build": "node -e \"require('node:fs').rmSync('dist',{recursive:true,force:true})\" && tsc -p tsconfig.build.json",
     "typecheck": "tsc -p tsconfig.json",
-    "test": "vitest run",
-    "test:coverage": "vitest run --coverage",
+    "test": "node --test 'tests/**/*.test.ts'",
+    "test:coverage": "node --test --experimental-test-coverage --test-coverage-include='src/rules/**' --test-coverage-include='src/utils/**' --test-coverage-branches=100 --test-coverage-functions=100 --test-coverage-lines=100 'tests/**/*.test.ts'",
     "test:pack": "node scripts/pack-smoke.mjs",
     "docs": "npm run build && eslint-doc-generator",
     "docs:check": "npm run build && eslint-doc-generator --check",
@@ -63,15 +63,11 @@
     "@types/node": "^26.6.3",
     "@typescript-eslint/parser": "^8.71.0",
     "@typescript-eslint/utils": "^8.71.0",
-    "@vitest/coverage-v8": "^5.0.2",
     "eslint": "^10.11.0",
-    "eslint-config-prettier": "^10.1.8",
     "eslint-doc-generator": "^3.7.1",
     "eslint-plugin-eslint-plugin": "^7.6.2",
-    "globals": "^17.13.0",
     "prettier": "^3.9.9",
     "typescript": "6.0",
-    "typescript-eslint": "^8.71.0",
-    "vitest": "^5.0.2"
+    "typescript-eslint": "^8.71.0"
   }
 }