eslint-plugin-test-governance 0.13.1 → 0.13.3

package/CHANGELOG.md

@@ -6,6 +6,77 @@ All notable changes to this project are documented here. The format follows
 
 ## [Unreleased]
 
+## [0.13.3] - 2026-11-09
+
+### Fixed
+
+- Vitest conditional factories can clear an earlier skip in a modifier chain. Runtime context methods
+  retain their state through TypeScript wrappers on the receiver or method.
+- Mutation detection follows wrapped references and aliases, and recognizes writes through the global
+  `Object` and `Reflect` mutation methods without treating shadowed helpers as those built-ins.
+- Retry counts are read through local constants and object members, with effective properties after
+  spreads and overrides. Unread spreads remain possible retries unless every relevant count is known.
+- Commented-out tests no longer hide a broken marker or a disallowed note behind another valid marker.
+- Negative numeric and bigint template interpolations, `void`, and unshadowed `undefined`, `NaN` and
+  `Infinity` retain their rendered text when checking tag boundaries.
+- Mutable constant objects and arrays no longer supply stale tag or annotation values after detected
+  property writes, deletion, array mutation or writes through a local alias.
+- Runtime context methods keep their original test owner inside nested subtests. Vitest skip notes
+  supplied through constants remain unconditional skips.
+- Test callees retain their meaning through TypeScript assertions and type instantiations, sequence
+  expressions and defaulted local destructuring. Repeated conditional factories use the final condition.
+- Nested conditional returns and throws, and conditional loop breaks and continues, guard later runtime
+  skips. Jest retry calls are recognized through CommonJS object bindings and method aliases, including
+  bound arguments.
+- Primitive template interpolations retain their rendered text when checking tag boundaries. Object
+  prototype setters do not count as own tag or metadata properties, and suggestions use computed keys
+  for metadata named `__proto__`.
+- Test functions are read through aliases of whole modules, local destructuring, bound functions and
+  nested conditional selections. Reassigning an alias to a helper no longer leaves it treated as a test.
+- Runtime test contexts and their methods keep their meaning through chains of aliases, `bind()` and
+  default parameter values. Arguments supplied by `bind()` retain their condition and reason, and a
+  bound title no longer gives a diagnostic whose end is before its start.
+- A runtime skip in a conditional loop, or after a conditional early exit inside a nested block, is
+  read as conditional. A TypeScript assertion around a literal boolean keeps that boolean's meaning.
+- With the retry state on, Jest's retry calls are read through renamed and namespace imports, and a
+  Mocha describe chosen by a condition still supplies its suite context for `this.retries()`.
+- Chains of constants retain their tags, details and annotation tickets. An unread computed property
+  no longer leaves an earlier member of a tag object treated as certain.
+- Tags from literal and nested template interpolations are checked using the rendered text's boundaries,
+  so joining text around an `@` doesn't invent a state tag. Plain Vitest tags written as templates count
+  like quoted strings. Cyclic constant and template definitions remain unread instead of recursing.
+- `annotations.only` checks every supplied issue ticket, including an invalid one next to a valid one.
+- The commented-out-test rule recognizes renamed test imports.
+- Removing an orphaned marker removes its complete line with CR or Unicode line endings too.
+- A suggestion to add another state's marker no longer copies a ticket that state's format rejects.
+- Suggestions that move a ticket into annotations escape line breaks in the annotation type or key,
+  keeping the suggested JavaScript valid.
+
+## [0.13.2] - 2026-11-08
+
+### Fixed
+
+- Local aliases such as `const check = it; check.skip(...)`, and aliases of conditional test functions,
+  are checked like the functions they keep.
+- A helper's parameter or block variable named like a test context no longer makes its `skip()` or
+  `test()` calls count as runtime skips or subtests.
+- Runtime calls with a literal `false` condition, such as Playwright's `test.skip(false)`, need neither
+  a ticket nor a reason.
+- Details, options and annotations use the last value of a property, including values from object
+  spreads. An unread spread or computed key no longer leaves an earlier value treated as certain.
+- A tag read beyond an array's bounds no longer crashes linting. An index after a spread, or a string
+  such as `'01'` that isn't an array index, is left unread instead of using the wrong tag.
+- Circular object spreads no longer overflow the stack during analysis.
+- Playwright annotation arrays read tickets from spreads of arrays declared in the same file, and
+  report unread spreads with `reportUnreadableTags`.
+- A ticket marker in a block comment no longer hides unrelated `TODO` or `FIXME` work comments on
+  other lines of that block.
+- The `pattern` preset matches the whole ticket even with the multiline flag, and no longer accepts
+  trailing line breaks outside the pattern.
+- Moving a ticket into an annotation preserves comments inside an empty details object.
+- node:test's `todo` state no longer makes `no-conflicting-states` call a new test skipped: Node still
+  runs its body.
+
 ## [0.13.1] - 2026-11-06
 
 ### Fixed
@@ -573,7 +644,9 @@ First release.
 - Support for ESLint 9 and 10 flat config, JavaScript and TypeScript test files, `.extend()`
   fixtures, describe blocks, runtime skips and tags in titles or the `tag` option.
 
-[Unreleased]: https://github.com/Huldoser/eslint-plugin-test-governance/compare/v0.13.1...HEAD
+[Unreleased]: https://github.com/Huldoser/eslint-plugin-test-governance/compare/v0.13.3...HEAD
+[0.13.3]: https://github.com/Huldoser/eslint-plugin-test-governance/compare/v0.13.2...v0.13.3
+[0.13.2]: https://github.com/Huldoser/eslint-plugin-test-governance/compare/v0.13.1...v0.13.2
 [0.13.1]: https://github.com/Huldoser/eslint-plugin-test-governance/compare/v0.13.0...v0.13.1
 [0.13.0]: https://github.com/Huldoser/eslint-plugin-test-governance/compare/v0.12.1...v0.13.0
 [0.12.1]: https://github.com/Huldoser/eslint-plugin-test-governance/compare/v0.12.0...v0.12.1

package/dist/rules/marker-matches-state.js

@@ -70,7 +70,10 @@ export default createRule({
                         state: state.name,
                         subject: subjectName,
                     },
-                    suggest: present.comment.type === 'Line' && tickets !== '' && directive?.kind !== 'eslint-disable-line'
+                    suggest: present.comment.type === 'Line' &&
+                        tickets !== '' &&
+                        present.tickets.every((ticket) => state.ticket.check(ticket.text) === 'ok') &&
+                        directive?.kind !== 'eslint-disable-line'
                         ? [
                             {
                                 messageId: 'addMarker',

package/dist/rules/require-ticket-for-commented-out-tests.js

@@ -32,9 +32,9 @@ export default createRule({
                 context.report({ loc, messageId: 'missingMarker', data });
                 continue;
             }
-            const valid = own.find((m) => m.tickets.length > 0 && m.tickets.every((t) => t.result === 'ok'));
-            if (valid) {
-                const { extra } = valid;
+            const broken = own.find((m) => m.tickets.length === 0 || m.tickets.some((t) => t.result !== 'ok'));
+            if (broken === undefined) {
+                const extra = own.find((marker) => marker.extra !== undefined)?.extra;
                 if (extra === undefined || options.allowNotes)
                     continue;
                 context.report({
@@ -51,7 +51,7 @@ export default createRule({
                 });
                 continue;
             }
-            const [marker] = own;
+            const marker = broken;
             const bad = marker.tickets.find((t) => t.result !== 'ok');
             if (bad === undefined) {
                 context.report({ loc: marker.comment.loc, messageId: 'missingTicket', data });

package/dist/rules/require-ticket-in-comments.js

@@ -37,7 +37,7 @@ export default createRule({
             for (const marker of [...subject.markers, ...subject.regionMarkers]) {
                 const state = marker.state ?? marker.caseOf;
                 if (state && appliesTo(subject, state.name))
-                    owned.add(marker.comment);
+                    owned.add(marker.keywordStart);
             }
         }
         // `TODO`/`FIXME` in capitals counts with or without a colon. Other casings need the colon, so a
@@ -62,13 +62,13 @@ export default createRule({
             return { ...parsed, extra: { text: note, range: [start + close, start + line.trimEnd().length] } };
         }
         for (const comment of sourceCode.getAllComments()) {
-            if (owned.has(comment))
-                continue;
             for (const { text: line, start } of commentLines(comment)) {
                 const match = keywordRe.exec(line);
                 if (!match)
                     continue;
                 const [whole, indent, keyword] = match;
+                if (owned.has(start + indent.length))
+                    continue;
                 // The parenthesised group is optional, so it can be undefined despite RegExpExecArray's typing.
                 const inParens = match[3];
                 const upper = keyword.toUpperCase();

package/dist/rules/require-ticket.js

@@ -107,11 +107,6 @@ export default createRule({
                         reportReason(subject, state);
                     continue;
                 }
-                if (annotationOnly) {
-                    reportAnnotationOnly(subject, state, annotationOnly);
-                    continue;
-                }
-                const result = evaluate(subject, state);
                 // Annotations are checked whenever a ticket is needed, whatever the markers say.
                 for (const ticket of annotationTicketsOf(subject)) {
                     if (state.ticket.check(ticket.text) !== 'ok' && reportOnce(`annotation:${ticket.node.range[0]}`)) {
@@ -122,6 +117,11 @@ export default createRule({
                         });
                     }
                 }
+                if (annotationOnly) {
+                    reportAnnotationOnly(subject, state, annotationOnly);
+                    continue;
+                }
+                const result = evaluate(subject, state);
                 if (result.kind === 'missing' && hasAnnotationTicket(subject, state, options))
                     continue;
                 if (result.kind !== 'ok' &&