eslint-plugin-svelte 2.4.1 → 2.7.0

package/README.md

@@ -13,6 +13,12 @@ You can check on the [Online DEMO](https://ota-meshi.github.io/eslint-plugin-sve
 [![NPM downloads](https://img.shields.io/npm/dt/eslint-plugin-svelte.svg)](http://www.npmtrends.com/eslint-plugin-svelte)
 [![Build Status](https://github.com/ota-meshi/eslint-plugin-svelte/workflows/CI/badge.svg?branch=main)](https://github.com/ota-meshi/eslint-plugin-svelte/actions?query=workflow%3ACI)
 
+[![Language grade: JavaScript](https://img.shields.io/lgtm/grade/javascript/g/ota-meshi/eslint-plugin-svelte.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/ota-meshi/eslint-plugin-svelte/context:javascript)
+[![type-coverage](https://img.shields.io/badge/dynamic/json.svg?label=type-coverage&prefix=%E2%89%A5&suffix=%&query=$.typeCoverage.atLeast&uri=https%3A%2F%2Fraw.githubusercontent.com%2Fota-meshi%2Feslint-plugin-svelte%2Fmain%2Fpackage.json)](https://github.com/plantain-00/type-coverage)
+[![Conventional Commits](https://img.shields.io/badge/conventional%20commits-1.0.0-yellow.svg)](https://conventionalcommits.org)
+[![Code Style: Prettier](https://img.shields.io/badge/code_style-prettier-ff69b4.svg)](https://github.com/prettier/prettier)
+[![changesets](https://img.shields.io/badge/maintained%20with-changesets-176de3.svg)](https://github.com/atlassian/changesets)
+
 ## :name_badge: What is this plugin?
 
 [ESLint] plugin for [Svelte].  
@@ -61,7 +67,7 @@ npm install --save-dev eslint eslint-plugin-svelte svelte
 
 ### Configuration
 
-Use `.eslintrc.*` file to configure rules. See also: [https://eslint.org/docs/user-guide/configuring](https://eslint.org/docs/user-guide/configuring).
+Use `.eslintrc.*` file to configure rules. See also: <https://eslint.org/docs/user-guide/configuring>.
 
 Example **.eslintrc.js**:
 
@@ -176,7 +182,7 @@ module.exports = {
 }
 ```
 
-See also [https://github.com/ota-meshi/svelte-eslint-parser#readme](https://github.com/ota-meshi/svelte-eslint-parser#readme).
+See also <https://github.com/ota-meshi/svelte-eslint-parser#readme>.
 
 #### settings.svelte
 
@@ -242,6 +248,7 @@ Example **.vscode/settings.json**:
 
 ## :white_check_mark: Rules
 
+<!-- prettier-ignore-start -->
 <!--RULES_SECTION_START-->
 
 :wrench: Indicates that the rule is fixable, and using `--fix` option on the [command line](https://eslint.org/docs/user-guide/command-line-interface#fixing-problems) can automatically fix some of the reported problems.  
@@ -262,6 +269,7 @@ These rules relate to possible syntax or logic errors in Svelte code:
 | [svelte/no-not-function-handler](https://ota-meshi.github.io/eslint-plugin-svelte/rules/no-not-function-handler/) | disallow use of not function in event handler | :star: |
 | [svelte/no-object-in-text-mustaches](https://ota-meshi.github.io/eslint-plugin-svelte/rules/no-object-in-text-mustaches/) | disallow objects in text mustache interpolation | :star: |
 | [svelte/no-shorthand-style-property-overrides](https://ota-meshi.github.io/eslint-plugin-svelte/rules/no-shorthand-style-property-overrides/) | disallow shorthand style properties that override related longhand properties | :star: |
+| [svelte/no-store-async](https://ota-meshi.github.io/eslint-plugin-svelte/rules/no-store-async/) | disallow using async/await inside svelte stores because it causes issues with the auto-unsubscribing features |  |
 | [svelte/no-unknown-style-directive-property](https://ota-meshi.github.io/eslint-plugin-svelte/rules/no-unknown-style-directive-property/) | disallow unknown `style:property` | :star: |
 | [svelte/valid-compile](https://ota-meshi.github.io/eslint-plugin-svelte/rules/valid-compile/) | disallow warnings when compiling. | :star: |
 
@@ -282,10 +290,12 @@ These rules relate to better ways of doing things to help you avoid problems:
 |:--------|:------------|:---|
 | [svelte/button-has-type](https://ota-meshi.github.io/eslint-plugin-svelte/rules/button-has-type/) | disallow usage of button without an explicit type attribute |  |
 | [svelte/no-at-debug-tags](https://ota-meshi.github.io/eslint-plugin-svelte/rules/no-at-debug-tags/) | disallow the use of `{@debug}` | :star: |
-| [svelte/no-reactive-literals](https://ota-meshi.github.io/eslint-plugin-svelte/rules/no-reactive-literals/) | Don't assign literal values in reactive statements | :bulb: |
+| [svelte/no-reactive-functions](https://ota-meshi.github.io/eslint-plugin-svelte/rules/no-reactive-functions/) | it's not necessary to define functions in reactive statements | :bulb: |
+| [svelte/no-reactive-literals](https://ota-meshi.github.io/eslint-plugin-svelte/rules/no-reactive-literals/) | don't assign literal values in reactive statements | :bulb: |
 | [svelte/no-unused-svelte-ignore](https://ota-meshi.github.io/eslint-plugin-svelte/rules/no-unused-svelte-ignore/) | disallow unused svelte-ignore comments | :star: |
 | [svelte/no-useless-mustaches](https://ota-meshi.github.io/eslint-plugin-svelte/rules/no-useless-mustaches/) | disallow unnecessary mustache interpolations | :wrench: |
 | [svelte/require-optimized-style-attribute](https://ota-meshi.github.io/eslint-plugin-svelte/rules/require-optimized-style-attribute/) | require style attributes that can be optimized |  |
+| [svelte/require-stores-init](https://ota-meshi.github.io/eslint-plugin-svelte/rules/require-stores-init/) | require initial value in store |  |
 
 ## Stylistic Issues
 
@@ -296,6 +306,7 @@ These rules relate to style guidelines, and are therefore quite subjective:
 | [svelte/first-attribute-linebreak](https://ota-meshi.github.io/eslint-plugin-svelte/rules/first-attribute-linebreak/) | enforce the location of first attribute | :wrench: |
 | [svelte/html-closing-bracket-spacing](https://ota-meshi.github.io/eslint-plugin-svelte/rules/html-closing-bracket-spacing/) | require or disallow a space before tag's closing brackets | :wrench: |
 | [svelte/html-quotes](https://ota-meshi.github.io/eslint-plugin-svelte/rules/html-quotes/) | enforce quotes style of HTML attributes | :wrench: |
+| [svelte/html-self-closing](https://ota-meshi.github.io/eslint-plugin-svelte/rules/html-self-closing/) | enforce self-closing style | :wrench: |
 | [svelte/indent](https://ota-meshi.github.io/eslint-plugin-svelte/rules/indent/) | enforce consistent indentation | :wrench: |
 | [svelte/max-attributes-per-line](https://ota-meshi.github.io/eslint-plugin-svelte/rules/max-attributes-per-line/) | enforce the maximum number of attributes per line | :wrench: |
 | [svelte/mustache-spacing](https://ota-meshi.github.io/eslint-plugin-svelte/rules/mustache-spacing/) | enforce unified spacing in mustache | :wrench: |
@@ -315,6 +326,7 @@ These rules extend the rules provided by ESLint itself to work well in Svelte:
 | Rule ID | Description |    |
 |:--------|:------------|:---|
 | [svelte/no-inner-declarations](https://ota-meshi.github.io/eslint-plugin-svelte/rules/no-inner-declarations/) | disallow variable or `function` declarations in nested blocks | :star: |
+| [svelte/no-trailing-spaces](https://ota-meshi.github.io/eslint-plugin-svelte/rules/no-trailing-spaces/) | disallow trailing whitespace at the end of lines | :wrench: |
 
 ## System
 
@@ -327,6 +339,7 @@ These rules relate to this plugin works:
 
 <!--RULES_TABLE_END-->
 <!--RULES_SECTION_END-->
+<!-- prettier-ignore-end -->
 
 <!--DOCS_IGNORE_START-->
 
@@ -336,43 +349,7 @@ Welcome contributing!
 
 Please use GitHub's Issues/PRs.
 
-### Development Tools
-
-- `yarn test` runs tests.
-- `yarn cover` runs tests and measures coverage.
-- `yarn new [new-rule-name]` generate the files needed to implement the new rule.
-- `yarn update` runs in order to update readme and recommended configuration.
-- `yarn docs:watch` launch the document site in development mode.
-
-### Test the Rule
-
-Rule testing almost always uses fixtures.  
-For example, for an `indent` rule, the `.ts` file that runs the test is `tests/src/rules/indent.ts` and the fixture is in `tests/fixtures/rules/indent`.  
-The fixture directory has an `invalid` directory and a `valid` directory.
-
-- The `invalid` directory contains test cases where the rule reports problems.
-- The `valid` directory contains test cases where the rule does not report a problem.
-
-The fixture input file should be named `*-input.svelte`. It is automatically collected and tested.  
-If your test requires configuration, you need to add a json file with the configuration.
-
-- If you want to apply a configuration to `my-test-input.svelte`, add `my-test-config.json`.
-- If you want to apply the same configuration to all the fixtures in that directory, add `_config.json`.
-
-To verify the output of invalid test cases requires `*-errors.json`, and `*-output.svelte` (for auto-fix). However, you don't have to add them yourself. If they do not exist, they will be automatically generated when you run the test. In other words, delete them manually when you want to recreate them.
-
-**Tips**:
-
-If you want to test only one rule, run the following command (for `indent` rule):
-
-```sh
-yarn test -g indent
-```
-
-Take <https://stackoverflow.com/questions/10832031/how-to-run-a-single-test-with-mocha> as reference for details.
-
-If you want to test only `my-test-input.svelte`, add `my-test-config.json` and save `{"only": true}`.  
-(Note that `{"only": true}` must be removed before making a pull request.)
+See also [CONTRIBUTING.md](./CONTRIBUTING.md)
 
 ### Working With Rules
 

package/lib/configs/prettier.d.ts

@@ -4,10 +4,12 @@ declare const _default: {
         "svelte/first-attribute-linebreak": string;
         "svelte/html-closing-bracket-spacing": string;
         "svelte/html-quotes": string;
+        "svelte/html-self-closing": string;
         "svelte/indent": string;
         "svelte/max-attributes-per-line": string;
         "svelte/mustache-spacing": string;
         "svelte/no-spaces-around-equal-signs-in-attribute": string;
+        "svelte/no-trailing-spaces": string;
         "svelte/shorthand-attribute": string;
         "svelte/shorthand-directive": string;
     };

package/lib/configs/prettier.js

@@ -11,10 +11,12 @@ module.exports = {
         "svelte/first-attribute-linebreak": "off",
         "svelte/html-closing-bracket-spacing": "off",
         "svelte/html-quotes": "off",
+        "svelte/html-self-closing": "off",
         "svelte/indent": "off",
         "svelte/max-attributes-per-line": "off",
         "svelte/mustache-spacing": "off",
         "svelte/no-spaces-around-equal-signs-in-attribute": "off",
+        "svelte/no-trailing-spaces": "off",
         "svelte/shorthand-attribute": "off",
         "svelte/shorthand-directive": "off",
     },

package/lib/index.d.ts

@@ -39,10 +39,12 @@ declare const _default: {
                 "svelte/first-attribute-linebreak": string;
                 "svelte/html-closing-bracket-spacing": string;
                 "svelte/html-quotes": string;
+                "svelte/html-self-closing": string;
                 "svelte/indent": string;
                 "svelte/max-attributes-per-line": string;
                 "svelte/mustache-spacing": string;
                 "svelte/no-spaces-around-equal-signs-in-attribute": string;
+                "svelte/no-trailing-spaces": string;
                 "svelte/shorthand-attribute": string;
                 "svelte/shorthand-directive": string;
             };

package/lib/rules/html-self-closing.d.ts

@@ -0,0 +1,2 @@
+declare const _default: import("../types").RuleModule;
+export default _default;

package/lib/rules/html-self-closing.js

@@ -0,0 +1,152 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const utils_1 = require("../utils");
+const ast_utils_1 = require("../utils/ast-utils");
+const TYPE_MESSAGES = {
+    normal: "HTML elements",
+    void: "HTML void elements",
+    component: "Svelte custom components",
+    svelte: "Svelte special elements",
+};
+exports.default = (0, utils_1.createRule)("html-self-closing", {
+    meta: {
+        docs: {
+            description: "enforce self-closing style",
+            category: "Stylistic Issues",
+            recommended: false,
+            conflictWithPrettier: true,
+        },
+        type: "layout",
+        fixable: "code",
+        messages: {
+            requireClosing: "Require self-closing on {{type}}.",
+            disallowClosing: "Disallow self-closing on {{type}}.",
+        },
+        schema: [
+            {
+                anyOf: [
+                    {
+                        properties: {
+                            void: {
+                                enum: ["never", "always", "ignore"],
+                            },
+                            normal: {
+                                enum: ["never", "always", "ignore"],
+                            },
+                            component: {
+                                enum: ["never", "always", "ignore"],
+                            },
+                            svelte: {
+                                enum: ["never", "always", "ignore"],
+                            },
+                        },
+                        additionalProperties: false,
+                    },
+                    {
+                        enum: ["all", "html", "none"],
+                    },
+                ],
+            },
+        ],
+    },
+    create(ctx) {
+        let options = {
+            void: "always",
+            normal: "always",
+            component: "always",
+            svelte: "always",
+        };
+        const option = ctx.options?.[0];
+        switch (option) {
+            case "none":
+                options = {
+                    void: "never",
+                    normal: "never",
+                    component: "never",
+                    svelte: "never",
+                };
+                break;
+            case "html":
+                options = {
+                    void: "always",
+                    normal: "never",
+                    component: "never",
+                    svelte: "always",
+                };
+                break;
+            default:
+                if (typeof option !== "object" || option === null)
+                    break;
+                options = {
+                    ...options,
+                    ...option,
+                };
+                break;
+        }
+        function getElementType(node) {
+            if (node.kind === "component")
+                return "component";
+            if (node.kind === "special")
+                return "svelte";
+            if ((0, ast_utils_1.isVoidHtmlElement)(node))
+                return "void";
+            return "normal";
+        }
+        function isElementEmpty(node) {
+            if (node.children.length <= 0)
+                return true;
+            for (const child of node.children) {
+                if (child.type !== "SvelteText")
+                    return false;
+                if (!/^\s*$/.test(child.value))
+                    return false;
+            }
+            return true;
+        }
+        function report(node, close) {
+            const elementType = getElementType(node);
+            ctx.report({
+                node,
+                messageId: close ? "requireClosing" : "disallowClosing",
+                data: {
+                    type: TYPE_MESSAGES[elementType],
+                },
+                *fix(fixer) {
+                    if (close) {
+                        for (const child of node.children) {
+                            yield fixer.removeRange(child.range);
+                        }
+                        yield fixer.insertTextBeforeRange([node.startTag.range[1] - 1, node.startTag.range[1]], "/");
+                        if (node.endTag)
+                            yield fixer.removeRange(node.endTag.range);
+                    }
+                    else {
+                        yield fixer.removeRange([
+                            node.startTag.range[1] - 2,
+                            node.startTag.range[1] - 1,
+                        ]);
+                        if (!(0, ast_utils_1.isVoidHtmlElement)(node))
+                            yield fixer.insertTextAfter(node, `</${(0, ast_utils_1.getNodeName)(node)}>`);
+                    }
+                },
+            });
+        }
+        return {
+            SvelteElement(node) {
+                if (!isElementEmpty(node))
+                    return;
+                const elementType = getElementType(node);
+                const elementTypeOptions = options[elementType];
+                if (elementTypeOptions === "ignore")
+                    return;
+                const shouldBeClosed = elementTypeOptions === "always";
+                if (shouldBeClosed && !node.startTag.selfClosing) {
+                    report(node, true);
+                }
+                else if (!shouldBeClosed && node.startTag.selfClosing) {
+                    report(node, false);
+                }
+            },
+        };
+    },
+});

package/lib/rules/no-reactive-functions.d.ts

@@ -0,0 +1,2 @@
+declare const _default: import("../types").RuleModule;
+export default _default;

package/lib/rules/no-reactive-functions.js

@@ -0,0 +1,48 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const utils_1 = require("../utils");
+exports.default = (0, utils_1.createRule)("no-reactive-functions", {
+    meta: {
+        docs: {
+            description: "it's not necessary to define functions in reactive statements",
+            category: "Best Practices",
+            recommended: false,
+        },
+        hasSuggestions: true,
+        schema: [],
+        messages: {
+            noReactiveFns: `Do not create functions inside reactive statements unless absolutely necessary.`,
+            fixReactiveFns: `Move the function out of the reactive statement`,
+        },
+        type: "suggestion",
+    },
+    create(context) {
+        return {
+            [`SvelteReactiveStatement > ExpressionStatement > AssignmentExpression > :function`](node) {
+                const parent = node.parent?.parent?.parent;
+                if (!parent) {
+                    return false;
+                }
+                const source = context.getSourceCode();
+                return context.report({
+                    node: parent,
+                    loc: parent.loc,
+                    messageId: "noReactiveFns",
+                    suggest: [
+                        {
+                            messageId: "fixReactiveFns",
+                            fix(fixer) {
+                                const tokens = source.getFirstTokens(parent, {
+                                    includeComments: false,
+                                    count: 3,
+                                });
+                                const noExtraSpace = source.isSpaceBetweenTokens(tokens[1], tokens[2]);
+                                return fixer.replaceTextRange([tokens[0].range[0], tokens[1].range[1]], noExtraSpace ? "const" : "const ");
+                            },
+                        },
+                    ],
+                });
+            },
+        };
+    },
+});

package/lib/rules/no-reactive-literals.js

@@ -4,7 +4,7 @@ const utils_1 = require("../utils");
 exports.default = (0, utils_1.createRule)("no-reactive-literals", {
     meta: {
         docs: {
-            description: "Don't assign literal values in reactive statements",
+            description: "don't assign literal values in reactive statements",
             category: "Best Practices",
             recommended: false,
         },

package/lib/rules/no-store-async.d.ts

@@ -0,0 +1,2 @@
+declare const _default: import("../types").RuleModule;
+export default _default;

package/lib/rules/no-store-async.js

@@ -0,0 +1,46 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const utils_1 = require("../utils");
+const svelte_store_1 = require("./reference-helpers/svelte-store");
+exports.default = (0, utils_1.createRule)("no-store-async", {
+    meta: {
+        docs: {
+            description: "disallow using async/await inside svelte stores because it causes issues with the auto-unsubscribing features",
+            category: "Possible Errors",
+            recommended: false,
+            default: "error",
+        },
+        schema: [],
+        messages: {
+            unexpected: "Do not pass async functions to svelte stores.",
+        },
+        type: "problem",
+    },
+    create(context) {
+        return {
+            Program() {
+                for (const { node } of (0, svelte_store_1.extractStoreReferences)(context)) {
+                    const [, fn] = node.arguments;
+                    if (!fn ||
+                        (fn.type !== "ArrowFunctionExpression" &&
+                            fn.type !== "FunctionExpression") ||
+                        !fn.async) {
+                        continue;
+                    }
+                    const start = fn.loc?.start ?? { line: 1, column: 0 };
+                    context.report({
+                        node: fn,
+                        loc: {
+                            start,
+                            end: {
+                                line: start.line,
+                                column: start.column + 5,
+                            },
+                        },
+                        messageId: "unexpected",
+                    });
+                }
+            },
+        };
+    },
+});

package/lib/rules/no-trailing-spaces.d.ts

@@ -0,0 +1,2 @@
+declare const _default: import("../types").RuleModule;
+export default _default;

package/lib/rules/no-trailing-spaces.js

@@ -0,0 +1,91 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const utils_1 = require("../utils");
+exports.default = (0, utils_1.createRule)("no-trailing-spaces", {
+    meta: {
+        type: "layout",
+        docs: {
+            description: "disallow trailing whitespace at the end of lines",
+            category: "Extension Rules",
+            recommended: false,
+            extensionRule: "no-trailing-spaces",
+            conflictWithPrettier: true,
+        },
+        fixable: "whitespace",
+        schema: [
+            {
+                type: "object",
+                properties: {
+                    skipBlankLines: { type: "boolean" },
+                    ignoreComments: { type: "boolean" },
+                },
+                additionalProperties: false,
+            },
+        ],
+        messages: {
+            trailingSpace: "Trailing spaces not allowed.",
+        },
+    },
+    create(context) {
+        const options = context.options[0];
+        const skipBlankLines = options?.skipBlankLines || false;
+        const ignoreComments = options?.ignoreComments || false;
+        const sourceCode = context.getSourceCode();
+        const ignoreLineNumbers = new Set();
+        if (ignoreComments) {
+            for (const { type, loc } of sourceCode.getAllComments()) {
+                const endLine = type === "Block" ? loc.end.line - 1 : loc.end.line;
+                for (let i = loc.start.line; i <= endLine; i++) {
+                    ignoreLineNumbers.add(i);
+                }
+            }
+        }
+        function report(loc) {
+            context.report({
+                loc,
+                messageId: "trailingSpace",
+                fix(fixer) {
+                    return fixer.removeRange([
+                        sourceCode.getIndexFromLoc(loc.start),
+                        sourceCode.getIndexFromLoc(loc.end),
+                    ]);
+                },
+            });
+        }
+        function collectIgnoreLineNumbers({ loc }) {
+            const endLine = loc.end.line - 1;
+            for (let i = loc.start.line; i <= endLine; i++) {
+                ignoreLineNumbers.add(i);
+            }
+        }
+        return {
+            TemplateElement: collectIgnoreLineNumbers,
+            ...(ignoreComments
+                ? {
+                    SvelteHTMLComment: collectIgnoreLineNumbers,
+                }
+                : {}),
+            "Program:exit"() {
+                const lines = sourceCode.lines;
+                for (let lineIndex = 0; lineIndex < lines.length; lineIndex++) {
+                    const line = lines[lineIndex];
+                    if (skipBlankLines && !line.trim()) {
+                        continue;
+                    }
+                    const lineNumber = lineIndex + 1;
+                    if (ignoreLineNumbers.has(lineNumber)) {
+                        continue;
+                    }
+                    const trimmed = line.trimEnd();
+                    if (trimmed === line) {
+                        continue;
+                    }
+                    report({
+                        start: { line: lineNumber, column: trimmed.length },
+                        end: { line: lineNumber, column: line.length },
+                    });
+                }
+            },
+        };
+    },
+});

package/lib/rules/reference-helpers/svelte-store.d.ts

@@ -0,0 +1,6 @@
+import type * as ESTree from "estree";
+import type { RuleContext } from "../../types";
+export declare function extractStoreReferences(context: RuleContext): Generator<{
+    node: ESTree.CallExpression;
+    name: string;
+}, void>;

package/lib/rules/reference-helpers/svelte-store.js

@@ -0,0 +1,27 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.extractStoreReferences = void 0;
+const eslint_utils_1 = require("eslint-utils");
+function* extractStoreReferences(context) {
+    const referenceTracker = new eslint_utils_1.ReferenceTracker(context.getScope());
+    for (const { node, path } of referenceTracker.iterateEsmReferences({
+        "svelte/store": {
+            [eslint_utils_1.ReferenceTracker.ESM]: true,
+            writable: {
+                [eslint_utils_1.ReferenceTracker.CALL]: true,
+            },
+            readable: {
+                [eslint_utils_1.ReferenceTracker.CALL]: true,
+            },
+            derived: {
+                [eslint_utils_1.ReferenceTracker.CALL]: true,
+            },
+        },
+    })) {
+        yield {
+            node: node,
+            name: path[path.length - 1],
+        };
+    }
+}
+exports.extractStoreReferences = extractStoreReferences;

package/lib/rules/require-stores-init.d.ts

@@ -0,0 +1,2 @@
+declare const _default: import("../types").RuleModule;
+export default _default;

package/lib/rules/require-stores-init.js

@@ -0,0 +1,39 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const utils_1 = require("../utils");
+const svelte_store_1 = require("./reference-helpers/svelte-store");
+exports.default = (0, utils_1.createRule)("require-stores-init", {
+    meta: {
+        docs: {
+            description: "require initial value in store",
+            category: "Best Practices",
+            recommended: false,
+        },
+        schema: [],
+        messages: {
+            storeDefaultValue: `Always set a default value for svelte stores.`,
+        },
+        type: "suggestion",
+    },
+    create(context) {
+        return {
+            Program() {
+                for (const { node, name } of (0, svelte_store_1.extractStoreReferences)(context)) {
+                    const minArgs = name === "writable" || name === "readable"
+                        ? 1
+                        : name === "derived"
+                            ? 3
+                            : 0;
+                    if (node.arguments.length >= minArgs ||
+                        node.arguments.some((arg) => arg.type === "SpreadElement")) {
+                        continue;
+                    }
+                    context.report({
+                        node,
+                        messageId: "storeDefaultValue",
+                    });
+                }
+            },
+        };
+    },
+});

package/lib/utils/ast-utils.d.ts

@@ -48,3 +48,5 @@ export declare function getMustacheTokens(node: SvAST.SvelteDirective | SvAST.Sv
 } | null;
 export declare function getAttributeKeyText(node: SvAST.SvelteAttribute | SvAST.SvelteShorthandAttribute | SvAST.SvelteStyleDirective | SvAST.SvelteDirective | SvAST.SvelteSpecialDirective): string;
 export declare function getDirectiveName(node: SvAST.SvelteDirective): string;
+export declare function getNodeName(node: SvAST.SvelteElement): string;
+export declare function isVoidHtmlElement(node: SvAST.SvelteElement): boolean;

package/lib/utils/ast-utils.js

@@ -22,9 +22,13 @@ var __importStar = (this && this.__importStar) || function (mod) {
     __setModuleDefault(result, mod);
     return result;
 };
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.getDirectiveName = exports.getAttributeKeyText = exports.getMustacheTokens = exports.getAttributeValueQuoteAndRange = exports.getScope = exports.findVariable = exports.getLangValue = exports.getStaticAttributeValue = exports.findBindDirective = exports.findShorthandAttribute = exports.findAttribute = exports.isHTMLElementLike = exports.needParentheses = exports.getStringIfConstant = exports.equalTokens = void 0;
+exports.isVoidHtmlElement = exports.getNodeName = exports.getDirectiveName = exports.getAttributeKeyText = exports.getMustacheTokens = exports.getAttributeValueQuoteAndRange = exports.getScope = exports.findVariable = exports.getLangValue = exports.getStaticAttributeValue = exports.findBindDirective = exports.findShorthandAttribute = exports.findAttribute = exports.isHTMLElementLike = exports.needParentheses = exports.getStringIfConstant = exports.equalTokens = void 0;
 const eslintUtils = __importStar(require("eslint-utils"));
+const void_elements_1 = __importDefault(require("./void-elements"));
 function equalTokens(left, right, sourceCode) {
     const tokensL = sourceCode.getTokens(left);
     const tokensR = sourceCode.getTokens(right);
@@ -322,3 +326,23 @@ function getAttributeValueRangeTokens(attr, sourceCode) {
         lastToken: tokens.closeToken,
     };
 }
+function getNodeName(node) {
+    if ("name" in node.name) {
+        return node.name.name;
+    }
+    let object = "";
+    let currentObject = node.name.object;
+    while ("object" in currentObject) {
+        object = `${currentObject.property.name}.${object}`;
+        currentObject = currentObject.object;
+    }
+    if ("name" in currentObject) {
+        object = `${currentObject.name}.${object}`;
+    }
+    return object + node.name.property.name;
+}
+exports.getNodeName = getNodeName;
+function isVoidHtmlElement(node) {
+    return void_elements_1.default.includes(getNodeName(node));
+}
+exports.isVoidHtmlElement = isVoidHtmlElement;

package/lib/utils/rules.js

@@ -9,6 +9,7 @@ const comment_directive_1 = __importDefault(require("../rules/comment-directive"
 const first_attribute_linebreak_1 = __importDefault(require("../rules/first-attribute-linebreak"));
 const html_closing_bracket_spacing_1 = __importDefault(require("../rules/html-closing-bracket-spacing"));
 const html_quotes_1 = __importDefault(require("../rules/html-quotes"));
+const html_self_closing_1 = __importDefault(require("../rules/html-self-closing"));
 const indent_1 = __importDefault(require("../rules/indent"));
 const max_attributes_per_line_1 = __importDefault(require("../rules/max-attributes-per-line"));
 const mustache_spacing_1 = __importDefault(require("../rules/mustache-spacing"));
@@ -21,16 +22,20 @@ const no_extra_reactive_curlies_1 = __importDefault(require("../rules/no-extra-r
 const no_inner_declarations_1 = __importDefault(require("../rules/no-inner-declarations"));
 const no_not_function_handler_1 = __importDefault(require("../rules/no-not-function-handler"));
 const no_object_in_text_mustaches_1 = __importDefault(require("../rules/no-object-in-text-mustaches"));
+const no_reactive_functions_1 = __importDefault(require("../rules/no-reactive-functions"));
 const no_reactive_literals_1 = __importDefault(require("../rules/no-reactive-literals"));
 const no_shorthand_style_property_overrides_1 = __importDefault(require("../rules/no-shorthand-style-property-overrides"));
 const no_spaces_around_equal_signs_in_attribute_1 = __importDefault(require("../rules/no-spaces-around-equal-signs-in-attribute"));
+const no_store_async_1 = __importDefault(require("../rules/no-store-async"));
 const no_target_blank_1 = __importDefault(require("../rules/no-target-blank"));
+const no_trailing_spaces_1 = __importDefault(require("../rules/no-trailing-spaces"));
 const no_unknown_style_directive_property_1 = __importDefault(require("../rules/no-unknown-style-directive-property"));
 const no_unused_svelte_ignore_1 = __importDefault(require("../rules/no-unused-svelte-ignore"));
 const no_useless_mustaches_1 = __importDefault(require("../rules/no-useless-mustaches"));
 const prefer_class_directive_1 = __importDefault(require("../rules/prefer-class-directive"));
 const prefer_style_directive_1 = __importDefault(require("../rules/prefer-style-directive"));
 const require_optimized_style_attribute_1 = __importDefault(require("../rules/require-optimized-style-attribute"));
+const require_stores_init_1 = __importDefault(require("../rules/require-stores-init"));
 const shorthand_attribute_1 = __importDefault(require("../rules/shorthand-attribute"));
 const shorthand_directive_1 = __importDefault(require("../rules/shorthand-directive"));
 const sort_attributes_1 = __importDefault(require("../rules/sort-attributes"));
@@ -43,6 +48,7 @@ exports.rules = [
     first_attribute_linebreak_1.default,
     html_closing_bracket_spacing_1.default,
     html_quotes_1.default,
+    html_self_closing_1.default,
     indent_1.default,
     max_attributes_per_line_1.default,
     mustache_spacing_1.default,
@@ -55,16 +61,20 @@ exports.rules = [
     no_inner_declarations_1.default,
     no_not_function_handler_1.default,
     no_object_in_text_mustaches_1.default,
+    no_reactive_functions_1.default,
     no_reactive_literals_1.default,
     no_shorthand_style_property_overrides_1.default,
     no_spaces_around_equal_signs_in_attribute_1.default,
+    no_store_async_1.default,
     no_target_blank_1.default,
+    no_trailing_spaces_1.default,
     no_unknown_style_directive_property_1.default,
     no_unused_svelte_ignore_1.default,
     no_useless_mustaches_1.default,
     prefer_class_directive_1.default,
     prefer_style_directive_1.default,
     require_optimized_style_attribute_1.default,
+    require_stores_init_1.default,
     shorthand_attribute_1.default,
     shorthand_directive_1.default,
     sort_attributes_1.default,

package/lib/utils/void-elements.d.ts

@@ -0,0 +1,2 @@
+declare const voidElements: string[];
+export default voidElements;

package/lib/utils/void-elements.js

@@ -0,0 +1,21 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const voidElements = [
+    "area",
+    "base",
+    "br",
+    "col",
+    "embed",
+    "hr",
+    "img",
+    "input",
+    "keygen",
+    "link",
+    "menuitem",
+    "meta",
+    "param",
+    "source",
+    "track",
+    "wbr",
+];
+exports.default = voidElements;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-svelte",
-  "version": "2.4.1",
+  "version": "2.7.0",
   "description": "ESLint plugin for Svelte using AST",
   "repository": "git+https://github.com/ota-meshi/eslint-plugin-svelte.git",
   "homepage": "https://ota-meshi.github.io/eslint-plugin-svelte",
@@ -34,20 +34,25 @@
     "docs:build": "yarn svelte-kit build",
     "docs:preview": "yarn svelte-kit preview",
     "docs:watch": "yarn svelte-kit dev",
-    "eslint-fix": "eslint . --fix",
     "format-for-gen-file": "eslint src/types-for-node.ts src/utils/rules.ts src/configs --fix",
-    "lint": "eslint .",
+    "lint": "run-p lint:*",
+    "lint-fix": "yarn lint:es --fix && yarn lint:style --fix",
+    "lint:es": "eslint --cache -f friendly .",
+    "lint:style": "stylelint --cache .",
     "mocha": "yarn ts ./node_modules/mocha/bin/mocha.js",
     "new": "yarn ts ./tools/new-rule.ts",
     "prebuild": "yarn clean",
-    "prepublishOnly": "yarn clean && yarn build",
-    "pretest:base": "cross-env DEBUG=eslint-plugin-svelte*",
-    "preversion": "yarn test && git add .",
+    "prepare": "simple-git-hooks && yarn-deduplicate --strategy fewer || exit 0",
+    "prerelease": "yarn clean && yarn build",
+    "release": "changeset publish",
     "svelte-kit": "node --experimental-loader ./svelte-kit-import-hook.mjs node_modules/vite/bin/vite.js",
     "test": "yarn mocha \"tests/src/**/*.ts\" --reporter dot --timeout 60000",
+    "test:debug": "env-cmd -e debug yarn test",
     "ts": "node -r esbuild-register",
+    "typecov": "type-coverage",
     "update": "yarn ts ./tools/update.ts && yarn format-for-gen-file",
-    "version": "env-cmd -e version yarn update && git add ."
+    "version": "env-cmd -e version yarn update",
+    "version:ci": "env-cmd -e version-ci yarn update && changeset version"
   },
   "peerDependencies": {
     "eslint": "^7.0.0 || ^8.0.0-0",
@@ -66,23 +71,32 @@
     "postcss-load-config": "^3.1.4",
     "postcss-safe-parser": "^6.0.0",
     "sourcemap-codec": "^1.4.8",
-    "svelte-eslint-parser": "^0.17.0"
+    "svelte-eslint-parser": "^0.18.0"
   },
   "devDependencies": {
+    "@1stg/browserslist-config": "^1.2.3",
+    "@1stg/commitlint-config": "^3.1.4",
+    "@1stg/lint-staged": "^3.3.0",
+    "@1stg/remark-config": "^4.0.3",
+    "@1stg/simple-git-hooks": "^0.2.1",
+    "@1stg/stylelint-config": "^4.6.1",
     "@babel/core": "^7.16.0",
     "@babel/eslint-parser": "^7.17.0",
     "@babel/plugin-proposal-function-bind": "^7.16.7",
     "@babel/types": "^7.16.0",
+    "@changesets/changelog-github": "^0.4.6",
+    "@changesets/cli": "^2.24.2",
     "@fontsource/fira-mono": "^4.5.0",
     "@ota-meshi/eslint-plugin": "^0.11.3",
     "@sindresorhus/slugify": "^2.1.0",
     "@sveltejs/adapter-static": "^1.0.0-next.26",
-    "@sveltejs/kit": "^1.0.0-next.360",
+    "@sveltejs/kit": "^1.0.0-next.406",
     "@types/babel__core": "^7.1.19",
     "@types/cross-spawn": "^6.0.2",
     "@types/escape-html": "^1.0.2",
     "@types/eslint": "^8.0.0",
     "@types/eslint-scope": "^3.7.0",
+    "@types/eslint-utils": "^3.0.1",
     "@types/eslint-visitor-keys": "^1.0.0",
     "@types/estree": "^1.0.0",
     "@types/less": "^3.0.3",
@@ -98,17 +112,20 @@
     "@typescript-eslint/parser": "^5.4.1-0",
     "@typescript-eslint/parser-v4": "npm:@typescript-eslint/parser@4",
     "assert": "^2.0.0",
+    "commitlint": "^17.0.3",
     "env-cmd": "^10.1.0",
-    "esbuild": "^0.14.1",
+    "esbuild": "^0.15.0",
     "esbuild-register": "^3.2.0",
     "escape-html": "^1.0.3",
     "eslint": "^8.0.0",
     "eslint-config-prettier": "^8.3.0",
+    "eslint-formatter-friendly": "^7.0.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-eslint-plugin": "^5.0.0",
     "eslint-plugin-json-schema-validator": "^4.0.0",
     "eslint-plugin-jsonc": "^2.0.0",
     "eslint-plugin-markdown": "^3.0.0",
+    "eslint-plugin-mdx": "^2.0.2",
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-node-dependencies": "^0.9.0",
     "eslint-plugin-prettier": "^4.0.0",
@@ -118,32 +135,49 @@
     "eslint-scope": "^7.1.1",
     "estree-walker": "^3.0.0",
     "less": "^4.1.2",
+    "lint-staged": "^13.0.3",
     "locate-character": "^2.0.5",
     "magic-string": "^0.26.0",
     "markdown-it-anchor": "^8.4.1",
     "markdown-it-container": "^3.0.0",
     "markdown-it-emoji": "^2.0.0",
     "mocha": "^10.0.0",
+    "npm-run-all": "^4.1.5",
     "nyc": "^15.1.0",
     "pako": "^2.0.3",
     "postcss-nested": "^5.0.6",
     "prettier": "^2.2.1",
-    "prettier-plugin-pkg": "^0.16.0",
+    "prettier-plugin-pkg": "^0.17.0",
     "prettier-plugin-svelte": "^2.6.0",
     "prism-svelte": "^0.5.0",
     "prismjs": "^1.25.0",
     "sass": "^1.51.0",
     "semver": "^7.3.5",
+    "simple-git-hooks": "^2.8.0",
     "stylelint": "^14.0.0",
-    "stylelint-config-standard": "^26.0.0",
-    "stylus": "^0.58.0",
+    "stylelint-config-standard": "^28.0.0",
+    "stylus": "^0.59.0",
     "svelte": "^3.46.1",
     "svelte-adapter-ghpages": "0.0.2",
+    "type-coverage": "^2.22.0",
     "typescript": "^4.5.2",
     "vite": "^3.0.0-0",
-    "vite-plugin-svelte-md": "^0.1.5"
+    "vite-plugin-svelte-md": "^0.1.5",
+    "yaml": "^2.1.1",
+    "yarn-deduplicate": "^5.0.0"
   },
   "publishConfig": {
     "access": "public"
+  },
+  "typeCoverage": {
+    "atLeast": 98.64,
+    "cache": true,
+    "detail": true,
+    "ignoreAsAssertion": true,
+    "ignoreNested": true,
+    "ignoreNonNullAssertion": true,
+    "showRelativePath": true,
+    "strict": true,
+    "update": true
   }
 }