eslint-plugin-svelte 2.33.2 → 2.34.1

package/README.md

@@ -340,6 +340,7 @@ These rules relate to better ways of doing things to help you avoid problems:
 | [svelte/block-lang](https://sveltejs.github.io/eslint-plugin-svelte/rules/block-lang/) | disallows the use of languages other than those specified in the configuration for the lang attribute of `<script>` and `<style>` blocks. |  |
 | [svelte/button-has-type](https://sveltejs.github.io/eslint-plugin-svelte/rules/button-has-type/) | disallow usage of button without an explicit type attribute |  |
 | [svelte/no-at-debug-tags](https://sveltejs.github.io/eslint-plugin-svelte/rules/no-at-debug-tags/) | disallow the use of `{@debug}` | :star: |
+| [svelte/no-ignored-unsubscribe](https://sveltejs.github.io/eslint-plugin-svelte/rules/no-ignored-unsubscribe/) | disallow ignoring the unsubscribe method returned by the `subscribe()` on Svelte stores. |  |
 | [svelte/no-immutable-reactive-statements](https://sveltejs.github.io/eslint-plugin-svelte/rules/no-immutable-reactive-statements/) | disallow reactive statements that don't reference reactive values. |  |
 | [svelte/no-reactive-functions](https://sveltejs.github.io/eslint-plugin-svelte/rules/no-reactive-functions/) | it's not necessary to define functions in reactive statements | :bulb: |
 | [svelte/no-reactive-literals](https://sveltejs.github.io/eslint-plugin-svelte/rules/no-reactive-literals/) | don't assign literal values in reactive statements | :bulb: |

package/lib/meta.d.ts

@@ -1,2 +1,2 @@
 export declare const name: "eslint-plugin-svelte";
-export declare const version: "2.33.2";
+export declare const version: "2.34.1";

package/lib/meta.js

@@ -2,4 +2,4 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.version = exports.name = void 0;
 exports.name = 'eslint-plugin-svelte';
-exports.version = '2.33.2';
+exports.version = '2.34.1';

package/lib/rules/no-ignored-unsubscribe.d.ts

@@ -0,0 +1,2 @@
+declare const _default: import("../types").RuleModule;
+export default _default;

package/lib/rules/no-ignored-unsubscribe.js

@@ -0,0 +1,29 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const utils_1 = require("../utils");
+exports.default = (0, utils_1.createRule)('no-ignored-unsubscribe', {
+    meta: {
+        docs: {
+            description: 'disallow ignoring the unsubscribe method returned by the `subscribe()` on Svelte stores.',
+            category: 'Best Practices',
+            recommended: false
+        },
+        fixable: undefined,
+        hasSuggestions: false,
+        messages: {
+            forbidden: 'Ignoring returned value of the subscribe method is forbidden.'
+        },
+        schema: [],
+        type: 'problem'
+    },
+    create: (context) => {
+        return {
+            "ExpressionStatement > CallExpression > MemberExpression.callee[property.name='subscribe']": (node) => {
+                context.report({
+                    messageId: 'forbidden',
+                    node: node.property
+                });
+            }
+        };
+    }
+});

package/lib/shared/svelte-compile-warns/index.js

@@ -89,7 +89,7 @@ function getSvelteCompileWarningsWithoutCache(context) {
     const text = buildStrippedText(context, ignoreComments, stripStyleTokens);
     transformResults.push(...transformScripts(context, text));
     if (!transformResults.length) {
-        const warnings = getWarningsFromCode(text);
+        const warnings = getWarningsFromCode(text, context);
         return {
             ...processIgnore(warnings.warnings, warnings.kind, stripStyleElements, ignoreComments, context),
             kind: warnings.kind,
@@ -209,7 +209,7 @@ function getSvelteCompileWarningsWithoutCache(context) {
         remapContext.appendTranspile(result);
     }
     const code = remapContext.postprocess();
-    const baseWarnings = getWarningsFromCode(code);
+    const baseWarnings = getWarningsFromCode(code, context);
     const warnings = [];
     for (const warn of baseWarnings.warnings) {
         let loc = null;
@@ -287,11 +287,26 @@ function* transformScripts(context, text) {
         }
     }
 }
-function getWarningsFromCode(code) {
+function hasTagOption(program) {
+    return program.body.some((body) => {
+        if (body.type !== 'SvelteElement' || body.kind !== 'special') {
+            return false;
+        }
+        if (body.name.name !== 'svelte:options') {
+            return false;
+        }
+        return Boolean((0, ast_utils_1.findAttribute)(body, 'tag'));
+    });
+}
+function getWarningsFromCode(code, context) {
     try {
         const result = compiler.compile(code, {
             generate: false,
-            ...(semver_1.default.satisfies(compiler.VERSION, '>=4.0.0-0') ? { customElement: true } : {})
+            ...(semver_1.default.satisfies(compiler.VERSION, '>=4.0.0-0')
+                ? { customElement: true }
+                : hasTagOption(context.getSourceCode().ast)
+                    ? { customElement: true }
+                    : {})
         });
         return { warnings: result.warnings, kind: 'warn' };
     }

package/lib/utils/rules.js

@@ -29,6 +29,7 @@ const no_dupe_use_directives_1 = __importDefault(require("../rules/no-dupe-use-d
 const no_dynamic_slot_name_1 = __importDefault(require("../rules/no-dynamic-slot-name"));
 const no_export_load_in_svelte_module_in_kit_pages_1 = __importDefault(require("../rules/no-export-load-in-svelte-module-in-kit-pages"));
 const no_extra_reactive_curlies_1 = __importDefault(require("../rules/no-extra-reactive-curlies"));
+const no_ignored_unsubscribe_1 = __importDefault(require("../rules/no-ignored-unsubscribe"));
 const no_immutable_reactive_statements_1 = __importDefault(require("../rules/no-immutable-reactive-statements"));
 const no_inner_declarations_1 = __importDefault(require("../rules/no-inner-declarations"));
 const no_not_function_handler_1 = __importDefault(require("../rules/no-not-function-handler"));
@@ -89,6 +90,7 @@ exports.rules = [
     no_dynamic_slot_name_1.default,
     no_export_load_in_svelte_module_in_kit_pages_1.default,
     no_extra_reactive_curlies_1.default,
+    no_ignored_unsubscribe_1.default,
     no_immutable_reactive_statements_1.default,
     no_inner_declarations_1.default,
     no_not_function_handler_1.default,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-svelte",
-  "version": "2.33.2",
+  "version": "2.34.1",
   "description": "ESLint plugin for Svelte using AST",
   "repository": "git+https://github.com/sveltejs/eslint-plugin-svelte.git",
   "homepage": "https://sveltejs.github.io/eslint-plugin-svelte",
@@ -39,7 +39,7 @@
     "@jridgewell/sourcemap-codec": "^1.4.14",
     "debug": "^4.3.1",
     "esutils": "^2.0.3",
-    "known-css-properties": "^0.28.0",
+    "known-css-properties": "^0.29.0",
     "postcss": "^8.4.5",
     "postcss-load-config": "^3.1.4",
     "postcss-safe-parser": "^6.0.0",
@@ -76,13 +76,13 @@
     "@types/markdown-it-container": "^2.0.5",
     "@types/markdown-it-emoji": "^2.0.2",
     "@types/mocha": "^10.0.0",
-    "@types/node": "^18.11.0",
+    "@types/node": "^20.0.0",
     "@types/postcss-safe-parser": "^5.0.1",
     "@types/prismjs": "^1.26.0",
     "@types/semver": "^7.5.0",
     "@types/stylus": "^0.48.38",
-    "@typescript-eslint/eslint-plugin": "^6.0.0",
-    "@typescript-eslint/parser": "^6.0.0",
+    "@typescript-eslint/eslint-plugin": "^6.9.0",
+    "@typescript-eslint/parser": "^6.9.0",
     "@typescript/vfs": "^1.4.0",
     "acorn": "^8.8.2",
     "assert": "^2.0.0",
@@ -103,7 +103,7 @@
     "eslint-plugin-n": "^16.0.0",
     "eslint-plugin-node-dependencies": "^0.11.0",
     "eslint-plugin-prettier": "^5.0.0",
-    "eslint-plugin-regexp": "^1.0.0",
+    "eslint-plugin-regexp": "^2.0.0",
     "eslint-plugin-svelte": "^2.28.0",
     "eslint-plugin-yml": "^1.0.0",
     "eslint-scope": "^7.1.1",
@@ -134,7 +134,7 @@
     "stylus": "^0.60.0",
     "svelte": "^4.0.0",
     "svelte-adapter-ghpages": "0.1.0",
-    "svelte-i18n": "^3.6.0",
+    "svelte-i18n": "^4.0.0",
     "tslib": "^2.5.0",
     "type-coverage": "^2.22.0",
     "typescript": "~5.1.0",