eslint-plugin-svelte 2.21.0 → 2.23.0

package/README.md

@@ -89,6 +89,7 @@ This plugin provides configs:
 - `plugin:svelte/base` ... Configuration to enable correct Svelte parsing.
 - `plugin:svelte/recommended` ... Above, plus rules to prevent errors or unintended behavior.
 - `plugin:svelte/prettier` ... Turns off rules that may conflict with [Prettier](https://prettier.io/) (You still need to configure prettier to work with svelte yourself, for example by using [prettier-plugin-svelte](https://github.com/sveltejs/prettier-plugin-svelte).).
+- `plugin:svelte/all` ... All rules. This configuration is not recommended for production use because it changes with every minor and major version of `eslint-plugin-svelte`. Use it at your own risk.
 
 See [the rule list](https://ota-meshi.github.io/eslint-plugin-svelte/rules/) to get the `rules` that this plugin provides.
 

package/lib/configs/all.d.ts

@@ -0,0 +1,7 @@
+declare const _default: {
+    extends: string[];
+    rules: {
+        [k: string]: string;
+    };
+};
+export = _default;

package/lib/configs/all.js

@@ -0,0 +1,12 @@
+"use strict";
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
+const path_1 = __importDefault(require("path"));
+const rules_1 = require("../utils/rules");
+const base = require.resolve("./base");
+const baseExtend = path_1.default.extname(`${base}`) === ".ts" ? "plugin:svelte/base" : base;
+module.exports = {
+    extends: [baseExtend],
+    rules: Object.fromEntries(rules_1.rules.map((rule) => [`svelte/${rule.meta.docs.ruleName}`, "error"])),
+};

package/lib/index.d.ts

@@ -49,6 +49,12 @@ declare const _default: {
                 "svelte/shorthand-directive": string;
             };
         };
+        all: {
+            extends: string[];
+            rules: {
+                [k: string]: string;
+            };
+        };
     };
     rules: {
         [key: string]: RuleModule;

package/lib/index.js

@@ -29,11 +29,13 @@ const rules_1 = require("./utils/rules");
 const base_1 = __importDefault(require("./configs/base"));
 const recommended_1 = __importDefault(require("./configs/recommended"));
 const prettier_1 = __importDefault(require("./configs/prettier"));
+const all_1 = __importDefault(require("./configs/all"));
 const processor = __importStar(require("./processor"));
 const configs = {
     base: base_1.default,
     recommended: recommended_1.default,
     prettier: prettier_1.default,
+    all: all_1.default,
 };
 const rules = rules_1.rules.reduce((obj, r) => {
     obj[r.meta.docs.ruleName] = r;

package/lib/rules/indent-helpers/commons.js

@@ -1,7 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.isBeginningOfElement = exports.isBeginningOfLine = exports.getFirstAndLastTokens = void 0;
-const eslint_utils_1 = require("eslint-utils");
+const eslint_utils_1 = require("@eslint-community/eslint-utils");
 const ast_1 = require("./ast");
 function getFirstAndLastTokens(sourceCode, node, borderOffset = 0) {
     let firstToken = sourceCode.getFirstToken(node);
@@ -47,8 +47,7 @@ function isBeginningOfElement(node) {
     if (node.parent.type === "Program") {
         return node.parent.body[0] === node;
     }
-    assertNever(node.parent);
-    return false;
+    return assertNever(node.parent);
 }
 exports.isBeginningOfElement = isBeginningOfElement;
 function assertNever(value) {

package/lib/rules/indent-helpers/es.js

@@ -2,7 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.defineVisitor = void 0;
 const commons_1 = require("./commons");
-const eslint_utils_1 = require("eslint-utils");
+const eslint_utils_1 = require("@eslint-community/eslint-utils");
 const ast_utils_1 = require("../../utils/ast-utils");
 function defineVisitor(context) {
     const { sourceCode, offsets, options } = context;

package/lib/rules/indent-helpers/index.js

@@ -28,7 +28,7 @@ const SV = __importStar(require("./svelte"));
 const ES = __importStar(require("./es"));
 const TS = __importStar(require("./ts"));
 const ast_1 = require("./ast");
-const eslint_utils_1 = require("eslint-utils");
+const eslint_utils_1 = require("@eslint-community/eslint-utils");
 const offset_context_1 = require("./offset-context");
 function parseOptions(options, defaultOptions) {
     const ret = {

package/lib/rules/indent-helpers/svelte.js

@@ -16,17 +16,21 @@ function defineVisitor(context) {
             node.children.forEach((n) => offsets.ignore(n));
         },
         SvelteElement(node) {
-            if ((node.name.type !== "Identifier" && node.name.type !== "SvelteName") ||
-                !PREFORMATTED_ELEMENT_NAMES.includes(node.name.name)) {
-                if (node.endTag) {
-                    offsets.setOffsetElementList(node.children.filter(isNotEmptyTextNode), node.startTag, node.endTag, 1);
+            if (node.name.type === "Identifier" || node.name.type === "SvelteName") {
+                if (PREFORMATTED_ELEMENT_NAMES.includes(node.name.name)) {
+                    const startTagToken = sourceCode.getFirstToken(node);
+                    const endTagToken = node.endTag && sourceCode.getFirstToken(node.endTag);
+                    offsets.setOffsetToken(endTagToken, 0, startTagToken);
+                    node.children.forEach((n) => offsets.ignore(n));
+                    return;
+                }
+                if (node.name.name === "style") {
+                    node.children.forEach((n) => offsets.ignore(n));
+                    return;
                 }
             }
-            else {
-                const startTagToken = sourceCode.getFirstToken(node);
-                const endTagToken = node.endTag && sourceCode.getFirstToken(node.endTag);
-                offsets.setOffsetToken(endTagToken, 0, startTagToken);
-                node.children.forEach((n) => offsets.ignore(n));
+            if (node.endTag) {
+                offsets.setOffsetElementList(node.children.filter(isNotEmptyTextNode), node.startTag, node.endTag, 1);
             }
         },
         SvelteStartTag(node) {

package/lib/rules/indent-helpers/ts.js

@@ -1,7 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.defineVisitor = void 0;
-const eslint_utils_1 = require("eslint-utils");
+const eslint_utils_1 = require("@eslint-community/eslint-utils");
 const commons_1 = require("./commons");
 const commons_2 = require("./commons");
 function defineVisitor(context) {

package/lib/rules/infinite-reactive-loop.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-const eslint_utils_1 = require("eslint-utils");
+const eslint_utils_1 = require("@eslint-community/eslint-utils");
 const utils_1 = require("../utils");
 const ast_utils_1 = require("../utils/ast-utils");
 const svelte_eslint_parser_1 = require("svelte-eslint-parser");
@@ -166,73 +166,81 @@ function isInsideOfFunction(node) {
     return false;
 }
 function doLint(context, ast, callFuncIdentifiers, tickCallExpressions, taskReferences, reactiveVariableNames, reactiveVariableReferences, pIsSameTask) {
-    let isSameMicroTask = pIsSameTask;
-    const differentMicroTaskEnterNodes = [];
-    (0, svelte_eslint_parser_1.traverseNodes)(ast, {
-        enterNode(node) {
-            if (isPromiseThenOrCatchBody(node)) {
-                differentMicroTaskEnterNodes.push(node);
-                isSameMicroTask = false;
-            }
-            for (const { node: callExpression } of [
-                ...tickCallExpressions,
-                ...taskReferences,
-            ]) {
-                if (isChildNode(callExpression, node)) {
+    const processed = new Set();
+    verifyInternal(ast, callFuncIdentifiers, pIsSameTask);
+    function verifyInternal(ast, callFuncIdentifiers, pIsSameTask) {
+        if (processed.has(ast)) {
+            return;
+        }
+        processed.add(ast);
+        let isSameMicroTask = pIsSameTask;
+        const differentMicroTaskEnterNodes = [];
+        (0, svelte_eslint_parser_1.traverseNodes)(ast, {
+            enterNode(node) {
+                if (isPromiseThenOrCatchBody(node)) {
                     differentMicroTaskEnterNodes.push(node);
                     isSameMicroTask = false;
                 }
-            }
-            if (node.parent?.type === "AssignmentExpression" &&
-                node.parent?.right.type === "AwaitExpression" &&
-                node.parent?.left === node) {
-                differentMicroTaskEnterNodes.push(node);
-                isSameMicroTask = false;
-            }
-            if (node.type === "Identifier" && isFunctionCall(node)) {
-                const functionDeclarationNode = getFunctionDeclarationNode(context, node);
-                if (functionDeclarationNode) {
-                    doLint(context, functionDeclarationNode, [...callFuncIdentifiers, node], tickCallExpressions, taskReferences, reactiveVariableNames, reactiveVariableReferences, isSameMicroTask);
+                for (const { node: callExpression } of [
+                    ...tickCallExpressions,
+                    ...taskReferences,
+                ]) {
+                    if (isChildNode(callExpression, node)) {
+                        differentMicroTaskEnterNodes.push(node);
+                        isSameMicroTask = false;
+                    }
                 }
-            }
-            if (!isSameMicroTask) {
-                if (isReactiveVariableNode(reactiveVariableReferences, node) &&
-                    reactiveVariableNames.includes(node.name) &&
-                    isNodeForAssign(node)) {
-                    context.report({
-                        node,
-                        loc: node.loc,
-                        messageId: "unexpected",
-                    });
-                    callFuncIdentifiers.forEach((callFuncIdentifier) => {
+                if (node.parent?.type === "AssignmentExpression" &&
+                    node.parent?.right.type === "AwaitExpression" &&
+                    node.parent?.left === node) {
+                    differentMicroTaskEnterNodes.push(node);
+                    isSameMicroTask = false;
+                }
+                if (node.type === "Identifier" && isFunctionCall(node)) {
+                    const functionDeclarationNode = getFunctionDeclarationNode(context, node);
+                    if (functionDeclarationNode) {
+                        verifyInternal(functionDeclarationNode, [...callFuncIdentifiers, node], isSameMicroTask);
+                    }
+                }
+                if (!isSameMicroTask) {
+                    if (isReactiveVariableNode(reactiveVariableReferences, node) &&
+                        reactiveVariableNames.includes(node.name) &&
+                        isNodeForAssign(node)) {
                         context.report({
-                            node: callFuncIdentifier,
-                            loc: callFuncIdentifier.loc,
-                            messageId: "unexpectedCall",
-                            data: {
-                                variableName: node.name,
-                            },
+                            node,
+                            loc: node.loc,
+                            messageId: "unexpected",
+                        });
+                        callFuncIdentifiers.forEach((callFuncIdentifier) => {
+                            context.report({
+                                node: callFuncIdentifier,
+                                loc: callFuncIdentifier.loc,
+                                messageId: "unexpectedCall",
+                                data: {
+                                    variableName: node.name,
+                                },
+                            });
                         });
-                    });
+                    }
                 }
-            }
-        },
-        leaveNode(node) {
-            if (node.type === "AwaitExpression") {
-                if (ast.parent?.type === "SvelteReactiveStatement") {
-                    if (!isInsideOfFunction(node)) {
+            },
+            leaveNode(node) {
+                if (node.type === "AwaitExpression") {
+                    if (ast.parent?.type === "SvelteReactiveStatement") {
+                        if (!isInsideOfFunction(node)) {
+                            isSameMicroTask = false;
+                        }
+                    }
+                    else {
                         isSameMicroTask = false;
                     }
                 }
-                else {
-                    isSameMicroTask = false;
+                if (differentMicroTaskEnterNodes.includes(node)) {
+                    isSameMicroTask = true;
                 }
-            }
-            if (differentMicroTaskEnterNodes.includes(node)) {
-                isSameMicroTask = true;
-            }
-        },
-    });
+            },
+        });
+    }
 }
 exports.default = (0, utils_1.createRule)("infinite-reactive-loop", {
     meta: {

package/lib/rules/mustache-spacing.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-const eslint_utils_1 = require("eslint-utils");
+const eslint_utils_1 = require("@eslint-community/eslint-utils");
 const utils_1 = require("../utils");
 const ast_utils_1 = require("../utils/ast-utils");
 const VALUE_SCHEMA = { enum: ["never", "always"] };

package/lib/rules/no-dom-manipulating.js

@@ -2,7 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 const utils_1 = require("../utils");
 const ast_utils_1 = require("../utils/ast-utils");
-const eslint_utils_1 = require("eslint-utils");
+const eslint_utils_1 = require("@eslint-community/eslint-utils");
 const DOM_MANIPULATING_METHODS = new Set([
     "appendChild",
     "insertBefore",

package/lib/rules/prefer-destructured-store-props.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-const eslint_utils_1 = require("eslint-utils");
+const eslint_utils_1 = require("@eslint-community/eslint-utils");
 const esutils_1 = require("esutils");
 const utils_1 = require("../utils");
 const ast_utils_1 = require("../utils/ast-utils");

package/lib/rules/reference-helpers/svelte-store.js

@@ -1,7 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.createStoreChecker = exports.extractStoreReferences = void 0;
-const eslint_utils_1 = require("eslint-utils");
+const eslint_utils_1 = require("@eslint-community/eslint-utils");
 const ts_utils_1 = require("../../utils/ts-utils");
 const ast_utils_1 = require("../../utils/ast-utils");
 function* extractStoreReferences(context, storeNames = ["writable", "readable", "derived"]) {

package/lib/rules/require-event-dispatcher-types.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-const eslint_utils_1 = require("eslint-utils");
+const eslint_utils_1 = require("@eslint-community/eslint-utils");
 const utils_1 = require("../utils");
 const ast_utils_1 = require("../utils/ast-utils");
 exports.default = (0, utils_1.createRule)("require-event-dispatcher-types", {

package/lib/shared/svelte-compile-warns/extract-leading-comments.js

@@ -1,7 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.extractLeadingComments = void 0;
-const eslint_utils_1 = require("eslint-utils");
+const eslint_utils_1 = require("@eslint-community/eslint-utils");
 function extractLeadingComments(context, node) {
     const sourceCode = context.getSourceCode();
     const beforeToken = sourceCode.getTokenBefore(node, {

package/lib/utils/ast-utils.js

@@ -27,7 +27,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.isExpressionIdentifier = exports.isVoidHtmlElement = exports.getNodeName = exports.getDirectiveName = exports.getAttributeKeyText = exports.getMustacheTokens = exports.getAttributeValueQuoteAndRange = exports.getParent = exports.getScope = exports.findVariable = exports.getLangValue = exports.getStaticAttributeValue = exports.findBindDirective = exports.findShorthandAttribute = exports.findAttribute = exports.isHTMLElementLike = exports.needParentheses = exports.getStringIfConstant = exports.equalTokens = void 0;
-const eslintUtils = __importStar(require("eslint-utils"));
+const eslintUtils = __importStar(require("@eslint-community/eslint-utils"));
 const void_elements_1 = __importDefault(require("./void-elements"));
 function equalTokens(left, right, sourceCode) {
     const tokensL = sourceCode.getTokens(left);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-svelte",
-  "version": "2.21.0",
+  "version": "2.23.0",
   "description": "ESLint plugin for Svelte using AST",
   "repository": "git+https://github.com/ota-meshi/eslint-plugin-svelte.git",
   "homepage": "https://ota-meshi.github.io/eslint-plugin-svelte",
@@ -65,9 +65,9 @@
     }
   },
   "dependencies": {
+    "@eslint-community/eslint-utils": "^4.2.0",
     "@jridgewell/sourcemap-codec": "^1.4.14",
     "debug": "^4.3.1",
-    "eslint-utils": "^3.0.0",
     "esutils": "^2.0.3",
     "known-css-properties": "^0.27.0",
     "postcss": "^8.4.5",
@@ -158,13 +158,13 @@
     "semver": "^7.3.5",
     "simple-git-hooks": "^2.8.0",
     "stylelint": "^15.0.0",
-    "stylelint-config-standard": "^30.0.0",
+    "stylelint-config-standard": "^31.0.0",
     "stylus": "^0.59.0",
     "svelte": "^3.46.1",
     "svelte-adapter-ghpages": "0.1.0",
     "svelte-i18n": "^3.4.0",
     "type-coverage": "^2.22.0",
-    "typescript": "^4.9.3",
+    "typescript": "^5.0.0",
     "vite": "^4.0.0",
     "vite-plugin-svelte-md": "^0.1.5",
     "yaml": "^2.1.1",