eslint-plugin-svelte 2.2.0 → 2.3.0

package/README.md

@@ -35,7 +35,7 @@ The [svelte-eslint-parser] and the `eslint-plugin-svelte` can not be used with t
 
 ## Migration Guide
 
-To migrate from `eslint-plugin-svelte` v1, or `@ota-meshi/eslint-plugin-svelte`, please refer to the [migration guide](https://ota-meshi.github.io/eslint-plugin-svelte/migration/).
+To migrate from `eslint-plugin-svelte` v1, or [`@ota-meshi/eslint-plugin-svelte`](https://www.npmjs.com/package/@ota-meshi/eslint-plugin-svelte), please refer to the [migration guide](https://ota-meshi.github.io/eslint-plugin-svelte/migration/).
 
 ## :book: Documentation
 
@@ -292,10 +292,12 @@ These rules relate to style guidelines, and are therefore quite subjective:
 | Rule ID | Description |    |
 |:--------|:------------|:---|
 | [svelte/first-attribute-linebreak](https://ota-meshi.github.io/eslint-plugin-svelte/rules/first-attribute-linebreak/) | enforce the location of first attribute | :wrench: |
+| [svelte/html-closing-bracket-spacing](https://ota-meshi.github.io/eslint-plugin-svelte/rules/html-closing-bracket-spacing/) | require or disallow a space before tag's closing brackets | :wrench: |
 | [svelte/html-quotes](https://ota-meshi.github.io/eslint-plugin-svelte/rules/html-quotes/) | enforce quotes style of HTML attributes | :wrench: |
 | [svelte/indent](https://ota-meshi.github.io/eslint-plugin-svelte/rules/indent/) | enforce consistent indentation | :wrench: |
 | [svelte/max-attributes-per-line](https://ota-meshi.github.io/eslint-plugin-svelte/rules/max-attributes-per-line/) | enforce the maximum number of attributes per line | :wrench: |
 | [svelte/mustache-spacing](https://ota-meshi.github.io/eslint-plugin-svelte/rules/mustache-spacing/) | enforce unified spacing in mustache | :wrench: |
+| [svelte/no-spaces-around-equal-signs-in-attribute](https://ota-meshi.github.io/eslint-plugin-svelte/rules/no-spaces-around-equal-signs-in-attribute/) | disallow spaces around equal signs in attribute | :wrench: |
 | [svelte/prefer-class-directive](https://ota-meshi.github.io/eslint-plugin-svelte/rules/prefer-class-directive/) | require class directives instead of ternary expressions | :wrench: |
 | [svelte/prefer-style-directive](https://ota-meshi.github.io/eslint-plugin-svelte/rules/prefer-style-directive/) | require style directives instead of style attribute | :wrench: |
 | [svelte/shorthand-attribute](https://ota-meshi.github.io/eslint-plugin-svelte/rules/shorthand-attribute/) | enforce use of shorthand syntax in attribute | :wrench: |

package/lib/configs/prettier.d.ts

@@ -2,10 +2,12 @@ declare const _default: {
     extends: string[];
     rules: {
         "svelte/first-attribute-linebreak": string;
+        "svelte/html-closing-bracket-spacing": string;
         "svelte/html-quotes": string;
         "svelte/indent": string;
         "svelte/max-attributes-per-line": string;
         "svelte/mustache-spacing": string;
+        "svelte/no-spaces-around-equal-signs-in-attribute": string;
         "svelte/shorthand-attribute": string;
         "svelte/shorthand-directive": string;
     };

package/lib/configs/prettier.js

@@ -9,10 +9,12 @@ module.exports = {
     extends: [baseExtend],
     rules: {
         "svelte/first-attribute-linebreak": "off",
+        "svelte/html-closing-bracket-spacing": "off",
         "svelte/html-quotes": "off",
         "svelte/indent": "off",
         "svelte/max-attributes-per-line": "off",
         "svelte/mustache-spacing": "off",
+        "svelte/no-spaces-around-equal-signs-in-attribute": "off",
         "svelte/shorthand-attribute": "off",
         "svelte/shorthand-directive": "off",
     },

package/lib/index.d.ts

@@ -37,10 +37,12 @@ declare const _default: {
             extends: string[];
             rules: {
                 "svelte/first-attribute-linebreak": string;
+                "svelte/html-closing-bracket-spacing": string;
                 "svelte/html-quotes": string;
                 "svelte/indent": string;
                 "svelte/max-attributes-per-line": string;
                 "svelte/mustache-spacing": string;
+                "svelte/no-spaces-around-equal-signs-in-attribute": string;
                 "svelte/shorthand-attribute": string;
                 "svelte/shorthand-directive": string;
             };

package/lib/rules/html-closing-bracket-spacing.d.ts

@@ -0,0 +1,2 @@
+declare const _default: import("../types").RuleModule;
+export default _default;

package/lib/rules/html-closing-bracket-spacing.js

@@ -0,0 +1,92 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const utils_1 = require("../utils");
+exports.default = (0, utils_1.createRule)("html-closing-bracket-spacing", {
+    meta: {
+        docs: {
+            description: "require or disallow a space before tag's closing brackets",
+            category: "Stylistic Issues",
+            conflictWithPrettier: true,
+            recommended: false,
+        },
+        schema: [
+            {
+                type: "object",
+                properties: {
+                    startTag: {
+                        enum: ["always", "never", "ignore"],
+                    },
+                    endTag: {
+                        enum: ["always", "never", "ignore"],
+                    },
+                    selfClosingTag: {
+                        enum: ["always", "never", "ignore"],
+                    },
+                },
+                additionalProperties: false,
+            },
+        ],
+        messages: {
+            expectedSpace: "Expected space before '>', but not found.",
+            unexpectedSpace: "Expected no space before '>', but found.",
+        },
+        fixable: "whitespace",
+        type: "layout",
+    },
+    create(ctx) {
+        const options = {
+            startTag: "never",
+            endTag: "never",
+            selfClosingTag: "always",
+            ...ctx.options[0],
+        };
+        const src = ctx.getSourceCode();
+        function containsNewline(string) {
+            return string.includes("\n");
+        }
+        function report(node, shouldHave) {
+            const tagSrc = src.getText(node);
+            const match = /(\s*)\/?>$/.exec(tagSrc);
+            const end = node.range[1];
+            const start = node.range[1] - match[0].length;
+            const loc = {
+                start: src.getLocFromIndex(start),
+                end: src.getLocFromIndex(end),
+            };
+            ctx.report({
+                loc,
+                messageId: shouldHave ? "expectedSpace" : "unexpectedSpace",
+                *fix(fixer) {
+                    if (shouldHave) {
+                        yield fixer.insertTextBeforeRange([start, end], " ");
+                    }
+                    else {
+                        const spaces = match[1];
+                        yield fixer.removeRange([start, start + spaces.length]);
+                    }
+                },
+            });
+        }
+        return {
+            "SvelteStartTag, SvelteEndTag"(node) {
+                const tagType = node.type === "SvelteEndTag"
+                    ? "endTag"
+                    : node.selfClosing
+                        ? "selfClosingTag"
+                        : "startTag";
+                if (options[tagType] === "ignore")
+                    return;
+                const tagSrc = src.getText(node);
+                const match = /(\s*)\/?>$/.exec(tagSrc);
+                if (containsNewline(match[1]))
+                    return;
+                if (options[tagType] === "always" && !match[1]) {
+                    report(node, true);
+                }
+                else if (options[tagType] === "never" && match[1]) {
+                    report(node, false);
+                }
+            },
+        };
+    },
+});

package/lib/rules/no-spaces-around-equal-signs-in-attribute.d.ts

@@ -0,0 +1,2 @@
+declare const _default: import("../types").RuleModule;
+export default _default;

package/lib/rules/no-spaces-around-equal-signs-in-attribute.js

@@ -0,0 +1,49 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const utils_1 = require("../utils");
+exports.default = (0, utils_1.createRule)("no-spaces-around-equal-signs-in-attribute", {
+    meta: {
+        docs: {
+            description: "disallow spaces around equal signs in attribute",
+            category: "Stylistic Issues",
+            recommended: false,
+            conflictWithPrettier: true,
+        },
+        schema: {},
+        fixable: "whitespace",
+        messages: {
+            noSpaces: "Unexpected spaces found around equal signs.",
+        },
+        type: "layout",
+    },
+    create(ctx) {
+        const source = ctx.getSourceCode();
+        function getAttrEq(node) {
+            const keyRange = node.key.range;
+            const eqSource = /^[\s=]*/u.exec(source.text.slice(keyRange[1], node.range[1]))[0];
+            const valueStart = keyRange[1] + eqSource.length;
+            return [eqSource, [keyRange[1], valueStart]];
+        }
+        function containsWhitespace(string) {
+            return /\s/u.test(string);
+        }
+        return {
+            "SvelteAttribute, SvelteDirective, SvelteStyleDirective, SvelteSpecialDirective"(node) {
+                const [eqSource, range] = getAttrEq(node);
+                if (!containsWhitespace(eqSource))
+                    return;
+                const loc = {
+                    start: source.getLocFromIndex(range[0]),
+                    end: source.getLocFromIndex(range[1]),
+                };
+                ctx.report({
+                    loc,
+                    messageId: "noSpaces",
+                    *fix(fixer) {
+                        yield fixer.replaceTextRange(range, "=");
+                    },
+                });
+            },
+        };
+    },
+});

package/lib/utils/rules.js

@@ -7,6 +7,7 @@ exports.rules = void 0;
 const button_has_type_1 = __importDefault(require("../rules/button-has-type"));
 const comment_directive_1 = __importDefault(require("../rules/comment-directive"));
 const first_attribute_linebreak_1 = __importDefault(require("../rules/first-attribute-linebreak"));
+const html_closing_bracket_spacing_1 = __importDefault(require("../rules/html-closing-bracket-spacing"));
 const html_quotes_1 = __importDefault(require("../rules/html-quotes"));
 const indent_1 = __importDefault(require("../rules/indent"));
 const max_attributes_per_line_1 = __importDefault(require("../rules/max-attributes-per-line"));
@@ -20,6 +21,7 @@ const no_inner_declarations_1 = __importDefault(require("../rules/no-inner-decla
 const no_not_function_handler_1 = __importDefault(require("../rules/no-not-function-handler"));
 const no_object_in_text_mustaches_1 = __importDefault(require("../rules/no-object-in-text-mustaches"));
 const no_shorthand_style_property_overrides_1 = __importDefault(require("../rules/no-shorthand-style-property-overrides"));
+const no_spaces_around_equal_signs_in_attribute_1 = __importDefault(require("../rules/no-spaces-around-equal-signs-in-attribute"));
 const no_target_blank_1 = __importDefault(require("../rules/no-target-blank"));
 const no_unknown_style_directive_property_1 = __importDefault(require("../rules/no-unknown-style-directive-property"));
 const no_unused_svelte_ignore_1 = __importDefault(require("../rules/no-unused-svelte-ignore"));
@@ -36,6 +38,7 @@ exports.rules = [
     button_has_type_1.default,
     comment_directive_1.default,
     first_attribute_linebreak_1.default,
+    html_closing_bracket_spacing_1.default,
     html_quotes_1.default,
     indent_1.default,
     max_attributes_per_line_1.default,
@@ -49,6 +52,7 @@ exports.rules = [
     no_not_function_handler_1.default,
     no_object_in_text_mustaches_1.default,
     no_shorthand_style_property_overrides_1.default,
+    no_spaces_around_equal_signs_in_attribute_1.default,
     no_target_blank_1.default,
     no_unknown_style_directive_property_1.default,
     no_unused_svelte_ignore_1.default,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-svelte",
-  "version": "2.2.0",
+  "version": "2.3.0",
   "description": "ESLint plugin for Svelte using AST",
   "repository": "git+https://github.com/ota-meshi/eslint-plugin-svelte.git",
   "homepage": "https://ota-meshi.github.io/eslint-plugin-svelte",
@@ -43,7 +43,7 @@
     "prepublishOnly": "yarn clean && yarn build",
     "pretest:base": "cross-env DEBUG=eslint-plugin-svelte*",
     "preversion": "yarn test && git add .",
-    "svelte-kit": "node --experimental-loader ./svelte-kit-import-hook.mjs node_modules/vite/bin/vite.js --config vite.config.mjs",
+    "svelte-kit": "node --experimental-loader ./svelte-kit-import-hook.mjs node_modules/vite/bin/vite.js",
     "test": "yarn mocha \"tests/src/**/*.ts\" --reporter dot --timeout 60000",
     "ts": "node -r esbuild-register",
     "update": "yarn ts ./tools/update.ts && yarn format-for-gen-file",
@@ -66,7 +66,7 @@
     "postcss-load-config": "^3.1.4",
     "postcss-safe-parser": "^6.0.0",
     "sourcemap-codec": "^1.4.8",
-    "svelte-eslint-parser": "^0.16.0"
+    "svelte-eslint-parser": "^0.17.0"
   },
   "devDependencies": {
     "@babel/core": "^7.16.0",
@@ -74,19 +74,25 @@
     "@babel/plugin-proposal-function-bind": "^7.16.7",
     "@babel/types": "^7.16.0",
     "@fontsource/fira-mono": "^4.5.0",
-    "@ota-meshi/eslint-plugin": "^0.11.0",
+    "@ota-meshi/eslint-plugin": "^0.11.3",
     "@sindresorhus/slugify": "^2.1.0",
     "@sveltejs/adapter-static": "^1.0.0-next.26",
     "@sveltejs/kit": "^1.0.0-next.360",
     "@types/babel__core": "^7.1.19",
+    "@types/cross-spawn": "^6.0.2",
+    "@types/escape-html": "^1.0.2",
     "@types/eslint": "^8.0.0",
     "@types/eslint-scope": "^3.7.0",
     "@types/eslint-visitor-keys": "^1.0.0",
-    "@types/estree": "^0.0.52",
+    "@types/estree": "^1.0.0",
     "@types/less": "^3.0.3",
+    "@types/markdown-it": "^12.2.3",
+    "@types/markdown-it-container": "^2.0.5",
+    "@types/markdown-it-emoji": "^2.0.2",
     "@types/mocha": "^9.0.0",
     "@types/node": "^16.0.0",
     "@types/postcss-safe-parser": "^5.0.1",
+    "@types/prismjs": "^1.26.0",
     "@types/stylus": "^0.48.38",
     "@typescript-eslint/eslint-plugin": "^5.4.0",
     "@typescript-eslint/parser": "^5.4.1-0",
@@ -99,10 +105,10 @@
     "eslint": "^8.0.0",
     "eslint-config-prettier": "^8.3.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
-    "eslint-plugin-eslint-plugin": "^4.0.0",
-    "eslint-plugin-json-schema-validator": "^3.0.0",
+    "eslint-plugin-eslint-plugin": "^5.0.0",
+    "eslint-plugin-json-schema-validator": "^4.0.0",
     "eslint-plugin-jsonc": "^2.0.0",
-    "eslint-plugin-markdown": "^2.1.0",
+    "eslint-plugin-markdown": "^3.0.0",
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-node-dependencies": "^0.9.0",
     "eslint-plugin-prettier": "^4.0.0",
@@ -119,7 +125,6 @@
     "mocha": "^10.0.0",
     "nyc": "^15.1.0",
     "pako": "^2.0.3",
-    "pirates": "^4.0.1",
     "postcss-nested": "^5.0.6",
     "prettier": "^2.2.1",
     "prettier-plugin-pkg": "^0.16.0",
@@ -134,8 +139,8 @@
     "svelte": "^3.46.1",
     "svelte-adapter-ghpages": "0.0.2",
     "typescript": "^4.5.2",
-    "vite": "^2.9.13",
-    "vite-plugin-svelte-md": "^0.1.3"
+    "vite": "^3.0.0-0",
+    "vite-plugin-svelte-md": "^0.1.5"
   },
   "publishConfig": {
     "access": "public"