eslint-plugin-stratified-design 0.5.0 → 0.5.2

package/lib/helpers/lowerLevelImports/1 layer.js

@@ -79,6 +79,7 @@ const reportHasProperLevelNumber = (context, options, rootDir, filePath) => {
    */
   return (node, modulePath) => {
     if (!options.useLevelNumber) return;
+    if (isNodeModule(rootDir)(modulePath)) return;
 
     const report = (messageId) =>
       reportError(context, rootDir, filePath)(node, messageId, modulePath);
@@ -98,16 +99,20 @@ const reportHasProperLevelNumber = (context, options, rootDir, filePath) => {
       return toPath(parent);
     })();
 
-    const { moduleLevel, isInterfaceError } = (() => {
+    const { moduleLevel, isBarrierError } = (() => {
       const segments = toSegments(toRelative(parentPath, modulePath));
-      const level = extractLevel(segments[1]);
+      const moduleLevel = extractLevel(segments[1]);
+      const isBarrierError =
+        segments.length === 2
+          ? false
+          : segments.some((seg) => extractLevel(seg) !== null);
       return {
-        moduleLevel: level,
-        isInterfaceError: segments.length > 2,
+        moduleLevel,
+        isBarrierError,
       };
     })();
 
-    if (isInterfaceError) {
+    if (isBarrierError) {
       report("barrier");
       return FINISHED;
     }
@@ -184,12 +189,15 @@ const reportHasProperLevel = (
 
     const isNodeModulePath = isNodeModule(rootDir)(modulePath);
 
+    const moduleLevel = findLevel(modulePath);
+
     if (fileLevel === null) {
-      if (!isNodeModulePath) report("not-registered:file");
+      if (moduleLevel !== null || !isNodeModulePath) {
+        report("not-registered:file");
+      }
       return FINISHED;
     }
 
-    const moduleLevel = findLevel(modulePath);
     if (moduleLevel === null) {
       if (!isNodeModulePath) report("not-registered:module");
       return FINISHED;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-stratified-design",
-  "version": "0.5.0",
+  "version": "0.5.2",
   "description": "ESlint rules for stratified design",
   "keywords": [
     "eslint",

package/tests/lib/rules/lower-level-imports.js

@@ -58,7 +58,7 @@ ruleTester.run("lower-level-imports", rule, {
       options: [{ structure, root: "./src", aliases: { "@/": "./src/" } }],
     },
     {
-      code: "import { func } from 'node-module'",
+      code: "import { func } from 'other-node-module'",
       filename: "./src/otherLayerA.js",
       options: [{ structure, root: "./src" }],
     },
@@ -170,6 +170,35 @@ ruleTester.run("lower-level-imports", rule, {
         },
       ],
     },
+    {
+      code: "import { func } from 'other-node-module'",
+      filename: "./src/1 otherLayerA.js",
+      options: [{ structure, root: "./src", useLevelNumber: true }],
+    },
+    {
+      code: "import { func } from 'node-module'",
+      filename: "./src/layer2/subLayer1/1 layer.js",
+      options: [
+        {
+          structure,
+          root: "./src",
+          aliases: { "@/": "./src/" },
+          useLevelNumber: true,
+        },
+      ],
+    },
+    {
+      code: "import { func } from '@/layer1/subLayer2/sub'",
+      filename: "./src/layer1/subLayer1/1 layer.js",
+      options: [
+        {
+          structure,
+          root: "./src",
+          aliases: { "@/": "./src/" },
+          useLevelNumber: true,
+        },
+      ],
+    },
   ],
   invalid: [
     {
@@ -310,5 +339,16 @@ ruleTester.run("lower-level-imports", rule, {
         },
       ],
     },
+    {
+      code: "import { func } from 'node-module'",
+      filename: "./src/layer3/subLayer1/1 layer.js",
+      options: [{ structure, root: "./src", useLevelNumber: true }],
+      errors: [
+        {
+          messageId: "not-lower-level",
+          data: { module: "node-module", file: "./layer3/subLayer1/1 layer" },
+        },
+      ],
+    },
   ],
 });