eslint-plugin-stratified-design 0.12.5 → 0.12.6

package/lib/rules/no-same-level-funcs.js

@@ -20,36 +20,97 @@ const { fromCwd, match } = require("../helpers/common");
  * @typedef {({[name: string]: number})} Levels
  */
 
+const hasArrFunction = (elements, levels) => {
+  return elements.reduce((hasFunc, element) => {
+    if (hasFunc) return true;
+    const type = element.type;
+    if (type === "FunctionExpression" || type === "ArrowFunctionExpression")
+      return true;
+    if (type === "ObjectExpression")
+      return hasObjFunction(element.properties, levels);
+    if (type === "ArrayExpression")
+      return hasArrFunction(element.elements, levels);
+    if ("name" in element && element.name in levels) return true;
+    return false;
+  }, false);
+};
+
+const hasObjFunction = (properties, levels) => {
+  return properties.reduce((hasFunc, property) => {
+    if (hasFunc) return true;
+    if (!("value" in property)) return false;
+    const type = property.value.type;
+    if (type === "FunctionExpression" || type === "ArrowFunctionExpression")
+      return true;
+    if (type === "ObjectExpression")
+      return hasObjFunction(property.value.properties, levels);
+    if (type === "ArrayExpression")
+      return hasArrFunction(property.value.elements, levels);
+    if ("name" in property.value && property.value.name in levels) return true;
+    return false;
+  }, false);
+};
+
+/**
+ * @param {Node | Token} nodeOrToken
+ */
+const deriveDeclaration = (nodeOrToken) => {
+  return (nodeOrToken.type === "ExportNamedDeclaration" ||
+    nodeOrToken.type === "ExportDefaultDeclaration") &&
+    Boolean(nodeOrToken.declaration)
+    ? nodeOrToken.declaration
+    : nodeOrToken;
+};
+
 /**
  * @param {Node | Token} nodeOrToken
  * @returns {string | null}
  */
 const deriveFuncName = (nodeOrToken) => {
-  const declaration =
-    (nodeOrToken.type === "ExportNamedDeclaration" ||
-      nodeOrToken.type === "ExportDefaultDeclaration") &&
-    Boolean(nodeOrToken.declaration)
-      ? nodeOrToken.declaration
-      : nodeOrToken;
-  const isFuncDeclaration = declaration.type === "FunctionDeclaration";
-  const isVarDeclaration =
-    declaration.type === "VariableDeclaration" &&
+  const declaration = deriveDeclaration(nodeOrToken);
+
+  if (declaration.type === "FunctionDeclaration") return declaration.id.name;
+  if (declaration.type !== "VariableDeclaration") return null;
+
+  const { init, id } = declaration.declarations[0];
+  if (
     [
       "ArrowFunctionExpression",
       "FunctionExpression",
       "CallExpression",
       "TaggedTemplateExpression",
-    ].includes(declaration.declarations[0].init.type);
-
-  if (isFuncDeclaration || isVarDeclaration) {
-    const name = isFuncDeclaration
-      ? declaration.id.name
-      : declaration.declarations[0].id.name;
-    return name;
+    ].includes(init.type)
+  ) {
+    return id.name;
   }
+
   return null;
 };
 
+/**
+ * @param {Node | Token} nodeOrToken
+ * @param {Levels} levels
+ * @returns {string | null}
+ */
+const deriveVarName = (nodeOrToken, levels) => {
+  const declaration = deriveDeclaration(nodeOrToken);
+  if (declaration.type !== "VariableDeclaration") return null;
+  const { init, id } = declaration.declarations[0];
+  if (
+    init.type === "ObjectExpression" &&
+    hasObjFunction(init.properties, levels)
+  ) {
+    return id.name;
+  } else if (
+    init.type === "ArrayExpression" &&
+    hasArrFunction(init.elements, levels)
+  ) {
+    return id.name;
+  } else {
+    return null;
+  }
+};
+
 /**
  * @param {SourceCode} sourceCode
  * @param {Node | Token} nodeOrToken
@@ -89,16 +150,24 @@ const isCalleeLowerLevel = (sourceCode, levels) => {
     if (calleeLevel === undefined) return true; // 호출되는 함수가 존재하지 않으면 true 리턴. 함수 내의 함수의 경우에는 항상 calleeLevel 이 undefined 이다.
 
     const caller = traceAncestor(sourceCode, node);
-    const callerLevel = deriveLevel(sourceCode, caller);
-    if (callerLevel < calleeLevel) return true;
+    const callerName = deriveFuncName(caller) || deriveVarName(caller, levels);
+    const callerLevel = levels[callerName];
 
-    const callerName = deriveFuncName(caller);
+    if (callerLevel === undefined) return true;
+    if (callerLevel < calleeLevel) return true;
     if (callerName === calleeName) return true; // recursive function
 
     return false;
   };
 };
 
+const deriveCalleeName = (callee) => {
+  if (callee.type === "Identifier") return callee.name;
+  if (callee.type === "MemberExpression")
+    return deriveCalleeName(callee.object);
+  return null;
+};
+
 /** @type {import('eslint').Rule.RuleModule} */
 module.exports = {
   meta: {
@@ -175,10 +244,11 @@ module.exports = {
       Program(node) {
         node.body.forEach((token) => {
           const name = deriveFuncName(token);
-          if (name) {
-            const level = deriveLevel(sourceCode, token);
-            levels[name] = level;
-          }
+          if (name !== null) levels[name] = deriveLevel(sourceCode, token);
+        });
+        node.body.forEach((token) => {
+          const name = deriveVarName(token, levels);
+          if (name !== null) levels[name] = deriveLevel(sourceCode, token);
         });
       },
       CallExpression(node) {
@@ -186,7 +256,7 @@ module.exports = {
           const isReported = report(node, name);
           if (isReported) return;
         }
-        report(node, node.callee.name);
+        report(node, deriveCalleeName(node.callee));
       },
       JSXOpeningElement(node) {
         report(node, node.name.name);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-stratified-design",
-  "version": "0.12.5",
+  "version": "0.12.6",
   "description": "ESlint rules for stratified design",
   "keywords": [
     "eslint",

package/tests/lib/rules/no-same-level-funcs.js

@@ -158,6 +158,66 @@ ruleTester.run("no-same-level-funcs", rule, {
       code: "/*@level 2*/const func = () => 'a'; /*@level 1*/const obj = { func: () => { func() } } ",
       filename: "./src/foo.js",
     },
+
+    {
+      code: "const func = () => 'a'; const obj = { a: func() } ",
+      filename: "./src/foo.js",
+    },
+    {
+      code: "/*@level 2*/const func = () => 'a'; /*@level 1*/const obj = { func: () => { func() } } ",
+      filename: "./src/foo.js",
+      errors: [{ messageId: "no-same-level-funcs", data: { func: "obj" } }],
+    },
+    {
+      code: "/*@level 2*/const obj = { func2: () => {} }; /*@level 1*/const func1 = () => { obj.func2() } ",
+      filename: "./src/foo.js",
+    },
+    {
+      code: "/*@level 2*/const obj = { func2(){} }; /*@level 1*/const func1 = () => { obj.func2() } ",
+      filename: "./src/foo.js",
+    },
+    {
+      code: "/*@level 3*/const func3 = () => 'a'; /*@level 2*/const obj = { func2: func3 }; /*@level 1*/const func1 = () => { obj.func2() } ",
+      filename: "./src/foo.js",
+      errors: [{ messageId: "no-same-level-funcs", data: { func: "obj" } }],
+    },
+
+    {
+      code: "const func = () => 'a'; const arr = [func()];",
+      filename: "./src/foo.js",
+    },
+    {
+      code: "/*@level 2*/const func = () => 'a'; /*@level 1*/const arr = [() => { func() }];",
+      filename: "./src/foo.js",
+    },
+    {
+      code: "/*@level 2*/const arr = [() => {}]; /*@level 1*/const func1 = () => { arr[0]() } ",
+      filename: "./src/foo.js",
+    },
+    {
+      code: "/*@level 3*/const func3 = () => 'a'; /*@level 2*/const arr = [func3]; /*@level 1*/const func1 = () => { arr[0]() } ",
+      filename: "./src/foo.js",
+    },
+    {
+      code: "import { func } from './module'; const arr = [{a: {b: {c: [func]}}}];",
+      filename: "./src/foo.js",
+    },
+    {
+      code: "const func = () => {}; const arr = [{a: {b: {c: [func]}}}];",
+      filename: "./src/foo.js",
+    },
+    {
+      code: "/*@level 3*/const func3 = () => {}; /*@level 2*/const arr = [{a: {b: {c: [func3]}}}]; /*@level 1*/const func1 = () => arr[0].a.b.c[0]();",
+      filename: "./src/foo.js",
+    },
+    {
+      code: "const obj2 = {}; const obj1 = {...obj2};",
+      filename: "./src/foo.js",
+    },
+    {
+      code: "const arr2 = []; const arr1 = [...arr2];",
+      filename: "./src/foo.js",
+    },
   ],
   invalid: [
     {
@@ -175,13 +235,11 @@ ruleTester.run("no-same-level-funcs", rule, {
       filename: "./src/foo.js",
       errors: [{ messageId: "no-same-level-funcs", data: { func: "func1" } }],
     },
-
     {
       code: "function func2(){ func1(); }; function func1(){}",
       filename: "./src/foo.js",
       errors: [{ messageId: "no-same-level-funcs", data: { func: "func1" } }],
     },
-
     {
       code: "export function func2(){ func1(); }; function func1(){}",
       filename: "./src/foo.js",
@@ -192,7 +250,6 @@ ruleTester.run("no-same-level-funcs", rule, {
       filename: "./src/foo.js",
       errors: [{ messageId: "no-same-level-funcs", data: { func: "func1" } }],
     },
-
     {
       code: "const func1 = () => {}; const func2 = () => { func1(); }",
       filename: "./src/foo.js",
@@ -203,7 +260,6 @@ ruleTester.run("no-same-level-funcs", rule, {
       filename: "./src/foo.js",
       errors: [{ messageId: "no-same-level-funcs", data: { func: "func1" } }],
     },
-
     {
       code: "const func1 = function(){}; const func2 = function(){ func1(); }",
       filename: "./src/foo.js",
@@ -214,7 +270,6 @@ ruleTester.run("no-same-level-funcs", rule, {
       filename: "./src/foo.js",
       errors: [{ messageId: "no-same-level-funcs", data: { func: "func1" } }],
     },
-
     {
       code: "const func1 = function func1(){}; const func2 = function func2(){ func1(); }",
       filename: "./src/foo.js",
@@ -225,7 +280,6 @@ ruleTester.run("no-same-level-funcs", rule, {
       filename: "./src/foo.js",
       errors: [{ messageId: "no-same-level-funcs", data: { func: "func1" } }],
     },
-
     {
       code: "const fn = () => 1; const value = fn()",
       filename: "./src/foo.js",
@@ -276,7 +330,6 @@ ruleTester.run("no-same-level-funcs", rule, {
       filename: "./src/foo.js",
       errors: [{ messageId: "no-same-level-funcs", data: { func: "func1" } }],
     },
-
     {
       code: "function func2(){};\n// @level 1\nfunction func1(){ func2(); }",
       filename: "./src/foo.js",
@@ -284,14 +337,45 @@ ruleTester.run("no-same-level-funcs", rule, {
     },
 
     {
-      code: "const func = () => 'a'; const obj = { a: func() } ",
+      code: "const func = () => 'a'; const obj = { func: () => { func() } };",
       filename: "./src/foo.js",
       errors: [{ messageId: "no-same-level-funcs", data: { func: "func" } }],
     },
     {
-      code: "const func = () => 'a'; const obj = { func: () => { func() } } ",
+      code: "const obj = { func2: () => {} }; const func1 = () => { obj.func2() } ",
+      filename: "./src/foo.js",
+      errors: [{ messageId: "no-same-level-funcs", data: { func: "obj" } }],
+    },
+    {
+      code: "const obj = { func2(){} }; const func1 = () => { obj.func2() } ",
+      filename: "./src/foo.js",
+      errors: [{ messageId: "no-same-level-funcs", data: { func: "obj" } }],
+    },
+    {
+      code: "const func3 = () => 'a'; const obj = { func2: func3 }; const func1 = () => { obj.func2() } ",
+      filename: "./src/foo.js",
+      errors: [{ messageId: "no-same-level-funcs", data: { func: "obj" } }],
+    },
+
+    {
+      code: "const func = () => 'a'; const arr = [() => { func() }];",
       filename: "./src/foo.js",
       errors: [{ messageId: "no-same-level-funcs", data: { func: "func" } }],
     },
+    {
+      code: "const arr = [() => {}]; const func1 = () => { arr[0]() } ",
+      filename: "./src/foo.js",
+      errors: [{ messageId: "no-same-level-funcs", data: { func: "arr" } }],
+    },
+    {
+      code: "const func3 = () => 'a'; const arr = [func3]; const func1 = () => { arr[0]() } ",
+      filename: "./src/foo.js",
+      errors: [{ messageId: "no-same-level-funcs", data: { func: "arr" } }],
+    },
+    {
+      code: "const func3 = () => {}; const arr = [{a: {b: {c: [func3]}}}]; const func1 = () => arr[0].a.b.c[0]();",
+      filename: "./src/foo.js",
+      errors: [{ messageId: "no-same-level-funcs", data: { func: "arr" } }],
+    },
   ],
 });