eslint-plugin-storybook 0.5.2 → 0.5.3

package/CHANGELOG.md

@@ -1,3 +1,16 @@
+# v0.5.3 (Fri Dec 03 2021)
+
+#### 🐛 Bug Fix
+
+- extend story-exports rule to support export lists, fixes #57 [#58](https://github.com/storybookjs/eslint-plugin-storybook/pull/58) (stephen@Stephens-MacBook-Air.local [@yannbf](https://github.com/yannbf))
+
+#### Authors: 2
+
+- Stephen Marsh ([@stephenhmarsh](https://github.com/stephenhmarsh))
+- Yann Braga ([@yannbf](https://github.com/yannbf))
+
+---
+
 # v0.5.2 (Thu Dec 02 2021)
 
 #### 🐛 Bug Fix

package/dist/rules/story-exports.js

@@ -3,11 +3,9 @@
  * @fileoverview A story file must contain at least one story export
  * @author Yann Braga
  */
-const csf_1 = require("@storybook/csf");
 const create_storybook_rule_1 = require("../utils/create-storybook-rule");
 const constants_1 = require("../utils/constants");
 const utils_1 = require("../utils");
-const ast_1 = require("../utils/ast");
 module.exports = (0, create_storybook_rule_1.createStorybookRule)({
     name: 'story-exports',
     defaultOptions: [],
@@ -30,7 +28,6 @@ module.exports = (0, create_storybook_rule_1.createStorybookRule)({
         //----------------------------------------------------------------------
         // Helpers
         //----------------------------------------------------------------------
-        const isValidStoryExport = (node) => (0, csf_1.isExportStory)(node.name, nonStoryExportsConfig) && node.name !== '__namedExportsOrder';
         //----------------------------------------------------------------------
         // Public
         //----------------------------------------------------------------------
@@ -54,22 +51,13 @@ module.exports = (0, create_storybook_rule_1.createStorybookRule)({
                 }
             },
             ExportNamedDeclaration: function (node) {
-                // if there are specifiers, node.declaration should be null
-                if (!node.declaration)
-                    return;
-                const decl = node.declaration;
-                if ((0, ast_1.isVariableDeclaration)(decl)) {
-                    const { id } = decl.declarations[0];
-                    if ((0, ast_1.isIdentifier)(id)) {
-                        namedExports.push(id);
-                    }
-                }
+                namedExports.push(...(0, utils_1.getAllNamedExports)(node));
             },
             'Program:exit': function (node) {
                 if (hasStoriesOfImport || !meta) {
                     return;
                 }
-                const storyExports = namedExports.filter(isValidStoryExport);
+                const storyExports = namedExports.filter((exp) => (0, utils_1.isValidStoryExport)(exp, nonStoryExportsConfig));
                 if (storyExports.length) {
                     return;
                 }

package/dist/utils/index.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.getDescriptor = exports.getMetaObjectExpression = exports.isPlayFunction = exports.docsUrl = void 0;
+exports.getAllNamedExports = exports.isValidStoryExport = exports.getDescriptor = exports.getMetaObjectExpression = exports.isPlayFunction = exports.docsUrl = void 0;
+const csf_1 = require("@storybook/csf");
 const ast_utils_1 = require("@typescript-eslint/experimental-utils/dist/ast-utils");
 const ast_1 = require("./ast");
 const docsUrl = (ruleName) => `https://github.com/storybookjs/eslint-plugin-storybook/blob/main/docs/rules/${ruleName}.md`;
@@ -47,3 +48,26 @@ const getDescriptor = (metaDeclaration, propertyName) => {
     }
 };
 exports.getDescriptor = getDescriptor;
+const isValidStoryExport = (node, nonStoryExportsConfig) => (0, csf_1.isExportStory)(node.name, nonStoryExportsConfig) && node.name !== '__namedExportsOrder';
+exports.isValidStoryExport = isValidStoryExport;
+const getAllNamedExports = (node) => {
+    // e.g. export { MyStory }
+    if (!node.declaration && node.specifiers) {
+        return node.specifiers.reduce((acc, specifier) => {
+            if ((0, ast_1.isIdentifier)(specifier.exported)) {
+                acc.push(specifier.exported);
+            }
+            return acc;
+        }, []);
+    }
+    const decl = node.declaration;
+    if ((0, ast_1.isVariableDeclaration)(decl)) {
+        const { id } = decl.declarations[0];
+        // e.g. export const MyStory
+        if ((0, ast_1.isIdentifier)(id)) {
+            return [id];
+        }
+    }
+    return [];
+};
+exports.getAllNamedExports = getAllNamedExports;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-storybook",
-  "version": "0.5.2",
+  "version": "0.5.3",
   "description": "Best practice rules for Storybook",
   "keywords": [
     "eslint",