eslint-plugin-sonarjs 0.22.0 → 0.23.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/LICENSE
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
GNU LESSER GENERAL PUBLIC LICENSE
|
|
2
2
|
Version 3, 29 June 2007
|
|
3
3
|
|
|
4
|
-
Copyright (C) 2007 Free Software Foundation, Inc. <
|
|
4
|
+
Copyright (C) 2007 Free Software Foundation, Inc. <https://fsf.org/>
|
|
5
5
|
Everyone is permitted to copy and distribute verbatim copies
|
|
6
6
|
of this license document, but changing it is not allowed.
|
|
7
7
|
|
|
@@ -51,7 +51,8 @@ function checkObjectInitialization(statements, context) {
|
|
|
51
51
|
const objectDeclaration = getObjectDeclaration(statements[index]);
|
|
52
52
|
// eslint-disable-next-line sonarjs/no-collapsible-if
|
|
53
53
|
if (objectDeclaration && (0, nodes_1.isIdentifier)(objectDeclaration.id)) {
|
|
54
|
-
|
|
54
|
+
const nextStmt = statements[index + 1];
|
|
55
|
+
if (isPropertyAssignment(nextStmt, objectDeclaration.id, context.getSourceCode())) {
|
|
55
56
|
context.report({ messageId: 'declarePropertiesInsideObject', node: objectDeclaration });
|
|
56
57
|
}
|
|
57
58
|
}
|
|
@@ -73,15 +74,19 @@ function isPropertyAssignment(statement, objectIdentifier, sourceCode) {
|
|
|
73
74
|
if ((0, nodes_1.isMemberExpression)(left)) {
|
|
74
75
|
return (!left.computed &&
|
|
75
76
|
isSingleLineExpression(right, sourceCode) &&
|
|
76
|
-
(0, equivalence_1.areEquivalent)(left.object, objectIdentifier, sourceCode)
|
|
77
|
+
(0, equivalence_1.areEquivalent)(left.object, objectIdentifier, sourceCode) &&
|
|
78
|
+
!isCircularReference(left, right, sourceCode));
|
|
77
79
|
}
|
|
78
80
|
}
|
|
79
81
|
return false;
|
|
80
|
-
|
|
81
|
-
|
|
82
|
-
|
|
83
|
-
|
|
84
|
-
|
|
82
|
+
function isSingleLineExpression(expression, sourceCode) {
|
|
83
|
+
const first = sourceCode.getFirstToken(expression).loc;
|
|
84
|
+
const last = sourceCode.getLastToken(expression).loc;
|
|
85
|
+
return first.start.line === last.end.line;
|
|
86
|
+
}
|
|
87
|
+
function isCircularReference(left, right, sourceCode) {
|
|
88
|
+
return (0, equivalence_1.areEquivalent)(left.object, right, sourceCode);
|
|
89
|
+
}
|
|
85
90
|
}
|
|
86
91
|
module.exports = rule;
|
|
87
92
|
//# sourceMappingURL=prefer-object-literal.js.map
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"prefer-object-literal.js","sourceRoot":"","sources":["../../src/rules/prefer-object-literal.ts"],"names":[],"mappings":";AAAA;;;;;;;;;;;;;;;;;;GAkBG;AACH,oDAAoD;AAGpD,0CAQwB;AACxB,sDAAqD;AACrD,gDAAwC;AAExC,MAAM,IAAI,GAA0C;IAClD,IAAI,EAAE;QACJ,QAAQ,EAAE;YACR,6BAA6B,EAC3B,yHAAyH;SAC5H;QACD,MAAM,EAAE,EAAE;QACV,IAAI,EAAE,YAAY;QAClB,IAAI,EAAE;YACJ,WAAW,EAAE,sCAAsC;YACnD,WAAW,EAAE,OAAO;YACpB,GAAG,EAAE,IAAA,kBAAO,EAAC,UAAU,CAAC;SACzB;KACF;IACD,MAAM,CAAC,OAAO;QACZ,OAAO;YACL,cAAc,EAAE,CAAC,IAAmB,EAAE,EAAE,CACtC,yBAAyB,CAAE,IAAgC,CAAC,IAAI,EAAE,OAAO,CAAC;YAC5E,OAAO,EAAE,CAAC,IAAmB,EAAE,EAAE;gBAC/B,MAAM,UAAU,GAAI,IAAyB,CAAC,IAAI,CAAC,MAAM,CACvD,CAAC,SAAS,EAAmC,EAAE,CAAC,CAAC,IAAA,2BAAmB,EAAC,SAAS,CAAC,CAChF,CAAC;gBACF,yBAAyB,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC;YACjD,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC;AAEF,SAAS,yBAAyB,CAChC,UAAgC,EAChC,OAA+C;IAE/C,IAAI,KAAK,GAAG,CAAC,CAAC;IACd,OAAO,KAAK,GAAG,UAAU,CAAC,MAAM,GAAG,CAAC,EAAE;QACpC,MAAM,iBAAiB,GAAG,oBAAoB,CAAC,UAAU,CAAC,KAAK,CAAC,CAAC,CAAC;QAClE,qDAAqD;QACrD,IAAI,iBAAiB,IAAI,IAAA,oBAAY,EAAC,iBAAiB,CAAC,EAAE,CAAC,EAAE;YAC3D,
|
|
1
|
+
{"version":3,"file":"prefer-object-literal.js","sourceRoot":"","sources":["../../src/rules/prefer-object-literal.ts"],"names":[],"mappings":";AAAA;;;;;;;;;;;;;;;;;;GAkBG;AACH,oDAAoD;AAGpD,0CAQwB;AACxB,sDAAqD;AACrD,gDAAwC;AAExC,MAAM,IAAI,GAA0C;IAClD,IAAI,EAAE;QACJ,QAAQ,EAAE;YACR,6BAA6B,EAC3B,yHAAyH;SAC5H;QACD,MAAM,EAAE,EAAE;QACV,IAAI,EAAE,YAAY;QAClB,IAAI,EAAE;YACJ,WAAW,EAAE,sCAAsC;YACnD,WAAW,EAAE,OAAO;YACpB,GAAG,EAAE,IAAA,kBAAO,EAAC,UAAU,CAAC;SACzB;KACF;IACD,MAAM,CAAC,OAAO;QACZ,OAAO;YACL,cAAc,EAAE,CAAC,IAAmB,EAAE,EAAE,CACtC,yBAAyB,CAAE,IAAgC,CAAC,IAAI,EAAE,OAAO,CAAC;YAC5E,OAAO,EAAE,CAAC,IAAmB,EAAE,EAAE;gBAC/B,MAAM,UAAU,GAAI,IAAyB,CAAC,IAAI,CAAC,MAAM,CACvD,CAAC,SAAS,EAAmC,EAAE,CAAC,CAAC,IAAA,2BAAmB,EAAC,SAAS,CAAC,CAChF,CAAC;gBACF,yBAAyB,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC;YACjD,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC;AAEF,SAAS,yBAAyB,CAChC,UAAgC,EAChC,OAA+C;IAE/C,IAAI,KAAK,GAAG,CAAC,CAAC;IACd,OAAO,KAAK,GAAG,UAAU,CAAC,MAAM,GAAG,CAAC,EAAE;QACpC,MAAM,iBAAiB,GAAG,oBAAoB,CAAC,UAAU,CAAC,KAAK,CAAC,CAAC,CAAC;QAClE,qDAAqD;QACrD,IAAI,iBAAiB,IAAI,IAAA,oBAAY,EAAC,iBAAiB,CAAC,EAAE,CAAC,EAAE;YAC3D,MAAM,QAAQ,GAAG,UAAU,CAAC,KAAK,GAAG,CAAC,CAAC,CAAC;YACvC,IAAI,oBAAoB,CAAC,QAAQ,EAAE,iBAAiB,CAAC,EAAE,EAAE,OAAO,CAAC,aAAa,EAAE,CAAC,EAAE;gBACjF,OAAO,CAAC,MAAM,CAAC,EAAE,SAAS,EAAE,+BAA+B,EAAE,IAAI,EAAE,iBAAiB,EAAE,CAAC,CAAC;aACzF;SACF;QACD,KAAK,EAAE,CAAC;KACT;AACH,CAAC;AAED,SAAS,oBAAoB,CAAC,SAA6B;IACzD,IAAI,IAAA,6BAAqB,EAAC,SAAS,CAAC,EAAE;QACpC,OAAO,SAAS,CAAC,YAAY,CAAC,IAAI,CAChC,WAAW,CAAC,EAAE,CAAC,CAAC,CAAC,WAAW,CAAC,IAAI,IAAI,uBAAuB,CAAC,WAAW,CAAC,IAAI,CAAC,CAC/E,CAAC;KACH;IACD,OAAO,SAAS,CAAC;AACnB,CAAC;AAED,SAAS,uBAAuB,CAAC,UAA+B;IAC9D,OAAO,IAAA,0BAAkB,EAAC,UAAU,CAAC,IAAI,UAAU,CAAC,UAAU,CAAC,MAAM,KAAK,CAAC,CAAC;AAC9E,CAAC;AAED,SAAS,oBAAoB,CAC3B,SAA6B,EAC7B,gBAAqC,EACrC,UAA+B;IAE/B,IAAI,IAAA,6BAAqB,EAAC,SAAS,CAAC,IAAI,IAAA,8BAAsB,EAAC,SAAS,CAAC,UAAU,CAAC,EAAE;QACpF,MAAM,EAAE,IAAI,EAAE,KAAK,EAAE,GAAG,SAAS,CAAC,UAAU,CAAC;QAC7C,IAAI,IAAA,0BAAkB,EAAC,IAAI,CAAC,EAAE;YAC5B,OAAO,CACL,CAAC,IAAI,CAAC,QAAQ;gBACd,sBAAsB,CAAC,KAAK,EAAE,UAAU,CAAC;gBACzC,IAAA,2BAAa,EAAC,IAAI,CAAC,MAAM,EAAE,gBAAgB,EAAE,UAAU,CAAC;gBACxD,CAAC,mBAAmB,CAAC,IAAI,EAAE,KAAK,EAAE,UAAU,CAAC,CAC9C,CAAC;SACH;KACF;IACD,OAAO,KAAK,CAAC;IAEb,SAAS,sBAAsB,CAC7B,UAA+B,EAC/B,UAA+B;QAE/B,MAAM,KAAK,GAAG,UAAU,CAAC,aAAa,CAAC,UAAU,CAAE,CAAC,GAAG,CAAC;QACxD,MAAM,IAAI,GAAG,UAAU,CAAC,YAAY,CAAC,UAAU,CAAE,CAAC,GAAG,CAAC;QACtD,OAAO,KAAK,CAAC,KAAK,CAAC,IAAI,KAAK,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC;IAC5C,CAAC;IAED,SAAS,mBAAmB,CAC1B,IAA+B,EAC/B,KAA0B,EAC1B,UAA+B;QAE/B,OAAO,IAAA,2BAAa,EAAC,IAAI,CAAC,MAAM,EAAE,KAAK,EAAE,UAAU,CAAC,CAAC;IACvD,CAAC;AACH,CAAC;AAED,iBAAS,IAAI,CAAC"}
|
package/package.json
CHANGED
|
@@ -1,11 +1,11 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "eslint-plugin-sonarjs",
|
|
3
|
-
"version": "0.
|
|
3
|
+
"version": "0.23.0",
|
|
4
4
|
"description": "SonarJS rules for ESLint",
|
|
5
5
|
"main": "lib/index.js",
|
|
6
6
|
"types": "lib/index.d.ts",
|
|
7
7
|
"repository": "git@github.com:SonarSource/eslint-plugin-sonarjs.git",
|
|
8
|
-
"license": "LGPL-3.0",
|
|
8
|
+
"license": "LGPL-3.0-only",
|
|
9
9
|
"keywords": [
|
|
10
10
|
"sonarjs",
|
|
11
11
|
"eslint",
|
|
@@ -51,7 +51,7 @@
|
|
|
51
51
|
"eslint-config-prettier": "8.5.0",
|
|
52
52
|
"eslint-plugin-import": "2.26.0",
|
|
53
53
|
"eslint-plugin-notice": "0.9.10",
|
|
54
|
-
"eslint-plugin-sonarjs": "0.
|
|
54
|
+
"eslint-plugin-sonarjs": "0.22.0",
|
|
55
55
|
"jest": "29.5.0",
|
|
56
56
|
"jest-sonar-reporter": "2.0.0",
|
|
57
57
|
"lint-staged": "13.0.3",
|