eslint-plugin-sonarjs 0.19.0 → 0.20.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
|
@@ -1,4 +1,10 @@
|
|
|
1
1
|
import type { TSESLint } from '@typescript-eslint/experimental-utils';
|
|
2
|
-
declare type Options =
|
|
2
|
+
declare type Options = [{
|
|
3
|
+
threshold?: number;
|
|
4
|
+
ignoreStrings?: string;
|
|
5
|
+
} | undefined, 'sonar-runtime'] | [{
|
|
6
|
+
threshold?: number;
|
|
7
|
+
ignoreStrings?: string;
|
|
8
|
+
} | undefined];
|
|
3
9
|
declare const rule: TSESLint.RuleModule<string, Options>;
|
|
4
10
|
export = rule;
|
|
@@ -23,6 +23,7 @@ const docs_url_1 = require("../utils/docs-url");
|
|
|
23
23
|
const locations_1 = require("../utils/locations");
|
|
24
24
|
// Number of times a literal must be duplicated to trigger an issue
|
|
25
25
|
const DEFAULT_THRESHOLD = 3;
|
|
26
|
+
const DEFAULT_IGNORE_STRINGS = 'application/json';
|
|
26
27
|
const MIN_LENGTH = 10;
|
|
27
28
|
const NO_SEPARATOR_REGEXP = /^\w*$/;
|
|
28
29
|
const EXCLUDED_CONTEXTS = [
|
|
@@ -46,13 +47,20 @@ const rule = {
|
|
|
46
47
|
url: (0, docs_url_1.default)(__filename),
|
|
47
48
|
},
|
|
48
49
|
schema: [
|
|
49
|
-
{
|
|
50
|
+
{
|
|
51
|
+
type: 'object',
|
|
52
|
+
properties: {
|
|
53
|
+
threshold: { type: 'integer', minimum: 2 },
|
|
54
|
+
ignoreStrings: { type: 'string', default: DEFAULT_IGNORE_STRINGS },
|
|
55
|
+
},
|
|
56
|
+
},
|
|
50
57
|
{ enum: ['sonar-runtime'] /* internal parameter for rules having secondary locations */ },
|
|
51
58
|
],
|
|
52
59
|
},
|
|
53
60
|
create(context) {
|
|
54
61
|
const literalsByValue = new Map();
|
|
55
|
-
const threshold
|
|
62
|
+
const { threshold, ignoreStrings } = extractOptions(context);
|
|
63
|
+
const whitelist = ignoreStrings.split(',');
|
|
56
64
|
return {
|
|
57
65
|
Literal: (node) => {
|
|
58
66
|
const literal = node;
|
|
@@ -61,7 +69,8 @@ const rule = {
|
|
|
61
69
|
parent &&
|
|
62
70
|
!['ExpressionStatement', 'TSLiteralType'].includes(parent.type)) {
|
|
63
71
|
const stringContent = literal.value.trim();
|
|
64
|
-
if (!
|
|
72
|
+
if (!whitelist.includes(literal.value) &&
|
|
73
|
+
!isExcludedByUsageContext(context, literal) &&
|
|
65
74
|
stringContent.length >= MIN_LENGTH &&
|
|
66
75
|
!stringContent.match(NO_SEPARATOR_REGEXP)) {
|
|
67
76
|
const sameStringLiterals = literalsByValue.get(stringContent) || [];
|
|
@@ -99,5 +108,17 @@ function isRequireContext(parent, context) {
|
|
|
99
108
|
function isObjectPropertyKey(parent, literal) {
|
|
100
109
|
return parent.type === 'Property' && parent.key === literal;
|
|
101
110
|
}
|
|
111
|
+
function extractOptions(context) {
|
|
112
|
+
let threshold = DEFAULT_THRESHOLD;
|
|
113
|
+
let ignoreStrings = DEFAULT_IGNORE_STRINGS;
|
|
114
|
+
const options = context.options[0];
|
|
115
|
+
if (typeof (options === null || options === void 0 ? void 0 : options.threshold) === 'number') {
|
|
116
|
+
threshold = options.threshold;
|
|
117
|
+
}
|
|
118
|
+
if (typeof (options === null || options === void 0 ? void 0 : options.ignoreStrings) === 'string') {
|
|
119
|
+
ignoreStrings = options.ignoreStrings;
|
|
120
|
+
}
|
|
121
|
+
return { threshold, ignoreStrings };
|
|
122
|
+
}
|
|
102
123
|
module.exports = rule;
|
|
103
124
|
//# sourceMappingURL=no-duplicate-string.js.map
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"no-duplicate-string.js","sourceRoot":"","sources":["../../src/rules/no-duplicate-string.ts"],"names":[],"mappings":";AAAA;;;;;;;;;;;;;;;;;;GAkBG;AACH,oDAAoD;AAGpD,gDAAwC;AACxC,kDAA2D;AAE3D,mEAAmE;AACnE,MAAM,iBAAiB,GAAG,CAAC,CAAC;AAC5B,MAAM,UAAU,GAAG,EAAE,CAAC;AACtB,MAAM,mBAAmB,GAAG,OAAO,CAAC;AACpC,MAAM,iBAAiB,GAAG;IACxB,mBAAmB;IACnB,kBAAkB;IAClB,cAAc;IACd,sBAAsB;IACtB,wBAAwB;CACzB,CAAC;AACF,MAAM,OAAO,GAAG,wEAAwE,CAAC;
|
|
1
|
+
{"version":3,"file":"no-duplicate-string.js","sourceRoot":"","sources":["../../src/rules/no-duplicate-string.ts"],"names":[],"mappings":";AAAA;;;;;;;;;;;;;;;;;;GAkBG;AACH,oDAAoD;AAGpD,gDAAwC;AACxC,kDAA2D;AAE3D,mEAAmE;AACnE,MAAM,iBAAiB,GAAG,CAAC,CAAC;AAC5B,MAAM,sBAAsB,GAAG,kBAAkB,CAAC;AAClD,MAAM,UAAU,GAAG,EAAE,CAAC;AACtB,MAAM,mBAAmB,GAAG,OAAO,CAAC;AACpC,MAAM,iBAAiB,GAAG;IACxB,mBAAmB;IACnB,kBAAkB;IAClB,cAAc;IACd,sBAAsB;IACtB,wBAAwB;CACzB,CAAC;AACF,MAAM,OAAO,GAAG,wEAAwE,CAAC;AAOzF,MAAM,IAAI,GAAyC;IACjD,IAAI,EAAE;QACJ,QAAQ,EAAE;YACR,cAAc,EAAE,OAAO;YACvB,YAAY,EAAE,sBAAsB;SACrC;QACD,IAAI,EAAE,YAAY;QAClB,IAAI,EAAE;YACJ,WAAW,EAAE,0CAA0C;YACvD,WAAW,EAAE,OAAO;YACpB,GAAG,EAAE,IAAA,kBAAO,EAAC,UAAU,CAAC;SACzB;QACD,MAAM,EAAE;YACN;gBACE,IAAI,EAAE,QAAQ;gBACd,UAAU,EAAE;oBACV,SAAS,EAAE,EAAE,IAAI,EAAE,SAAS,EAAE,OAAO,EAAE,CAAC,EAAE;oBAC1C,aAAa,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE,OAAO,EAAE,sBAAsB,EAAE;iBACnE;aACF;YACD,EAAE,IAAI,EAAE,CAAC,eAAe,CAAC,CAAC,6DAA6D,EAAE;SAC1F;KACF;IAED,MAAM,CAAC,OAAO;QACZ,MAAM,eAAe,GAAoC,IAAI,GAAG,EAAE,CAAC;QACnE,MAAM,EAAE,SAAS,EAAE,aAAa,EAAE,GAAG,cAAc,CAAC,OAAO,CAAC,CAAC;QAC7D,MAAM,SAAS,GAAG,aAAa,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC;QAC3C,OAAO;YACL,OAAO,EAAE,CAAC,IAAmB,EAAE,EAAE;gBAC/B,MAAM,OAAO,GAAG,IAAwB,CAAC;gBACzC,MAAM,EAAE,MAAM,EAAE,GAAG,OAAO,CAAC;gBAC3B,IACE,OAAO,OAAO,CAAC,KAAK,KAAK,QAAQ;oBACjC,MAAM;oBACN,CAAC,CAAC,qBAAqB,EAAE,eAAe,CAAC,CAAC,QAAQ,CAAC,MAAM,CAAC,IAAI,CAAC,EAC/D;oBACA,MAAM,aAAa,GAAG,OAAO,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC;oBAE3C,IACE,CAAC,SAAS,CAAC,QAAQ,CAAC,OAAO,CAAC,KAAK,CAAC;wBAClC,CAAC,wBAAwB,CAAC,OAAO,EAAE,OAAO,CAAC;wBAC3C,aAAa,CAAC,MAAM,IAAI,UAAU;wBAClC,CAAC,aAAa,CAAC,KAAK,CAAC,mBAAmB,CAAC,EACzC;wBACA,MAAM,kBAAkB,GAAG,eAAe,CAAC,GAAG,CAAC,aAAa,CAAC,IAAI,EAAE,CAAC;wBACpE,kBAAkB,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;wBACjC,eAAe,CAAC,GAAG,CAAC,aAAa,EAAE,kBAAkB,CAAC,CAAC;qBACxD;iBACF;YACH,CAAC;YAED,cAAc;gBACZ,eAAe,CAAC,OAAO,CAAC,QAAQ,CAAC,EAAE;oBACjC,IAAI,QAAQ,CAAC,MAAM,IAAI,SAAS,EAAE;wBAChC,MAAM,CAAC,WAAW,EAAE,GAAG,cAAc,CAAC,GAAG,QAAQ,CAAC;wBAClD,MAAM,eAAe,GAAG,cAAc,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAChD,IAAA,yBAAa,EAAC,IAAI,CAAC,GAAG,EAAE,IAAI,CAAC,GAAG,EAAE,aAAa,CAAC,CACjD,CAAC;wBACF,IAAA,kBAAM,EACJ,OAAO,EACP;4BACE,SAAS,EAAE,gBAAgB;4BAC3B,IAAI,EAAE,WAAW;4BACjB,IAAI,EAAE,EAAE,KAAK,EAAE,QAAQ,CAAC,MAAM,CAAC,QAAQ,EAAE,EAAE;yBAC5C,EACD,eAAe,EACf,OAAO,CACR,CAAC;qBACH;gBACH,CAAC,CAAC,CAAC;YACL,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC;AAEF,SAAS,wBAAwB,CAAC,OAAgB,EAAE,OAAyB;IAC3E,MAAM,MAAM,GAAG,OAAO,CAAC,MAAO,CAAC;IAC/B,MAAM,UAAU,GAAG,MAAM,CAAC,IAAI,CAAC;IAE/B,OAAO,CACL,iBAAiB,CAAC,QAAQ,CAAC,UAAU,CAAC;QACtC,gBAAgB,CAAC,MAAM,EAAE,OAAO,CAAC;QACjC,mBAAmB,CAAC,MAAM,EAAE,OAAO,CAAC,CACrC,CAAC;AACJ,CAAC;AAED,SAAS,gBAAgB,CAAC,MAAqB,EAAE,OAAgB;IAC/D,OAAO,CACL,MAAM,CAAC,IAAI,KAAK,gBAAgB,IAAI,OAAO,CAAC,aAAa,EAAE,CAAC,OAAO,CAAC,MAAM,CAAC,MAAM,CAAC,KAAK,SAAS,CACjG,CAAC;AACJ,CAAC;AAED,SAAS,mBAAmB,CAAC,MAAqB,EAAE,OAAyB;IAC3E,OAAO,MAAM,CAAC,IAAI,KAAK,UAAU,IAAI,MAAM,CAAC,GAAG,KAAK,OAAO,CAAC;AAC9D,CAAC;AAED,SAAS,cAAc,CAAC,OAAgB;IACtC,IAAI,SAAS,GAAW,iBAAiB,CAAC;IAC1C,IAAI,aAAa,GAAW,sBAAsB,CAAC;IACnD,MAAM,OAAO,GAAG,OAAO,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC;IACnC,IAAI,OAAO,CAAA,OAAO,aAAP,OAAO,uBAAP,OAAO,CAAE,SAAS,CAAA,KAAK,QAAQ,EAAE;QAC1C,SAAS,GAAG,OAAO,CAAC,SAAS,CAAC;KAC/B;IACD,IAAI,OAAO,CAAA,OAAO,aAAP,OAAO,uBAAP,OAAO,CAAE,aAAa,CAAA,KAAK,QAAQ,EAAE;QAC9C,aAAa,GAAG,OAAO,CAAC,aAAa,CAAC;KACvC;IACD,OAAO,EAAE,SAAS,EAAE,aAAa,EAAE,CAAC;AACtC,CAAC;AAED,iBAAS,IAAI,CAAC"}
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "eslint-plugin-sonarjs",
|
|
3
|
-
"version": "0.
|
|
3
|
+
"version": "0.20.0",
|
|
4
4
|
"description": "SonarJS rules for ESLint",
|
|
5
5
|
"main": "lib/index.js",
|
|
6
6
|
"types": "lib/index.d.ts",
|
|
@@ -51,7 +51,7 @@
|
|
|
51
51
|
"eslint-config-prettier": "8.5.0",
|
|
52
52
|
"eslint-plugin-import": "2.26.0",
|
|
53
53
|
"eslint-plugin-notice": "0.9.10",
|
|
54
|
-
"eslint-plugin-sonarjs": "0.
|
|
54
|
+
"eslint-plugin-sonarjs": "0.19.0",
|
|
55
55
|
"jest": "28.1.3",
|
|
56
56
|
"jest-sonar-reporter": "2.0.0",
|
|
57
57
|
"lint-staged": "13.0.3",
|