eslint-plugin-smarthr 6.1.0 → 6.2.0

package/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+## [6.2.0](https://github.com/kufu/tamatebako/compare/eslint-plugin-smarthr-v6.1.0...eslint-plugin-smarthr-v6.2.0) (2026-01-29)
+
+
+### Features
+
+* **best-practice-for-interactive-element:** 特定の要素・コンポーネントに対してrole属性の設定を共用する条件を追加 ([#1031](https://github.com/kufu/tamatebako/issues/1031)) ([1bf4c67](https://github.com/kufu/tamatebako/commit/1bf4c679e767edf169de53c89d7ac69c4873b1e1))
+
 ## [6.1.0](https://github.com/kufu/tamatebako/compare/eslint-plugin-smarthr-v6.0.2...eslint-plugin-smarthr-v6.1.0) (2026-01-29)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-smarthr",
-  "version": "6.1.0",
+  "version": "6.2.0",
   "author": "SmartHR",
   "license": "MIT",
   "description": "A sharable ESLint plugin for SmartHR",
@@ -37,5 +37,5 @@
     "eslintplugin",
     "smarthr"
   ],
-  "gitHead": "1b4d368c3cdf3b637b8f4866638b2b8bc261f3ca"
+  "gitHead": "aed30ef2313795136134408db0ab4fb88dd49d02"
 }

package/rules/best-practice-for-interactive-element/index.js

@@ -32,6 +32,13 @@ const INTERACTIVE_COMPONENT_NAMES = `(${[
 const INTERACTIVE_ON_REGEX = /^on(Change|Input|Focus|Blur|(Double)?Click|Key(Down|Up|Press)|Mouse(Enter|Over|Down|Up|Leave)|Select|Submit)$/
 const DELEGATE_REGEX = /(d|D)elegate/
 
+const ARROW_ROLES = {
+  '((^i|I)nput|(^c|C)heck(b|B)ox)$': 'switch',
+  '(^i|I)nput$': 'combobox',
+  '(^b|B)utton$': 'option',
+}
+const NOT_ARROW_ROLE_ATTRIBUTES = Object.entries(ARROW_ROLES).reduce((prev, [key, value]) => `${prev}:not([parent.name.name=/${key}/][value.value="${value}"])`, '')
+
 const ELEMENT_HAS_ROLE_ATTRIBUTE = 'JSXOpeningElement:has(JSXAttribute[name.name="role"])'
 const AS_FORM_PART_ATTRIBUTE = 'JSXAttribute[name.name=/^(as|forwardedAs)$/][value.value=/^f(orm|ieldset)$/]'
 
@@ -59,7 +66,7 @@ module.exports = {
     const targetNameProp = `[name.name=${interactiveComponentRegex}]`
 
     return {
-      [`JSXOpeningElement${targetNameProp}>JSXAttribute[name.name="role"]:not([parent.name.name=/(^c|C)heck(b|B)ox$/][value.value="switch"])`]: (node) => {
+      [`JSXOpeningElement${targetNameProp}>JSXAttribute[name.name="role"]${NOT_ARROW_ROLE_ATTRIBUTES}`]: (node) => {
         context.report({
           node: node.parent,
           message: `${node.parent.name.name}にrole属性は指定しないでください。

package/test/best-practice-for-interactive-element.js

@@ -69,6 +69,9 @@ ruleTester.run('best-practice-for-interactive-element', rule, {
     { code: `<Stack onSubmit={hoge.fuga.delegateAny.piyo} />` },
     { code: `<Stack onSubmit={(a, delegateEvent, b) => {}} />` },
     { code: `<HogeCheckbox role="switch" />` },
+    { code: `<HogeInput role="switch" />` },
+    { code: `<input role="combobox" />` },
+    { code: `<FugaButton role="option" />` },
   ],
   invalid: [
     { code: `<button role="presentation">...</button>`, errors: [{ message: interactiveError('button') }] },
@@ -79,6 +82,9 @@ ruleTester.run('best-practice-for-interactive-element', rule, {
     { code: `<CrewDetail onChange={onChange} />`, errors: [{ message: uninteractiveError('CrewDetail') }] },
     { code: `<Stack onSubmit={onSubmit} />`, errors: [{ message: uninteractiveError('Stack') }] },
     { code: `<HogeCheckbox role="any" />`, errors: [{ message: interactiveError('HogeCheckbox') }] },
+    { code: `<HogeInput role="any" />`, errors: [{ message: interactiveError('HogeInput') }] },
+    { code: `<input role="any" />`, errors: [{ message: interactiveError('input') }] },
+    { code: `<FugaButton role="any" />`, errors: [{ message: interactiveError('FugaButton') }] },
   ]
 })