eslint-plugin-smarthr 4.0.0 → 4.0.1

package/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+## [4.0.1](https://github.com/kufu/tamatebako/compare/eslint-plugin-smarthr-v4.0.0...eslint-plugin-smarthr-v4.0.1) (2026-01-04)
+
+
+### Bug Fixes
+
+* **best-practice-for-spread-syntax:** 関数に対してspread syntaxで引数を渡すパターンが誤検知される問題を修正 ([#999](https://github.com/kufu/tamatebako/issues/999)) ([3f4a163](https://github.com/kufu/tamatebako/commit/3f4a163b183305922651612d7945434dcb5fa991))
+
 ## [4.0.0](https://github.com/kufu/tamatebako/compare/eslint-plugin-smarthr-v3.5.1...eslint-plugin-smarthr-v4.0.0) (2026-01-04)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-smarthr",
-  "version": "4.0.0",
+  "version": "4.0.1",
   "author": "SmartHR",
   "license": "MIT",
   "description": "A sharable ESLint plugin for SmartHR",
@@ -26,7 +26,7 @@
     "json5": "^2.2.3"
   },
   "devDependencies": {
-    "typescript-eslint": "^8.50.1"
+    "typescript-eslint": "^8.51.0"
   },
   "peerDependencies": {
     "eslint": "^9"
@@ -37,5 +37,5 @@
     "eslintplugin",
     "smarthr"
   ],
-  "gitHead": "f08245ba8257aa3587aa30b0024cb617638df74c"
+  "gitHead": "8dd34c6f8ed86887e4287f55b2b511e340291b32"
 }

package/rules/best-practice-for-spread-syntax/index.js

@@ -16,13 +16,16 @@ const CHECK_OBJ_REGEX = /^(always|only-object)$/
 const getInsertIndex = (node, type, attributesKey) => {
   const attributes = node.parent[attributesKey]
 
-  for (let i = 0; i < attributes.length; i++) {
-    const a = attributes[i]
+  // HINT: 関数のspread elementの場合などは除外したいので属性がない場合に対応
+  if (attributes) {
+    for (let i = 0; i < attributes.length; i++) {
+      const a = attributes[i]
 
-    if (a === node) {
-      return -1
-    } else if (a.type !== type) {
-      return i
+      if (a === node) {
+        return -1
+      } else if (a.type !== type) {
+        return i
+      }
     }
   }
 

package/test/best-practice-for-spread-syntax.js

@@ -20,6 +20,7 @@ ruleTester.run('best-practice-for-spread-syntax', rule, {
     { code: `<Fuga {...props1} {...props2} id="ABC" />` },
     { code: `const hoge = { ...props, id: props.id || 'ABC' }` },
     { code: `const hoge = { ...props1, ...props2, id: 'ABC' }` },
+    { code: `dig(target, ...keys.slice(1))` },
   ],
   invalid: [
     {