eslint-plugin-smarthr 3.3.0 → 3.3.1

package/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+## [3.3.1](https://github.com/kufu/tamatebako/compare/eslint-plugin-smarthr-v3.3.0...eslint-plugin-smarthr-v3.3.1) (2025-12-19)
+
+
+### Bug Fixes
+
+* smarthr/best-practice-for-rest-parametersの誤検知を修正 ([#959](https://github.com/kufu/tamatebako/issues/959)) ([12d2018](https://github.com/kufu/tamatebako/commit/12d20189c5f697b74751169925a063b8c67b4edb))
+
 ## [3.3.0](https://github.com/kufu/tamatebako/compare/eslint-plugin-smarthr-v3.2.0...eslint-plugin-smarthr-v3.3.0) (2025-12-18)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-smarthr",
-  "version": "3.3.0",
+  "version": "3.3.1",
   "author": "SmartHR",
   "license": "MIT",
   "description": "A sharable ESLint plugin for SmartHR",
@@ -37,5 +37,5 @@
     "eslintplugin",
     "smarthr"
   ],
-  "gitHead": "61261c2334b39d607b47e1f5be64fdb74f4ac83f"
+  "gitHead": "7390a378bca7e0f44fa90cb2a983cc807dc6c403"
 }

package/rules/best-practice-for-rest-parameters/index.js

@@ -9,6 +9,15 @@ module.exports = {
     schema: SCHEMA,
   },
   create(context) {
+    const restAction = (node) => {
+      context.report({
+        node,
+        message: `残余引数以外に 'rest' という名称を利用しないでください
+ - 詳細: https://github.com/kufu/tamatebako/tree/master/packages/eslint-plugin-smarthr/rules/best-practice-for-rest-parameters
+ - 残余引数(rest parameters)と混同する可能性があるため別の名称に修正してください`,
+      });
+    }
+
     return {
       [`RestElement[argument.name='props']`]: (node) => {
         context.report({
@@ -18,14 +27,8 @@ module.exports = {
  - 'rest' という名称を推奨します`,
         });
       },
-      [`:not(RestElement)>Identifier[name='rest']`]: (node) => {
-        context.report({
-          node,
-          message: `残余引数以外に 'rest' という名称を利用しないでください
- - 詳細: https://github.com/kufu/tamatebako/tree/master/packages/eslint-plugin-smarthr/rules/best-practice-for-rest-parameters
- - 残余引数(rest parameters)と混同する可能性があるため別の名称に修正してください`,
-        });
-      },
+      [`:not(:matches(RestElement,JSXSpreadAttribute,ObjectPattern>Property,ObjectExpression>Property))>Identifier[name='rest']`]: restAction,
+      [`:matches(ObjectPattern>Property[value.name='rest'],ObjectExpression>Property[key.name='rest'])`]: restAction,
     }
   },
 }

package/test/best-practice-for-rest-parameters.js

@@ -27,13 +27,18 @@ ruleTester.run('best-practice-for-rest-parameters', rule, {
     { code: `const hoge = (props) => {}` },
     { code: `const props = {}` },
     { code: `const hogeRest = {}` },
+    { code: `const hoge = { fuga: rest }` },
+    { code: `<Any {...rest} />` },
   ],
   invalid: [
     { code: `const hoge = (a, b, ...props) => {}`, errors: [ { message: ERROR_PROPS } ] },
     { code: `const hoge = ({ a, b, ...props }) => {}`, errors: [ { message: ERROR_PROPS } ] },
     { code: `const hoge = (rest) => {}`, errors: [ { message: ERROR_REST } ] },
     { code: `const hoge = (a, b, rest) => {}`, errors: [ { message: ERROR_REST } ] },
+    { code: `const hoge = ({ a: rest, b }) => {}`, errors: [ { message: ERROR_REST } ] },
     { code: `const rest = {}`, errors: [ { message: ERROR_REST } ] },
+    { code: `const hoge = { rest }`, errors: [ { message: ERROR_REST } ] },
+    { code: `const hoge = { rest: fuga }`, errors: [ { message: ERROR_REST } ] },
   ]
 })