eslint-plugin-smarthr 3.1.0 → 3.2.0

package/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+## [3.2.0](https://github.com/kufu/tamatebako/compare/eslint-plugin-smarthr-v3.1.0...eslint-plugin-smarthr-v3.2.0) (2025-12-15)
+
+
+### Features
+
+* best-practice-for-prohibit-import-smarthr-ui-local を追加 ([#946](https://github.com/kufu/tamatebako/issues/946)) ([1be8bf8](https://github.com/kufu/tamatebako/commit/1be8bf82aa97ccca9dba60277f50c5247ad2b664))
+
 ## [3.1.0](https://github.com/kufu/tamatebako/compare/eslint-plugin-smarthr-v3.0.0...eslint-plugin-smarthr-v3.1.0) (2025-12-10)
 
 

package/README.md

@@ -21,6 +21,7 @@
 - [best-practice-for-date](https://github.com/kufu/tamatebako/tree/master/packages/eslint-plugin-smarthr/rules/best-practice-for-date)
 - [best-practice-for-layouts](https://github.com/kufu/tamatebako/tree/master/packages/eslint-plugin-smarthr/rules/best-practice-for-layouts)
 - [best-practice-for-nested-attributes-array-index](https://github.com/kufu/tamatebako/tree/master/packages/eslint-plugin-smarthr/rules/best-practice-for-nested-attributes-array-index)
+- [best-practice-for-prohibit-import-smarthr-ui-local](https://github.com/kufu/tamatebako/tree/master/packages/eslint-plugin-smarthr/rules/best-practice-for-prohibit-import-smarthr-ui-local)
 - [best-practice-for-remote-trigger-dialog](https://github.com/kufu/tamatebako/tree/master/packages/eslint-plugin-smarthr/rules/best-practice-for-remote-trigger-dialog)
 - [best-practice-for-tailwind-prohibit-root-margin](https://github.com/kufu/tamatebako/tree/master/packages/eslint-plugin-smarthr/rules/best-practice-for-tailwind-prohibit-root-margin)
 - [best-practice-for-tailwind-variants](https://github.com/kufu/tamatebako/tree/master/packages/eslint-plugin-smarthr/rules/best-practice-for-tailwind-variants)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-smarthr",
-  "version": "3.1.0",
+  "version": "3.2.0",
   "author": "SmartHR",
   "license": "MIT",
   "description": "A sharable ESLint plugin for SmartHR",
@@ -26,7 +26,7 @@
     "json5": "^2.2.3"
   },
   "devDependencies": {
-    "typescript-eslint": "^8.48.1"
+    "typescript-eslint": "^8.49.0"
   },
   "peerDependencies": {
     "eslint": "^9"
@@ -37,5 +37,5 @@
     "eslintplugin",
     "smarthr"
   ],
-  "gitHead": "beddf6927401452bb9ac84ab7de9bb3fe0d85461"
+  "gitHead": "c6e4fb54bb2ff5d8421c656213dc29f3bc7237ac"
 }

package/rules/best-practice-for-prohibit-import-smarthr-ui-local/README.md

@@ -0,0 +1,46 @@
+# smarthr/best-practice-for-prohibit-import-smarthr-ui-local
+
+- smarthr-uiの内部的に利用している型などのimportを禁止します
+  - 型は必要とするコンポーネントなどから生成することをおすすめします
+
+## rules
+
+```js
+{
+  rules: {
+    'smarthr/best-practice-for-prohibit-import-smarthr-ui-local': 'error', // 'warn', 'off'
+  },
+}
+```
+
+## ❌ Incorrect
+
+```jsx
+// smarthr-uiの内部構造に依存したpathからimportしているためNG
+import { AnchorButton } from 'smarthr-ui/lib/components/Button/AnchorButton'
+import { FaArrowRightIcon } from 'smarthr-ui/lib/components/Icon'
+
+// 型情報は内部実装、storybookのためにexportしているもののため利用するとNG
+import { HeadingTagTypes } from 'smarthr-ui/lib/components/Heading/Heading'
+import type { Variant } from 'smarthr-ui/lib/components/Button/types'
+import { type Navigation } from 'smarthr-ui/lib/components/AppHeader/types'
+```
+
+## ✅ Correct
+
+```jsx
+// 'smarthr-ui' からimportしているのでOK
+import { AnchorButton, FaArrowRightIcon } from 'smarthr-ui'
+
+// 型情報をコンポーネントから生成しているのでOK
+import { ComponentProps } from 'react'
+
+import { Heading } from 'smarthr-ui'
+type HeadingTagTypes = Required<ComponentProps<typeof Heading>>['tag']
+
+import { Button } from 'smarthr-ui'
+type Variant = Required<ComponentProps<typeof Button>>['variant']
+
+import { AppHeader } from 'smarthr-ui'
+type Navigation = Exclude<ComponentProps<typeof AppHeader>['navigations'], undefined | null>[number]
+```

package/rules/best-practice-for-prohibit-import-smarthr-ui-local/index.js

@@ -0,0 +1,25 @@
+const SCHEMA = []
+
+/**
+ * @type {import('@typescript-eslint/utils').TSESLint.RuleModule<''>}
+ */
+module.exports = {
+  meta: {
+    type: 'problem',
+    schema: SCHEMA,
+  },
+  create(context) {
+    return {
+      [`ImportDeclaration[source.value=/^smarthr-ui\\u002Flib\\u002Fcomponents\\u002F/]`]: (node) => {
+        context.report({
+          node,
+          message: `smarthr-uiからコンポーネントや型をimportする際は 'smarthr-ui' からimportしてください
+ - 詳細: https://github.com/kufu/tamatebako/tree/master/packages/eslint-plugin-smarthr/rules/best-practice-for-prohibit-import-smarthr-ui-local
+ - 'smarthr-ui/lib/components' 以下からのexportはsmarthr-uiの内部実装・もしくはstorybook用であり、プロダクトからの利用は非推奨です
+ - 型を使いたい場合、コンポーネントからreact/ComponentPropsを利用し生成するように修正してください`,
+        })
+      },
+    }
+  },
+}
+module.exports.schema = SCHEMA

package/test/best-practice-for-prohibit-import-smarthr-ui-local.js

@@ -0,0 +1,27 @@
+const rule = require('../rules/best-practice-for-prohibit-import-smarthr-ui-local')
+const RuleTester = require('eslint').RuleTester
+
+const ERROR_MESSAGE = `smarthr-uiからコンポーネントや型をimportする際は 'smarthr-ui' からimportしてください
+ - 詳細: https://github.com/kufu/tamatebako/tree/master/packages/eslint-plugin-smarthr/rules/best-practice-for-prohibit-import-smarthr-ui-local
+ - 'smarthr-ui/lib/components' 以下からのexportはsmarthr-uiの内部実装・もしくはstorybook用であり、プロダクトからの利用は非推奨です
+ - 型を使いたい場合、コンポーネントからreact/ComponentPropsを利用し生成するように修正してください`
+
+const ruleTester = new RuleTester({
+  languageOptions: {
+    parserOptions: {
+      ecmaFeatures: {
+        jsx: true,
+      },
+    },
+  },
+})
+ruleTester.run('best-practice-for-prohibit-import-smarthr-ui-local', rule, {
+  valid: [
+    { code: `import { AnchorButton } from 'smarthr-ui'` },
+  ],
+  invalid: [
+    { code: `import { AnchorButton } from 'smarthr-ui/lib/components/Button/AnchorButton'`, errors: [ { message: ERROR_MESSAGE } ] },
+    { code: `import { FaArrowRightIcon } from 'smarthr-ui/lib/components/Icon'`, errors: [ { message: ERROR_MESSAGE } ] },
+    { code: `import { HeadingTagTypes } from 'smarthr-ui/lib/components/Heading/Heading'`, errors: [ { message: ERROR_MESSAGE } ] },
+  ]
+})